Commit Graph

30 Commits

Author SHA1 Message Date
Guy Harris 619e455299 No C++-style comments, please; some C compilers reject them.
svn path=/trunk/; revision=42368
2012-04-30 23:08:26 +00:00
Guy Harris 3b6b521c28 Add some initializations to squelch (bogus) warnings (either the version
is 0 or it isn't, so the variables are not, in fact, used uninitialized).

svn path=/trunk/; revision=42366
2012-04-30 22:05:33 +00:00
Bill Meier aff0e40393 Rework code slightly:
- use proto_tree_add_item() istead of tvb_get...()/proto_tree_add_uint() in a few cases;
 - misc ...
Also: Whitespace cleanup and reformatting of hf[] entries.

svn path=/trunk/; revision=42364
2012-04-30 21:50:21 +00:00
Bill Meier 26566d7cb7 Parenthesize an expression to prevent a possible overflow resulting an incorrect result.
svn path=/trunk/; revision=42361
2012-04-30 20:49:19 +00:00
Anders Broman e5fcc57d87 One more contributor...
svn path=/trunk/; revision=40100
2011-12-06 07:07:19 +00:00
Anders Broman 10c7707559 Add a contributor.
svn path=/trunk/; revision=40068
2011-12-02 05:46:11 +00:00
Anders Broman 3db35fc5f3 From Krishnamurthy Mayya:
Add Copyright.

svn path=/trunk/; revision=40055
2011-11-30 20:00:42 +00:00
Anders Broman 094e30816d Fix Checkapi found errors.
svn path=/trunk/; revision=40030
2011-11-28 18:10:57 +00:00
Anders Broman c610654cc8 From Krishnamurthy Mayya:
Part of patch:
2. BFD extension has been added as per RFC 6428, to decode the BFD packet with
ACH encapsulation(without IP/UDP header encapsulation). The channel type in ACH
header identifies the BFD payload as BFD CC or CV packet. Also decoding for
MPLS-TP source MEP-ID TLV in BFD CV packet has been added.

applied with a change to add packet-bfd.h

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6610#add_comment

svn path=/trunk/; revision=40029
2011-11-28 17:59:54 +00:00
Anders Broman 2cd8cf96f9 From Krishnamurthy Mayya:
BFD extension has been added as per RFC 6428, to decode the BFD packet with
ACH encapsulation(without IP/UDP header encapsulation). The channel type in ACH
header identifies the BFD payload as BFD CC or CV packet. Also decoding for
MPLS-TP source MEP-ID TLV in BFD CV packet has been added.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6610#add_comment

svn path=/trunk/; revision=40027
2011-11-28 17:13:45 +00:00
Anders Broman 4b952c1324 Get rid of check_col, while at it set ENC.
svn path=/trunk/; revision=39146
2011-09-26 08:25:18 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier 10ffd14b8f Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)
svn path=/trunk/; revision=32735
2010-05-10 15:54:57 +00:00
Bill Meier 055dd62063 #include <string.h> not needed.
svn path=/trunk/; revision=32410
2010-04-06 21:14:01 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Stig Bjørlykke cc229fada3 Removed an unused variable.
svn path=/trunk/; revision=30882
2009-11-09 14:09:40 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Stig Bjørlykke 4d8dd01e8e Changed flags_set_truth -> tfs_set_notset
svn path=/trunk/; revision=28989
2009-07-07 14:54:15 +00:00
Anders Broman a98ce52e80 From Artem Tamazov:
Added: PW ATM 1:1, AAL5 SDU, AAL5 PDU support + BFD fix + PW ATM OAM fix

svn path=/trunk/; revision=28881
2009-06-29 19:24:14 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier 808a4e2c3c Define certain fcns as static (if not used externally).
Also: whiule we're at it: 
 - fix hf[] blurbs as appropriate to use NULL;
 - fix some indentation

svn path=/trunk/; revision=27890
2009-03-29 22:16:26 +00:00
Stig Bjørlykke 28ae535b00 Removed even more "statement not reached" warnings.
svn path=/trunk/; revision=24286
2008-02-07 15:44:45 +00:00
Stig Bjørlykke f725ed8b6a From Todd J Martin:
The attached patch to packet-bfd.c adds the following enhancements to BFD
decoding:
- The Authentication Section is now decoded.  All of the authentication methods
are supported.  Verification of checksums is not implemented.
- BFD flags are now shown in a tree
- Added support for the M flag
- Added a display filter for the message length
- For the Desired Min TX Interval, Required Min RX Interval, and Required Min
Echo RX Interval fields, the time value is now printed in both milliseconds and
microseconds.  (Previously, only milliseconds was being shown.)  The PDU
represents the time in microseconds, but most implementations deal in
milliseconds.
- Added a warning to flag the packet if the Authentication bit is set, but the
full Authentication Section is not present.
- Added descriptions for most of the fields
- Fix the name of the protocol.  BFD stands for Bidirectional Forwarding
Detection and not Bi-directional Fault Detection.
- Register the protocol on the UDP multihop port (4784).
- Change the filter name for the protocol from bfdcontrol to bfd since all of
the other display filters started with bfd.


Removed unused hf_bfd_auth_checksum.
Modified printing of the ':' at the end of the Authentication tree.

svn path=/trunk/; revision=22825
2007-09-07 19:05:55 +00:00
Jaap Keuter c9a6054b75 From: Bálint Réczey:
The attached patch fixes decoding of message flags in BFD control packets.

svn path=/trunk/; revision=18853
2006-08-08 19:54:37 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Gerald Combs 38a305bbfb Properly terminate a value string. Fixes a current Buildbot complaint.
svn path=/trunk/; revision=17422
2006-02-27 15:39:08 +00:00
Anders Broman 8e03852501 From Balint Reczey (IJ/ETH)
> The included patch fixes BFD version detection in the BFD packet 
> dissector and extends it to correctly dissect version 1 packets. The 
> Authentication Section part of the packet is still not dissected.
> 

svn path=/trunk/; revision=17357
2006-02-20 17:21:47 +00:00
Guy Harris b13f6dcbd3 Use the new "proto_tree_add_*_format_value" routines.
svn path=/trunk/; revision=17316
2006-02-16 11:43:38 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00