Commit Graph

9 Commits

Author SHA1 Message Date
Jörg Mayer 7280702537 If there is just a tftp response without a prior request,
dissection would fail with dissector assert.

svn path=/trunk/; revision=20562
2007-01-26 08:09:20 +00:00
Jörg Mayer 370a162e87 - Make options filterable
- Display options in info column
- Only remember blksize from OACK packets
- Add some rfc numbers
- Move tftp_dissect_options in front of dissect_tftp
  (I forgot to fix the forward decl once too often ;)
- Warning fixes
- Add expert error in case of tftp-error pdu


svn path=/trunk/; revision=19162
2006-09-06 08:24:36 +00:00
Jörg Mayer adc56b8e95 option name "blksize" is case in-sensitive
svn path=/trunk/; revision=19158
2006-09-05 16:09:49 +00:00
Jörg Mayer 56e1dd7780 Fix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1092
Actually, this was a feature request:

Store the value of the blksize option in the conversation data
and use that information to compare whether we have reached the
last packet.

Includes the cleanup ideas from Ronnie.

svn path=/trunk/; revision=19155
2006-09-05 15:58:11 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Ronnie Sahlberg fcab322ada Some applications do very naughty things like reusing a port for a different protocol during different stages of an application cycle.
This is very naughty and will cause problems when we have assigned a dissector to a dynamic port using conversation_set_dissector().


To make ethereal handle this case I have changed the try_conversation_dissector() to allow it to fail and return 0,   meaning   yes there is indeed a protocol registered for this conversation but that protocol rejected this packet.
(which only happens for "new" style dissectors, "old" style dissectors will never reject a packet that way)

When this happens  the decode_udp_port() helper will still allow other dissectors to be tried, in the hope that the conversation is now used for some other protocol and thus someone else might be able to decode the packet.


Update SNMP and TFTP dissectors to  check that even if there already is a conversation but that conversation does NOT have snmp/tftp registered as the dissector for it, then create a new conversation anyway and attach the proper dissector.

Since ethereal keeps track of which frame number a conversation started in, this actually works really well.



svn path=/trunk/; revision=14345
2005-05-11 10:40:53 +00:00
Tomas Kukosa 3bb0b3a56b TFTP dissector registering
svn path=/trunk/; revision=14198
2005-04-27 06:50:04 +00:00
Anders Broman 851ecd2ac4 From Jon Ringle:
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the 
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass 
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image 
are present, and T.38 conversation if only m=image is present. I expect that 
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 
packets.

svn path=/trunk/; revision=13243
2005-02-02 20:07:03 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00