Commit Graph

23524 Commits

Author SHA1 Message Date
Jakub Zawadzki 7b89063243 Don't include <epan/strutil.h> when not needed.
svn path=/trunk/; revision=53194
2013-11-09 14:58:28 +00:00
Jakub Zawadzki 0b0bbf0965 Replace STRINGIFY with glib version.
svn path=/trunk/; revision=53193
2013-11-09 14:37:13 +00:00
Jakub Zawadzki 3b2e519422 Remove comment (leftovers from r49444) + add missing WS_DLL_PUBLIC for adler32
(modifing files to be commited when svn commit is already running is no good).

svn path=/trunk/; revision=53192
2013-11-09 14:19:19 +00:00
Jakub Zawadzki ca42cb3e40 Move adler32 from epan/ to wsutil/
The same like done for crc*

svn path=/trunk/; revision=53190
2013-11-09 14:03:53 +00:00
Jakub Zawadzki 1899903f69 Include <epan/to_str.h> only when needed.
svn path=/trunk/; revision=53189
2013-11-09 13:41:10 +00:00
Jakub Zawadzki 9aac55472c Put "private" to_str.c functions to to_str-int.h
svn path=/trunk/; revision=53187
2013-11-09 11:26:41 +00:00
Jakub Zawadzki 5aa4b848ee g_snprintf() don't return -1 from glib-1.2.3 [1]
[1] https://developer.gnome.org/glib/2.28/glib-String-Utility-Functions.html#g-snprintf

svn path=/trunk/; revision=53186
2013-11-09 11:23:02 +00:00
Jakub Zawadzki 38edae1c71 Replace wtap_nstime with nstime_t, remove wtap_nstime_to_sec.
After r50154 nstime_t is inside wsutil/ so wiretap don't need it's own copy. 

svn path=/trunk/; revision=53184
2013-11-09 10:38:02 +00:00
Jakub Zawadzki f207c70075 I have added tvb_get_bits_buf() in r37217, nobody is using it, remove.
svn path=/trunk/; revision=53183
2013-11-09 10:08:58 +00:00
Jakub Zawadzki c86d38af23 Remove old (5 yrs) #if 0 code (from r25028).
svn path=/trunk/; revision=53182
2013-11-09 10:02:39 +00:00
Jakub Zawadzki 8be10b5662 Remove #if 0 code (introduced in r29489).
svn path=/trunk/; revision=53181
2013-11-09 10:00:54 +00:00
Jörg Mayer 0e61383d07 Fix a tpyo (packet-quic.)
svn path=/trunk/; revision=53179
2013-11-09 08:19:13 +00:00
Jakub Zawadzki 9297c9e780 Rename swar_count_bits() to ws_count_ones()
Try to make ws_count_ones() inline function.

svn path=/trunk/; revision=53178
2013-11-09 04:47:08 +00:00
Alexis La Goutte 3aaf560877 Add QUIC (Quick UDP Internet Connections) dissector
See http://blog.chromium.org/2013/06/experimenting-with-quic.html

Don't yet support protocol decryption...

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9402

svn path=/trunk/; revision=53177
2013-11-09 00:19:52 +00:00
Jakub Zawadzki e6944e68b9 Try to split ws_ctz() from hfinfo_bitshift().
svn path=/trunk/; revision=53176
2013-11-08 22:01:12 +00:00
Jakub Zawadzki 7e312c9bbc Convert: vlan, sll, rip to NEW_PROTO_TREE_API
svn path=/trunk/; revision=53175
2013-11-08 21:38:32 +00:00
Jakub Zawadzki b3a4b56ae9 Use escape_string*() functions in ftype-string.
Found in attachment #11961, by Didier Gautheron

svn path=/trunk/; revision=53174
2013-11-08 20:09:54 +00:00
Guy Harris 853da2eb9b The "file types" we have are actually combinations of types and
subtypes, e.g. Network Monitor version 1 and Network Monitor version 2
are separate "file types", even though they both come from Network
Monitor.

Rename various functions, #defines, and variables appropriately.

svn path=/trunk/; revision=53166
2013-11-08 09:53:01 +00:00
Anders Broman 88d0e909a2 From Katrina Zhang:
Add/fix RFSP dissection.

svn path=/trunk/; revision=53163
2013-11-08 05:58:13 +00:00
Michael Mann d62f92b7f1 Make LDAP dissector use ASN.1 private_data instead of pinfo->private_data.
Cleanup a forgotten pinfo->private_data use in the H245 dissector.

svn path=/trunk/; revision=53160
2013-11-08 02:02:43 +00:00
Jörg Mayer 28129427d4 As the code seems to be working now for two people
(both using Linux) it's time to be able to play with
the new HFI code.
Run cmake with -DHAVE_HFI_SECTION_INIT and you are good to go.

svn path=/trunk/; revision=53155
2013-11-08 00:23:32 +00:00
Jörg Mayer 9aa9d608cf With the new HFI code the compiler complains about unused element - great!
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-mint.c:205:26: error: ‘hfi_mint_control_0x0c_unknown4’ defined but not used [-Werror=unused-variable]
 static header_field_info hfi_mint_control_0x0c_unknown4 MINT_HF_INIT =
                          ^

svn path=/trunk/; revision=53154
2013-11-08 00:13:02 +00:00
Jörg Mayer 7c2c2d89f5 Fix:
cd /home/jmayer/work/wireshark/svn/build/qt-gtk3/epan && /usr/bin/cc  -DG_DISABLE_DEPRc
In file included from /home/jmayer/work/wireshark/svn/trunk/epan/packet.h:29:0,
                 from /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-2dp:
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-2dparityfec.c: In functio:
/home/jmayer/work/wireshark/svn/trunk/epan/proto.h:2128:2: error: ISO C90 forbids mixe]
  extern header_field_info __start__data_ ##proto[]; \
  ^
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-2dparityfec.c:331:4: note’
    proto_register_fields(proto_2dparityfec, hfi, array_length(hfi));
    ^
cc1: all warnings being treated as errors


svn path=/trunk/; revision=53152
2013-11-08 00:01:19 +00:00
Jakub Zawadzki 1dffd1a949 GCC on amd64 align header_field_info variables to 16-bytes, this cause problems with proto_register_fields_section().
sizeof(void *) alignment should be enough, use it in HFI_INIT.

This fixes http://www.wireshark.org/lists/wireshark-dev/201311/msg00069.html

svn path=/trunk/; revision=53150
2013-11-07 23:20:06 +00:00
Pascal Quantin 696194999e From Vasil Velichkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9382 :
Fix dissection of GSM MAPv3 ReportSM_DeliveryStatusRes

svn path=/trunk/; revision=53148
2013-11-07 21:08:15 +00:00
Jakub Zawadzki ce6ca9a05d Add infrastructure for section-initializing protocol hfis (without array).
configure implementation later.

svn path=/trunk/; revision=53146
2013-11-07 20:14:18 +00:00
Evan Huus 5c319860fb Add a p_add_proto_data call to dissect_ndmp to match the one in
dissect_ndmp_heur.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9393

Potentially we should add a void *data to tcp_dissect_pdus instead...?

svn path=/trunk/; revision=53144
2013-11-07 17:06:04 +00:00
Evan Huus 6441f10c41 Add modelines. Minor indentation fixes.
svn path=/trunk/; revision=53143
2013-11-07 17:03:04 +00:00
Pascal Quantin 8f112c0390 Fix dissection of MBIM data packets when using 32-bits NDPs
svn path=/trunk/; revision=53142
2013-11-07 16:53:59 +00:00
Michael Mann eac2762d46 8-bit counter variable not big enough and causes infinite loop. Bug 9392 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9392).
svn path=/trunk/; revision=53141
2013-11-07 15:54:11 +00:00
Pascal Quantin 9201e8ce14 3GPP2 SMS: add support for KSC5601 (Korean) character set
svn path=/trunk/; revision=53139
2013-11-07 10:27:11 +00:00
Alexis La Goutte 9fd106a5e2 (re)Fix warning found by fix-encodings-arg tool
svn path=/trunk/; revision=53138
2013-11-07 09:53:56 +00:00
Alexis La Goutte 49485528d8 Add Packet Editor Preference
svn path=/trunk/; revision=53134
2013-11-07 07:43:11 +00:00
Michael Mann 21ddc7ae4e Revert r53118 as it breaks reassemble_test.
svn path=/trunk/; revision=53130
2013-11-07 04:50:53 +00:00
Michael Mann b9e36145f4 Got burned by forgetting to compile first...
svn path=/trunk/; revision=53129
2013-11-07 03:13:53 +00:00
Michael Mann 4fb9091422 Have the gsm_rlcmac_ul and gsm_rlcmac_dl use the data parameter of the dissector function instead of pinfo->private_data to receive a RlcMacPrivateData_t structure.
This work was done in bug 7615 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7615), but the tie in to use the RlcMacPrivateData_t structure (passed by the GSMTAP dissector) was never completed.  Whenever that picks up again, the data parameter of the dissector should be used instead of pinfo->private_data.

svn path=/trunk/; revision=53128
2013-11-07 02:47:22 +00:00
Jörg Mayer 29fef43b40 With the updated pidl it is now possible to generate several
of the dcerpc dissectors again. Commit those of the generated
onces that actually compile.

svn path=/trunk/; revision=53122
2013-11-06 22:55:17 +00:00
Michael Mann f9e5c14dde Add Zoltan Lajos Kis as author
svn path=/trunk/; revision=53119
2013-11-06 22:07:04 +00:00
Michael Mann c59fab0352 Correctly report segments marked with REASSEMBLE_FLAGS_NO_FRAG_NUMBER. Bug 9304 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9304)
Instead of incrementing the offset for each new segment by one we add the length of the segment so that each segment is correctly shown in the segment list.

It proves to be very useful to find which packet (segment) is causing an application dissector to go wrong.

From Matthieu Patou

svn path=/trunk/; revision=53118
2013-11-06 21:59:03 +00:00
Jakub Zawadzki c011e54567 Fix buildbot, typo:
tvbuff.c:1258: warning: passing argument 2 of '__builtin___memcpy_chk' makes pointer from integer without a cast
	tvbuff.c:1258: warning: passing argument 2 of '__inline_memcpy_chk' makes pointer from integer without a cast

svn path=/trunk/; revision=53117
2013-11-06 21:15:46 +00:00
Michael Mann 912b591200 NFC: PN532: Dissect InListPassiveTarget Response and Diagnose request and response. Bug 9333 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9333)
From Michal Labedzki

From me: adjust datatype to guint8 on a few local variables to quiet the Microsoft compiler.

svn path=/trunk/; revision=53116
2013-11-06 20:57:23 +00:00
Michael Mann 99e20da08e Add response time to the rtpproxy dissector. Bug 9380 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9380)
From Peter Lemenkov.

svn path=/trunk/; revision=53115
2013-11-06 20:39:10 +00:00
Guy Harris 2a088c1d53 Add support for displaying dates as year and day-of-year (1-origin).
In the process, fix various man page descriptions of the -t flag,
and add support for UTC absolute times in the iousers and iostat TShark
taps.

svn path=/trunk/; revision=53114
2013-11-06 20:39:09 +00:00
Jakub Zawadzki 67f69e99e8 tvb: optimize tvb_get_*guid()
we already have valid ptr from ensure_contiguous() so use it to fill structure.

svn path=/trunk/; revision=53113
2013-11-06 20:34:27 +00:00
Jakub Zawadzki b4be2fa489 tvbuff: use always ops->tvb_size
svn path=/trunk/; revision=53112
2013-11-06 20:22:28 +00:00
Jakub Zawadzki d54b3a74f6 tvbuff: cleanup, remove dead code.
ensure_contiguous() will throw exception but won't return NULL.

svn path=/trunk/; revision=53111
2013-11-06 19:03:14 +00:00
Michael Mann dc53bb7648 Bluetooth: OBEX: Storing info about previous protocol is not needed anymore. Bug 9303 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9303)
From Michal Labedzki.

svn path=/trunk/; revision=53110
2013-11-06 18:40:29 +00:00
Evan Huus 5efc340771 Mark more unused parameters.
svn path=/trunk/; revision=53109
2013-11-06 17:52:11 +00:00
Michael Mann 55922b6bac Fix for checking RTPS sub message length. Bug 9378 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9378)
From Steve Osselton

#BACKPORT(1.10)

svn path=/trunk/; revision=53107
2013-11-06 16:51:19 +00:00
Michael Mann c278a0ac0a SID28 is special kind of SID where no matter what it uses 28 bytes it's used in the DRS protocol. Bug 9337 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9337)
From Matthieu Patou

svn path=/trunk/; revision=53106
2013-11-06 16:30:14 +00:00