Commit Graph

48 Commits

Author SHA1 Message Date
Michael Mann 8dcfa4214c replace unnecessary decode_numeric_bitfield calls
svn path=/trunk/; revision=45154
2012-09-26 18:33:10 +00:00
Jeff Morriss 3551a86c36 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45015
2012-09-20 01:29:52 +00:00
Jakub Zawadzki 5a8783f5b1 Initial commit to support yet another method of passing data between dissectors.
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00
Guy Harris 944ae5ae49 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42590
2012-05-11 20:02:52 +00:00
Anders Broman b1b0af6e66 From Pascal Quantin:
Fix Bug 6793  Some WiMAX messages decoded incorrectly

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6793

svn path=/trunk/; revision=42045
2012-04-13 13:02:57 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier cca6984ab9 Do some more conversions of proto_tree_add_item() 'encoding' arg
(previously missed).

svn path=/trunk/; revision=39450
2011-10-18 00:17:48 +00:00
Chris Maynard cfca66f6e1 Remove const qualifier to name, abbrev and blurb to pacify the buildbots.
svn path=/trunk/; revision=36860
2011-04-26 01:06:25 +00:00
Guy Harris 34f8f7e77d Get rid of some unnecessary casts that just provoke uninteresting
warnings.

More fun with GArrays: cast away some warnings that don't report real
alignment problems and that wouldn't even happen if the "data" member of
a GArray were a "void *".

svn path=/trunk/; revision=36856
2011-04-25 21:20:47 +00:00
Martin Mathieson 7356320a2a Don't assign proto_item pointers that are not used.
Coverity 1174

svn path=/trunk/; revision=36395
2011-03-29 14:23:13 +00:00
Jeff Morriss f53744b59d There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().
   
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string().

svn path=/trunk/; revision=35603
2011-01-21 03:00:31 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Jeff Morriss 9aeb1dac17 From David Katz via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5166 :
Add a configuration parameter of the NWG version for WiMAX ASN CP dissector.
The format and meaning of TLVs, as well as function types  and messages changed
between the different NWG versions.
Added support for the version number of TLVs in the dictionary xml, its parser,
and of course in the packet itself.
Added support for the version number of function-types and message-types by
extending the value_string structure to contain also a "since" version number.

Successfully tested with a live capture and capture file, containing WiMAX ASN
packets (full Network entry).
Also fuzzed 500 passes successfully.

The XML doesn't contain all existing NWG versions, only selected ones. This is
a little tedious work to go over all TLVs of each version, so I'll add some
newer versions later on. can add a short how-to of adding a new version, for
others to use, if needed.


svn path=/trunk/; revision=34919
2010-11-17 03:16:30 +00:00
Bill Meier 7219ee2a49 Use val_to_str_ext() & friends to access sminmpec_values[];
Also: packet-nhrp.c: #include sminmpec.h not req'd;

svn path=/trunk/; revision=34143
2010-09-17 04:51:21 +00:00
Anders Broman 846eed1d9e Get rid of check_col
svn path=/trunk/; revision=32401
2010-04-06 16:13:09 +00:00
Anders Broman dc5e066cae From sangaran:
8-bit Bit Flag decoder method needed in wimaxasncp plugin dissecto.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4608

svn path=/trunk/; revision=32356
2010-04-01 20:49:07 +00:00
Bill Meier c033a08313 Fix some gcc -Wshadow warnings.
svn path=/trunk/; revision=31724
2010-01-28 23:53:27 +00:00
Anders Broman 440c3f9261 From Didier Gautheron:
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
Anders Broman 4d2e653901 From Didier Gautheron:
Dissectors using call_dissector() function inside a 'if (tree) {}' block.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107

svn path=/trunk/; revision=30415
2009-10-09 07:24:33 +00:00
Bill Meier 94f28dd8f9 (FWIW) One step towards including stdio.h & stdlib.h only when req'd.
svn path=/trunk/; revision=29568
2009-08-26 19:27:49 +00:00
Bill Meier 6f87844d0a (Minor) Remove unneeded #includes.
svn path=/trunk/; revision=29492
2009-08-21 14:36:27 +00:00
Kovarththanan Rajaratnam ac463d2697 Don't guard col_clear with col_check
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Anders Broman 1196da707d From Rajasekhar Reddy Gali:
packet-wimaxasncp.c file need to update with latest wimax spec.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3730

svn path=/trunk/; revision=29125
2009-07-16 21:27:56 +00:00
Stig Bjørlykke 6d472a50fc From Kovarththanan Rajaratnam via bug 3548:
Minor hf cleanup.

svn path=/trunk/; revision=28968
2009-07-07 07:46:57 +00:00
Stig Bjørlykke 2bba6be84f From Kovarththanan Rajaratnam via bug 3548:
Cleanup header_field_info in plugins.

svn path=/trunk/; revision=28771
2009-06-18 23:22:10 +00:00
Gerald Combs 6d04f793f0 Back out r27047 and r27053.
svn path=/trunk/; revision=27062
2008-12-19 17:39:52 +00:00
Gerald Combs fc71188963 Update calls to proto_tree_add_bytes_format to reflect r27047.
svn path=/trunk/; revision=27053
2008-12-18 20:19:49 +00:00
Stig Bjørlykke 94e9e2b1ec Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26652
2008-10-31 17:27:51 +00:00
Martin Mathieson 4aa522855d Make sure info column is set correctly when tree == NULL.
Fixes but 2561.













svn path=/trunk/; revision=25530
2008-06-23 13:02:50 +00:00
Martin Mathieson 03d7032acd Show ops, etc even when no filter set.
Also avoid crash I was seeing when changing preferences.

svn path=/trunk/; revision=25379
2008-05-26 08:22:33 +00:00
Martin Mathieson 88744abd6f Don't load in files unless tree is set.
If a user wants to load or capture quickly, they won't want to wait
for the file to be processed after the first frame.

svn path=/trunk/; revision=24781
2008-04-05 04:48:36 +00:00
Martin Mathieson 4cfefcc5a4 Use proto_register_prefix() with wimaxasncp plugin.
Also fix a crash problem seen with no filters (i.e. NULL tree).

svn path=/trunk/; revision=24767
2008-04-04 05:38:13 +00:00
Martin Mathieson b0998315f9 Fix some specifier strings (%d -> %u).
svn path=/trunk/; revision=23785
2007-12-06 17:47:00 +00:00
Martin Mathieson 9fb579537e - Prettify "Value" node that contains EAP tree with top-level details
- Lose unuseful header file

svn path=/trunk/; revision=23499
2007-11-19 19:07:49 +00:00
Martin Mathieson 24d6a39eb0 Embedding EAP inside wimaxasncp.
svn path=/trunk/; revision=23474
2007-11-16 23:03:09 +00:00
Guy Harris 6f1740aa6c Cast "char"s to "unsigned char" before handing them to <ctype.h> macros.
svn path=/trunk/; revision=23417
2007-11-10 00:36:01 +00:00
Martin Mathieson 0f63de9281 From Stephen Croll.
Dynamically register filter fields from TLV definitions.

svn path=/trunk/; revision=23414
2007-11-09 14:41:04 +00:00
Martin Mathieson 7c80a7feae Add expert item for cases of unmatched function type or message op.
svn path=/trunk/; revision=23276
2007-10-26 10:38:16 +00:00
Martin Mathieson 358c4399ba TLVs now defined in XML (from Stephen Croll).
svn path=/trunk/; revision=23156
2007-10-12 09:59:10 +00:00
Martin Mathieson 8e59e99b5c - show type (number) of unrecognised tlvs in the tlv root item
- also add this as an expert item
- tlv root item is now an FT_BYTES item (allowing filtering on whole tlv contents)

svn path=/trunk/; revision=22986
2007-09-26 14:47:22 +00:00
Martin Mathieson 9d0e61f12c Replace remaining non-printable characters that looked like spaces with real spaces.
svn path=/trunk/; revision=22824
2007-09-07 15:58:24 +00:00
Martin Mathieson fe8b214d35 Small cleanup:
- remove unprintable chars (pasted from formatted spec doc?)
- use _U_ for unsused function argument
- remove accidental(?) assignment in function parameter
- make indentation consistent by removing the (few) tabs in the file

svn path=/trunk/; revision=22819
2007-09-07 13:53:49 +00:00
Martin Mathieson aef34dca35 Try Stephen Croll's workaround.
svn path=/trunk/; revision=22818
2007-09-07 09:56:19 +00:00
Anders Broman 01bd582bc0 Change it back...
Plus Temp change VALS(sminmpec_values) to NULL to let the buildbot do arun.

svn path=/trunk/; revision=22813
2007-09-06 21:33:57 +00:00
Anders Broman 83f7ac9f95 Add A11 RRQ-CVSE-Active Start Airlink Record-Subtype 108 is expressed to Subnet.
Plus Temp change VALS(sminmpec_values) to NULL to let the buildbot do arun.

svn path=/trunk/; revision=22812
2007-09-06 21:25:41 +00:00
Martin Mathieson 400f998e3b Fix the unsigned errors. Not sure about the other windows errors yet...
svn path=/trunk/; revision=22806
2007-09-06 14:14:09 +00:00
Martin Mathieson c4c6de35df Add wimaxasncp plugin folder contents (other changes will follow)
svn path=/trunk/; revision=22800
2007-09-06 10:05:41 +00:00