Commit graph

18043 commits

Author SHA1 Message Date
Ronnie Sahlberg
797bb2d5d7 for iscsi traces where there is a lot of packetloss the dissector frequently gets out of sync
and the weak heuristics often cause wireshark to mistake some segment containing read/write data to be iscsi.


make the heuristics to check that a packet really is iscsi much stronger


svn path=/trunk/; revision=18523
2006-06-20 13:16:50 +00:00
Anders Broman
0e1b053f82 From Albert Chin:
This fixes a redefine of AF_INET6 on AIX 4.3.3. We pull in <sys/socket.h> so the OS can define it first, nullifying the #define in epan/inet_v6defs.h.

svn path=/trunk/; revision=18522
2006-06-20 05:59:55 +00:00
Anders Broman
c72d4e8f2e From Albert Chin:
Fix some C++ comments in C source files and fixes some non-constant initializations.

svn path=/trunk/; revision=18521
2006-06-20 05:57:29 +00:00
Anders Broman
d327d37e82 Fix Ethereal bug 994 in Wireshark:
MIP Advertisement reverse tunneling flag not dissected

svn path=/trunk/; revision=18520
2006-06-19 15:54:13 +00:00
Anders Broman
764e3ac167 New rutine tvb_format_text_wsp() which will change "whiite space" characters to space
before output.

svn path=/trunk/; revision=18519
2006-06-19 15:53:03 +00:00
Anders Broman
0eb577e17b From Eugene Tarlovskij:
After synchronization with wireshark repository I see that the patch is applied in the incorrect way. 
I send you another patch to fix this issue.

svn path=/trunk/; revision=18518
2006-06-19 15:43:17 +00:00
Ronnie Sahlberg
c71d5ef7cb coverity 195
remove a redundant check for str==NULL
since str can never be NULL here


svn path=/trunk/; revision=18517
2006-06-19 10:18:42 +00:00
Ronnie Sahlberg
75030295d1 add tracking of TID -> sharenames
reuse the recent structure for fid->filename mappings since the problemspace is virtually the same


(go to tired of trying to find the sharename in 10mpacket traces with 1000s of shares)



svn path=/trunk/; revision=18516
2006-06-19 09:44:15 +00:00
Ronnie Sahlberg
15c935b535 make fid->filename tracking work for files opened with NTCreateAndX
This needs to be done for all other Create/Open calls as well but would notmally just be 6 lines tyo add.

I rarely see older methods to open files   so others using older clients are encoraged to use these 6 lines to the other places where needed.




svn path=/trunk/; revision=18515
2006-06-19 07:41:09 +00:00
Ronnie Sahlberg
986085204d add infrastructure to make tracking of fid->filename easy to implement and use
svn path=/trunk/; revision=18514
2006-06-19 07:39:19 +00:00
Ronnie Sahlberg
d76b58cbfb track smb FIDFs when tehy are opened and closed.
add an expansion to the fid that display which frame itr was opened in and when it was closed.



someone may want to add tracking of actual filenames here as well.   i am not sure i need that feature myself   so ...



svn path=/trunk/; revision=18512
2006-06-18 05:45:40 +00:00
Ronnie Sahlberg
e0c7fcca2d include emem
svn path=/trunk/; revision=18511
2006-06-18 05:41:14 +00:00
Ronnie Sahlberg
5d045b15d9 include emem
svn path=/trunk/; revision=18510
2006-06-18 05:39:49 +00:00
Ronnie Sahlberg
b39d9be585 include emem.h
svn path=/trunk/; revision=18509
2006-06-18 05:38:35 +00:00
Ronnie Sahlberg
ab54bfdf50 include emem.h
svn path=/trunk/; revision=18508
2006-06-18 05:15:55 +00:00
Ronnie Sahlberg
533be475fc include emem.h
svn path=/trunk/; revision=18507
2006-06-18 05:14:45 +00:00
Ronnie Sahlberg
a5db166102 rename add_fid() to dissect_smb_fid() as a firsdt step towards adding tracking of filename/openedframe/closedframe tracking for smb fids
svn path=/trunk/; revision=18506
2006-06-18 01:58:34 +00:00
Anders Broman
c213f73ab0 Port the ssn range setting stuff.
svn path=/trunk/; revision=18505
2006-06-17 16:19:23 +00:00
Anders Broman
eb83c826ca From Tarlovskij Eugene:
- MEGACO dissector fails to decode observedevents descriptor 
- BoundsError exception in text MEGACO packets

svn path=/trunk/; revision=18504
2006-06-17 16:13:25 +00:00
Ronnie Sahlberg
86eaf399d0 ethereal to wireshark
svn path=/trunk/; revision=18503
2006-06-17 12:30:06 +00:00
Ronnie Sahlberg
17dd373fbd ethereal to wireshark
svn path=/trunk/; revision=18502
2006-06-17 12:27:56 +00:00
Ronnie Sahlberg
06bdc31f5b ethereal to wireshark changes
svn path=/trunk/; revision=18501
2006-06-17 12:21:54 +00:00
Ronnie Sahlberg
62e32390b5 ethereal to wireshark changes
svn path=/trunk/; revision=18500
2006-06-17 12:07:49 +00:00
Ronnie Sahlberg
9b67217fb5 ethereal to wireshark changes
svn path=/trunk/; revision=18499
2006-06-17 12:04:30 +00:00
Ronnie Sahlberg
0c222fdbd0 ethereal to wireshark change
svn path=/trunk/; revision=18498
2006-06-17 12:00:41 +00:00
Ronnie Sahlberg
9647ea21f8 ethereal to wireshark change
svn path=/trunk/; revision=18497
2006-06-17 11:57:26 +00:00
Ronnie Sahlberg
d7581a641c ethereal to wireshark conversion
svn path=/trunk/; revision=18496
2006-06-17 11:50:39 +00:00
Ronnie Sahlberg
25c3f0a107 ethereal to wireshark conversion
svn path=/trunk/; revision=18495
2006-06-17 11:49:03 +00:00
Ronnie Sahlberg
85f49f1d49 fix for coverity 182
this bug can not currently trigger    but if someone would rename the module
in the future then this could potentially cause a null dereference.



svn path=/trunk/; revision=18494
2006-06-17 11:11:34 +00:00
Ronnie Sahlberg
847090fe54 fix coverity 188
at the same time, get rid of some unused parameter compiler warnings


svn path=/trunk/; revision=18493
2006-06-17 10:47:10 +00:00
Ronnie Sahlberg
22edbe1066 fix coverity "bug" 184 (false positive)
the contract for wiretap ..._read() functions are that the *err pointer MUST always
be provided as a valid pointer and not a NULL pointer.


ber.c contained a spurios and redundant check for the pointer being non-NULL wich triggered coverity to detect this as a false positive.

this redundant test if the pointer is NULL has been revoved.



svn path=/trunk/; revision=18492
2006-06-17 10:26:20 +00:00
Ronnie Sahlberg
d8e1827401 allocate the correct size of buffer to store the itlq structure for scsi
we used the wrong size which caused emem to complain that the canary value had been stomped upon.

another win for the canary feature.  thanks gerald


svn path=/trunk/; revision=18491
2006-06-17 08:40:14 +00:00
Ronnie Sahlberg
2849771e3d make ndmp track itl structures
everytime a ndmp_[scsi|tape]_open is seen   create a new itl

we need an itl structure to be able to know what commandset a certain device is using.




svn path=/trunk/; revision=18490
2006-06-17 08:22:03 +00:00
Ronnie Sahlberg
cea0653059 we need a itl structure to decode a scsi cdb properly.
make dissect_scsi_cdb abort with an assert if called with a null pointer for itl.

This means scsi over ndmp will be aborted by an assert sicne ndmp passes a null pointer here always but at least is better than a segv since some cdb's require itl to decode properly.


next checkin will fix ndmp in this regard.



svn path=/trunk/; revision=18489
2006-06-17 05:42:55 +00:00
Guy Harris
535a8bd006 Not all UN*Xes have MAP_ANONYMOUS; some have MAP_ANON instead, and some
have neither.  For those with MAP_ANON but not MAP_ANONYMOUS, use
MAP_ANON; for those with neither, add some code to use "/dev/zero".

svn path=/trunk/; revision=18488
2006-06-17 02:31:56 +00:00
Jaap Keuter
2288c8590d From Albert Chin
HP-UX doesn't have MAP_ANON but it does have MAP_ANONYMOUS. Moreoever,
according to mmap(2) on RHEL:
       MAP_ANONYMOUS
              The mapping is not backed by any file; the fd and offset argu-
              ments are ignored.  This flag in conjunction with MAP_SHARED is
              implemented since Linux 2.4.

       MAP_ANON
              Alias for MAP_ANONYMOUS. Deprecated.


svn path=/trunk/; revision=18486
2006-06-16 21:30:58 +00:00
Guy Harris
2d20359c26 Include <epan/dissectors/packet-tcp.h> to declare tcp_dissect_pdus().
svn path=/trunk/; revision=18483
2006-06-16 07:18:25 +00:00
Guy Harris
753aa36dbf "proto_tree_add_text()" supports printf-style formats; there's no need
to format into a buffer and then pass that buffer.

Make a count an "int" rather than a "size_t" to squelch a (valid)
compiler warning.

svn path=/trunk/; revision=18482
2006-06-16 07:17:00 +00:00
Guy Harris
1af7caeeb1 Squelch a (valid) compiler warning.
Clean up indentation a bit.

svn path=/trunk/; revision=18481
2006-06-16 07:15:03 +00:00
Anders Broman
c01e45186f From Martin Mathieson:
Fix the part where the DeleteConnection messages and 
responses were not being included in the graphs.
There is a test that allows messages such as these for 1 second after 
the call has been hung up, but the time calculation was wrong.

svn path=/trunk/; revision=18479
2006-06-15 21:38:37 +00:00
Anders Broman
c19f6b2d97 gsm_a: Dissect LLC
Q.931: Add Bit 8 first in Bearer Cap IE

svn path=/trunk/; revision=18477
2006-06-15 21:14:26 +00:00
Anders Broman
e803b5cefa Fix BUG 971 Facility IE dissection error in GSM_DTAP.
svn path=/trunk/; revision=18476
2006-06-15 21:12:47 +00:00
Jörg Mayer
60a546c1cf autofoo will fail on systems that lack libgcrypt.m4.
Provide one in aclocal-fallback. While I'm at it: Remove
the libgnutls.m4 stuff from acinclude and provide it in
aclocal-fallback as well.


svn path=/trunk/; revision=18475
2006-06-15 20:25:01 +00:00
Ulf Lamping
19cbd3f03f add some information to the "Output File Formats" section
svn path=/trunk/; revision=18474
2006-06-15 19:13:47 +00:00
Ulf Lamping
b498f9a3ca rename "graphics" directory to "wsug_graphics" to make it clear that it's only used for the users_guide
svn path=/trunk/; revision=18473
2006-06-15 14:18:03 +00:00
Ulf Lamping
46e3b81e58 we shouldn't use the admonition graphics from the xsl stylesheets because of unknown copyright things and because we have our own graphics for some time
svn path=/trunk/; revision=18472
2006-06-15 14:13:56 +00:00
Ulf Lamping
38d86ced8c use the colored logo for wsdg too, slightly prettify the page layout
svn path=/trunk/; revision=18471
2006-06-15 14:09:05 +00:00
Ulf Lamping
28f87e7d3b add a missing status code
svn path=/trunk/; revision=18470
2006-06-15 11:43:35 +00:00
Ulf Lamping
39e7f020e6 fix the hresult "filter" fields
svn path=/trunk/; revision=18469
2006-06-15 11:42:47 +00:00
Tomas Kukosa
f0f319acf1 - BER_MAX_OID_STR_LEN removed and replaced with MAX_OID_STR_LEN
- x411 and dop regenerated
- dissect_ber_tagged_type() prepared (support in asn2wrs will follow)

svn path=/trunk/; revision=18468
2006-06-15 07:46:07 +00:00