osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
37561 commits 23 branches 0 tags 1.3 GiB
Commit graph

183 commits

Author SHA1 Message Date
Anders Broman
5d82ea810d Make it possiblwe to creare a trime string from frame data. 
svn path=/trunk/; revision=39036
 2011-09-19 05:15:58 +00:00
Anders Broman
bd87f77148 set_abs_time and friends always return 1. 
svn path=/trunk/; revision=39027
 2011-09-16 14:25:50 +00:00
Stig Bjørlykke
50be3577ab Support negative nsecs when viewing seconds with hours and minutes. 
svn path=/trunk/; revision=38862
 2011-09-02 11:46:33 +00:00
Anders Broman
2f05cf4dcf From Michael Mann: 
Added ability to display UTC time or UTC time with date.  I liked having the
difference between UTC and local time, not just setting local=UTC.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2629

svn path=/trunk/; revision=37898
 2011-07-04 21:43:34 +00:00
Stig Bjørlykke
d201977d9c Don't assert on invalid custom columns, just set as invalid/unknown. 
This fixes bug 6028.

svn path=/trunk/; revision=37756
 2011-06-22 20:15:34 +00:00
Guy Harris
c8d2cd3cb5 In packet_list_dissect_and_cache_record(), set the columns to 
*something* if we get an error reading the packet from the capture file,
rather than leaving them as null (which will cause a crash).

svn path=/trunk/; revision=36527
 2011-04-09 04:33:26 +00:00
Chris Maynard
8f429fd919 separator will never be NULL, but sep_len could be 0, so test for that instead. 
Fixes CID 620.

svn path=/trunk/; revision=36423
 2011-03-31 17:27:48 +00:00
Sake Blok
307c0d70fb Removal of the old packet-list in favor of the new packet list. 
It compiles with "./configure without options" on my Mac. Let's see what the buildbots have to say about it :-)


svn path=/trunk/; revision=36161
 2011-03-08 01:52:25 +00:00
Sake Blok
7364bef1b3 When using a custom column, make it possible to select which occurrence to show if the field has multiple occurrences. 
svn path=/trunk/; revision=34186
 2010-09-22 20:56:14 +00:00
Stig Bjørlykke
c1a591cd37 Support negative values when viewing seconds with hours and minutes. 
svn path=/trunk/; revision=34079
 2010-09-08 10:29:06 +00:00
Anders Broman
6d1a0a2e86 Doxygen related changes. 
svn path=/trunk/; revision=34009
 2010-08-30 05:39:02 +00:00
Jeff Morriss
b0cf38c06c Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4854 (crash when adding 
2nd info column):

Duplicate col_do_append_sep_va_fstr()'s code into col_append_fstr() and
col_append_sep_fstr() (and remove col_do_append_sep_va_fstr()) because we need
to call va_start() and va_end() after each call to g_vsnprintf().  (This is a
followon to rev 32961.)

svn path=/trunk/; revision=33472
 2010-07-08 02:54:26 +00:00
Stig Bjørlykke
5e0a3b2ded Corrected a typo in "display seconds with hours and minutes". 
svn path=/trunk/; revision=33174
 2010-06-09 08:52:56 +00:00
Stig Bjørlykke
bdc492cc40 Improved readability when displaying seconds with hours and minutes. 
svn path=/trunk/; revision=33074
 2010-06-03 13:53:03 +00:00
Guy Harris
ebc3739570 Once you've used a va_list, you can't use it again until you 
reinitialize it with va_start().  (Yes, there are platforms where
reusing the va_arg fails, e.g. Mac OS X on x86-64.)

svn path=/trunk/; revision=32961
 2010-05-26 02:01:49 +00:00
Stig Bjørlykke
39eb93b5a2 Simplified hour_min_sec calculations. 
svn path=/trunk/; revision=32684
 2010-05-06 11:25:15 +00:00
Stig Bjørlykke
6efcb1adf0 Added an option to display seconds as hours, minutes and seconds 
in the packet list, on this format: "1h 2m 3.456s".

svn path=/trunk/; revision=32683
 2010-05-06 10:32:59 +00:00
Gerald Combs
d13ecdea62 Add a catch-all if statement for column formats that are filled in by 
dissectors. Fixes bug 4732.

svn path=/trunk/; revision=32615
 2010-04-30 20:49:41 +00:00
Gerald Combs
3c8db1cae5 Several dissectors fill in custom custom data in the source and 
destination address columns. Don't clobber it in the new packet list.

svn path=/trunk/; revision=32609
 2010-04-29 23:53:57 +00:00
Bill Meier
6812b68eb1 From Yaniv Kaul: constify parameters 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4422

 From me: Fix a number of instances where the function prototype or
  the function definition wasn't changed so there was a mismatch 
  thus causing Windows (but not gcc) compilation errors.

svn path=/trunk/; revision=32365
 2010-04-03 18:18:50 +00:00
Bill Meier
d32b4c0758 Revert SVN #32360 until Windows compilation errors corrected. 
svn path=/trunk/; revision=32361
 2010-04-02 15:18:03 +00:00
Bill Meier
049f9eac85 From Yaniv Kaul: constify parameters 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4422

svn path=/trunk/; revision=32360
 2010-04-02 14:37:49 +00:00
Anders Broman
4e66c899d1 From Jakub Zawadzki: 
Optimizations.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4303

svn path=/trunk/; revision=31967
 2010-02-23 19:28:38 +00:00
Bill Meier
e0064797fb Use more unique names for certain enum constants. 
(enum constant names are part of the global name space).
(Fixes at least one gcc -Wshadow warning).

svn path=/trunk/; revision=31572
 2010-01-19 19:37:03 +00:00
Gerasimos Dimitriadis
a72447c0da Avoid assertion failure when adding a column of type 
IEEE 802.11 TX rate.

svn path=/trunk/; revision=31527
 2010-01-14 18:30:57 +00:00
Bill Meier
cfca0020c5 From Jakub Zawadzki: remove double NUL termination. 
From me: fix a 3rd instance.
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3339

svn path=/trunk/; revision=31373
 2009-12-28 16:12:25 +00:00
Kovarththanan Rajaratnam
e981de7a99 Don't attempt to fill custom columns if we don't have a valid column expression. 
svn path=/trunk/; revision=30407
 2009-10-08 16:35:58 +00:00
Stig Bjørlykke
9401317238 Removed unused variable 'sep_len' in col_do_append_str(). 
svn path=/trunk/; revision=30199
 2009-09-29 19:19:40 +00:00
Kovarththanan Rajaratnam
99624329fa Don't col_clear() followed by col_set_str(). A col_set_str() will clear (replace) any existing string (the fence still needs to be respected though) 
svn path=/trunk/; revision=30086
 2009-09-23 14:30:36 +00:00
Kovarththanan Rajaratnam
a05517fd21 (Cosmetic) Reorder functions 
svn path=/trunk/; revision=30081
 2009-09-22 21:08:48 +00:00
Kovarththanan Rajaratnam
afe5b2fe9d Use ep_verify_pointer() in col_set_str() to verify that the caller hasn't passed us something from the ephemeral pool 
svn path=/trunk/; revision=30012
 2009-09-20 12:09:25 +00:00
Kovarththanan Rajaratnam
b50ffb1c6b Assert on null string in col_set_str(). This is reasonable behaviour since the caller is expeceted to pass in a constant string 
svn path=/trunk/; revision=30010
 2009-09-20 10:19:37 +00:00
Kovarththanan Rajaratnam
f4e27f4549 Add a couple of g_asserts 
svn path=/trunk/; revision=29992
 2009-09-20 07:48:33 +00:00
Bill Meier
38dae2ab74 (Trivial) Fix a typo in a comment 
svn path=/trunk/; revision=29899
 2009-09-14 16:04:54 +00:00
Kovarththanan Rajaratnam
8d802d414c Make sure that we point the current column to a constant string if we have no address. 
Fixes http://wiki.wireshark.org/Development/OptimizePacketList?action=diff&rev1=20&rev2=21

svn path=/trunk/; revision=29860
 2009-09-11 14:21:04 +00:00
Kovarththanan Rajaratnam
129f907f0c Move some CHECK_COL to our public functions, allowing us to bail our more quickly 
svn path=/trunk/; revision=29859
 2009-09-11 14:00:36 +00:00
Kovarththanan Rajaratnam
de23d92163 Add an option to col_fill_in() to allow us to disable column expression processing. This is rarely needed. It's only needed when the user right clicks on the packet list view to generate a display filter. 
svn path=/trunk/; revision=29806
 2009-09-08 19:00:54 +00:00
Kovarththanan Rajaratnam
d713b846e6 Hoist COL_CHECK_REF_TIME in the call hierarchy. Use it in our public functions, not our internal functions 
svn path=/trunk/; revision=29798
 2009-09-08 15:55:10 +00:00
Kovarththanan Rajaratnam
d75778eb4a Custom columnfication: 
* Deprecate COL_DCE_CTX ("Context ID). Use dcerpc.cn_ctx_id

svn path=/trunk/; revision=29797
 2009-09-08 14:59:26 +00:00
Kovarththanan Rajaratnam
bc845e056c Custom column deprecation: 
We fill out the COL_DSTIDX column by using 'pinfo->dst_idx'. This member is only set by the MDS Header dissector based on 'mdshdr.dstidx'. So remove COL_DSTIDX and migrate to 'mdshdr.dstidx' custom column.

svn path=/trunk/; revision=29795
 2009-09-08 14:29:08 +00:00
Kovarththanan Rajaratnam
62af6eff84 Custom column deprecation: 
We fill out the COL_SRCIDX column by using 'pinfo->src_idx'. This member is only set by the MDS Header dissector based on 'mdshdr.srcidx'. So remove COL_SRCIDX and migrate to 'mdshdr.srcidx' custom column.

svn path=/trunk/; revision=29794
 2009-09-08 14:26:09 +00:00
Kovarththanan Rajaratnam
2cf14900d2 Custom column deprecation: 
We fill out the COL_RXID column by using 'pinfo->rxid'. This member is only set by the Fibre Channel dissector based on 'fc.rx_id'. So remove COL_RXID and migrate to 'fc.rx_id' custom column.

svn path=/trunk/; revision=29793
 2009-09-08 14:21:14 +00:00
Kovarththanan Rajaratnam
cdfeebdd26 Custom column deprecation: 
We fill out the COL_OXID column by using 'pinfo->oxid'. This member is only set by the Fibre Channel dissector based on 'fc.ox_id'. So remove COL_OXID and migrate to 'fc.ox_id' custom column.

svn path=/trunk/; revision=29792
 2009-09-08 14:17:36 +00:00
Anders Broman
c6d4c80371 From : Didier Gautheron 
speed up a little proto_custom_set.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3972

svn path=/trunk/; revision=29789
 2009-09-08 10:33:15 +00:00
Anders Broman
65e2d90058 Remove an unused parameter. 
svn path=/trunk/; revision=29784
 2009-09-08 04:50:48 +00:00
Kovarththanan Rajaratnam
3efea601d4 Make sure that we fill in the frame_data before passing it onto col_fill_in_frame_data 
svn path=/trunk/; revision=29780
 2009-09-07 19:43:05 +00:00
Kovarththanan Rajaratnam
72c9662da6 ntroduce some seasonal address name lookup functions which we use when NEW_PACKET_LIST is defined. This change partially reverts some parts of r29768, which didn't seem to work because it assumed that get_addr_name() would always return a seasonal string. This wasn't the case if the adddress type was AT_STRINGZ. 
svn path=/trunk/; revision=29771
 2009-09-07 16:05:37 +00:00
Anders Broman
2fe83ebaed mark unused parameter. 
svn path=/trunk/; revision=29769
 2009-09-07 15:01:51 +00:00
Anders Broman
3abd049a9b Use constant strings for Addresses saves some memory. 
svn path=/trunk/; revision=29768
 2009-09-07 14:03:05 +00:00
Kovarththanan Rajaratnam
c7eb52b086 Remove already #if 0'ed code that was made redundant due to COL_CIRCUIT_ID custom column deprecation 
svn path=/trunk/; revision=29745
 2009-09-06 13:35:27 +00:00