Anders Broman
8f96a14263
Dissection of Q.763 ISUP Generic Notification.
...
based on bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8311
svn path=/trunk/; revision=47630
2013-02-11 14:50:50 +00:00
Anders Broman
fe29434e82
Export dissect_japan_isup_additonal_user_cat()
...
svn path=/trunk/; revision=47497
2013-02-05 15:12:54 +00:00
Anders Broman
264ac136ef
Make it easier to make full extended value string if required.
...
svn path=/trunk/; revision=46437
2012-12-07 09:34:39 +00:00
Anders Broman
a85be64367
Found non-ASCII characters on line 7323 of packet-isup.c
...
svn path=/trunk/; revision=46407
2012-12-05 17:45:54 +00:00
Anders Broman
59af28f911
unused variable 'length'
...
svn path=/trunk/; revision=46406
2012-12-05 17:08:34 +00:00
Anders Broman
f06a499b83
Dissect more Japanese ISUP parameters.
...
svn path=/trunk/; revision=46405
2012-12-05 16:21:09 +00:00
Anders Broman
c9622178cf
Add more dissection for Japan ISUP.
...
svn path=/trunk/; revision=46368
2012-12-04 16:22:00 +00:00
Anders Broman
362dd1dcb5
Add more Japan ISUP parameters to value sting, dissection remains to be done.
...
svn path=/trunk/; revision=46364
2012-12-04 09:15:21 +00:00
Pascal Quantin
51323635aa
From Ojab via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8035 :
...
Wrong packet bytes are selected for ISUP CUG binary code
svn path=/trunk/; revision=46334
2012-12-02 20:49:19 +00:00
Jeff Morriss
0266cceef3
Make all enum_val_t's const.
...
svn path=/trunk/; revision=46292
2012-11-29 20:15:37 +00:00
Anders Broman
6408671bad
Add more parameters for Japanese ISUP.
...
svn path=/trunk/; revision=46220
2012-11-27 13:36:18 +00:00
Guy Harris
dda0e94161
hf_isup_cic is now BASE_DEC, so there's no reason to use
...
proto_tree_add_uint_format() to make it display in decimal -
proto_tree_add_uint() suffices.
svn path=/trunk/; revision=45464
2012-10-11 08:23:29 +00:00
Anders Broman
f6914a05af
"Prepare/Apply a filter" on ISUP CIC should make a filter with decimal CIC number, not hex.
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7848
svn path=/trunk/; revision=45463
2012-10-11 08:12:41 +00:00
Anders Broman
2c181db864
Fix unused parameters.
...
svn path=/trunk/; revision=45387
2012-10-08 15:10:24 +00:00
Anders Broman
4856bcfd40
Let ISUP national settings be valid for BICC too.
...
Extend dissection of Japan ISUP.
svn path=/trunk/; revision=45386
2012-10-08 14:22:24 +00:00
Jeff Morriss
2552c750e5
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jakub Zawadzki
5a8783f5b1
Initial commit to support yet another method of passing data between dissectors.
...
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL
svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00
Jeff Morriss
aa5d9d78dd
From Robert Bullen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7683 :
...
The reassembled fragments tree in the Packet Details view is awesome, but it
lacks one thing: a field that exposes the reassembled data.
tcp.data already exists for exposing a single TCP segment's payload as a byte
array. It would be handy to have something similar for a single application
layer PDU when TCP segment reassembly is involved. I propose
tcp.reassembled.data, named and placed after the already existing field
tcp.reassembled.length.
My primary use case for this feature is outputting tcp.reassembled.data with
tshark for further processing with a script.
The attached patch implements this very feature. Because the reassembled
fragment tree code is general purpose, i.e. not specific to just TCP, any
dissector that relies upon it can add a similar field very cheaply. In that
vein I've also implemented ip.reassembled.data and ipv6.reassembled.data, which
expose reassembled fragment data as a single byte stream for IPv4 and IPv6,
respectively. All other protocols that use the reassembly code have been left
alone, other than inserting NULL into their initializer lists for the newly
introduced struct field reassemble.h:fragment_items.hf_reassembled_data.
svn path=/trunk/; revision=44802
2012-09-07 02:09:59 +00:00
Chris Maynard
3e976d69d1
tools/checkhf.pl reported 3 unused hf entries. Commented them out for now.
...
BTW:
tools/checkAPIs.pl reports 109 useless add_text()'s vs. 346 add_<something else>() calls (31.50%), under 50% threshhold, but not really that great.
tools/checkfiltername.pl reports 42 errors.
svn path=/trunk/; revision=44706
2012-08-30 20:36:53 +00:00
Jeff Morriss
3268b5b215
Remove trailing space in some hf names.
...
Add some hf names (some entries had only a space for a name).
Remove non-ASCII chars and C++/C99-style comments.
svn path=/trunk/; revision=44705
2012-08-30 20:22:09 +00:00
Anders Broman
e94d8a0b7e
Add Japanese ISUP variant(not all IE's)
...
IE dissection code from Brian Mceniery.
svn path=/trunk/; revision=44703
2012-08-30 18:40:49 +00:00
Bill Meier
7641d97020
Cleanup: Whitespace and long lines;
...
Also: remove a few boilerplate comments.
svn path=/trunk/; revision=44637
2012-08-23 17:11:36 +00:00
Bill Meier
da57a45b8c
value-string arrays - allow "direct" access: fix dup val & fill in a "gap".
...
svn path=/trunk/; revision=44636
2012-08-23 15:38:03 +00:00
Evan Huus
6960a27c75
From Bodo Petermann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7632
...
Fix dissection of ISUP message Generic Numbers with no digits.
svn path=/trunk/; revision=44487
2012-08-14 11:58:20 +00:00
Bill Meier
638d74d43f
Use val_to_str_const() where appropriate;
...
Also (for a few files):
- create/use some extended value strings;
- remove unneeded #include files;
- remove unneeded variable initialization;
- re-order fcns slightly so prefs_reg_handoff...() at end, etc
svn path=/trunk/; revision=44438
2012-08-10 22:55:02 +00:00
Michael Mann
dd6ca38fff
updated more display filters per checkfiltername.pl
...
svn path=/trunk/; revision=44178
2012-08-01 01:57:18 +00:00
Chris Maynard
6590deb37f
Fix Coverity CID 712526: Missing break in switch. Bug introduced with r44134.
...
svn path=/trunk/; revision=44157
2012-07-31 14:32:10 +00:00
Anders Broman
5a4c037e87
Add Russian national variant.
...
svn path=/trunk/; revision=44134
2012-07-30 13:22:38 +00:00
Anders Broman
71f4754f19
Extend a value string.
...
svn path=/trunk/; revision=44028
2012-07-26 08:16:07 +00:00
Jakub Zawadzki
b18e880040
Update FSF address - part II.
...
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Anders Broman
ae43364681
Only dissect as SDp if it's IPBCP (text encoded).
...
svn path=/trunk/; revision=43152
2012-06-08 11:50:52 +00:00
Jeff Morriss
d8c246d53d
Fix CID 700200: the Israeli variant case can't happen in
...
dissect_application_isup() so comment it out for now.
svn path=/trunk/; revision=42554
2012-05-10 18:33:24 +00:00
Jeff Morriss
7afe87264d
Decode the Israeli TCM and CAM messages.
...
svn path=/trunk/; revision=42465
2012-05-07 15:13:28 +00:00
Jeff Morriss
444187c5e8
Add support for Israeli national variant of (ITU) ISUP; Only the BCM
...
message is decoded for now.
Also clean up lots of white space and replace tabs (including 4-space tabs)
with spaces.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4231
svn path=/trunk/; revision=42435
2012-05-05 01:55:21 +00:00
pascal
a4232cc6bd
Remove non-ASCII character
...
svn path=/trunk/; revision=42101
2012-04-16 18:13:34 +00:00
Chris Maynard
3f7146a937
Define ISUP_ITU_STANDARD_VARIANT before using it.
...
svn path=/trunk/; revision=42100
2012-04-16 17:17:18 +00:00
Anders Broman
b365941321
Introduce a preference to set Standard or National ITU ISUP variant.
...
svn path=/trunk/; revision=42099
2012-04-16 15:52:32 +00:00
Anders Broman
3f87ab8e85
Add dissection of French national messages.
...
svn path=/trunk/; revision=42098
2012-04-16 15:28:57 +00:00
Anders Broman
d7192a8bac
Use content_type_parameter_str in dissect_application_isup()
...
to determine ISUP standard and ISUP variant(French).
Also fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6258
svn path=/trunk/; revision=42095
2012-04-16 14:11:32 +00:00
Anders Broman
a43d44f907
Separate ANSI and ITU messages.
...
svn path=/trunk/; revision=42093
2012-04-16 13:28:41 +00:00
Chris Maynard
1574813764
Fix Coverity CID's 1439-1448 OVERRUN_STATIC introduced with r41468. Also fix one additional dead store.
...
svn path=/trunk/; revision=41702
2012-03-21 03:04:15 +00:00
Alexis La Goutte
63b9d7324e
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41468
2012-03-10 17:49:17 +00:00
Jeff Morriss
183f0e934c
Create a list of MTP Service Indicator macros and use them.
...
svn path=/trunk/; revision=40828
2012-02-03 18:26:37 +00:00
Chris Maynard
436b44b99e
Fix some duplicate display filter names.
...
svn path=/trunk/; revision=40592
2012-01-19 21:57:24 +00:00
Bill Meier
794757ae8f
For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
...
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Jeff Morriss
449d732485
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5221 :
...
Don't assume that the Called party number has digits: it may not, especially
in protocols like INAP.
Rearrange the (pre-existing) no-digits check when dissecting Calling addresses
so we don't pass the empty address to taps.
svn path=/trunk/; revision=39502
2011-10-21 01:50:25 +00:00
Bill Meier
293049dfba
Do some conversions of proto_tree_add_item() 'encoding' arg.
...
(previously missed).
57 FT_BOOLEAN: FALSE-->ENC_BIG_ENDIAN
31 FT_BOOLEAN: TRUE-->ENC_LITTLE_ENDIAN
10 FT_BYTES: ENC_BIG_ENDIAN-->ENC_NA
1 FT_BYTES: ENC_LITTLE_ENDIAN-->ENC_NA
21 FT_BYTES: FALSE-->ENC_NA
2 FT_BYTES: TRUE-->ENC_NA
2 FT_IPXNET: ENC_BIG_ENDIAN-->ENC_NA
6 FT_IPv6: ENC_BIG_ENDIAN-->ENC_NA
1 FT_IPv6: FALSE-->ENC_NA
6 FT_NONE: ENC_BIG_ENDIAN-->ENC_NA
19 FT_NONE: FALSE-->ENC_NA
3 FT_NONE: TRUE-->ENC_NA
1 FT_STRING: ENC_BIG_ENDIAN-->ENC_ASCII|ENC_NA
1 FT_STRING: ENC_LITTLE_ENDIAN-->ENC_ASCII|ENC_NA
5 FT_STRING: FALSE-->ENC_ASCII|ENC_NA
1 FT_STRING: TRUE-->ENC_ASCII|ENC_NA
4 FT_STRINGZ: ENC_NA-->ENC_ASCII|ENC_NA
8 FT_STRINGZ: FALSE-->ENC_ASCII|ENC_NA
1 FT_INT32: FALSE-->ENC_BIG_ENDIAN
1 FT_INT32: TRUE-->ENC_LITTLE_ENDIAN
11 FT_UINT8: 0-->ENC_BIG_ENDIAN
111 FT_UINT8: FALSE-->ENC_BIG_ENDIAN
17 FT_UINT8: TRUE-->ENC_LITTLE_ENDIAN
1 FT_UINT16: 0-->ENC_BIG_ENDIAN
68 FT_UINT16: FALSE-->ENC_BIG_ENDIAN
18 FT_UINT16: TRUE-->ENC_LITTLE_ENDIAN
4 FT_UINT24: FALSE-->ENC_BIG_ENDIAN
70 FT_UINT32: FALSE-->ENC_BIG_ENDIAN
1 FT_UINT32: TRUE-->ENC_LITTLE_ENDIAN
4 FT_UINT64: FALSE-->ENC_BIG_ENDIAN
1 FT_UINT64: TRUE-->ENC_LITTLE_ENDIAN
1 FT_UINT_STRING: FALSE-->ENC_ASCII|ENC_BIG_ENDIAN
svn path=/trunk/; revision=39442
2011-10-16 23:38:49 +00:00
Bill Meier
67ee5049d4
Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
...
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_BOOLEAN
FT_IPv4
FT_EUI64
FT_GUID
FT_UINT_STRING
Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260 )
svn path=/trunk/; revision=39328
2011-10-10 00:39:31 +00:00
Bill Meier
4e57694d4a
Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
...
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_UINT8
FT_UINT16
FT_UINT24
FT_UINT32
FT_UINT64
FT_INT8
FT_INT16
FT_INT24
FT_INT32
FT_INT64
FT_FLOAT
FT_DOUBLE
svn path=/trunk/; revision=39288
2011-10-06 03:35:44 +00:00
Bill Meier
94f36ca4ff
Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
...
FT_NONE
FT_BYTES
FT_IPV6
FT_IPXNET
FT_OID
Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN
svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00