Commit Graph

27 Commits

Author SHA1 Message Date
Guy Harris aa36cca7d8 Don't explicitly initialize "h245_labels", as it's hard to initialize
all of it correctly, and as if you don't initialize all of it you get a
compiler warning.

Add an assignment to squelch a compiler warning.

svn path=/trunk/; revision=14317
2005-05-05 11:07:22 +00:00
Gerald Combs b233c06fb2 From Cvetan Ivanov:
This patch fixes the slightly broken logic in the loop which searches
for establisted call in isup_calls_packet.

The problem is that (right_pair) is set to false if we see call on the
same CIC as existing conversation, but with different opc/dpc pair:

at this point dpc/opc pair is not checked, so any call with the same
CIC matches:

voip_call.c:851
                                 else{
                                         right_pair = FALSE;
                                 }

and then the correct conversation is never found, because right_pair is
never reset for this packet, which leads to total confusion of the call
tracking logic

Fixed by initializing right_pair = TRUE for every loop iteration 

svn path=/trunk/; revision=14269
2005-05-02 14:45:43 +00:00
Lars Roland 41e0f63cfb From Francisco Alcoba:
fix the H323 and SIP part of the voip call analysis for the new tap ordering.

svn path=/trunk/; revision=14070
2005-04-14 00:26:11 +00:00
Ronnie Sahlberg 573ba4ee40 From Francisco Alcoba
patch for viop analysis to fix the breakage from the tap reordering patch



svn path=/trunk/; revision=14017
2005-04-05 08:14:58 +00:00
Anders Broman 0785351d20 From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.

svn path=/trunk/; revision=13935
2005-03-27 20:54:18 +00:00
Guy Harris c0f813c0a4 Flag an unused argument as unused, to squelch compiler warnings, and
don't flag a used argument as unused.

svn path=/trunk/; revision=13706
2005-03-11 01:15:35 +00:00
Luis Ontanon 008054453b From Alejandro Vaquero:
- Automatic dissection of RTP events (RFC2833) set in SDP sessions.
- Add RTP events (RFC2833) to the Voip Graph


svn path=/trunk/; revision=13697
2005-03-10 19:32:22 +00:00
Luis Ontanon 27915a0f80 From Alejandro Vaqero:
- Fix a problem when pressing a key when  the "Graph" is  displayed
without any frame selected.

   - Add support for RTP Payload changes. Now the graph will show any
change in the RTP payload type. This is useful for example to show DTMF
2833 in a call.

-This line, and those below, will be ignored--

M    gtk/graph_analysis.c
M    gtk/voip_calls.c
M    gtk/voip_calls.h

svn path=/trunk/; revision=13651
2005-03-07 19:10:21 +00:00
Luis Ontanon 2e28b1b828 From Alejandro Vaquero:
Avoid adding to a call non ISUP mtp3 packets towards the same destination as a copy of the last ISUP packet towards that dpc.

svn path=/trunk/; revision=13576
2005-03-02 23:25:41 +00:00
Luis Ontanon f7d5537137 From Alejandro Vaquero:
patch to the voip calls facility to:

- Add a horizontal scrollbar in the "Graph" to scroll the "comments"
- Fix a "state" bug in H323 and SIP calls
- Fix a bug that can make the "graph" to crash, and also clean up the "address" when the window is close



svn path=/trunk/; revision=13565
2005-03-01 16:19:46 +00:00
Lars Roland 2ed9ca813b By Francisco Alcoba:
Support for name resolution and IPv6 in VoIP Call Analysis

svn path=/trunk/; revision=13501
2005-02-24 21:31:20 +00:00
Ronnie Sahlberg 76d9049746 g_strrstr does not exist in gtk 1
replace it with strstr


svn path=/trunk/; revision=13477
2005-02-23 08:37:30 +00:00
Luis Ontanon 5926160fa9 From Alejandro Vaquero:
replace the code that used g_strsplit_set and was broken by me
  changing it to g_strsplit with something that works


svn path=/trunk/; revision=13470
2005-02-22 19:37:46 +00:00
Ulf Lamping 424a80c9c7 bugfix: using the "rtp_example.raw.gz" from the wiki, the dialog runs into an endless loop, as a g_list_next() was missing in a while loop
svn path=/trunk/; revision=13466
2005-02-22 07:25:16 +00:00
Luis Ontanon a26c9e6299 from Alejandro Vaquero
- fix the thinks I broken removing warnings in the last commit

other than that I removed calls to glib2 that broke
compilation on solaris' buiddbot


svn path=/trunk/; revision=13461
2005-02-21 22:53:01 +00:00
Luis Ontanon 9ff6891a86 fix few things:
- boolean does not exists in *nix change them to g_boolean
- removed some warnings about uninitialized variables
- mgcp_info->hasDigitMap is a pointer to a boolean, dereference it


svn path=/trunk/; revision=13456
2005-02-21 02:36:55 +00:00
Lars Roland b65e9739d2 Don't register mgcp taps,
when we haven't loaded the mgcp plugin.

and

From Alejandro Vaquero:
mgcp support for the voip call analysis tap

svn path=/trunk/; revision=13447
2005-02-20 15:53:11 +00:00
Guy Harris ffc29da21e Add #includes to define various macros and declare various functions.
svn path=/trunk/; revision=13403
2005-02-14 22:06:22 +00:00
Lars Roland aec5f71469 remove a bunch of unnecessary "includes" from VoIP tap and graph analysis sources
svn path=/trunk/; revision=13392
2005-02-13 23:30:56 +00:00
Lars Roland 66194e3f4a And finally (I hope) the last part from the patch
from Alejandro Vaquero:
 
  patch for "Voip analysis" to get the LRQ/LCF/LRJ messages included in the H323 calls for Gatekeeper to Gatekeeper configurations

svn path=/trunk/; revision=13347
2005-02-07 21:09:23 +00:00
Lars Roland a9cc1df551 remove obsolete function add_rtp_streams_graph() from voip_calls.[ch] and fix a register_tap_listener() call.
svn path=/trunk/; revision=13314
2005-02-05 23:34:56 +00:00
Anders Broman c00014119d From Alejandro Vaquero:
a patch that to shows the RTP streams in the Graph. Now 
using an RTP tap (not using the rtp_stream).

svn path=/trunk/; revision=13299
2005-02-05 11:07:21 +00:00
Anders Broman 4d97ad9eb1 From Francisco Alcoba:
Patch for graphing ISUP calls. It shows the type of message, 
in the first one the calling and called numbers, and in the second the SPs 
and CIC; in releases it shows the cause value.

svn path=/trunk/; revision=13262
2005-02-03 21:50:19 +00:00
Guy Harris 291e154e03 Use C89 syntax, not C++ syntax, for functions that take no arguments.
svn path=/trunk/; revision=13238
2005-02-02 09:08:42 +00:00
Guy Harris 20730353e2 Make sure "comment" is set.
Get rid of an unused variable.

svn path=/trunk/; revision=13235
2005-02-02 08:08:53 +00:00
Lars Roland 70eb306bb2 for VoIP Call Analysis:
- make VoIP Call Analysis work if, called from command line
- should also work now while capturing with packet list
  updated in "real time" (to be tested)
- give each tap listener a unique identifier, so ethereal
  won't mix them up
- various cleanups
- compile by default

Todo:
- add support for "tap display filter"
- reimplement function to add rtp streams to the call flow.
 

svn path=/trunk/; revision=13232
2005-02-02 01:02:09 +00:00
Lars Roland 197ceddab1 From Alejandro Vaquero:
h323 taps support up to 5 messages per packet now.

VoIP call analysis:
      - Collect ISUP, SIP and H323 calls from a capture and show them in window with the following info:
      - Start and Stop time of the call
      - Init

svn path=/trunk/; revision=13225
2005-02-01 12:12:35 +00:00