Commit Graph

16 Commits

Author SHA1 Message Date
Jeff Morriss 0e8fef5827 Finish getting making the Diameter XML valid XML.
... Except for the fact that many AVP names start with "3GPP".

Make the AVP names XML IDs again.

Fix all the grouped AVPs that reference AVPs (by name) or vice-versa.  This
includes:
 * Fixing a bunch of typos (including type mismatches).
 * Commenting out a number of references to vendor AVPs for which we don't have
   the specs.
 * Adding a few missing AVPs.

Change-Id: Ic2ddb50cc947877de9086be51f7813e8f9be02b4
Reviewed-on: https://code.wireshark.org/review/15973
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-16 17:12:08 +00:00
Jeff Morriss c5528d0b06 Make some more Diameter AVP names unique.
In some cases this means using the correct (updated?) name from the
specification. In others it means prepending the application- or vendor-name
to force uniqueness.

Remove a few more "Unassigned" AVPs from the XML files.

Change-Id: I61d55ef97ff8efc3317c91bf79e73031735f740a
Reviewed-on: https://code.wireshark.org/review/15949
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-15 23:41:04 +00:00
Jeff Morriss d74113fbfb Don't list "AVP" as a possible member of a grouped AVP.
There's no AVP named "AVP".  And there's no need to tell Wireshark that any AVP
may put in the group (the RFC lists "AVP" for that purpose).

Change-Id: I3591af725ebe089e13eae7b712ef4404cb7924a2
Reviewed-on: https://code.wireshark.org/review/15906
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-14 21:44:08 +00:00
Jeff Morriss 7f6fe7a1fd Reorganize some of the Diameter XML files, taking advantage of the fact that
AVPs can be grouped by Vendor now (not just by Application).

Move a bunch of vendor-specific Application IDs to the vendor's XML file.

Delete the (basically empty) SKT.xml, ChinaTelecom.xml, and VerizonWireless.xml
files.

Fix a typo: 16777224 is 3GPP Gx, not 3GPP Cx.

Use (derived) type Enumerated (rather than Unsigned32 or Integer32) when the
AVP is of type Enumerated.

Change-Id: I7a9702c0c48dc3fe751ad74413d8ecc040984f1f
Reviewed-on: https://code.wireshark.org/review/8235
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-29 11:37:29 +00:00
Jeff Morriss ecc3369c05 Misc. Diameter XML cleanups.
Consistently used (derived) type Enumerated (rather than Unsigned32 or
Integer32) when the AVP is of type Enumerated.

Use a uri of "none" when we don't have access to the specification.
Update the URI of an Application or two.

Clean up white space and formatting.

Change-Id: Iad677db186469b7d8c4a23b7a7fca6c357dbc012
Reviewed-on: https://code.wireshark.org/review/8164
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2015-04-22 01:50:23 +00:00
Alexis La Goutte 7287b58ff5 Continue to remove $Id$ from top of file
(Using sed : sed -i '/^<!-- \$Id\$ -->/,+0 d') (XML Comments)

Change-Id: Ifd03f70ae84dfbbbe04d91f10fd30857fd197014
Reviewed-on: https://code.wireshark.org/review/882
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-31 18:46:03 +00:00
Anders Broman 0badfa1224 From Josip Medved: Diameter dictionary has few invalid gavp definitions https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6867
svn path=/trunk/; revision=41169
2012-02-24 05:39:13 +00:00
Anders Broman 8785d27bd8 Define unused AVP:s to make it possible to use value_string_ext for
common AVP:s.

svn path=/trunk/; revision=34824
2010-11-09 17:23:57 +00:00
Anders Broman 52c69cd0b6 From KATAOKA Toshihiro:
Completion Diameter definition for mobileipv4.xml.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4600

svn path=/trunk/; revision=32254
2010-03-20 22:21:19 +00:00
Anders Broman e3259bb648 From KATAOKA Toshihiro:
Diameter dictionary for MIPv4 is out of RFC4004.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4587

svn path=/trunk/; revision=32213
2010-03-16 21:29:42 +00:00
Anders Broman 3246929f31 Add enum values for some IANA registered AVP:s.
svn path=/trunk/; revision=27300
2009-01-26 20:06:22 +00:00
Anders Broman 5018f190e5 Add AVP:s
svn path=/trunk/; revision=23559
2007-11-24 10:55:42 +00:00
Anders Broman a3215e2d65 Add SIP application AVP:s (Incomplete) and sortmobileipv4 in numerical order.
svn path=/trunk/; revision=19889
2006-11-14 06:14:20 +00:00
Anders Broman 6aea9d65c9 Use the correct Application Id:s fix a typo.
svn path=/trunk/; revision=16551
2005-11-19 15:58:16 +00:00
Anders Broman 131a1b3269 Update some 3GPP AVP:s
svn path=/trunk/; revision=16498
2005-11-13 16:40:55 +00:00
Guy Harris a275cd2495 Move the Diameter dictionary files to a "diameter" subdirectory, along
the lines of what's done for RADIUS.  That keeps them together (and
separate from other files), and makes the layout of the top-level source
directory closer to the layout of the installation directory, so that if
you run Ethereal or Tethereal from the top-level directory on Windows
it'll pick up the Diameter dictionary files (if it supports loading
them), and can do so on UN*X if we support a mechanism to let it find
its control files in the directory in which the binary resides.

Use the diameter_DATA, dtds_DATA, and radius_DATA macros in the
EXTRA_DIST macro, so you only have to change the lists of Diameter, DTD,
and RADIUS files in one place if you add or remove a file.

svn path=/trunk/; revision=16050
2005-09-29 02:20:29 +00:00