Commit Graph

1292 Commits

Author SHA1 Message Date
Ulf Lamping c01339acd3 bugfix: don't write the recent files list in the wrong order to the recent file
svn path=/trunk/; revision=10073
2004-02-16 19:00:09 +00:00
Guy Harris 75acdcbba0 As noted by Pavel Kankovsky, the "Resolve Name" menu items should be
available if *any* forms of name resolution aren't enabled.  (Well,
actually, it should probably affect only the item the mouse was over
when you selected it, and should be available if name resolution for
that type of name isn't enabled, but....)

svn path=/trunk/; revision=10056
2004-02-13 01:09:52 +00:00
Guy Harris a1667bf2c0 The Help window should be a separate top-level window, not a dialog
subordinate to the main window - it's a separate top-level window in
W2K, Mac OS X, and, I think, both GNOME and KDE.

svn path=/trunk/; revision=10055
2004-02-13 00:56:30 +00:00
Guy Harris 36ece5a17a Add a "window_new()" routine that creates a window of a given type, sets
the title, and arranges to set the icon for it.  Use that instead of
"gtk_window_new()" and separate calls to set the title and arrange to
set the icon.

Regularize #includes a bit.

Clean up white space.

svn path=/trunk/; revision=10054
2004-02-13 00:53:37 +00:00
Guy Harris 5f27347dfa Create only one "Plugins" window per process.
svn path=/trunk/; revision=10053
2004-02-13 00:00:56 +00:00
Guy Harris c5b4dad036 Create only one "About Ethereal" window per process.
svn path=/trunk/; revision=10052
2004-02-13 00:00:25 +00:00
Guy Harris 90cf9a6b7b The HIG's and/or GUI toolkit documentation for:
Mac OS X

	GNOME

	Qt

	KDE

	Windows

all indicate that {message,alert} boxes are modal, at least for the
window to which they apply.  (Presumably the idea is that not forcing
the user to pay attention to the alert box, and allowing more than one
alert box to be up for a given window, causes more problems than not
letting the user do stuff to that window in order to figure out what the
underlying problem is or figure out what to do to fix it - the message
should be sufficient, in most if not all cases, to let you know what the
problem is.)

Make "simple_dialog()" unconditionally make the alert box modal, and get
rid of ESD_TYPE_MODAL.  XXX - we need to make it possible to make an
alert box modal for a given window, rather than just the top-level
window.

svn path=/trunk/; revision=10051
2004-02-12 22:24:28 +00:00
Guy Harris f99bb93e55 Cast "char" values to "guchar" before passing them to <ctype.h> macros,
so that characters with the 8th bit set don't get sign-extended and
cause the macros not to return the right answer.

svn path=/trunk/; revision=10036
2004-02-11 09:19:54 +00:00
Guy Harris 6b1a0bf430 Most taps that now include "tap_menu.h" no longer need to include
<stdio.h> to define FILE; get rid of the include.

svn path=/trunk/; revision=10034
2004-02-11 04:28:49 +00:00
Guy Harris 9aa32731b9 From Michael Lum: add tap for GSM MAP message statistics.
svn path=/trunk/; revision=10032
2004-02-11 04:19:03 +00:00
Guy Harris 8e4a1c1cc6 Move the declaration of "register_tap_menu_item()" into a new
"tap_menu.h" file, and have the Ethereal taps include that rather than
"menu.h", so we don't have to worry about making sure we've included
<stdio.h> to define FILE, etc. just because some "menu.h" functions
require it.

svn path=/trunk/; revision=10031
2004-02-11 04:17:05 +00:00
Guy Harris 2e4e229739 Get rid of the "Question" alert box type - rename it to "Confirmation",
as that seems to be the name used in the GNOME HIG, at least.  Make it
use the Warning icon (that's what the GNOME HIG says - and it's also
what's used for the equivalent on Windows), and use it for the "Save
current capture?" alert boxes.

svn path=/trunk/; revision=10030
2004-02-11 03:55:48 +00:00
Guy Harris 34349cedcc Give alert boxes an empty title on UN*X and a title of "Ethereal" on
Win32, to match the GNOME HIG on UN*X and the Win32 HIG on Windows (or,
at least, to approximate the Win32 HIG on Windows).

svn path=/trunk/; revision=10029
2004-02-11 03:40:17 +00:00
Guy Harris 3a4e71a724 Add "write_failure_alert_box()" to put up an alert box for a failed
attempt to write to a file (or close a file opened for writing).

Get rid of no-longer-needed #includes of <epan/filesystem.h>.

svn path=/trunk/; revision=10027
2004-02-11 01:37:13 +00:00
Guy Harris 727b913bbd Add an "open_failure_alert_box()" routine to pop up an alert box for a
failed attempt to open/create a file.

Fix one call to pass the right value for the "for_writing" flag.

svn path=/trunk/; revision=10026
2004-02-11 01:23:25 +00:00
Guy Harris c7fd1b2b13 Add a routine to be used to put up alert boxes for invalid display
filter expressions; use that in a number of places, so we use the same
alert box.  (More work is needed to figure out the right way to handle
some other "dfilter_compile()" failures.)

Use the error message from the display filter as the primary error, as
that's the message that tells you what the underlying problem is.  (The
GNOME HIG says "In most situations the user should only need the primary
text to make a quick decision", so the primary text should tell you
what's wrong with the filter, not just that it's invalid.  If there are
messages from the display filter code that don't give enough
information, or are a bit cryptic, such as "Unexpected end of filter
string," those should be fixed in the display filter code.)

Improve the error used if an empty filter is used for "find frame".

svn path=/trunk/; revision=10025
2004-02-11 00:55:28 +00:00
Ulf Lamping 1b9bef2743 bugfix: init the toolbar's Save icons correctly
svn path=/trunk/; revision=10016
2004-02-09 18:32:41 +00:00
Ulf Lamping 1f15fc7bdc minor changes
svn path=/trunk/; revision=10015
2004-02-09 18:25:48 +00:00
Ulf Lamping 5297f06717 replaced every appearance of gtk_scrolled_window_new() with
scrolled_window_new().
added gtk_scrolled_window_set_policy(AUTOMATIC,AUTOMATIC) to
scrolled_window_new()
added GTK2's gtk_scrolled_window_set_shadow(GTK_SHADOW_IN)
to every place needed

svn path=/trunk/; revision=9999
2004-02-06 19:19:12 +00:00
Jörg Mayer 348c83db8c Fix a few warnings
svn path=/trunk/; revision=9997
2004-02-06 14:59:52 +00:00
Guy Harris 046ec36540 The menu item for changing the state of name resolution for
network-layer addresses should call the callback for network name
resolution, not MAC name resolution.

svn path=/trunk/; revision=9980
2004-02-04 20:46:20 +00:00
Guy Harris 372e6b2da0 Add some comments about the types of alert boxes you get with the
simple_dialog routines (which are really just message box/alert box
routines).

Add some macros for combinations of buttons (corresponding to
combinations that some GUI toolkits, which only support some
combinations, allow).

svn path=/trunk/; revision=9977
2004-02-04 01:10:37 +00:00
Ulf Lamping 1d2c791ab6 enhanced some dialog messages,
close capture file when user told so

svn path=/trunk/; revision=9965
2004-02-03 17:59:01 +00:00
Ulf Lamping 3f2f2929eb added some more info to the statusbar (filesize, packet count, ..),
fixed a minor bug in the cfile handling (file length in summary dialog)

svn path=/trunk/; revision=9961
2004-02-03 00:16:59 +00:00
Guy Harris 12e944262d Include <string.h> to declare "strlen()".
svn path=/trunk/; revision=9959
2004-02-02 22:51:30 +00:00
Guy Harris 7b5e98bf8e Mark the "widget" argument to "main_load_window_geometry()" as unused
when building for GTK+ 1.2[.x].

svn path=/trunk/; revision=9955
2004-02-01 22:43:34 +00:00
Ulf Lamping d11080a09f moved window geometry values from prefs to recent,
added new pref / recent setting: "maximized main window",
which will save, if the main window is maximized or not,
this will take effect on GTK version 2 only, but is saved nonetheless

svn path=/trunk/; revision=9949
2004-02-01 20:28:11 +00:00
Ulf Lamping 5ed2dfc130 replace "RTT Graph" by "Round Trip Time Graph" as this is more descriptive
svn path=/trunk/; revision=9948
2004-02-01 15:36:15 +00:00
Ulf Lamping b1141c97d1 beautified the dialog a bit
svn path=/trunk/; revision=9947
2004-02-01 15:33:08 +00:00
Ulf Lamping 44f10048da avoid very large dialogs, when display filters becoming too large,
especially true when working with TCP stream filtering

svn path=/trunk/; revision=9946
2004-02-01 13:13:33 +00:00
Ulf Lamping 3b688a8aaf avoid problems when strings becoming too large,
especially true when working with TCP stream filtering

svn path=/trunk/; revision=9945
2004-02-01 13:12:10 +00:00
Ulf Lamping db13141aab DND: also unescape URI characters (e.g. %20 -> ' ')
svn path=/trunk/; revision=9940
2004-02-01 10:01:19 +00:00
Guy Harris e1e17ea8b2 Konqueror, in KDE 3.0, appears to drop file names of the form
"file:/foo/bar/...", so that only the "file:" should be stripped off.

Note that we should probably look for "file:" followed by an arbitrary
number of "/"s, and, at least on UNIX, strip off all but the last of
those "/"s.

svn path=/trunk/; revision=9932
2004-02-01 02:59:20 +00:00
Ulf Lamping d3bd405201 change layout, as dialog was a bit tall,
improved resizability

svn path=/trunk/; revision=9927
2004-01-31 20:31:20 +00:00
Ulf Lamping 5b38a022e4 Implemented rudimentary Drag and Drop support.
svn path=/trunk/; revision=9926
2004-01-31 18:32:37 +00:00
Ulf Lamping 3c763c4fb6 fixed some sensitivity things in the context menues
svn path=/trunk/; revision=9925
2004-01-31 14:23:53 +00:00
Ulf Lamping 124d4e8c90 minor change in dialog text
svn path=/trunk/; revision=9924
2004-01-31 14:16:43 +00:00
Ulf Lamping acd562ac91 gtk_label_set_selectable() is only available from GTK version 2
svn path=/trunk/; revision=9923
2004-01-31 12:49:54 +00:00
Ulf Lamping d244cd82f5 cleanup of new "question dialogs",
using GTK2 primary/secondary message text from GNOME HIG for simple_dialogs,
added a "question dialog" for the coloring rules "Clear" button

svn path=/trunk/; revision=9921
2004-01-31 12:13:23 +00:00
Guy Harris d4857dc706 Add to the _rtp_info structure a "info_all_data_present" boolean, which
is TRUE if all the RTP raw data is present in the tvbuff and FALSE
otherwise.  If it's not all present, also set "info_data_len" to 0 and
"info_data" to NULL.

In the RTP Analysis "Save Payload..." operation, check the
"info_all_data_present" flag and fail if it's not set, and use
"rtpinfo->info_data" and "rtpinfo->info_payload_offset" to get at the
payload, rather than using "cfile.pd", as the latter doesn't necessarily
refer to the current frame data.

Note that the RTP Streams save operation should also check the
"info_all_data_present" flag.

svn path=/trunk/; revision=9920
2004-01-31 09:48:26 +00:00
Guy Harris c3d41534ff If comparing any field other than the frame number, if both field values
are the same, compare the frame number, so that the sort order doesn't
depend on how packets happened to be sorted previously (i.e., so that if
you sort on a given column in a given direction, the sort order is
always the same).

svn path=/trunk/; revision=9918
2004-01-31 04:26:23 +00:00
Guy Harris f914e6e9e7 Fix the spelling of "cumulative" (and variables whose names derive from
that spelling).

svn path=/trunk/; revision=9917
2004-01-31 04:10:05 +00:00
Guy Harris 1980fa5dbf Pass ESD_BTN_OK rather than NULL as a second argument to
"simple_dialog()"; NULL might be #defined to be a pointer expression on
some platforms, causing compiler warnings (and, on platforms where a
null pointer doesn't have all its bits 0, possibly causing misbehavior,
although I don't think there are any such platforms on which Ethereal
runs).

Don't allow 0 as button mask argument to "simple_dialog()".

Squelch a compiler warning.

Report fatal problems as errors, not warnings.

Report file I/O errors with "file_open_error_message()".

Report file write errors (including those reported by "close()", e.g.
some errors writing to an NFS server) when saving raw packet data to a
file.

svn path=/trunk/; revision=9915
2004-01-31 03:22:42 +00:00
Ulf Lamping 25edd1c53e renamed ESD_TYPE_CRIT to ESD_TYPE_ERROR to
better reflect the real error text

svn path=/trunk/; revision=9913
2004-01-31 02:25:46 +00:00
Ulf Lamping 70fa1b55ff using GTK2 stock icons for dialogs instead of Ethereal specific ones
svn path=/trunk/; revision=9911
2004-01-31 01:28:11 +00:00
Ulf Lamping d3316d2834 slightly higher polling rate, to detect stop condition from capture task
svn path=/trunk/; revision=9909
2004-01-30 06:43:16 +00:00
Ulf Lamping 3c76ec1aa2 every GUI action, which will erease a currently unsaved capture file,
will now raise a dialog "Save xy before z?" with Yes/No/Cancel buttons.

svn path=/trunk/; revision=9908
2004-01-29 23:11:38 +00:00
Ulf Lamping 419837e531 added "Yes" and "No" buttons to the simple_dialog,
added a callback method, to be called if a button was pressed

svn path=/trunk/; revision=9907
2004-01-29 23:07:17 +00:00
Ulf Lamping e66b849e23 added GTK_STOCK_YES and GTK_STOCK_NO to the dlg_button_row
svn path=/trunk/; revision=9906
2004-01-29 22:37:45 +00:00
Guy Harris d2e4e9ecc9 Fix a comment.
svn path=/trunk/; revision=9897
2004-01-28 10:37:14 +00:00