osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
55148 commits 23 branches 0 tags 1.3 GiB
Commit graph

80 commits

Author SHA1 Message Date
Bill Meier
10406870f5 Add editor modelines; fix indentation as needed. 
Change-Id: I1ad94654343e5a018a0b3159481d45ffb3a91263
Reviewed-on: https://code.wireshark.org/review/4363
Reviewed-by: Bill Meier <wmeier@newsguy.com>
 2014-09-29 13:47:02 +00:00
Michael Mann
3df42e79a5 proto_tree_add_text cleanup 
Create filters (expert and hf_) that have the "most bang for the buck" (ie have many instances for a single filter)

Change-Id: I61995e41c5b298df77e084e65cdf30ebe95da1e6
Reviewed-on: https://code.wireshark.org/review/4086
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-09-12 05:51:11 +00:00
Jeff Morriss
863b6646d6 Replace a couple of implementations of unpack_digits() with tvb_bcd_dig_to_wmem_packet_str(). 
Change-Id: Ic9e740345fb3a748f6df4f624441bb947bbd9429
Reviewed-on: https://code.wireshark.org/review/3797
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-08-22 20:24:47 +00:00
AndersBroman
ca390efcad Remove now unused code, do API changes missed in previous commit. 
Change-Id: Ibc814fb56f34b6c74cb7751e790978748ea8b1db
Reviewed-on: https://code.wireshark.org/review/3747
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-08-20 11:38:31 +00:00
AndersBroman
9f43bbd01a Use dissect_e212_imsi() to dissect IMSI. 
Fix deprecated APIs
Restore delted hf.

Change-Id: I5c08dd8e702a6fadd0409cec608d9a7b153f8164
Reviewed-on: https://code.wireshark.org/review/3746
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-08-20 11:27:56 +00:00
Michael Mann
188aa9a80e convert to proto_tree_add_subtree[_format] 
Change-Id: Ib60ca75b7da8cfa21cfe2999c9b9448a02c332df
Reviewed-on: https://code.wireshark.org/review/2560
Tested-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-06-22 21:07:16 +00:00
Michael Mann
4560881070 Cleanup display filters reported by checkfiltername.pl 
Also ensured some files have their correct names at the top so they are more easily grepped

Change-Id: Ib0f5ddf14eb1616a93dee496107dc0eb09048825
Reviewed-on: https://code.wireshark.org/review/2452
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-06-20 04:09:31 +00:00
Michael Mann
14824e6adf Revert "Fixup: tvb_* -> tvb_captured" 
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html

This reverts commit 246fe2ca4c.

Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-06-19 18:25:59 +00:00
Dario Lombardo
246fe2ca4c Fixup: tvb_* -> tvb_captured 
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-06-18 14:14:58 +00:00
Michael Mann
73217d9f3f tvb_new_subset -> tvb_new_subset_length when length parameters are equal. 
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is.

Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d
Reviewed-on: https://code.wireshark.org/review/1999
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-06-07 15:41:07 +00:00
Alexis La Goutte
296591399f Remove all $Id$ from top of file 
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')

Fix manually some typo (in export_object_dicom.c and crc16-plain.c)

Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-03-04 14:27:33 +00:00
Evan Huus
8f665d9b36 Add a sixteenth element to all BCD digit sets to avoid garbage values when 
decoding corrupt bytes. Some of these digit sets could probably be
deduplicated...

svn path=/trunk/; revision=54224
 2013-12-18 15:54:32 +00:00
Pascal Quantin
6cedc2c336 Convert a few more dissectors to wmem 
svn path=/trunk/; revision=51991
 2013-09-12 22:03:31 +00:00
Anders Broman
bed8ebd289 Register BSSAP+ by name. 
svn path=/trunk/; revision=50851
 2013-07-23 19:51:14 +00:00
Anders Broman
4f1f9903f4 [-Wmissing-prototypes] 
explicit casts.

svn path=/trunk/; revision=48310
 2013-03-15 04:52:42 +00:00
Bill Meier
96a24cc79f Fix spelling/typos found using a list of commonly misspelled words. 
The misspellings were mostly in comments but some were
in text strings visible to the user.


svn path=/trunk/; revision=47899
 2013-02-26 04:42:26 +00:00
Bill Meier
c439b805e2 Comment out unused hf[] entries & etc. 
(found by checkhf)

svn path=/trunk/; revision=47389
 2013-01-31 17:55:31 +00:00
Anders Broman
c6f702432e Register in the UDP heuristic table rather than the internal one. 
svn path=/trunk/; revision=47133
 2013-01-17 16:10:22 +00:00
Anders Broman
5c1bc94608 "Fill" a couple of value_string(ext) 
svn path=/trunk/; revision=46518
 2012-12-12 12:48:12 +00:00
Evan Huus
2461373edd Remove unneeded variable initializers. 
svn path=/trunk/; revision=46328
 2012-12-02 15:21:53 +00:00
Jeff Morriss
0266cceef3 Make all enum_val_t's const. 
svn path=/trunk/; revision=46292
 2012-11-29 20:15:37 +00:00
Bill Meier
93d3fa2257 Minor cleanup: 
- revert incorrect replacement of FALSE by ENC_BIG_ENDIAN
  done a while back (10 instances);
  [The incorrect use of ENC_BIG_ENDIAN was benign since
   ENC_BIG_ENDIAN is currently defined ad 0x0000000];
- create/use extended value strings as appropriate;
- remove unneeded initializers;
- reformat hf[] entries;
- whitespace.

svn path=/trunk/; revision=45638
 2012-10-18 17:39:45 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Jakub Zawadzki
5a8783f5b1 Initial commit to support yet another method of passing data between dissectors. 
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
 2012-09-10 21:40:21 +00:00
Chris Maynard
03a9a37863 Don't add proto_bssap to the tree twice, once as a hidden item and once using proto_tree_add_text(). Instead use proto_tree_add_protocol_format(). Problem reported here: http://article.gmane.org/gmane.network.wireshark.user/14509 
svn path=/trunk/; revision=44509
 2012-08-14 21:58:36 +00:00
Bill Meier
638d74d43f Use val_to_str_const() where appropriate; 
Also (for a few files):
- create/use some extended value strings;
- remove unneeded #include files;
- remove unneeded variable initialization;
- re-order fcns slightly so prefs_reg_handoff...() at end, etc

svn path=/trunk/; revision=44438
 2012-08-10 22:55:02 +00:00
Pascal Quantin
8ce8431f4e Update filter names following the changes done in r44162 
svn path=/trunk/; revision=44168
 2012-07-31 20:44:34 +00:00
Chris Maynard
ad3c388b4b tvb_length_remaining() can return -1, so check if its return value is <= 0 when aborting and not just == 0. 
svn path=/trunk/; revision=43702
 2012-07-13 21:32:15 +00:00
Jakub Zawadzki
b18e880040 Update FSF address - part II. 
svn path=/trunk/; revision=43538
 2012-06-28 23:18:38 +00:00
Bill Meier
d12d5a606c AFAICT sys/types.h & netinet/in.h #includes are not needed for these files. 
(Let's see if any of the buildbots give any errors).
Also: remove trailing whitespace on lines.

svn path=/trunk/; revision=42429
 2012-05-04 21:29:00 +00:00
Alexis La Goutte
5634cf10fd Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=41462
 2012-03-10 17:46:18 +00:00
Chris Maynard
b0326c9b9a Fix a duplicate display filter name. 
svn path=/trunk/; revision=40696
 2012-01-24 18:19:35 +00:00
Chris Maynard
c2208aa172 Fix some duplicate display filter names. 
svn path=/trunk/; revision=40586
 2012-01-19 19:15:13 +00:00
Bill Meier
794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg. 
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
 2011-10-21 02:10:19 +00:00
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Anders Broman
4b952c1324 Get rid of check_col, while at it set ENC. 
svn path=/trunk/; revision=39146
 2011-09-26 08:25:18 +00:00
Anders Broman
8d6ca293dc Change the signature of elem_fcn():ns to include pinfo. 
svn path=/trunk/; revision=36443
 2011-04-04 14:37:25 +00:00
Anders Broman
72b69aeaf5 Change the msg_fcn() signature to include pinfo. 
svn path=/trunk/; revision=36441
 2011-04-04 07:45:34 +00:00
Bill Meier
121c65c613 Remove unneeded #includes (stdio.h,stdlib.h); 
Whitespace cleanup: trailing, indentation, "4-space tabs"

svn path=/trunk/; revision=35850
 2011-02-07 18:49:29 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer 
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
 2010-12-20 05:35:29 +00:00
Gerasimos Dimitriadis
27b4dfa426 The Mobile Status msg in BSSAP+ has IMSI as first possible IE 
svn path=/trunk/; revision=33832
 2010-08-17 21:35:26 +00:00
Bill Meier
10ffd14b8f Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces) 
svn path=/trunk/; revision=32735
 2010-05-10 15:54:57 +00:00
Bill Meier
055dd62063 #include <string.h> not needed. 
svn path=/trunk/; revision=32410
 2010-04-06 21:14:01 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h> 
svn path=/trunk/; revision=32367
 2010-04-03 21:55:23 +00:00
Gerasimos Dimitriadis
dfde72f247 Fix for Bug 4588: 
RANAP and friends want the MNC encoded in big endian form.

svn path=/trunk/; revision=32257
 2010-03-20 23:53:22 +00:00
Stig Bjørlykke
b5b2953f61 Fixed abbrev for "Location information age IE". 
svn path=/trunk/; revision=31421
 2010-01-03 14:56:44 +00:00
Gerasimos Dimitriadis
b7261fe2e4 Expert info when E.212 MCC/MNC contain non-decimal digits 
svn path=/trunk/; revision=31102
 2009-11-27 22:57:50 +00:00
Kovarththanan Rajaratnam
6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29345
 2009-08-09 07:59:51 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548: 
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
 2009-06-18 21:30:42 +00:00
Anders Broman
c91a384702 Apply some of the patches from: 
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28356
 2009-05-13 19:46:11 +00:00