Bill Meier
36ce5e1b90
Fix encoding-arg mostly for FT_UINT_STRING; Also: Do misc as needed.
...
Misc: (as needed)
- Add editor modelines;
- Adjust whitespace.
Change-Id: I0e5d877a2a6273842ad8e771ac0c0acbfcb83200
Reviewed-on: https://code.wireshark.org/review/4173
Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-18 15:07:58 +00:00
Evan Huus
f9d4e0a815
Replace deprecated tvb_length calls
...
And a few other misc. cleanups while in the neighbourhood.
Change-Id: Ic0d6836dec9c36d31ea244a6adc74d4713565090
Reviewed-on: https://code.wireshark.org/review/4047
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-10 07:54:00 +00:00
Michael Mann
188aa9a80e
convert to proto_tree_add_subtree[_format]
...
Change-Id: Ib60ca75b7da8cfa21cfe2999c9b9448a02c332df
Reviewed-on: https://code.wireshark.org/review/2560
Tested-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-22 21:07:16 +00:00
Michael Mann
14824e6adf
Revert "Fixup: tvb_* -> tvb_captured"
...
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html
This reverts commit 246fe2ca4c
.
Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19 18:25:59 +00:00
Dario Lombardo
246fe2ca4c
Fixup: tvb_* -> tvb_captured
...
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18 14:14:58 +00:00
Michael Mann
73217d9f3f
tvb_new_subset -> tvb_new_subset_length when length parameters are equal.
...
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is.
Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d
Reviewed-on: https://code.wireshark.org/review/1999
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-07 15:41:07 +00:00
Guy Harris
70ad7d8fd3
Move the status dissecting code to the AFP dissector.
...
The ASP and DSI dissectors had almost-identical dissection of the ASP
and DSI "status" responses. What's being dissected is defined by the AFP
specification (and might be different for protocols *other* than AFP
running atop AFP or DSI), so move that dissection to the AFP dissector.
Note that, at least for AFP-over-DSI, the spec isn't being followed in
at least one capture.
Change-Id: Idb1013483f3a3bdf2b7eb0618e48fc178a338642
Reviewed-on: https://code.wireshark.org/review/987
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-04-06 19:13:48 +00:00
Michael Mann
b6a5f8939a
Expose dissect_spotlight as its own dissector. Needed for DCE/RPC MDSSVC
...
Change-Id: I5c9dbd59b18eff5dc9cb9476f1883cb9fa9d9c02
Reviewed-on: https://code.wireshark.org/review/958
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-04 23:03:03 +00:00
Guy Harris
c5e29ac9a5
Clean up some strings - "UTF8" to "UTF-8", etc..
...
Clean up the display of addresses a bit, and the use of verbs in some
field descriptions.
Change-Id: I3d2d4fc4cd13503924abecee55adfaa899385ffb
Reviewed-on: https://code.wireshark.org/review/954
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-04-04 02:27:28 +00:00
Alexis La Goutte
296591399f
Remove all $Id$ from top of file
...
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')
Fix manually some typo (in export_object_dicom.c and crc16-plain.c)
Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04 14:27:33 +00:00
Guy Harris
07f22ffd40
Use tvb_get_string_enc() rather than tvb_get_string().
...
XXX - if we supported various MacXXX character encodings, we could use
those; that might require a preference to specify the encoding.
svn path=/trunk/; revision=54906
2014-01-22 19:31:03 +00:00
Bill Meier
c00f8779f5
Don't use 'L' as a constant modifier.
...
svn path=/trunk/; revision=54358
2013-12-22 14:47:16 +00:00
Jakub Zawadzki
064082e68a
Change G_GINT64_CONSTANT(xxxxU) to G_GUINT64_CONSTANT(xxxx)
...
svn path=/trunk/; revision=54314
2013-12-20 22:39:32 +00:00
Guy Harris
4043db5865
Rename spotlight_get_utf16_string_encoding() to
...
spotlight_get_utf16_string_byte_order(), and have it return
ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN if it finds a BOM and 0xFFFFFFFF if
it doesn't, to make it a bit clearer what it's doing.
Use tvb_get_string_enc() rather than tvb_get_unicode_string().
svn path=/trunk/; revision=54075
2013-12-13 22:44:58 +00:00
Chris Maynard
acc5fd78e4
Reject the packet if data is NULL.
...
svn path=/trunk/; revision=53707
2013-12-02 02:18:21 +00:00
Jakub Zawadzki
ae59b09443
Add missing includes in order to remove exceptions.h from proto.h (next commit).
...
svn path=/trunk/; revision=53230
2013-11-10 15:59:37 +00:00
Michael Mann
77837d2c9e
Pass struct aspinfo "private data" into subdissectors instead of using pinfo->private_data.
...
svn path=/trunk/; revision=52728
2013-10-21 00:27:36 +00:00
Pascal Quantin
102c452bcb
More emem -> wmem conversion:
...
- tvb_get_g_stringz()/tvb_get_ephemeral_stringz()/tvb_get_seasonal_stringz() -> tvb_get_stringz()
- tvb_get_g_stringz_enc()/tvb_get_ephemeral_stringz_enc() -> tvb_get_stringz_enc()
- tvb_get_ephemeral_unicode_stringz() -> tvb_get_unicode_stringz()
- tvb_bcd_dig_to_ep_str() -> tvb_bcd_dig_to_wmem_packet_str()
- update docs accordingly
svn path=/trunk/; revision=52180
2013-09-22 20:04:35 +00:00
Pascal Quantin
a0c53ffaa1
emem -> wmem conversion:
...
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly
svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
Evan Huus
343772cbcf
Convert a few more dissectors to wmem.
...
svn path=/trunk/; revision=51967
2013-09-12 12:25:17 +00:00
Michael Mann
9e3f9b449f
expert_add_info_format_text -> expert_add_info_format
...
svn path=/trunk/; revision=51852
2013-09-09 00:44:09 +00:00
Michael Mann
28bb3a5591
Batch of filterable expert infos.
...
svn path=/trunk/; revision=50384
2013-07-05 03:10:36 +00:00
Jaap Keuter
97136126bc
Typo's. That is all.
...
svn path=/trunk/; revision=48685
2013-04-01 15:29:49 +00:00
Anders Broman
455f5c8243
- [-Wmissing-prototypes]
...
- explicit casts.
svn path=/trunk/; revision=48265
2013-03-12 20:00:50 +00:00
Guy Harris
7f40879104
Squelch a (Y2.038K) warning.
...
svn path=/trunk/; revision=46756
2012-12-26 06:41:49 +00:00
Guy Harris
be77dce42a
Make some loop counters unsigned, so that we handle very large loop
...
counts by trying to iterate all over the items (and, presumably, failing
when we go past the end of the packet).
When assigning to the loop count, cast the value down, to avoid implicit
64-bit-to-32-bit conversion warnings.
Write those loops as for loops - it makes it a bit clearer what's going
on.
svn path=/trunk/; revision=46657
2012-12-21 08:16:12 +00:00
Jeff Morriss
2552c750e5
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Bill Meier
c591c6dd56
Comment out all but first value_string array entries with dup values:
...
kept: first dup since that's the one which would
be found with a linear search.
svn path=/trunk/; revision=44642
2012-08-23 17:30:42 +00:00
Gerald Combs
cd3cca7edc
Make the corresponding packet_info available to each tree item. This
...
lets us pass a NULL pinfo to expert_add_info_format() and
expert_add_undecoded_item(), which makes it possible to use those
routines deep in the bowels of many dissectors. As a proof of concept
remove the recent pinfo additions to packet-afp.c. This should also make
it easier to fix bug 3884.
svn path=/trunk/; revision=44435
2012-08-10 20:33:01 +00:00
Gerald Combs
015f22cc9a
Use wording that's more in line with other expert messages.
...
svn path=/trunk/; revision=44402
2012-08-09 22:02:28 +00:00
Gerald Combs
5bdeb03b83
Fix a large loop found by Stefan Cornelius of Red Hat Security Response
...
Team (bug 7603).
Display the ACL entry count as decimal instead of hexadecimal.
svn path=/trunk/; revision=44317
2012-08-07 23:06:29 +00:00
Jakub Zawadzki
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Pascal Quantin
2f035a3c0f
From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7334 :
...
FPSpotlightRPC dates structure can contain multiple dates
svn path=/trunk/; revision=43133
2012-06-06 16:55:48 +00:00
Anders Broman
b69547925f
Get rid of a couple of warnings.
...
svn path=/trunk/; revision=43066
2012-06-04 13:52:46 +00:00
Bill Meier
91e5923458
Fix some "warning: Value stored to '...' is never read" clang scan-build warnings.
...
Also; Do some whitespace cleanup in a few cases.
svn path=/trunk/; revision=42715
2012-05-19 14:20:55 +00:00
pascal
101e304d4e
Spaces -> tabs
...
svn path=/trunk/; revision=42637
2012-05-15 21:18:39 +00:00
pascal
96e21ee3f7
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7261 :
...
Add some sanity checks when dissecting SQ_TYPE_NULL
svn path=/trunk/; revision=42636
2012-05-15 21:16:06 +00:00
pascal
d5aa739fd0
From Alexander Lüders & Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7254 :
...
Enhancements for FPSpotlightRPC AFP function
svn path=/trunk/; revision=42633
2012-05-15 19:25:33 +00:00
pascal
05cfd1c391
From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7256 :
...
Fix subquery_count loop variable updating
svn path=/trunk/; revision=42624
2012-05-14 21:46:02 +00:00
pascal
723b213c89
From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7246 :
...
Patch adding dissection of time data
svn path=/trunk/; revision=42620
2012-05-13 21:02:42 +00:00
pascal
b42423a8dc
From Frank Lahm:
...
In FPSpotlightRPC packets, check for elements with 0 childs (denoted by L in TLV is sizeof(TLV tag))
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7245
svn path=/trunk/; revision=42571
2012-05-11 09:03:22 +00:00
pascal
19a766b152
Remove unused hf entries
...
svn path=/trunk/; revision=42516
2012-05-08 20:20:12 +00:00
pascal
0c4569d941
From Frank Lahm:
...
Display guids in FPSpotlightRPC AFP packets
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7237
svn path=/trunk/; revision=42515
2012-05-08 19:38:58 +00:00
Anders Broman
b438c7415f
From Frank Lahm:
...
Fixes for FPSpotlightRPC AFP dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7235
svn path=/trunk/; revision=42508
2012-05-08 14:24:13 +00:00
Bill Meier
2fef9f460f
Don't use tabs in string constants;
...
svn path=/trunk/; revision=42357
2012-04-30 19:55:24 +00:00
Jeff Morriss
891c9db19b
As suggested in http://www.wireshark.org/lists/wireshark-dev/201204/msg00062.html :
...
Don't use ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN with ENC_ASCII: ASCII has no
endianism, so ENC_NA is more appropriate.
svn path=/trunk/; revision=42297
2012-04-27 18:58:37 +00:00
Jakub Zawadzki
8a1dc57c03
Remove doubled semicolons and semicolons outside function.
...
svn path=/trunk/; revision=42053
2012-04-13 20:22:31 +00:00
Bill Meier
cad303d777
(Trivial) Fix a typo in a comment; Do some whitespace changes.
...
svn path=/trunk/; revision=41092
2012-02-20 22:46:24 +00:00
Alexis La Goutte
78c4f454f9
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=40093
2011-12-04 18:43:05 +00:00
Stephen Fisher
082938900c
Fix Coverity ID #1288 : UNUSED_VALUE in spotlight_dissect_query_loop:
...
"returned_pointer: Pointer ... is never used" due to break and end
of function after the switch block.
svn path=/trunk/; revision=39470
2011-10-19 16:15:53 +00:00