Commit graph

2068 commits

Author SHA1 Message Date
Ulf Lamping
8087f8ccb7 add icons for the "File Set" menu items
svn path=/trunk/; revision=14326
2005-05-07 20:47:39 +00:00
Guy Harris
aa36cca7d8 Don't explicitly initialize "h245_labels", as it's hard to initialize
all of it correctly, and as if you don't initialize all of it you get a
compiler warning.

Add an assignment to squelch a compiler warning.

svn path=/trunk/; revision=14317
2005-05-05 11:07:22 +00:00
Guy Harris
4a229a099c Fix a test (bug found by a compiler warning).
svn path=/trunk/; revision=14316
2005-05-05 11:06:08 +00:00
Michael Tüxen
0332e7c9dd Base the assoc search on port/vtags only.
svn path=/trunk/; revision=14288
2005-05-03 08:34:11 +00:00
Gerald Combs
b233c06fb2 From Cvetan Ivanov:
This patch fixes the slightly broken logic in the loop which searches
for establisted call in isup_calls_packet.

The problem is that (right_pair) is set to false if we see call on the
same CIC as existing conversation, but with different opc/dpc pair:

at this point dpc/opc pair is not checked, so any call with the same
CIC matches:

voip_call.c:851
                                 else{
                                         right_pair = FALSE;
                                 }

and then the correct conversation is never found, because right_pair is
never reset for this packet, which leads to total confusion of the call
tracking logic

Fixed by initializing right_pair = TRUE for every loop iteration 

svn path=/trunk/; revision=14269
2005-05-02 14:45:43 +00:00
Michael Tüxen
5e89412e0c Fix a bug in counting DATA chunks.
svn path=/trunk/; revision=14264
2005-05-02 14:04:25 +00:00
Michael Tüxen
d33365dc43 Get rid of some debug code.
svn path=/trunk/; revision=14257
2005-05-01 13:59:07 +00:00
Michael Tüxen
8a852887ae Editorial stuff.
svn path=/trunk/; revision=14256
2005-05-01 13:55:09 +00:00
Michael Tüxen
b3f69cada5 Editorial stuff
svn path=/trunk/; revision=14255
2005-05-01 13:53:53 +00:00
Michael Tüxen
053504ca5c Editorial stuff.
svn path=/trunk/; revision=14253
2005-05-01 13:52:05 +00:00
Michael Tüxen
db8ff6d946 Editorial cleanups
svn path=/trunk/; revision=14252
2005-05-01 13:51:07 +00:00
Michael Tüxen
05f840c40e Editorial cleanups.
svn path=/trunk/; revision=14251
2005-05-01 13:50:02 +00:00
Ulf Lamping
2777289f85 removed various gcc warnings
svn path=/trunk/; revision=14246
2005-04-30 17:23:33 +00:00
Ulf Lamping
a48744a84b add a new feature: list the files of a "File Set" (set of files generated by capturing "Multiple Files"/ringbuffer) and jump from one file of it to the next/previous one
svn path=/trunk/; revision=14231
2005-04-29 14:51:52 +00:00
Ulf Lamping
073da09b29 fix #117
give a warning, if user never selected an interface before

svn path=/trunk/; revision=14208
2005-04-27 20:52:56 +00:00
Ulf Lamping
22e13e1197 fix bugzilla #110 (http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=110)
don't crash if dropping a file while running a capture or reading a file

svn path=/trunk/; revision=14206
2005-04-27 19:56:31 +00:00
Ronnie Sahlberg
0389d222e2 With the speedup changes to epan/proto.c the tree will be faked to only contain those fields actually referenced by a filter.
Other nodes will never be created by the tree (sort of auto pruning of the tree).

While this greatly spped up the processing performance of ethereal, it makes it "dangerous" for apps that try to walk the tree directly.


rtp_analysis did not specify the fields "rtp.version" nor " rtp.ssrc" when dissecting the current packet  and as such these fields were no longer part of the tree.
This surprised rtp_analysis and a coredump resulted.


This change will add the field that we walkt the tree to find to the filter string so that they will be there.



svn path=/trunk/; revision=14200
2005-04-27 13:58:54 +00:00
Ronnie Sahlberg
6658493b2f increase the length of the field field from 30 to 50 characters so that hopefully all long named fields can fit in the textbox for iorapgs/advanced
svn path=/trunk/; revision=14146
2005-04-20 08:58:49 +00:00
Ulf Lamping
5115a265a9 fix some minor bugs with the current interface name:
-always show descriptive string in combo box
-correct the initialization, so cancelling the option dialog won't make trouble

svn path=/trunk/; revision=14144
2005-04-19 22:32:52 +00:00
Ulf Lamping
9b5d52aab6 ask for unsaved file when using the new start capture feature,
ask for unsaved file when really starting the capture, not already when showing the options dialog,
use the start capture icon in the capture options dialog (instead of simply Ok)

svn path=/trunk/; revision=14142
2005-04-19 21:02:01 +00:00
Ulf Lamping
d22ba722a4 bugfix: don't crash if we have no interface name
svn path=/trunk/; revision=14140
2005-04-19 20:55:27 +00:00
Ulf Lamping
38b423ec6b fix labels of the two toggle toolbar buttons
svn path=/trunk/; revision=14138
2005-04-19 20:53:22 +00:00
Ulf Lamping
40222850f8 add keyboard expand/collapse in the tree view (with Left/Right keys) with GTK2
svn path=/trunk/; revision=14137
2005-04-19 20:46:35 +00:00
Ulf Lamping
597305cb31 add some comments what all the functions going to do...
svn path=/trunk/; revision=14131
2005-04-19 00:23:31 +00:00
Ulf Lamping
7ee0db1080 statusbar changes:
-show the current capture file size, if capturing in real time mode.
-move the packet "Drops" count (if available) from file to packets statusbar part

svn path=/trunk/; revision=14130
2005-04-18 22:05:56 +00:00
Ulf Lamping
f315d0976c add "Decode As" and "Checkbox" (Enabled Protocols) Icons
svn path=/trunk/; revision=14116
2005-04-17 21:38:52 +00:00
Ulf Lamping
fdb2184315 temporarily fix a GTK1.x related bug
svn path=/trunk/; revision=14108
2005-04-16 22:19:59 +00:00
Gerald Combs
83f3aa6e08 Add an extra_info_type field to smb_extra_info_t so that we can make
sure we're not referencing a fid when we think we're referencing an
smb_nt_transact_info_t pointer.  (A fuzzed capture I have triggers
this behavior).


svn path=/trunk/; revision=14107
2005-04-16 21:54:32 +00:00
Ulf Lamping
3625956f52 disable some toolbar icons, if no capture packets loaded
svn path=/trunk/; revision=14106
2005-04-16 20:39:18 +00:00
Ulf Lamping
83dc83abd8 rename capture_clear() to capture_restart()
statusbar update should work now even in capture error case

svn path=/trunk/; revision=14105
2005-04-16 20:08:00 +00:00
Ulf Lamping
4eb2c02901 fix cf_cb_... callback handling (but it's still not perfect)
svn path=/trunk/; revision=14103
2005-04-16 19:29:48 +00:00
Ulf Lamping
ce8a65b3da minor refactoring
svn path=/trunk/; revision=14102
2005-04-16 19:24:10 +00:00
Ulf Lamping
7debbfdfac prepare for "Don't show this message again" checkboxes in the simple_dialog
svn path=/trunk/; revision=14100
2005-04-16 19:18:05 +00:00
Ulf Lamping
e571cbfa9d add 12 new toolbar/menu icons
add two toolbar toggle buttons
add icons to various menu items

create new Statistics telephony group and put telephony and alike protocols in it

svn path=/trunk/; revision=14098
2005-04-16 10:53:09 +00:00
Ulf Lamping
9718569b63 add some new capture and filter related handcrafted (toolbar) icons
add "new" capture options feature, which will act like old capture start, and change capture start option (for immediately capture)

rename Capture/Clear to Capture/Restart

svn path=/trunk/; revision=14083
2005-04-15 07:41:15 +00:00
Ulf Lamping
aee376228c fix bugzilla #16: make columns resizeable again after doing "Resize Columns"
svn path=/trunk/; revision=14082
2005-04-14 20:54:01 +00:00
Lars Roland
41e0f63cfb From Francisco Alcoba:
fix the H323 and SIP part of the voip call analysis for the new tap ordering.

svn path=/trunk/; revision=14070
2005-04-14 00:26:11 +00:00
Lars Roland
13f019e952 From Francisco Alcoba:
- change the "write to file" to "save as"
- avoid the segmentation fault reported by Ruud Linders in another mail

svn path=/trunk/; revision=14069
2005-04-13 23:12:41 +00:00
Ulf Lamping
854c387c0b add clear toolbar icon (from GTK stock icons)
svn path=/trunk/; revision=14061
2005-04-12 22:55:40 +00:00
Ulf Lamping
7e9cedfed8 capture engine:
add a new feature to clear the currently captured packets and restart the capture with the previous parameters

various code cleanup and minor bugfixes

Win32: use millisecond resolution in capture_loop, to smooth screen update a bit (500ms instead of 1000ms)

svn path=/trunk/; revision=14059
2005-04-12 21:44:55 +00:00
Ulf Lamping
fcb74124f8 Save As: ask user if he wants to overwrite an already existing file
svn path=/trunk/; revision=14058
2005-04-12 21:24:30 +00:00
Ulf Lamping
06ef0a3b52 it should now be possible to use "Update packets in real time" even if used with one of the "Multiple files" option.
If this is used together with an option where input files changes too fast (e.g. new file every second), capturing will be (hopefully) stopped.

I've replaced the former capture pipe message format into a somewhat more general format to remove a lot of confusion.


svn path=/trunk/; revision=14054
2005-04-12 00:54:52 +00:00
Ulf Lamping
61ccc8baf1 various capture code cleanup and fixes:
display filename in statusbar while capturing
print_usage banner fixed
cf_cb_live_capture_prepare no longer needed
rename sync_pipe_do_capture -> sync_pipe_start
bugfix: sync_pipe_input_wait_for_start replaced by former implementation
fix cleanup of old file in capture_input_new_file
fix a tempfile detection bug (named file showed up as tempfile after capture)

svn path=/trunk/; revision=14053
2005-04-11 18:57:19 +00:00
Ulf Lamping
af118c9e12 disable /View/Resize Columns menu item, if no packets available
svn path=/trunk/; revision=14047
2005-04-10 23:13:35 +00:00
Ulf Lamping
5625c461d0 bugfix: call to cf_cb_live_capture_..._started with correct parameter
svn path=/trunk/; revision=14045
2005-04-10 21:03:31 +00:00
Ulf Lamping
163f2b61a8 fix statusbar messages by splitting into update and fixed messages between capture and main
svn path=/trunk/; revision=14044
2005-04-10 19:36:56 +00:00
Ronnie Sahlberg
df98534657 From Didier:
optimization for COLUMNS to make ethereal faster when filtering

optimization to make the slow find_protocol_by_id() fast.
(idea from Didier, implementation modified by me to be less intrusive)



svn path=/trunk/; revision=14026
2005-04-07 12:00:03 +00:00
Ronnie Sahlberg
6ac7c99cc5 From Francisco Alcoba
Very cool ASCII art version of viop graphs


svn path=/trunk/; revision=14023
2005-04-07 09:14:35 +00:00
Ulf Lamping
37f7683cd1 from Ilya Konstantinov: fixed a bug as DND wasn't working with GNOME, I've also added a comment how GNOME handles these things
svn path=/trunk/; revision=14020
2005-04-06 21:24:00 +00:00
Ronnie Sahlberg
573ba4ee40 From Francisco Alcoba
patch for viop analysis to fix the breakage from the tap reordering patch



svn path=/trunk/; revision=14017
2005-04-05 08:14:58 +00:00