Commit graph

2429 commits

Author SHA1 Message Date
Lars Roland
74328742ed Some fixes for the new SIP contact header parser.
svn path=/trunk/; revision=14334
2005-05-09 01:15:45 +00:00
Lars Roland
20901fcedf only lower-case ASCII letters, numbers,
underscores, and dots are allowed in the
preference name. 

Fix it the camel dissector.

svn path=/trunk/; revision=14333
2005-05-09 00:11:03 +00:00
Lars Roland
5f092fe201 Mark a function parameter as unused
svn path=/trunk/; revision=14332
2005-05-08 23:29:55 +00:00
Lars Roland
01f10ccd00 When saying that I remove the trailing white spaces I should do it, too.
So I do it now and do some more reindentation, too.

svn path=/trunk/; revision=14331
2005-05-08 22:39:38 +00:00
Lars Roland
e5134e2f2d Improve dissection of SIP contact header and counting of bindings in REGISTER messages.
Introduce a function for disseting a sip uri in general

TODO: 
- add dissection of contact and uri parameters
- simplify the ugly code for dissecting "to" and "from" headers
      by using the new function for uri dissection

svn path=/trunk/; revision=14330
2005-05-08 22:19:18 +00:00
Lars Roland
429d72c457 Reindent dissect_sip_common() and remove trailing white spaces from packet-sip.c.
svn path=/trunk/; revision=14329
2005-05-08 21:17:37 +00:00
Anders Broman
fd075dadf0 From Javier Acuna:
Added some code to dissect DateAndTime.

svn path=/trunk/; revision=14328
2005-05-08 20:35:44 +00:00
Lars Roland
52d26f6eb8 Increase size of an integer to prevent an integer overflow
Fixes Bug 162

svn path=/trunk/; revision=14325
2005-05-07 00:14:11 +00:00
Ronnie Sahlberg
a456014e29 prettify YPSERV
svn path=/trunk/; revision=14324
2005-05-06 10:11:08 +00:00
Gilbert Ramirez
61e5a33ea2 A fix for the previous fix for the infinite loop in bootp, bug #160.
svn path=/trunk/; revision=14323
2005-05-06 02:08:30 +00:00
Gilbert Ramirez
01a3ed9c58 Check the offset delta while we loop through the options.
Make sure the delta is > 0.
This intends to fix bug 160, although with a capture file
to test it, I can't be totally sure.

svn path=/trunk/; revision=14322
2005-05-06 01:56:40 +00:00
Jörg Mayer
b6db235c77 Change 802.11f -> F, 802.1d -> D, 802.1x -> X, 802.1q -Q, 802.1P -> p
svn path=/trunk/; revision=14321
2005-05-05 17:07:58 +00:00
Guy Harris
fff7cd2f34 Change some data types, and add initializations, to squelch compiler
warnings.

Fix indentation.

svn path=/trunk/; revision=14315
2005-05-05 11:05:15 +00:00
Guy Harris
25443a7a87 Change data types to match those of "iconv()", at least on OS X.
svn path=/trunk/; revision=14314
2005-05-05 11:03:46 +00:00
Guy Harris
f98e6c2533 Squelch a compiler warning.
svn path=/trunk/; revision=14313
2005-05-05 11:02:31 +00:00
Guy Harris
f17c1822cc Re-parenthesize an expression, to squelch a compiler warning.
svn path=/trunk/; revision=14312
2005-05-05 10:00:29 +00:00
Guy Harris
73cad260c5 "oid_to_str()" and "oid_to_str_buf()" don't modify what the "oid"
argument points to, so make it a "const" pointer.

svn path=/trunk/; revision=14311
2005-05-05 09:40:24 +00:00
Gerald Combs
fe5561715b Don't try to feed a null pointer to strncmp(). Fixes bug 158.
Shouldn't the number of fuzz bugs decrease asymptotically at some
point?

svn path=/trunk/; revision=14306
2005-05-04 17:02:56 +00:00
Gerald Combs
0b1b3d5716 From Lars Roland:
Make sure a hash table exists before trying to access it.  Fixes bug 105.

svn path=/trunk/; revision=14305
2005-05-04 16:40:30 +00:00
Gerald Combs
c2b4cd7993 Don't roll our own buffer-overflow-able string_to_hex() routine
when there's a perfectly good tvb_bytes_to_str() lying around, just
_begging_ to be used.

Fix up white space.

svn path=/trunk/; revision=14304
2005-05-04 15:35:21 +00:00
Uwe Girlich
c1c395dc2d Added RPC/ONC SYSTEM_ERROR accept state.
svn path=/trunk/; revision=14303
2005-05-04 13:09:46 +00:00
Anders Broman
be12da7f98 Dissect GPRS user data.
svn path=/trunk/; revision=14302
2005-05-03 20:53:21 +00:00
Gerald Combs
985f94ec24 In proto_tree_set_string(), don't set a null fvalue or Ethereal will throw
a hissy fit.  Fixes bug 157.

svn path=/trunk/; revision=14299
2005-05-03 19:33:02 +00:00
Gerald Combs
9ab36a73a8 Back out all of the tvb_ensure_bytes_exist() calls. They shouldn't be
neccessary any more, and were causing problems.

svn path=/trunk/; revision=14298
2005-05-03 18:43:06 +00:00
Gerald Combs
2ab34cb095 Fix two places where we might loop infinitely, including the one found in
bug 155.  Fix a couple of compiler warnings.

svn path=/trunk/; revision=14289
2005-05-03 14:36:08 +00:00
Anders Broman
07e46b0c48 From Nils O. Sel?sdal:
- Decodes all the remaining bitfields in 9P
- Tidies up display a bit (using more subtrees)
- Fixes a few fields that are better off displayed as decimal/octal.


svn path=/trunk/; revision=14287
2005-05-03 05:22:43 +00:00
Ulf Lamping
4e3c0cde68 move the pn-dcp dissector into the profinet plugin
svn path=/trunk/; revision=14285
2005-05-03 01:39:00 +00:00
Gerald Combs
313d9105f3 From Rich Coe:
- fix memory leak when Assoc packet is processed repeatedly in ethereal

 - removed unused partial packet flag

 - added better support for DICOM VR
     - sequences
     - report actual VR in packet display, if supplied by xfer syntax 
     - show that we are not displaying entire tag string with '[...]',
       some tags can hold up to 2^32-1 chars

 - remove my goofy attempt at trying to get access to the fragmented packets
   (anyone have an idea on how to fix this ???)

 - process all the data in the Assoc packet even if display is off

 - limit display of data in Assoc packet to defined size of the data even
   if reported size is larger

 - show the last tag in a packet as [incomplete] if we don't have all the data

 - added framework for reporting DICOM async negotiation (not finished)
   (I'm not aware of an implementation which currently supports this)

 - still need to fix display of continuation packets

svn path=/trunk/; revision=14280
2005-05-02 21:56:40 +00:00
Michael Tüxen
b4af92846c Provide an indication to taps if the verification tag is reflected.
svn path=/trunk/; revision=14278
2005-05-02 20:45:22 +00:00
Gerald Combs
949a9da364 Break out of an infinite loop. Fixes bug 154.
svn path=/trunk/; revision=14277
2005-05-02 20:30:56 +00:00
Anders Broman
a105502f35 Dissect URLC correctly and add dissection of LCC PDU.
svn path=/trunk/; revision=14276
2005-05-02 20:26:56 +00:00
Anders Broman
5a2d87c586 Add dissection of q850 cause.
svn path=/trunk/; revision=14273
2005-05-02 18:32:00 +00:00
Anders Broman
be5db98edd Correct some AVP:s and minor updates from iana.org
svn path=/trunk/; revision=14272
2005-05-02 18:31:15 +00:00
Anders Broman
3f395aec51 Use the correct parameters in a function call.
svn path=/trunk/; revision=14271
2005-05-02 18:30:14 +00:00
Gerald Combs
f8765a5a28 From Cvetan Ivanov:
1) dissect_isup_calling_party_number_parameter reported malformed packet
if the calling party number IE contains empty number (possibly with
presentation set to 'number not available')

I've basicly added if(length > 0) around the digits tree dissector,
which may not be obvious from the patch becase of the indenting of the
entire block.

2) As the tap_calling_number is static, if there is call with missing
calling_party_number IE, it gets assigned the calling party number of
the previuos call containing such IE.

fixed by adding tap_calling_number = NULL;
in the beginning of dissect_isup_message, and

tap_rec.calling_number=tap_calling_number?tap_calling_number:g_strdup("");

in the end to avoid segfault

Those things may not happen too often in the telecom world, but happen
all the time with VoIP.


svn path=/trunk/; revision=14268
2005-05-02 14:41:07 +00:00
Gerald Combs
bf48f8e4d4 Check for a few more integer overflows. Found during fuzz testing.
svn path=/trunk/; revision=14266
2005-05-02 14:12:42 +00:00
Michael Tüxen
23d022349d - Add support for libpcap files for MTP2 with a per packet header
indicating the direction, narrowband/broadband, and interface number.
- Add support to display the direction and interface number.
- Add support to packet-mtp2.c to use the broadband/narrowband indication.

svn path=/trunk/; revision=14265
2005-05-02 14:07:33 +00:00
Gerald Combs
2e0f4b9750 Fix a couple of infinite loops. Make similar changes elsewhere to keep the
code consistent.

svn path=/trunk/; revision=14260
2005-05-02 00:57:44 +00:00
Michael Tüxen
e0d7600bb5 Fix chunk length handling. Go back to initial concept that
the chunk_length always is the length indicated in the packet header.

svn path=/trunk/; revision=14258
2005-05-01 21:00:26 +00:00
Gerald Combs
17fa218ed5 Make sure we pass a positive length to proto_item_set_len().
svn path=/trunk/; revision=14254
2005-05-01 13:52:15 +00:00
Ulf Lamping
48aee19b1a move the profinet related files to a plugin (step by step), to make prototyping and further development easier (at least for me :-)
svn path=/trunk/; revision=14248
2005-04-30 20:52:20 +00:00
Gerald Combs
6ba8b243b0 Fix a buffer overflow found during fuzz testing.
svn path=/trunk/; revision=14247
2005-04-30 19:37:03 +00:00
Gerald Combs
a416a4b6f5 Check for an integer overflow. Fixes bug 149.
svn path=/trunk/; revision=14245
2005-04-30 16:42:04 +00:00
Ronnie Sahlberg
75438b269f From Miklos Szurdi :
update to GSM_A to display the maximum bit rate properly



svn path=/trunk/; revision=14244
2005-04-30 16:29:03 +00:00
Ronnie Sahlberg
b19a303f3f once we know a conversation is iscsi, use conversation_set_dissector()
so that we block any heuristic dissectors from attempring and mistaking this conversation from being it.

In particular:  DCERPC often mistakes iscsi DataOut PDUs for being DCERPC.



svn path=/trunk/; revision=14243
2005-04-30 16:14:57 +00:00
Gerald Combs
01270e7e44 Don't call proto_item_set_len() with a negative length. Found during
fuzz testing.

svn path=/trunk/; revision=14242
2005-04-30 16:08:29 +00:00
Gerald Combs
6380ee9999 Make sure we don't recurse into oblivion. Fixes bug 147.
svn path=/trunk/; revision=14238
2005-04-30 04:30:32 +00:00
Gerald Combs
b41f8bfb2a Make sure we don't pass an invalid length to proto_tree_add_item(). Found
during fuzz testing.

svn path=/trunk/; revision=14237
2005-04-30 04:09:28 +00:00
Gerald Combs
89c4f03738 The previous changes were causing weird exception errors. Back them out,
and simply check the length of each buffer.

svn path=/trunk/; revision=14236
2005-04-30 00:28:05 +00:00
Gerald Combs
d11d3d6f8d Use GStrings instead of character arrays, so that we don't overflow any
buffers.  Found during fuzz testing.

svn path=/trunk/; revision=14233
2005-04-29 16:39:20 +00:00