Commit graph

13558 commits

Author SHA1 Message Date
Guy Harris
c8a0d29d22 Use "format_text()" on strings fetched from packets.
svn path=/trunk/; revision=13794
2005-03-17 19:44:45 +00:00
Gerald Combs
023d72fb44 Fix a couple of format string bugs discovered by Bryan Fulton.
svn path=/trunk/; revision=13793
2005-03-17 18:32:36 +00:00
Gerald Combs
73163bf8c5 Insert "%s" at various points in an attempt to trigger format string bugs.
svn path=/trunk/; revision=13792
2005-03-17 16:06:20 +00:00
Ronnie Sahlberg
5162c81d71 iscsi LUNs were reported incorrectly for SCSI Command PDUs when they were not matched with a response.
Read the LUN value into a local variable always and use that to pass to the scsi dissector since we can always use this value from the iscsi heade for COMMAND pdus   (but not data/in/out)



svn path=/trunk/; revision=13791
2005-03-17 10:18:18 +00:00
Gerald Combs
fd61f72cb7 Use val_to_str instead of indexing a value_string directly. This keeps us
from crashing when we encounter an invalid type value.

svn path=/trunk/; revision=13790
2005-03-17 05:14:01 +00:00
Guy Harris
61c7ec6534 Fix the display of help information for various --with arguments (for
whatever reason, the changequote() hack doesn't seem to be working, at
least on OS X; the square brackets were simply being removed from the
messages).

Rename the "ifpresent" value for the --with variables to "ifavailable",
to match the help messages.

At least for the SNMP libraries, have the "checking" message just say
"whether to use XXX" and have the result message say "yes, if available"
if the user didn't explicitly specify "--with" or "--without", as the
default just leaves the library out if it doesn't work, but explicitly
specifying "--with" means you get an error if it doesn't work.

Make "--with-net-snmp" fail if the headers aren't present (if the user
explicitly asks for something, we should fail if we can't give it to
them, as they presumably really wanted it).

svn path=/trunk/; revision=13789
2005-03-17 05:09:42 +00:00
Tim Potter
2ebd49cd2c Apply abartlet@samba.org's "raw NTLMSSP over GSS-SPNEGO" patch.
svn path=/trunk/; revision=13788
2005-03-17 02:27:26 +00:00
Lars Roland
af529a9fb0 Clean up.
Remove obsolete plugin address table and related files.
Remove related targets from various makefiles.

svn path=/trunk/; revision=13787
2005-03-17 00:10:23 +00:00
Guy Harris
da00482b66 Capitalize "Net-SNMP" the way the Net-SNMP project capitalizes it.
Note that the "=PATH" argument to "--with-net-snmp" is optional.

If "--with-net-snmp" is specified, give an error if Net-SNMP is found
but "--with-ssl" wasn't specified, as the user has specified that they
really want a version of Ethereal with Net-SNMP; if it's not specified,
just warn of that and drive on, as we did before.

svn path=/trunk/; revision=13786
2005-03-16 23:53:49 +00:00
Guy Harris
e44a0c7dd1 Use 0, not NULL, for integer arguments; NULL might be defined as "(void *)0",
and that causes compiler warnings when it's passed as an integer argument.

svn path=/trunk/; revision=13785
2005-03-16 23:49:12 +00:00
Gerald Combs
8ff6c3d656 Replace malloc()/free() with g_malloc()/g_free().
svn path=/trunk/; revision=13784
2005-03-16 23:25:11 +00:00
Lars Roland
42dcc095af Add subversion Id to libethereal.def
svn path=/trunk/; revision=13783
2005-03-16 23:22:28 +00:00
Lars Roland
65fb9ef620 Remove support for the old plugin api.
TODO: 
cleanup files in /trunk/plugins

svn path=/trunk/; revision=13782
2005-03-16 23:07:08 +00:00
Anders Broman
53c43f0757 Add a comment about where lemon is maintained now.
svn path=/trunk/; revision=13781
2005-03-16 22:09:30 +00:00
Guy Harris
90f8224360 Have GSS-API subdissectors supply a "data is encrypted" flag to their
callers, so that they can tell "no decrypted tvbuff because I couldn't
decrypt it" from "no decrypted tvbuff because it's not encrypted in the
first place".  Set that based on the Kerberos seal algorithm field in
the SPNEGO Kerberos 5 wrap dissector code.

Use that to determine whether the GSS-API encapsulated data in LDAP is
encrypted or not., rather than using a heuristic.

Set the length of the SASL blob tvbuff based on the SASL length and the
length of the tvbuff from which it's consstructed, rather than setting
it to the SASL length.

svn path=/trunk/; revision=13780
2005-03-16 21:59:25 +00:00
Guy Harris
c664c29958 Spell out "G.723".
svn path=/trunk/; revision=13779
2005-03-16 21:48:46 +00:00
Guy Harris
0eaac18fff Check whether we have a first byte before checking it.
svn path=/trunk/; revision=13778
2005-03-16 21:40:34 +00:00
Guy Harris
b678ec3704 Get rid of an unused variable.
svn path=/trunk/; revision=13777
2005-03-16 21:37:28 +00:00
Anders Broman
71e75d9183 Dissect a bit of the payload to, Picture start block and temporal ref.
svn path=/trunk/; revision=13776
2005-03-16 20:06:01 +00:00
Guy Harris
7846581664 Fix some comments.
Use the same code to handle payload types in sessions set up by SDP and
sessions set up by other protocols, rather than duplicating that code.

svn path=/trunk/; revision=13775
2005-03-16 19:55:49 +00:00
Guy Harris
38de3a617a Get rid of some redundant tests that cause compiler warnings.
svn path=/trunk/; revision=13774
2005-03-16 19:41:33 +00:00
Anders Broman
4bb41cd1c7 Dissect some more IE:s and bug fixes.
svn path=/trunk/; revision=13773
2005-03-16 19:30:39 +00:00
Anders Broman
fce4f45b75 Try the pt_dissector table also if conversation has been set up with SDP.
svn path=/trunk/; revision=13772
2005-03-16 19:25:13 +00:00
Guy Harris
ad555d7c60 Fix a typo in a comment, and get rid of some unused variables, to
squelch compiler warnings.

svn path=/trunk/; revision=13771
2005-03-16 19:07:32 +00:00
Guy Harris
6bf27da8ce Doing a g_assert() that can fail with data that could appear in a packet
is wrong; cast the "guint8" value to "guint" to widen it, so that adding
1 to it doesn't overflow.  (But I don't think that cast should be
necessary - the "usual arithmetic conversions" in C should widen the
value anyway.)

svn path=/trunk/; revision=13770
2005-03-16 18:53:28 +00:00
Gerald Combs
47999c28c4 Fix a format string vulnerability discovered by Bryan Fulton.
svn path=/trunk/; revision=13769
2005-03-16 17:22:38 +00:00
Gerald Combs
eadb365e2a For UDP output, set the length to 65535 instead of 0.
svn path=/trunk/; revision=13768
2005-03-16 16:44:06 +00:00
Jörg Mayer
be2bab3d18 IEEE is correct about 00:00:39
svn path=/trunk/; revision=13767
2005-03-16 16:42:53 +00:00
Ronnie Sahlberg
a01dfef2f7 close potential overflow causing malloc to allocate 0 bytes
svn path=/trunk/; revision=13766
2005-03-16 13:39:55 +00:00
Ronnie Sahlberg
a777d5b1ad prettify nlm a bit
svn path=/trunk/; revision=13765
2005-03-16 12:47:29 +00:00
Ronnie Sahlberg
bfdd246e65 make idl2eth able to handle negative case tags
svn path=/trunk/; revision=13764
2005-03-16 11:39:46 +00:00
Ronnie Sahlberg
525bdb673b decode some more of drsuapi
svn path=/trunk/; revision=13763
2005-03-16 11:29:09 +00:00
Ronnie Sahlberg
e5f203eb7a jxta updates from duigou
svn path=/trunk/; revision=13762
2005-03-15 10:18:54 +00:00
Ronnie Sahlberg
abd7102bed fix a compiler warning
svn path=/trunk/; revision=13761
2005-03-15 10:05:54 +00:00
Ronnie Sahlberg
e85d023949 ikev2 support from Shoichi Sakane
svn path=/trunk/; revision=13760
2005-03-15 09:58:58 +00:00
Ronnie Sahlberg
b140a83293 more idl2eth and drsuapi updates
svn path=/trunk/; revision=13759
2005-03-15 09:36:18 +00:00
Ronnie Sahlberg
5d7b72fd86 update to idl2eth adding WERROR as a built in type
svn path=/trunk/; revision=13758
2005-03-15 08:24:10 +00:00
Guy Harris
5817da91dc Export another routine that's been asked for at least once.
svn path=/trunk/; revision=13757
2005-03-14 23:41:08 +00:00
Anders Broman
612e924994 Routines for Unlicensed Mobile Access(UMA) dissection ( http://www.umatechnology.org/
UMA Protocols (Stage 3) R1.0.2 (2004-11-05) )
Work in progress.

svn path=/trunk/; revision=13756
2005-03-14 22:26:57 +00:00
Ronnie Sahlberg
1fe0f9022e a lot of people dont specify top level pointers in teh idl and just
cerlare it as a parameter that is a struct/union and not a ref pointer to one.

this is ok since toplevel ref pointers are invisible in the wire encoding anyway.

unfortunatelky  ethereal dce runtime needed to see that pointer to keep track of whisch one was a toplevel and which one wasnt.


implement a new api to call pointers which explicitely specifies whether the pointer is toplevel or embedded.
eventually all dce dissectors will use this new interface and the generic dissect_ndr_pointer() can be retired.



svn path=/trunk/; revision=13755
2005-03-14 20:51:13 +00:00
Ulf Lamping
e7a72ba624 from Frederic Peters: bring debian package generation .deb up to date
I don't have the facility to test this, hopefully Frederic knows what he's doing :-) 

However, this was out of date since a long time ago, so can't get worse anyway...

svn path=/trunk/; revision=13754
2005-03-14 20:46:46 +00:00
Guy Harris
9ce4ff20ef Tagged integers have 4 bytes of data (1 byte of tag, 3 bytes of
integer), not 5 bytes.

svn path=/trunk/; revision=13753
2005-03-14 20:23:11 +00:00
Guy Harris
a81c8f1738 Some VoIP VLAN query and reply fields have a length of 6, not 7, with
only 2 bytes of data; dissect those differently.

svn path=/trunk/; revision=13752
2005-03-14 19:53:07 +00:00
Guy Harris
c7e7167a2b Combine the two switch statements on IE type into one; this cleans
things up a bit (so that if we go through one switch statement we don't
fall into the other).

svn path=/trunk/; revision=13751
2005-03-14 11:12:00 +00:00
Guy Harris
0c70225fc6 Comment changes.
svn path=/trunk/; revision=13750
2005-03-14 10:45:46 +00:00
Ronnie Sahlberg
549ec8ee25 fix typo in name of KINK developer
svn path=/trunk/; revision=13749
2005-03-14 10:27:25 +00:00
Ronnie Sahlberg
59b3267d40 updates for drsuapi
svn path=/trunk/; revision=13748
2005-03-14 09:49:58 +00:00
Guy Harris
5f1b64cf8c Don't cruft up the display of the bitmap with "Tag interpretation".
(Perhaps we should just get rid of the "tag interpretation" field and,
instead, have explicit hf_ values for each of the fields and subfields.)

svn path=/trunk/; revision=13747
2005-03-14 03:08:38 +00:00
Ulf Lamping
49213d49da Very first start of a dissection of the VNC (RFB) protocol.
This is not much more than the dissector skeleton code.

svn path=/trunk/; revision=13746
2005-03-14 00:53:58 +00:00
Ulf Lamping
f1f48a30bd fix a bug and add a forward declaration in the example skeleton code
svn path=/trunk/; revision=13745
2005-03-14 00:43:39 +00:00