osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
54,353 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

74 Commits

Author SHA1 Message Date
Michael Mann cd02af56a1 Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors. 
This mostly involved adding expert info capabilities to many of the dissectors so that they could correctly flag error conditions.

Only remaining proto_tree_add_text calls are in H248.cnf, which has a convoluted way of using hf_ data to make its tree.

Change-Id: I6412150c2ec1977d7fa38f3f0ed416680bdfb141
Reviewed-on: https://code.wireshark.org/review/3500
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-08-09 01:57:08 +00:00
Bill Meier 9ed99d5c4e Strip some trailing whitespace; Fix some indentation; Add editor-modelines as needed. 
Change-Id: I943153e28f468070d86535abad7be032e1386118
Reviewed-on: https://code.wireshark.org/review/2994
Reviewed-by: Bill Meier <wmeier@newsguy.com>
 2014-07-11 03:20:54 +00:00
Michael Mann 9356d5c689 convert to proto_tree_add_subtree[_format] for ASN.1 dissectors 
Change-Id: I753ca95e2e1b38bad2c09955317e648c525e40ef
Reviewed-on: https://code.wireshark.org/review/2509
Tested-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-06-22 21:08:21 +00:00
Evan Huus 37b903d7ab batch of tvb-length conversions 
Change-Id: I76ca4d075756e3ac691070e0c05344a410ea2498
Reviewed-on: https://code.wireshark.org/review/2507
Reviewed-by: Evan Huus <eapache@gmail.com>
 2014-06-21 04:01:52 +00:00
Michael Mann 14824e6adf Revert "Fixup: tvb_* -> tvb_captured" 
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html

This reverts commit 246fe2ca4c.

Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
 2014-06-19 18:25:59 +00:00
Dario Lombardo 246fe2ca4c Fixup: tvb_* -> tvb_captured 
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 2014-06-18 14:14:58 +00:00
Jeff Morriss 8c608e6e82 Remove $Id$ from the ASN.1 dissectors and regenerate them. 
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954
Reviewed-on: https://code.wireshark.org/review/244
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
 2014-02-18 03:05:28 +00:00
Chris Maynard 79fa0d0a3f Reject the packet if data is NULL without doing anything else. 
Note: We *might* want to do _something_ but that _something_ should be well-defined and consistent across all dissectors.  Previously, some dissectors called proto_tree_add_text() to add some error message text to the tree, while others called DISSECTOR_ASSERT().

svn path=/trunk/; revision=53895
 2013-12-09 22:23:44 +00:00
Michael Mann d5d8c3c359 context is not being passed to dissector, not through pinfo->private_data so check data parameter, not pinfo->private_data. 
svn path=/trunk/; revision=53236
 2013-11-10 17:17:18 +00:00
Michael Mann b6b78d69db In an effort to reduce the use of pinfo->private_data (and some true global variables), I converted the ASN.1 dissectors that use pinfo->private_data to exchange a SESSION_DATA_STRUCTURE to instead only exchange it in the context of ASN.1. This meant converting dissectors to the "new" style to pass the SESSION_DATA_STRUCTURE as well as providing a pointer to it in asn1_ctx_t.private_data. Yes, it's still "private data", but it's not used by all dissectors like pinfo->private data is. 
svn path=/trunk/; revision=53090
 2013-11-05 18:47:26 +00:00
Michael Mann 02a8391535 Require dissector_try_string to pass a data parameter to its subdissectors. There weren't that many calls, so might as well modify the function than create a need for dissector_try_string_new. 
svn path=/trunk/; revision=53049
 2013-11-02 15:52:25 +00:00
Jörg Mayer ac6214533e Regenerate all files where the .cnf files had whitespace changes. 
svn path=/trunk/; revision=52125
 2013-09-17 18:55:18 +00:00
Michael Mann 00dd0adc0d expert_add_info_format_text -> expert_add_info_format 
svn path=/trunk/; revision=51851
 2013-09-09 00:28:48 +00:00
Evan Huus b1e12ec925 Convert the rest of the ASN1 dissectors from emem to wmem. 
svn path=/trunk/; revision=50063
 2013-06-19 22:47:36 +00:00
Michael Mann 2dbf6c59a2 Remove check_col() from ASN.1 dissectors 
svn path=/trunk/; revision=49927
 2013-06-14 12:44:50 +00:00
Michael Mann 7fe5422c4b Convert ASN.1 dissectors to use filterable expert info. 
NOTE: Kerberos ASN.1 template was updated, but not generated to source.

svn path=/trunk/; revision=49707
 2013-06-03 03:42:36 +00:00
Pascal Quantin 0ee4d0a00a Postfix FT_NONE fields with "_element" string to reduce number of incompatible filters in ASN.1 dissectors 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402

svn path=/trunk/; revision=49599
 2013-05-27 20:26:49 +00:00
Pascal Quantin a37c044203 Update the ASN.1 based dissectors following the changes done in r48812 
svn path=/trunk/; revision=48820
 2013-04-11 18:14:53 +00:00
Anders Broman dafdc19d9e -Wmissing-prototypes 
svn path=/trunk/; revision=48609
 2013-03-28 07:34:13 +00:00
Anders Broman 84241f46ad From beroset: 
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48399
 2013-03-18 20:44:36 +00:00
Guy Harris 29715ccc8f How can I get a new tvbuff that starts at an offset within a given 
tvbuff and runs to the end of the tvbuff?  Let me count the ways....

Replace a bunch of different ways of doing that (some incorrect, in that
they're not properly handling tvbuffs where the captured and reported
lengths are different) with tvb_new_subset_remaining().

svn path=/trunk/; revision=47751
 2013-02-19 23:17:07 +00:00
Jakub Zawadzki 7a9d27c33f Regenerate asn.1 dissectors. 
svn path=/trunk/; revision=45110
 2012-09-24 19:38:46 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Jakub Zawadzki 5a8783f5b1 Initial commit to support yet another method of passing data between dissectors. 
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
 2012-09-10 21:40:21 +00:00
Pascal Quantin babe622987 Use G_MININT32 instead of -2^31 so as to get rid of 'this decimal constant is unsigned only in ISO C90' warning 
svn path=/trunk/; revision=43764
 2012-07-17 13:12:50 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address. 
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
 2012-06-28 22:56:06 +00:00
Alexis La Goutte fe3168dc2a Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40462
 2012-01-13 16:22:50 +00:00
Anders Broman 34ea886454 [-Wunused-but-set-variable] 
svn path=/trunk/; revision=39829
 2011-11-14 17:35:04 +00:00
Bill Meier 24cf0aad06 Update generated ASN1 *.[hc] files after recent work done by Jeff Morriss; 
The only change in each file is in a comment showing the asn2wrs cmd used to build that file.

svn path=/trunk/; revision=39427
 2011-10-15 19:27:27 +00:00
Stig Bjørlykke ba2aae0f8e Use ENC_NA as encoding for FT_PROTOCOL, FT_NONE and FT_BYTES. 
svn path=/trunk/; revision=38122
 2011-07-19 18:48:31 +00:00
Stig Bjørlykke f282154ab0 Use correct encoding for proto_tree_add_item(). 
svn path=/trunk/; revision=38107
 2011-07-19 10:51:12 +00:00
Stig Bjørlykke a7c5d642d5 Regenerate ASN.1 dissectors to update the #line directive. 
svn path=/trunk/; revision=37118
 2011-05-13 08:12:27 +00:00
Graeme Lunt cfdd4788cf Updates to the ROS dissector to support IDMP and fix to IDMP for implicit declaration of return value of call_ros_oid_callback(). 
svn path=/trunk/; revision=33182
 2010-06-09 14:45:38 +00:00
Jeff Morriss 81da8e0b6b Use find_or_create_conversation() in some ASN.1 dissectors 
svn path=/trunk/; revision=32791
 2010-05-13 18:55:31 +00:00
Jeff Morriss a0c858efcd Add a little more code to avoid not-very-useful blurbs: 
- Change spaces in the name to underscores before comparing it to the blurb.
  - Check if the type simply as T_ prepended to the name.
  - Don't put in a blurb of "NULL".

and regenerate the dissectors.

svn path=/trunk/; revision=32748
 2010-05-11 03:53:31 +00:00
Jeff Morriss 08026e8bcc Regenerate a few more of the ASN.1 dissectors 
svn path=/trunk/; revision=32746
 2010-05-11 02:51:39 +00:00
Bill Meier 9ade30a7b1 #include <string.h> and/or #include <stdio.h> not needed. 
svn path=/trunk/; revision=32417
 2010-04-07 16:54:29 +00:00
Bill Meier f8b92f8d0b #include <stdio.h> not needed. 
svn path=/trunk/; revision=32405
 2010-04-06 17:01:14 +00:00
Bill Meier 3a9c03abd6 Fix gcc -Wshadow warnings 
svn path=/trunk/; revision=31714
 2010-01-28 14:43:01 +00:00
Bill Meier 723533dbe4 Remove a check_col() in asn1 template file (SVN #31519 did only the generated file). 
svn path=/trunk/; revision=31697
 2010-01-27 14:54:48 +00:00
Anders Broman 440c3f9261 From Didier Gautheron: 
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31519
 2010-01-13 20:32:01 +00:00
Jeff Morriss 6bbd17bcf9 Don't se_alloc() the conversation structure which contains pointers to two 
g_hash_tables that we then try to free in ros_reinit().  Instead, g_malloc()
the conversation structure and free it (along with the hash tables) in the
reinit function.

svn path=/trunk/; revision=30601
 2009-10-18 20:13:56 +00:00
Stig Bjørlykke 6d1dae6f28 Make all proto_* values static. 
svn path=/trunk/; revision=30516
 2009-10-11 16:24:29 +00:00
Kovarththanan Rajaratnam 9490d1b74c Regenerate asn1 dissectors (no change, only some line offset changes) 
svn path=/trunk/; revision=30454
 2009-10-09 21:34:49 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check 
svn path=/trunk/; revision=29344
 2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29340
 2009-08-09 06:26:46 +00:00
Stig Bjørlykke 0437f102c3 From Kovarththanan Rajaratnam: 
More FT_XXX cleanup.

svn path=/trunk/; revision=28971
 2009-07-07 09:02:59 +00:00
Stig Bjørlykke 6a713aad50 Added expert info for OID not implemented. 
svn path=/trunk/; revision=28422
 2009-05-20 09:27:45 +00:00
Stig Bjørlykke c47e788c94 Regenerate all asn2wrs generated dissectors. 
svn path=/trunk/; revision=28379
 2009-05-16 22:07:03 +00:00
Anders Broman e375c3990a Regenerate all asn2wrs generated dissectors 
svn path=/trunk/; revision=26670
 2008-11-01 22:30:14 +00:00