Commit Graph

47 Commits

Author SHA1 Message Date
Bill Meier 48af69f95f From beroset:
remove C++ incompatibilities
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10409

svn path=/trunk/; revision=48449
2013-03-21 03:07:23 +00:00
Guy Harris 8ed7a73e22 Fix a bunch of warnings.
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.

Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().

Change some data types to avoid those implicit conversion warnings.

When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.

Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers.  Cast
away those warnings in some cases where an API we don't control forces
us to do so.

Enable a bunch of additional warnings by default.  Note why at least
some of the other warnings aren't enabled.

randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.

If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.

svn path=/trunk/; revision=46748
2012-12-26 05:57:06 +00:00
Jakub Zawadzki b18e880040 Update FSF address - part II.
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Jakub Zawadzki 8a1dc57c03 Remove doubled semicolons and semicolons outside function.
svn path=/trunk/; revision=42053
2012-04-13 20:22:31 +00:00
Jörg Mayer 2b3167dcf9 Fix another old style function declaration warning
svn path=/trunk/; revision=37281
2011-05-19 05:08:42 +00:00
Bill Meier 6e079af172 Whitespace cleanup (remove trailing blanks from lines).
svn path=/trunk/; revision=35711
2011-01-30 22:57:00 +00:00
Jeff Morriss b09f79f414 Be sure we initialize the p_id in hf's. This fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3010 .

Also finish the implementation of ShowTimes for GOGs so that the variable gets
initialized (preventing another uninitialized variable warning from Valgrind).

svn path=/trunk/; revision=32465
2010-04-14 18:39:00 +00:00
Jeff Morriss ef2548d093 Fix up MATE's hf display values so MATE will actually run.
svn path=/trunk/; revision=32464
2010-04-14 14:20:16 +00:00
Bill Meier a0eee8c299 Replace some unnecessary use of g_snprintf and g_strdup_printf
svn path=/trunk/; revision=27864
2009-03-27 14:46:54 +00:00
Bill Meier 9a3563e807 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27085
2008-12-22 15:24:18 +00:00
Luis Ontanon 42c3239a1a luis.ontanon@gmail.com => luis@ontanon.org
svn path=/trunk/; revision=25937
2008-08-05 21:03:46 +00:00
Bill Meier fe5c2d9820 g_string_sprintf --> g_string_printf and g_string_sprintfa --> g_string_append_printf
svn path=/trunk/; revision=25276
2008-05-11 18:33:49 +00:00
Stephen Fisher 726a1caaf1 - Remove GLIB1 code
- Change ugly GLIB version checking statements to GLIB_CHECK_VERSION
- Remove ws_strsplit files because we no longer need to borrow GLIB2's
  g_strsplit code for the no longer supported GLIB1 builds


svn path=/trunk/; revision=24829
2008-04-07 05:22:54 +00:00
Stephen Fisher 46b8669566 Fix a bunch more warnings. Add -Werror when using --with-warnings-as-errors
under gcc to tools/lemon, plugins/mate and epan/


svn path=/trunk/; revision=21204
2007-03-26 06:10:52 +00:00
Stephen Fisher 2896811274 Fix about 150 warnings new to gcc 4.0 in the error on warning directories.
Comment out -Werror in plugins/asn1/ until warnings can be fixed.


svn path=/trunk/; revision=21158
2007-03-23 22:49:23 +00:00
Stephen Fisher 0ebc01dc03 From Sebastien Tandel:
Create two new files (ws_strsplit.[ch]) that use GTK2 code to override
the buggy g_strsplit() function when compiling for GTK1.  Include this
work-around function (ws_strsplit) in libwireshark.def.  Add notes on usage
to README.developer.  Include epan/ws_strsplit.h in all files that use
g_strsplit().


svn path=/trunk/; revision=20804
2007-02-13 20:57:22 +00:00
Anders Broman db57e7b724 Ethereal->Wireshark
svn path=/trunk/; revision=18231
2006-05-28 16:32:49 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Jörg Mayer f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Luis Ontanon 088ffa504e - add Debug and Default declarations.
- supress unwanted console printouts.


svn path=/trunk/; revision=16769
2005-12-12 23:23:32 +00:00
Luis Ontanon 5883ff951b Avoid to crash if we are given an unexistent field.
svn path=/trunk/; revision=16762
2005-12-12 01:32:31 +00:00
Jörg Mayer 30a8557868 More 'char*' -> 'const char*' changes to fix warnings.
svn path=/trunk/; revision=15015
2005-07-23 11:41:25 +00:00
Guy Harris b67f63560e More constification.
svn path=/trunk/; revision=14740
2005-06-24 02:51:01 +00:00
Luis Ontanon dbe55501fc at this point mate should be working as it did before the grammar
- pdu transports were upside down (ip/tcp vs tcp/ip)
 - the gop to gog index was not being populated
 - tell svn to ignore generated c files


svn path=/trunk/; revision=14416
2005-05-22 00:44:34 +00:00
Luis Ontanon bf1117c4c9 Transforms and Pdus are working already, Gops start to work.
svn path=/trunk/; revision=14376
2005-05-16 17:16:52 +00:00
Luis Ontanon 047baf2c38 MATE has a grammar.
Although not yet fully implemented I want this version as a reference. 


svn path=/trunk/; revision=14373
2005-05-16 13:28:35 +00:00
Luis Ontanon 5912813eeb avoid crashing when Debug_Cfg is set and no Payload is given for a Pdu
svn path=/trunk/; revision=13464
2005-02-22 02:16:35 +00:00
Luis Ontanon 80ec76c622 Changed the GopTree in GogDef and GogExtra from a boolean to a string
GopTree={BasicTree|NoTree|FullTree}
    NoTree: just an item for each gop
    BasicTree: (default) some essential information regarding the gop
    FullTree: the Gop's full tree

added Id and eol-style to examples


svn path=/trunk/; revision=13435
2005-02-20 02:21:04 +00:00
Luis Ontanon e2e5536fef In order to avoid a crash at reanalize_gop(), do not accept a GogKey where the Gop has not yet being declared.
svn path=/trunk/; revision=13429
2005-02-19 03:10:50 +00:00
Luis Ontanon 2cd67ce468 Adds Payload AVP to PduDef AVPLs simmetric to the Transport AVP
allows to fetch fields also from ranges that are the payload of the Proto

svn path=/trunk/; revision=13427
2005-02-18 22:33:16 +00:00
Luis Ontanon f7a7af313d Add a pointer to the start frame of each gop in the gog's tree
svn path=/trunk/; revision=13423
2005-02-18 20:02:40 +00:00
Luis Ontanon 99f52419d5 two fixes in config loading:
- do not accept GopDefs for non existent pdus Pdu
  - GogExtra "no For" instead of "no Name" 


svn path=/trunk/; revision=13422
2005-02-18 18:40:25 +00:00
Luis Ontanon f660b69b4f add "mate" as a protocol to its tree
svn path=/trunk/; revision=13380
2005-02-10 16:55:08 +00:00
Anders Broman c3440553eb From: LEGO
- fix a bug at gog reinit that disabled gogs after reload of a file.
- fix some crashes when Debug_GoG>0
- cleanup the debug output (no CR at the end is needed)
- Gops start when no GopStart is given and match an existing GogKey

svn path=/trunk/; revision=13318
2005-02-06 20:37:02 +00:00
Guy Harris 428475c8a8 HFILL can't be used to initialize at run time.
svn path=/trunk/; revision=13286
2005-02-04 10:32:28 +00:00
Jörg Mayer d01c1ddaef albert chin:
The HP-UX compilers don't like non-constant initializers (C99'ism).
        Patch attached for plugins/mate/mate_setup.c.

Fix a few warnings (change some () to (void))

svn path=/trunk/; revision=13274
2005-02-04 00:22:00 +00:00
Lars Roland f7a9907702 From Luis Ontanon for Mate:
- supress some solaris compiler warnings
- adds GopExpiration, GopIdleTimeout and GopLifetime parameters

svn path=/trunk/; revision=13154
2005-01-21 19:11:59 +00:00
Lars Roland 2b88200a3a One more patch for mate:
- renamed analyze_frame() into mate_analyze_frame().
- prepare mate to be statically linked
- use report_open_failure() , report_read_failure() and
report_failure() in case there's an error while loading the config
- some cleanup in mate_util.c
- some fixes and cleanup in examples and matelib

svn path=/trunk/; revision=13001
2005-01-10 02:37:19 +00:00
Lars Roland 603c9edd83 From Luis Ontanon:
A new patch for mate

- changed the default config file name to "" 
- avoid trying to confgure mate when the config filename is ""
- add filename and line to config errors, that way one can actually
find errors in config files
- teady up the config error strings ( made them uniform )
- fixed a crash when missing index AVPs (Name,For,On etc) in config AVPLS
- make sure we do not delete the config AVPs and AVPLs to avoid
references to unsubscribed strings been left arround
- fixed the len on LoALs 
- changed the way loal_from_file reports an error.
- matelib/sip.mate was missing the Name in a PduDef  (from Julien Leproust)
- matelib/h225_ras had a wrong field name (from Julien Leproust)

At this point mate is silent when it's not expressely configured by the user.

From me:
reduce compiler noise on MSVC

svn path=/trunk/; revision=12985
2005-01-07 18:07:18 +00:00
Lars Roland ccf44f7fb1 From Luis Ontanon:
Fix some MSVC warnings in MATE

svn path=/trunk/; revision=12969
2005-01-06 23:21:10 +00:00
Lars Roland b7642931ad From Luis Ontanon:
Another patch for mate:
 - adds a "GopTree={TRUE|FALSE}" attribute to Gogs
 - changes "ShowPduTree={NoTree|PduTree|FrameTree}"
 - adds "implicit stop" to Gops with no Stop declared

svn path=/trunk/; revision=12968
2005-01-06 12:39:54 +00:00
Lars Roland 2ce1e037f6 From Luis Ontanon for Mate:
- moved gop and gog indexes into gopcfgs, which is a propedeutic
change for upcoming changes in the way gops are to be grouped
-  changed the way gog-keys are kept in memory
- every gopkey attribute is copied into the gop->extras to avoid
redundancy in the configuration
- added timers to gogs mate.gog_type.StartTime and mate.gog_type.Time
- fixed a bug in scs_subscribe that mangled some strings
- minor interface improvement to scs propedeutic to having types avp
values in a future
- changed medium and large into mate_medium and mate_large in the
scs_collection
- fixed Mode=Replace in Transforms, now it works
- fixed a crash at reinit due to impropper initialization of mate_items

svn path=/trunk/; revision=12902
2004-12-31 14:27:38 +00:00
Lars Roland 5474c91d65 Fixes for Mate from Luis Ontanon:
- fixes crash at reinit when DiscardPduData=TRUE: check if there's an
avpl before deleting it.
- mate.pdu_type.RelativeTime had a dual use, add
mate.pdu_type.TimeInGop and leave the other alone.
- other fixes related to times (they now seem to be right)
- scs_subscribe doesn't use g_malloc anymore. it uses GMemChunks
(I had to rename two GMemChunks to make MSVC happy)
- fixes crash at reinit when DiscardPduData=TRUE: check if there's an
avpl before deleting it.
- mate.pdu_type.RelativeTime had a dual use, add
mate.pdu_type.TimeInGop and leave the other alone.
- other fixes related to times (they now seem to be right)
- fixed few things at reinit:
     - reset last_id 
     - remove the nodes in the items hash tables 

svn path=/trunk/; revision=12820
2004-12-23 08:27:30 +00:00
Lars Roland af8041a316 Patch for Mate Plugin.
From Luis Ontanon:
- moves mate configuration from proto_register to proto_register_handoff
- add the config file protocol preference
- every item (gop,gog,pdu) has it's own ett
- the tap doesn't do nothing, it just primes the tree
- analyze_frame()  what once was the tap now is called by the dissector
- should work with tethereal now (to be tested)

svn path=/trunk/; revision=12763
2004-12-16 19:36:23 +00:00
Lars Roland 04a6f55e4c Update for Mate from Luis Ontanon:
- make rd static (no purpose for it to be global)
- remove outdated comments
- add "PduCriteria" feature (as already stated in the wiki)
- add "DiscardUnassignedPdu" feature (as already stated in the wiki)
- removed ".Id" from abbrev for "mate.item_name"

- in radius.mate:  Don't use the port to determine the Gop key.

svn path=/trunk/; revision=12735
2004-12-12 23:40:44 +00:00
Lars Roland 62506c09d6 Fixes for Mate Plugin:
As suggested by Martin Regner:
- Use strtod() instead of strtof()

From Luis Ontanon:
- changes the id of mate items to be integer (the old string ID
imposed a lenght limit and as mate fileds had become dynamic it makes
no more sense anymore)

- fixes a huge avp leak on reinit (every avp object was leaked when a
new file was loaded)

- adds the "Lib" AVP to the Action=Include AVPL to include definitions
>from matelib

- rename mate.[dll/so] to zzmate.[dll/so] so it gets initialized as
the very last protocol (so that fields from every dissector can be
used).

svn path=/trunk/; revision=12728
2004-12-12 16:58:59 +00:00
Lars Roland 86d7ed9bae New Plugin from Luis Ontanon:
MATE -- Meta Analysis and Tracing Engine

Won't be compiled by default.

It is still not possible to link the plugin on Win32.

svn path=/trunk/; revision=12716
2004-12-11 01:00:17 +00:00