Commit graph

28963 commits

Author SHA1 Message Date
Jeff Morriss
8c2b702670 Move svnadd to the tools directory.
svn path=/trunk/; revision=29866
2009-09-11 18:15:46 +00:00
Jeff Morriss
c6261aee41 From Peter Harris via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2981 :
Put the git version of mesa and xcbproto in the generated header files.

From me: Don't use 'which' to find git--it wouldn't work on Windows.

svn path=/trunk/; revision=29865
2009-09-11 18:06:50 +00:00
Jaap Keuter
d764400291 From Jean-François Wauthy:
Dissect the Auxiliary Security Header for IEEE 802.15.4-2006 only.
Also Auxiliary Security Header dissection endianness bugfix.

svn path=/trunk/; revision=29864
2009-09-11 16:58:21 +00:00
Stephen Fisher
5dfeb86fb7 Fix warning that variable may be unused and then declare volatile so it
survives the TRY/CATCH code.


svn path=/trunk/; revision=29863
2009-09-11 15:38:33 +00:00
Martin Mathieson
d69ac7dc4a Add more useful summary info to RLC root. Useful mostly for when called from MAC.
svn path=/trunk/; revision=29862
2009-09-11 15:16:53 +00:00
Anders Broman
6edeb87ad7 Only move to last row if it's vissible.
svn path=/trunk/; revision=29861
2009-09-11 14:58:49 +00:00
Kovarththanan Rajaratnam
8d802d414c Make sure that we point the current column to a constant string if we have no address.
Fixes http://wiki.wireshark.org/Development/OptimizePacketList?action=diff&rev1=20&rev2=21

svn path=/trunk/; revision=29860
2009-09-11 14:21:04 +00:00
Kovarththanan Rajaratnam
129f907f0c Move some CHECK_COL to our public functions, allowing us to bail our more quickly
svn path=/trunk/; revision=29859
2009-09-11 14:00:36 +00:00
Jörg Mayer
3a100b0cd8 - Update README.cmake: The stuff now build without
running autofoo first.
- Add a comment how to change the name of a generated target

svn path=/trunk/; revision=29858
2009-09-11 13:30:01 +00:00
Anders Broman
0772dd06b4 New_packet_list
Select the correct frame in packet details when filtering.

svn path=/trunk/; revision=29857
2009-09-11 11:58:00 +00:00
Jeff Morriss
72a86ea5c5 When pre-declaring variables, use the right type.
svn path=/trunk/; revision=29856
2009-09-11 11:22:23 +00:00
Jörg Mayer
107c3b70b4 Update generating the x11 stuff to follow configure
svn path=/trunk/; revision=29855
2009-09-11 10:46:53 +00:00
Jeff Morriss
961cd3c6ce From Peter Harris via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2981 :
This patch adds extension support to the X11 dissector.

I've removed the perl script from the make file, since the new one depends on
perl 5.10, xcbproto (at least git as of today), and mesa (at least the
mesa/src/mesa/glapi directory). It seemed easier to just add the generated
header files to svn directly.

svn path=/trunk/; revision=29854
2009-09-11 01:57:59 +00:00
Guy Harris
b75a84dd4f Get rid of trailing space in string.
svn path=/trunk/; revision=29853
2009-09-11 00:00:45 +00:00
Martin Mathieson
e09d89e145 Add the option to call RLC dissector for LCID 1&2.
These should be srb1 & srb2 (AM).

svn path=/trunk/; revision=29852
2009-09-10 22:53:57 +00:00
Jaap Keuter
85cfb2d98c From Jean-François Wauthy:
Implementation of the IEEE 802.15.4 dissector ignores the Auxiliary Security
Header of the MHR (see IEEE 802.15.4-2006 specs p.138). 
The attached patch, add two things :
 1) Support for dissecting the Auxiliary Security Header
 2) Add a preference option to force the dissection of 
    the FCS field as being in the TI CC24xx format

svn path=/trunk/; revision=29849
2009-09-10 20:42:17 +00:00
Jaap Keuter
c4ab58dd42 From Jean-François Wauthy:
This patch fixes a bug in the dissection of the TI CC24xx FCS where the
endianness of the bitmasks used was wrong.

svn path=/trunk/; revision=29847
2009-09-10 18:54:12 +00:00
Kovarththanan Rajaratnam
56b8d36e03 Introduce a few FT_XXX lengths defines and use those instead of hard coding constants
svn path=/trunk/; revision=29846
2009-09-10 18:22:33 +00:00
Martin Mathieson
019625d876 Re-arrange dissection of UL/DL-SCH so easier to test for ommitted SDUs.
svn path=/trunk/; revision=29845
2009-09-10 18:12:41 +00:00
Kovarththanan Rajaratnam
b97cfa22fd offset_from_real_beginning() is only called with 0 as second argument, so remove the argument completely. It seems that the second argument only acts as an accumulator allowing offset_from_real_beginning() to call itself recursively. To be consistent offset_from_real_beginning() is renamed to tvb_offset_from_real_beginning().
svn path=/trunk/; revision=29844
2009-09-10 16:54:02 +00:00
Gerald Combs
22dcdd3f9a WPA decryption fix from Greg Schwendimann via bug 3890:
I'm reasonably sure that I introduced this bug and I apologize for the problems
with my previous patch.  The problem is that I did not use all of the seen
keys,  I used all except the first key, which in a case of one key is none. 
The attached patch fixes the error.

svn path=/trunk/; revision=29843
2009-09-10 16:50:25 +00:00
Jeff Morriss
037f83cb88 From Artem Tamazov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3903 :
Decoding of UDP-multiplexed CESoPSN and SAToP traffic.

svn path=/trunk/; revision=29842
2009-09-10 15:30:10 +00:00
Kovarththanan Rajaratnam
48069c2b01 Use the correct type, that is GByteArray instead of GString. The reason why this 'worked' before (on non-64bit platforms that is):
struct _GString
{
  gchar  *str;
  gsize len;    
  gsize allocated_len;
};

And:

struct _GArray
{
  gchar *data;
  guint len;
};

We only accessed the first two fields of the GString struct.

svn path=/trunk/; revision=29841
2009-09-10 14:37:09 +00:00
Kovarththanan Rajaratnam
aaa6d87cf0 Remove unused field
svn path=/trunk/; revision=29840
2009-09-10 13:52:36 +00:00
Michael Tüxen
e6391e94d8 Fix handling of BEARER_CONTROL_UNIT_IDENTIFIER.
svn path=/trunk/; revision=29839
2009-09-10 09:50:30 +00:00
Jörg Mayer
9250a69a99 Update to add the last missing detection stuff.
Some of it is untested, kerberos is currently a hack.
Apart from that, package detection should be complete.

svn path=/trunk/; revision=29838
2009-09-10 07:04:54 +00:00
Anders Broman
159904bdc4 From Diego:
proto_item_set_len is missing from Lua API.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3994

svn path=/trunk/; revision=29837
2009-09-10 06:37:04 +00:00
Anders Broman
213c607443 From Alex deVries:
DSI/AFP dissectors need support for AFP 3.3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3995

svn path=/trunk/; revision=29836
2009-09-10 06:07:31 +00:00
Anders Broman
8a23b29c91 From Alex Lindberg:
Add H248V1 suport.
(H248 dissector fails on poorly formed AuditReply packet from Media Gateway)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3953

svn path=/trunk/; revision=29835
2009-09-10 05:57:30 +00:00
Jeff Morriss
c6c330b092 Add blurb for Chris Maynard's recent NHRP changes.
svn path=/trunk/; revision=29834
2009-09-10 02:46:40 +00:00
Jeff Morriss
7841dc8c5b From Chris Maynard via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3950 :
The attached patch improves NHRP dissection and encompasses the following
changes:
1) Now displays Request ID and CIE Reply code or Error code in Info column.

2) Added support for RFC 2520 and RFC 2735 extensions and error codes.
   References:
       -> http://www.ietf.org/rfc/rfc2520.txt?number=2520
       -> http://www.ietf.org/rfc/rfc2735.txt?number=2735
   Note: Cisco's NAT Address Extension conflicts with RFC 2735's published
Device Capabilities Extension.  Both are assigned type 9.  As such, I have had
to add some heuristics to differentiate between them.  It should be reliable
though since the former carries a CIE with length > 8 bytes, and the latter a
fixed-length payload of 8 bytes.

3) A few fields previously not filterable now are: hf_nhrp_hdr_op_type,
hf_nhrp_hdr_version and hf_nhrp_error_code.

4) Added support for authentication and vendor-private extension header decode.
   NOTE: The authentication extension has been added according to RFC 2332.  In
practice, it seems that at least with certain Cisco equipment (I tested with
cisco 2851 IOS version 12.4(15)T), they use their own non-standard
authentication extension format.  Because of this, Cisco's version of the
extension will likely either be displayed a little differently than one may
expect or be indicated as being mal-formed ... because in reality, it is.

5) Utilizes expert info in a couple more places to indicate mal-formed packets.
 Cisco's Error Indication packet, for example, violates RFC 2332 Section 5.2.7
by including extensions in the Error Indication packet as well as by including
erroneous data following the End Extension.  Both cases are reported via expert
info now.  Previously, at least with the case of the erroneous data following
the End Extension, the packet would almost certainly have been marked
mal-formed anyway.  I now just prevent Wireshark from even attempting to decode
the non-sensical mess.


svn path=/trunk/; revision=29833
2009-09-10 02:40:19 +00:00
Jeff Morriss
bc0a9f12d3 From Edward J. Paradise via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3954 :
The A and N bit descriptions should be Always and Never, not Answer and
Incomplete.

svn path=/trunk/; revision=29832
2009-09-10 02:15:55 +00:00
Guy Harris
e89ad210c7 Put in a note about the Snow Leopard bug that requires that you have BPF
devices open for writing in order to capture outgoing traffic.

svn path=/trunk/; revision=29831
2009-09-10 00:37:16 +00:00
Guy Harris
6efbdf6cc9 To quote
http://developer.apple.com/mac/library/documentation/MacOSX/Conceptual/BPSystemStartup/Articles/StartupItems.html

"Table 1  StartupParameters.plist key-value pairs

Key		Type	Value
Description	String	A short description of the startup item,
			used by administrative tools.

Provides	Array	The names of the services provided by this
			startup item.  Although a startup item can
			potentially provide multiple services, it is
			recommended that you limit your startup items
			to only one service each."

Fix "Provides" to be the name of the service, not a description of the
helpful operations that it provides.

(Propagated from tcpdump.org git repository.)

svn path=/trunk/; revision=29830
2009-09-09 23:56:27 +00:00
Anders Broman
b9901ede8a Be consistent use and g_string_chunk_insert_const() in stead of
g_string_chunk_insert() as in expert_dlg.c

svn path=/trunk/; revision=29827
2009-09-09 19:34:14 +00:00
Jaap Keuter
564eff837f From Ivan Sy:
Add a more descriptive log message on DH key exchange.

svn path=/trunk/; revision=29825
2009-09-09 19:09:57 +00:00
Kovarththanan Rajaratnam
0fb1a3eca3 * Free dfilter on shutdown
* Remove unused packet_info variable

svn path=/trunk/; revision=29824
2009-09-09 16:38:09 +00:00
Stig Bjørlykke
3f5e66a999 Added support for Multi-Topology (MT) Routing (RFC4915)
Added W and N flags
Fixed some string capitalizations.

svn path=/trunk/; revision=29823
2009-09-09 15:06:38 +00:00
Stig Bjørlykke
ae806f51fd Fixed data type signedness for protocol_data_1_global.
svn path=/trunk/; revision=29822
2009-09-09 14:11:10 +00:00
Kovarththanan Rajaratnam
2547ce21bf We no longer support the old plugin API so remove it completely from the build system
svn path=/trunk/; revision=29821
2009-09-09 14:01:57 +00:00
Jörg Mayer
8694c4ba3c Add missing include dirs when building wslua.
wslua doesn't build due to some probably non-cmake
related problem (have to verify though).

svn path=/trunk/; revision=29820
2009-09-09 13:27:25 +00:00
Jörg Mayer
ca6b1e2b21 CMAKE: Get most of of missing *build* pieces into place
svn path=/trunk/; revision=29819
2009-09-09 13:20:33 +00:00
Anders Broman
a65f72e8f0 Allocate col_text and col_text_len when the fdata struct is allocated.
(complete the checkin).

svn path=/trunk/; revision=29818
2009-09-09 08:51:33 +00:00
Anders Broman
1e137770e6 Allocate col_text and col_text_len when the fdata struct is allocated.
svn path=/trunk/; revision=29817
2009-09-09 08:50:06 +00:00
Anders Broman
0c5dfd7698 Target Identification shall be coded as TLV IE where value is
coded as TargetRNC-ID.
Proposed fix to
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3974
(The enclosed trace dioes not decode properly but may be wrongly encoded).

svn path=/trunk/; revision=29816
2009-09-09 07:29:41 +00:00
Jaap Keuter
b30cc51638 From kahou:
FCSOF incorrect checksum calculation.

svn path=/trunk/; revision=29815
2009-09-09 07:27:01 +00:00
Jaap Keuter
a1738f2fec Fix for bug 3987:
Option Request option values are in 16 bit units.

svn path=/trunk/; revision=29814
2009-09-09 07:22:44 +00:00
Gerald Combs
ffd3a72374 Check our array lengths and refuse to process them if they're too large.
Fixes bug 3986. Use tvb_memeql and proto_tree_add_item instead of
digging around in tvb->real_data.

svn path=/trunk/; revision=29813
2009-09-09 00:18:15 +00:00
Gerald Combs
40e2849be8 Just use proto_tree_add_item instead of feeding tvb->real_data to
proto_tree_add_bytes.

svn path=/trunk/; revision=29812
2009-09-08 22:58:23 +00:00
Gerald Combs
c238175acf Move the infinite loop check from proto_tree_add_node to
TRY_TO_FAKE_THIS_ITEM. Partial fix for bug 3986.

svn path=/trunk/; revision=29811
2009-09-08 22:56:55 +00:00