037f83cb88
From Artem Tamazov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3903 :
...
Decoding of UDP-multiplexed CESoPSN and SAToP traffic.
svn path=/trunk/; revision=29842
2009-09-10 15:30:10 +00:00
48069c2b01
Use the correct type, that is GByteArray instead of GString. The reason why this 'worked' before (on non-64bit platforms that is):
...
struct _GString
{
gchar *str;
gsize len;
gsize allocated_len;
};
And:
struct _GArray
{
gchar *data;
guint len;
};
We only accessed the first two fields of the GString struct.
svn path=/trunk/; revision=29841
2009-09-10 14:37:09 +00:00
aaa6d87cf0
Remove unused field
...
svn path=/trunk/; revision=29840
2009-09-10 13:52:36 +00:00
e6391e94d8
Fix handling of BEARER_CONTROL_UNIT_IDENTIFIER.
...
svn path=/trunk/; revision=29839
2009-09-10 09:50:30 +00:00
9250a69a99
Update to add the last missing detection stuff.
...
Some of it is untested, kerberos is currently a hack.
Apart from that, package detection should be complete.
svn path=/trunk/; revision=29838
2009-09-10 07:04:54 +00:00
159904bdc4
From Diego:
...
proto_item_set_len is missing from Lua API.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3994
svn path=/trunk/; revision=29837
2009-09-10 06:37:04 +00:00
213c607443
From Alex deVries:
...
DSI/AFP dissectors need support for AFP 3.3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3995
svn path=/trunk/; revision=29836
2009-09-10 06:07:31 +00:00
8a23b29c91
From Alex Lindberg:
...
Add H248V1 suport.
(H248 dissector fails on poorly formed AuditReply packet from Media Gateway)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3953
svn path=/trunk/; revision=29835
2009-09-10 05:57:30 +00:00
7841dc8c5b
From Chris Maynard via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3950 :
...
The attached patch improves NHRP dissection and encompasses the following
changes:
1) Now displays Request ID and CIE Reply code or Error code in Info column.
2) Added support for RFC 2520 and RFC 2735 extensions and error codes.
References:
-> http://www.ietf.org/rfc/rfc2520.txt?number=2520
-> http://www.ietf.org/rfc/rfc2735.txt?number=2735
Note: Cisco's NAT Address Extension conflicts with RFC 2735's published
Device Capabilities Extension. Both are assigned type 9. As such, I have had
to add some heuristics to differentiate between them. It should be reliable
though since the former carries a CIE with length > 8 bytes, and the latter a
fixed-length payload of 8 bytes.
3) A few fields previously not filterable now are: hf_nhrp_hdr_op_type,
hf_nhrp_hdr_version and hf_nhrp_error_code.
4) Added support for authentication and vendor-private extension header decode.
NOTE: The authentication extension has been added according to RFC 2332. In
practice, it seems that at least with certain Cisco equipment (I tested with
cisco 2851 IOS version 12.4(15)T), they use their own non-standard
authentication extension format. Because of this, Cisco's version of the
extension will likely either be displayed a little differently than one may
expect or be indicated as being mal-formed ... because in reality, it is.
5) Utilizes expert info in a couple more places to indicate mal-formed packets.
Cisco's Error Indication packet, for example, violates RFC 2332 Section 5.2.7
by including extensions in the Error Indication packet as well as by including
erroneous data following the End Extension. Both cases are reported via expert
info now. Previously, at least with the case of the erroneous data following
the End Extension, the packet would almost certainly have been marked
mal-formed anyway. I now just prevent Wireshark from even attempting to decode
the non-sensical mess.
svn path=/trunk/; revision=29833
2009-09-10 02:40:19 +00:00
bc0a9f12d3
From Edward J. Paradise via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3954 :
...
The A and N bit descriptions should be Always and Never, not Answer and
Incomplete.
svn path=/trunk/; revision=29832
2009-09-10 02:15:55 +00:00
564eff837f
From Ivan Sy:
...
Add a more descriptive log message on DH key exchange.
svn path=/trunk/; revision=29825
2009-09-09 19:09:57 +00:00
3f5e66a999
Added support for Multi-Topology (MT) Routing (RFC4915)
...
Added W and N flags
Fixed some string capitalizations.
svn path=/trunk/; revision=29823
2009-09-09 15:06:38 +00:00
ae806f51fd
Fixed data type signedness for protocol_data_1_global.
...
svn path=/trunk/; revision=29822
2009-09-09 14:11:10 +00:00
ca6b1e2b21
CMAKE: Get most of of missing *build* pieces into place
...
svn path=/trunk/; revision=29819
2009-09-09 13:20:33 +00:00
0c5dfd7698
Target Identification shall be coded as TLV IE where value is
...
coded as TargetRNC-ID.
Proposed fix to
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3974
(The enclosed trace dioes not decode properly but may be wrongly encoded).
svn path=/trunk/; revision=29816
2009-09-09 07:29:41 +00:00
b30cc51638
From kahou:
...
FCSOF incorrect checksum calculation.
svn path=/trunk/; revision=29815
2009-09-09 07:27:01 +00:00
a1738f2fec
Fix for bug 3987:
...
Option Request option values are in 16 bit units.
svn path=/trunk/; revision=29814
2009-09-09 07:22:44 +00:00
40e2849be8
Just use proto_tree_add_item instead of feeding tvb->real_data to
...
proto_tree_add_bytes.
svn path=/trunk/; revision=29812
2009-09-08 22:58:23 +00:00
c238175acf
Move the infinite loop check from proto_tree_add_node to
...
TRY_TO_FAKE_THIS_ITEM. Partial fix for bug 3986.
svn path=/trunk/; revision=29811
2009-09-08 22:56:55 +00:00
c96804223f
Print cic in info column for BICC messages similar to ISUP.
...
svn path=/trunk/; revision=29810
2009-09-08 21:20:31 +00:00
d2db67480c
Use g_strlcpy when possible
...
svn path=/trunk/; revision=29808
2009-09-08 20:06:52 +00:00
8341ccabc6
From Xavier Laxa:
...
UNS bit not correctly parsed in DNP APP Layer.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3318
svn path=/trunk/; revision=29807
2009-09-08 19:38:42 +00:00
de23d92163
Add an option to col_fill_in() to allow us to disable column expression processing. This is rarely needed. It's only needed when the user right clicks on the packet list view to generate a display filter.
...
svn path=/trunk/; revision=29806
2009-09-08 19:00:54 +00:00
1ad55d8c02
From Steve Osselton:
...
Fix for MIOP dissector for GIOP < 1.2.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3892
svn path=/trunk/; revision=29805
2009-09-08 18:46:47 +00:00
b90a11bee3
Make tshark and rawshark use build_column_format_array() instead of duplicating the code
...
svn path=/trunk/; revision=29803
2009-09-08 17:29:57 +00:00
4c1be31824
Trivial: add direction to expert info string for CRC failures.
...
svn path=/trunk/; revision=29802
2009-09-08 17:13:55 +00:00
1aca48909c
- now wireshark compiles with cmake as well
...
svn path=/trunk/; revision=29799
2009-09-08 15:56:16 +00:00
d713b846e6
Hoist COL_CHECK_REF_TIME in the call hierarchy. Use it in our public functions, not our internal functions
...
svn path=/trunk/; revision=29798
2009-09-08 15:55:10 +00:00
d75778eb4a
Custom columnfication:
...
* Deprecate COL_DCE_CTX ("Context ID). Use dcerpc.cn_ctx_id
svn path=/trunk/; revision=29797
2009-09-08 14:59:26 +00:00
bc845e056c
Custom column deprecation:
...
We fill out the COL_DSTIDX column by using 'pinfo->dst_idx'. This member is only set by the MDS Header dissector based on 'mdshdr.dstidx'. So remove COL_DSTIDX and migrate to 'mdshdr.dstidx' custom column.
svn path=/trunk/; revision=29795
2009-09-08 14:29:08 +00:00
62af6eff84
Custom column deprecation:
...
We fill out the COL_SRCIDX column by using 'pinfo->src_idx'. This member is only set by the MDS Header dissector based on 'mdshdr.srcidx'. So remove COL_SRCIDX and migrate to 'mdshdr.srcidx' custom column.
svn path=/trunk/; revision=29794
2009-09-08 14:26:09 +00:00
2cf14900d2
Custom column deprecation:
...
We fill out the COL_RXID column by using 'pinfo->rxid'. This member is only set by the Fibre Channel dissector based on 'fc.rx_id'. So remove COL_RXID and migrate to 'fc.rx_id' custom column.
svn path=/trunk/; revision=29793
2009-09-08 14:21:14 +00:00
cdfeebdd26
Custom column deprecation:
...
We fill out the COL_OXID column by using 'pinfo->oxid'. This member is only set by the Fibre Channel dissector based on 'fc.ox_id'. So remove COL_OXID and migrate to 'fc.ox_id' custom column.
svn path=/trunk/; revision=29792
2009-09-08 14:17:36 +00:00
99fbe23445
Cleanup code for type and code, do not show empty "()" when code is unused.
...
Use hex values for bitmasks in header_field_info.
svn path=/trunk/; revision=29790
2009-09-08 13:44:34 +00:00
c6d4c80371
From : Didier Gautheron
...
speed up a little proto_custom_set.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3972
svn path=/trunk/; revision=29789
2009-09-08 10:33:15 +00:00
3d2e307ae6
From Alex Lindberg:
...
Update to h248v3.asn
Applied the change from the Amendment 1 by hand.
svn path=/trunk/; revision=29787
2009-09-08 09:11:21 +00:00
3b3ea47176
dftest and rawshark now build.
...
tshark might build.
svn path=/trunk/; revision=29786
2009-09-08 07:03:57 +00:00
65e2d90058
Remove an unused parameter.
...
svn path=/trunk/; revision=29784
2009-09-08 04:50:48 +00:00
3efea601d4
Make sure that we fill in the frame_data before passing it onto col_fill_in_frame_data
...
svn path=/trunk/; revision=29780
2009-09-07 19:43:05 +00:00
33b8efd375
Auto size COL_NUMBER, COL_PACKET_LENGTH and COL_CUMULATIVE_BYTES
...
svn path=/trunk/; revision=29778
2009-09-07 18:53:17 +00:00
d41058065f
From Mike Morrin:
...
The GSM L3 part of the BSSMAP CipherModeComplete message is not being decoded.
Sligtly modified.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3983
svn path=/trunk/; revision=29776
2009-09-07 17:17:07 +00:00
99c24a8eb4
From Mike Morrin:
...
Patch adding BSSMAP dissectors MSC Invoke Trace and BSS Invoke Trace.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3985
svn path=/trunk/; revision=29774
2009-09-07 17:08:34 +00:00
c629dde8b6
Constify some functions
...
svn path=/trunk/; revision=29773
2009-09-07 16:17:58 +00:00
98d18343c8
Whitespace changes
...
svn path=/trunk/; revision=29772
2009-09-07 16:07:04 +00:00
72c9662da6
ntroduce some seasonal address name lookup functions which we use when NEW_PACKET_LIST is defined. This change partially reverts some parts of r29768, which didn't seem to work because it assumed that get_addr_name() would always return a seasonal string. This wasn't the case if the adddress type was AT_STRINGZ.
...
svn path=/trunk/; revision=29771
2009-09-07 16:05:37 +00:00
ea0ab046e0
Tigthen scope of local variables
...
svn path=/trunk/; revision=29770
2009-09-07 15:49:14 +00:00
2fe83ebaed
mark unused parameter.
...
svn path=/trunk/; revision=29769
2009-09-07 15:01:51 +00:00
3abd049a9b
Use constant strings for Addresses saves some memory.
...
svn path=/trunk/; revision=29768
2009-09-07 14:03:05 +00:00
a65d590002
Store the packet encapsulation type as gint8. Saves 3 bytes per packet
...
svn path=/trunk/; revision=29767
2009-09-07 13:54:46 +00:00
cd8831c72d
Track length of columns strings. We'll need this in order to resize columns quickly
...
svn path=/trunk/; revision=29759
2009-09-07 11:33:38 +00:00
9500e97cb3
- Undo the PACKAGELIST WSWIN32 stuff in CMakeLists.txt:
...
That's what the packages are for, so instead of creating
WSWIN32, the stuff should probably go into the GLIB2
package.
- libwireshark now compiles - no time to add linking with
it until tonight
svn path=/trunk/; revision=29756
2009-09-07 07:26:43 +00:00
7a413a615a
Don't pass length 0 to a FT_UINT.
...
Fixed some uint types with length 2.
svn path=/trunk/; revision=29755
2009-09-07 01:19:26 +00:00
0e5cef61be
Split a bunch of init routines into init() and cleanup(). This allows us to free memory properly on shutdown.
...
This is an initial step. There's still some work to do.
svn path=/trunk/; revision=29754
2009-09-06 18:25:23 +00:00
d6122ad422
Reorder file to group related functionality
...
svn path=/trunk/; revision=29753
2009-09-06 15:06:41 +00:00
aed021a72d
[Automatic manuf and enterprise-numbers update for 2009-09-06]
...
svn path=/trunk/; revision=29750
2009-09-06 15:03:28 +00:00
a4ce0d3d69
Put back
...
http://anonsvn.wireshark.org/viewvc?view=rev&revision=29656
http://anonsvn.wireshark.org/viewvc?view=rev&revision=29658
http://anonsvn.wireshark.org/viewvc?view=rev&revision=29661
Reverted by my previous checkin.
svn path=/trunk/; revision=29749
2009-09-06 14:53:21 +00:00
f641693bf4
Change se_address_to_str() to call address_to_str_buf() directly
...
svn path=/trunk/; revision=29748
2009-09-06 14:39:53 +00:00
8c48c6835f
Rename address_to_str() to ep_address_to_str() because:
...
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().
svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
c7eb52b086
Remove already #if 0'ed code that was made redundant due to COL_CIRCUIT_ID custom column deprecation
...
svn path=/trunk/; revision=29745
2009-09-06 13:35:27 +00:00
bfe9f61a7c
Remove static custom column variable which is no longer used
...
svn path=/trunk/; revision=29744
2009-09-06 13:25:31 +00:00
571e69fdfa
We don't currently fake fields if they are referenced indirectly through some other fields (currently only FT_PROTOCOL's can be indirectly referenced) . However, there doesn't seem to be any reason for this restriction. We already have proto_tree_set_fake_protocols() to disable 'faking' if any clients requires this. So, this changelist removes this restriction on indirectly referenced fields.
...
svn path=/trunk/; revision=29742
2009-09-06 11:30:41 +00:00
ba14c67566
Use correct field types for variable length fields.
...
Fixed types by adding new types for "undissected" blocks:
- Replace Bridge Address
- Multicast With Response
- Confirm Network Encryption Key
- Host Tag
svn path=/trunk/; revision=29741
2009-09-06 11:24:56 +00:00
09237c27f9
Inline col_has_time_fmt() into col_based_on_frame_data()
...
svn path=/trunk/; revision=29739
2009-09-06 10:03:06 +00:00
474f5930db
Macrofy have_custom_cols() -> HAVE_CUSTOM_COLS() internally in columns-utils.c
...
svn path=/trunk/; revision=29737
2009-09-06 09:11:17 +00:00
22077a8eb1
Macrofy check_col() -> CHECK_COL() internally in columns-utils.c
...
svn path=/trunk/; revision=29736
2009-09-06 09:03:15 +00:00
137b886960
From Didier Gautheron:
...
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Optimize address handling.
The address hash should be possible to use from the new_packet_list.
svn path=/trunk/; revision=29735
2009-09-06 08:59:30 +00:00
b91827f5a0
Avoid calling emem_create_chunk() needlessly
...
svn path=/trunk/; revision=29734
2009-09-06 08:10:12 +00:00
b3b9be09c7
We track all protocols that appear in each packet in the frame dissector. This is an expensive operation because we:
...
* Disable the TRY_TO_FAKE_THIS_ITEM optimization
* Use GString to store the protocols
We should only do this if the 'hf_frame_protocols' is referenced (unlikely)
svn path=/trunk/; revision=29733
2009-09-06 07:55:17 +00:00
820ce62af5
This fix was supposed to be in r29731 which some how only contained whitespace changes.
...
svn path=/trunk/; revision=29732
2009-09-06 07:33:07 +00:00
9c512f7cb4
Introduce TRY_TO_FAKE_THIS_REPR which is an optimization similar to the existing TRY_TO_FAKE_THIS_ITEM. The purpose of TRY_TO_FAKE_THIS_REPR is to avoid generating the string representation for the protocol item. There is no point in doing this if the protocol tree isn't visible. In this case the result will be discarded any way.
...
svn path=/trunk/; revision=29731
2009-09-06 07:24:54 +00:00
4df25480b7
The frame dissector disables the TRY_TO_FAKE_THIS_ITEM() optimization by marking the protocol tree as permamently visible. It only needs to disable the optimization temporarily while it creates the protocol item it intends to use proto_item_append_string() on
...
svn path=/trunk/; revision=29730
2009-09-06 06:33:13 +00:00
f352fa6d90
s/col_add_fstr/col_add_str
...
svn path=/trunk/; revision=29727
2009-09-06 05:29:51 +00:00
6fe1060cd1
Don't pass ep_alloc()'ed strings to col_set_str().
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3984
svn path=/trunk/; revision=29726
2009-09-06 04:26:50 +00:00
a9e644f382
Changed type for "Wireless data" to FT_BYTES.
...
svn path=/trunk/; revision=29725
2009-09-05 22:12:51 +00:00
7d4cf0b966
col_custom_set_fstr() is unused. Remove it
...
svn path=/trunk/; revision=29722
2009-09-05 18:45:55 +00:00
a108023b2a
COL_BSSGP_TLLI is deprecated
...
svn path=/trunk/; revision=29721
2009-09-05 18:39:46 +00:00
7e8455ff63
Reorder col_fill_in()
...
svn path=/trunk/; revision=29720
2009-09-05 18:28:06 +00:00
e275d24c39
Ignore preferences for deleted protocols "etheric" and "isup_thin".
...
svn path=/trunk/; revision=29709
2009-09-05 13:06:45 +00:00
b7bdf3efc1
A few minor revisions:
...
- if (check_col ...) no longer required;
- Use match_strval when verifying the fcn code;
- Add a missing #ifdef;
- Make a global variable static;
- Fix indentation to be consistent in a few places.
svn path=/trunk/; revision=29701
2009-09-04 18:40:02 +00:00
3ab20de02b
From Rob Casey: Fix for: Incorrect station identifier parsing in Kingfisher dissector
...
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3946
svn path=/trunk/; revision=29700
2009-09-04 18:18:34 +00:00
a3c38e1057
Include "proto.h" instead of <proto.h>
...
svn path=/trunk/; revision=29694
2009-09-04 11:48:04 +00:00
e99983ab3a
From Vincent Helfre:
...
Dissect_ccch does not dissect sys info content.
Me: Remove check_col.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3901
svn path=/trunk/; revision=29693
2009-09-04 11:06:52 +00:00
f0ea776605
From : Didier Gautheron
...
Addresse hash is slow on little endian CPU.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3973
svn path=/trunk/; revision=29692
2009-09-04 10:53:37 +00:00
efd2ed4b51
Show UEId in info column for UL-SCH / DL-SCH frames.
...
svn path=/trunk/; revision=29687
2009-09-03 16:42:16 +00:00
06d5136beb
Add initial support to decode the ADIP and PhysicalInformation for MMC
...
media
svn path=/trunk/; revision=29669
2009-09-02 17:24:52 +00:00
2ef4429761
Add Semi-Persistent Scheduling (SPS) RNTI.
...
svn path=/trunk/; revision=29667
2009-09-02 16:39:39 +00:00
d26cdc30ea
Beginnings of getting cmake to build stuff in epan.
...
It's only beginnings, so epan is commented out in
the subdirs statement.
This is more a synch to avoid duplicate work and creating
conflicting patches to the cmake stuff.
svn path=/trunk/; revision=29666
2009-09-02 16:33:01 +00:00
822d0a2242
No need to include packet-frame.h
...
svn path=/trunk/; revision=29665
2009-09-02 15:52:11 +00:00
5dd678f0a7
Check whether "size" points to something positive, not whether "size"
...
itself is positive (which makes no sense for a pointer).
svn path=/trunk/; revision=29661
2009-09-01 19:31:41 +00:00
f8f4f0fb6b
Remove superfluous NULL pointer checks wrt. g_malloc() and g_realloc()
...
svn path=/trunk/; revision=29658
2009-09-01 18:44:08 +00:00
17f010119a
From Jakub Zawadzki via. Bug 3330:
...
* Fix memleak (df->deprecated in dfilter_free())
* Free protocol hash tables on cleanup.
* Free protocols list on cleanup.
* Free memory allocated by fgetline() in parse_services_file()
From me:
* proto.c: set gmc_hfinfo to NULL after free
* proto.c: switch order of g_free() and g_list_remove() in proto_cleanup()
svn path=/trunk/; revision=29656
2009-09-01 18:16:55 +00:00
95bf560727
Misc cleanup;
...
- Remove no longer needed usage of check_col();
- Add some defensive coding;
- Change a few guints to gints;
- Add parentheses to a few expressions;
- Use consistent indentation.
svn path=/trunk/; revision=29655
2009-09-01 17:17:14 +00:00
8cba530c81
From Richard Brodie via. Bug 3913:
...
Free ptr array allocated through proto_find_finfo()
svn path=/trunk/; revision=29654
2009-09-01 17:09:36 +00:00
8bd7ebc6a1
- Fix for bug 3965 as reported by Ivan Sy <ivan_jr@yahoo.com>
...
mDNS and LLMNR also deviate from the TTL=1 for 224.0.0.0/24
- Fix two warnings about removing const by casting.
svn path=/trunk/; revision=29644
2009-08-31 22:34:25 +00:00
174c2047b1
From Gerasimos Dimitriadis:
...
DTAP decoding of Cause Diagnostics.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3968
svn path=/trunk/; revision=29637
2009-08-31 18:37:15 +00:00
1cadaa2590
[Automatic manuf and enterprise-numbers update for 2009-08-30]
...
svn path=/trunk/; revision=29627
2009-08-30 15:03:26 +00:00
cd49063473
Revert r29614 until I figure out why buildbot doesn't like it
...
svn path=/trunk/; revision=29615
2009-08-29 07:53:48 +00:00
cc948586bf
Use G_STRINGIFY/G_PASTE
...
svn path=/trunk/; revision=29614
2009-08-29 06:42:23 +00:00
bb0108cf25
Use NB_RTPMUX as protocol short name
...
svn path=/trunk/; revision=29610
2009-08-29 04:47:28 +00:00
e0c4b20c86
We need to handoff even when we don't have a tree
...
svn path=/trunk/; revision=29609
2009-08-29 04:43:52 +00:00
Jeff Morriss