Commit graph

39994 commits

Author SHA1 Message Date
Guy Harris
70f67d065f From Evan Huus: fix a memory leak. Fixes bug 7097.
svn path=/trunk/; revision=42088
2012-04-15 22:21:50 +00:00
Guy Harris
a93f134b99 checkapi said
Error: the blurb for field "NMO I" ("gsm_a.nmo_1") has trailing
	    space in packet-gsm_a_common.c

so remove the trailing space.

svn path=/trunk/; revision=42087
2012-04-15 17:37:16 +00:00
Alexis La Goutte
9a988f7de5 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=42086
2012-04-15 17:27:50 +00:00
Gerald Combs
5758c2cd32 [Automatic manuf, services and enterprise-numbers update for 2012-04-15]
svn path=/trunk/; revision=42083
2012-04-15 14:03:31 +00:00
pascal
24559a876c Fix compilation error under Windows
svn path=/trunk/; revision=42082
2012-04-15 12:07:47 +00:00
pascal
1e2f3bb55a Update RRC to V10.7.0 and add dissection of Core Network System Information IEs
svn path=/trunk/; revision=42081
2012-04-15 11:51:40 +00:00
Michael Tüxen
bacf81ff06 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7048
Write timetamps for the interface statistic blocks the way specified
by http://www.winpcap.org/ntar/draft/PCAP-DumpFileFormat.html


svn path=/trunk/; revision=42080
2012-04-15 11:11:36 +00:00
Michael Tüxen
587e0213eb Whitespace cleanup (done while debugging).
svn path=/trunk/; revision=42079
2012-04-15 11:08:40 +00:00
Martin Mathieson
82a2fc4934 Set the extent of the tagged parameters.
svn path=/trunk/; revision=42078
2012-04-15 03:41:15 +00:00
Martin Mathieson
722c68ec90 Fix a typo (just clearing my client out before I start doing diffs).
svn path=/trunk/; revision=42077
2012-04-15 01:38:12 +00:00
Martin Mathieson
4d256e6628 Getting closer to deleting old ROHC from PDCP dissector.
Don't register ROHC fields there (so its easier to find real fields with
auto-completion).

svn path=/trunk/; revision=42076
2012-04-15 01:37:08 +00:00
Guy Harris
cb8edf66a6 From Even Huus: free a strduped string. Fixes bug 7094.
svn path=/trunk/; revision=42074
2012-04-14 18:16:56 +00:00
Guy Harris
6b1c5a9e0d From Evan Huus: free if_string when we're done with it. Fixes bug 7093.
From me: don't bother initializing if_string in its definition, as if
it's used at all it's set to a different value before all uses.

svn path=/trunk/; revision=42073
2012-04-14 18:04:12 +00:00
Guy Harris
04cd90e99e From Evan Huus: add a missing free. Fixes bug 7092.
svn path=/trunk/; revision=42070
2012-04-14 17:45:03 +00:00
Guy Harris
f3c2e6087e More double-free fixes - destroy_k12_file_data() frees its argument, so
calling g_free() on that argument after calling destroy_k12_file_data()
is always an error.

svn path=/trunk/; revision=42067
2012-04-14 17:20:22 +00:00
Anders Broman
514092549c Cosmetic changes
svn path=/trunk/; revision=42066
2012-04-14 12:17:06 +00:00
pascal
7ded30acc1 Set direction according to destination address field also (and not only originating address).
svn path=/trunk/; revision=42065
2012-04-14 11:59:14 +00:00
pascal
a01bf60abf Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6202 :
Stop applying a specific treatment when receiving a SMS-DELIVER packet with an unknown direction (no such treatment is done for SMS-SUBMIT).
Store SMS fragment length in hash table to avoid mangling the output when displaying the reassembled SMS.

svn path=/trunk/; revision=42064
2012-04-14 11:56:12 +00:00
Anders Broman
7d1cef1a06 From Tyson Key: Support for PN532 InDeselect, Release, and InSelect Command and Response Packets. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7083
svn path=/trunk/; revision=42063
2012-04-14 07:58:59 +00:00
Anders Broman
f4c5e276c5 From From Evan Huus: Potential double-free while importing k12xx *.rf5 files https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7084
svn path=/trunk/; revision=42062
2012-04-14 07:53:22 +00:00
Anders Broman
7330ec7035 From Evan Huus: Memory leak in scan_local_interfaces. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7086
svn path=/trunk/; revision=42061
2012-04-14 07:44:51 +00:00
Anders Broman
ff2840fc2f From Evan Huus: Memory leaks in graph_analysis.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7082 changed to not allocating time_str unless needed.
svn path=/trunk/; revision=42060
2012-04-14 07:36:47 +00:00
Guy Harris
de42012ffd If we don't even *have* a filter combo box, there's nothing we can check
or colorize; quit before we even *try* to get the link-layer header
type.

If we don't have an active link-layer header type, that probably means
we don't know what link-layer header types the interface provides, which
would be the case if it were a named pipe or an interface we can't open.
Don't crash in that case, just leave the filter combo box uncolored, to
indicate that we have no clue whether the filter is valid or not.

Fixes bug 7049.

svn path=/trunk/; revision=42059
2012-04-14 00:36:30 +00:00
Guy Harris
b4392dad37 From Evan Huus: fix memory leak. Fixes bug 7081.
svn path=/trunk/; revision=42057
2012-04-13 22:42:19 +00:00
Guy Harris
3fc6c21130 "OUI", not "OID", for IEEE OUIs.
svn path=/trunk/; revision=42056
2012-04-13 22:29:11 +00:00
Guy Harris
2d2d5f47f4 Patch from Alex Lindberg to update the LLDP dissector to display
registered OUIs from manuf and allow custom dissectors for
Organizationally Specific TLVs.  Fixes bug 7080.

Use uint_get_manuf_name() and uint_get_manuf_name_if_known(), rather
than tvb_get_manuf_name() and tvb_get_manuf_name_if_known(), in cases
where we've fetched the OUI.

Have the ECP/VDP dissector also display registered OUIs from manuf.

Get rid of the OUI_CISCO_2 OUI from tlv_oui_subtype_vals, as that can
come from the manuf file.  Leave in comments explaining why, for now, we
aren't using the manuf file for *all* the OUIs.

svn path=/trunk/; revision=42055
2012-04-13 22:26:35 +00:00
Guy Harris
7f8d3e24e3 Add uint_get_manuf_name() and uint_get_manuf_name_if_known() routines,
which take an OUI, presumably fetched with a routine such as
tvb_get_ntoh24(), as an argument and attempt to look it up in the manuf
file.

Fix up the comments for all the get_manuf_name routines.

Get rid of "extern"s in definitions of functions (definitions, not
declarations).

svn path=/trunk/; revision=42054
2012-04-13 22:23:04 +00:00
Jakub Zawadzki
8a1dc57c03 Remove doubled semicolons and semicolons outside function.
svn path=/trunk/; revision=42053
2012-04-13 20:22:31 +00:00
pascal
8fd3fcfd78 From Tyson Key:
Additional PN532 dissector opcode descriptions
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7078

svn path=/trunk/; revision=42052
2012-04-13 20:01:16 +00:00
Guy Harris
f2f11f4a2b GUINT_TO_POINTER() causes warnings when passed something *shorter* than
a guint; cast the argument to guint.

svn path=/trunk/; revision=42051
2012-04-13 19:40:57 +00:00
Guy Harris
01b2867f4e Clean up white space.
svn path=/trunk/; revision=42050
2012-04-13 19:36:44 +00:00
Jakub Zawadzki
25178510bd Try to fix OSX builds.
svn path=/trunk/; revision=42049
2012-04-13 18:27:51 +00:00
Guy Harris
1ebd7c819c Emphasize that TAG_DELIMITER must be a null-terminated string.
svn path=/trunk/; revision=42048
2012-04-13 16:54:24 +00:00
Alexis La Goutte
b40cea4d5b Update ICMPv6 to last IANA Parameters (2012-03-28)
* RFC-ietf-roll-rpl-19 => RFC6550
* draft-ietf-csi-proxy-send-05 => RFC 6496
* Add RFC6495 : Subject Key Identifier (SKI) SEND Name Type fields
* Add RFC6554 : An IPv6 Routing Header for Source Routes with RPL

svn path=/trunk/; revision=42047
2012-04-13 14:05:52 +00:00
Anders Broman
84e8250146 From Pascal Quantin:
Ignore Content-Length if Transfer-Encoding is present

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5182

svn path=/trunk/; revision=42046
2012-04-13 13:10:38 +00:00
Anders Broman
b1b0af6e66 From Pascal Quantin:
Fix Bug 6793  Some WiMAX messages decoded incorrectly

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6793

svn path=/trunk/; revision=42045
2012-04-13 13:02:57 +00:00
Anders Broman
b2f9b5614a From Cristian Constantin:
There was something really wrong in conversation_lookup_hashtable().


https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7066

svn path=/trunk/; revision=42044
2012-04-13 12:53:47 +00:00
Anders Broman
bba21ab84f gunzip gzip:ed SIP bodies.
svn path=/trunk/; revision=42043
2012-04-13 12:04:25 +00:00
Jakub Zawadzki
12ea608604 Needle for guint8_pbrk() must be NULL terminated. Fix bug #7070
svn path=/trunk/; revision=42042
2012-04-13 10:38:41 +00:00
pascal
6f91bcc65a Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6477:
Use T-User-Data-Length to define the string size decoded with the 7 bits alphabet

svn path=/trunk/; revision=42041
2012-04-13 10:01:38 +00:00
Guy Harris
bdda4a4498 When skipping white space, don't skip past the end of the line.
This *might* fix bug 7070, but I can't reproduce that bug on my machine
- I'm guessing from the "out of CPU time" that there's an infinite loop
somewhere, but I'm not seeing it.  In any case, these tests *are*
necessary.

svn path=/trunk/; revision=42040
2012-04-13 03:34:18 +00:00
Guy Harris
ee13854e77 Give some URLs for descriptions of RTMP.
svn path=/trunk/; revision=42039
2012-04-12 22:13:59 +00:00
Jakub Zawadzki
a94826528b Simplify r42030 expression. Thanks!
svn path=/trunk/; revision=42038
2012-04-12 21:56:13 +00:00
Graham Bloice
aa8c8f6dfd Added Rel. Start and Duration to tshark -z conv,xxx output. Tidied up duplicated code
svn path=/trunk/; revision=42037
2012-04-12 20:18:49 +00:00
Anders Broman
6968651735 Refactor to use dissect_gsm_map_msisdn().
svn path=/trunk/; revision=42036
2012-04-12 14:34:52 +00:00
Anders Broman
9551f33d95 Bugfix and enhancement of MM Context dissection.
svn path=/trunk/; revision=42035
2012-04-12 14:07:31 +00:00
pascal
9f70eb0ca6 From Nick Lowe:
Use correct return type for tvb_get_ephemeral_string
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1450

svn path=/trunk/; revision=42034
2012-04-12 10:08:38 +00:00
Anders Broman
7f6a40b810 From Michael Mann: improved the IRC dissector to be able to pick out the CTCP protocol. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1450
svn path=/trunk/; revision=42033
2012-04-12 05:46:42 +00:00
Anders Broman
5d101caa89 From Martin Kaiser: CID 525 is about tvb_new_octet_aligned(). datalen can be negative or 0 when ep_alloc0(datalen) is called. If this happens, it's because of a dissector not checking the bit_offset, I think a DISSECTOR_ASSERT() is ok for fixing this. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7068
svn path=/trunk/; revision=42032
2012-04-12 05:36:26 +00:00
Anders Broman
8cdb90bd44 From Martin Kaiser: CID 476: add missing break. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7067
svn path=/trunk/; revision=42031
2012-04-12 05:32:22 +00:00