Martin Mathieson
5ed2e2f914
Trivial: Update AUTHORS entry, remove out-of-date comments, minor formatting
...
svn path=/trunk/; revision=32611
2010-04-30 17:15:59 +00:00
Martin Mathieson
253e2541e9
Put offset++ back in again.
...
svn path=/trunk/; revision=32531
2010-04-21 10:12:03 +00:00
Martin Mathieson
08100dc039
From Pascal Quantin:
...
Don't report as an error if see non-zero padding bits.
svn path=/trunk/; revision=32524
2010-04-20 15:41:03 +00:00
Bill Meier
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Martin Mathieson
1ef05048a3
Use val_to_str_const() where have no format is default string
...
svn path=/trunk/; revision=32188
2010-03-14 16:36:41 +00:00
Martin Mathieson
27efebc70c
Last missing SN wasn't coming out correctly if it was 1023...
...
svn path=/trunk/; revision=32174
2010-03-12 03:50:47 +00:00
Martin Mathieson
13e5793106
Write context fields inside own subtree.
...
Use common functions to append text to info column and tree items.
svn path=/trunk/; revision=32150
2010-03-09 01:39:08 +00:00
Martin Mathieson
c5a2423a7a
Fix another crashing problem.
...
A status PDU can contain multiple entries for the same SN (for different partial ranges). So make sure that we don't copy the same SN twice into our list of repeated NACKs (otherwise each instance in the tap struct will get added multiple times and we'll end up writing beyond the array bound).
svn path=/trunk/; revision=32133
2010-03-07 10:03:05 +00:00
Martin Mathieson
e10b2fb11e
Add hidden roots for each mode (i.e. rlc-lte.tm, rlc-lte.um, rlc-lte.am).
...
svn path=/trunk/; revision=32128
2010-03-06 19:35:40 +00:00
Martin Mathieson
5e8b6b21b2
Report accurate NACK count in stats (although not all values stored in array in tap).
...
svn path=/trunk/; revision=32117
2010-03-04 20:58:54 +00:00
Martin Mathieson
d5fb076397
Check that we haven't gone over MAX_NACKs!
...
svn path=/trunk/; revision=32115
2010-03-04 17:49:51 +00:00
Bill Meier
f041bb3e19
Fix a gcc -Wshadow warning.
...
svn path=/trunk/; revision=32093
2010-03-03 15:47:28 +00:00
Martin Mathieson
c40143abbc
Fix re-NACk detection by updating channel *after* have compared with tap_info!
...
svn path=/trunk/; revision=32091
2010-03-03 15:34:44 +00:00
Martin Mathieson
bec769f815
Add 'repeated-NACK' analysis.
...
This is a common symptom of serious problems.
svn path=/trunk/; revision=32085
2010-03-02 18:40:34 +00:00
Martin Mathieson
15e32b3c73
Re-order file, and give some types/vars more specific names.
...
svn path=/trunk/; revision=32075
2010-03-01 23:56:35 +00:00
Martin Mathieson
862dd48d35
Improve RLC AM sequence analysis by taking MAC retx into account.
...
svn path=/trunk/; revision=32071
2010-03-01 22:52:34 +00:00
Martin Mathieson
58edf76433
Fix test for AM Rx window, and add a seqnum.analysis.ok field.
...
svn path=/trunk/; revision=32051
2010-02-28 20:43:04 +00:00
Martin Mathieson
9a1100ce5a
Add 'missing SDUs' to tap info / RLC stats window.
...
Also includes typo fixes from Pascal Quantin.
svn path=/trunk/; revision=32049
2010-02-28 18:42:41 +00:00
Martin Mathieson
76d5a1eb75
Add some AM sequence analysis.
...
svn path=/trunk/; revision=32044
2010-02-28 02:18:35 +00:00
Martin Mathieson
8126a8ab32
Add a preference that allows the LTE RLC dissector to accept RLC PDUs truncated after the header rather than report missing data.
...
svn path=/trunk/; revision=31750
2010-02-01 11:00:08 +00:00
Stig Bjørlykke
fa8d45f2a3
From Didier Gautheron via bug 4420:
...
Call p_add_proto_data only once.
svn path=/trunk/; revision=31664
2010-01-25 18:24:14 +00:00
Stig Bjørlykke
c198fc6546
From Didier Gautheron via bug 4419:
...
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized
data with 0.
svn path=/trunk/; revision=31654
2010-01-25 11:47:39 +00:00
Bill Meier
1a4283ccf8
Fixes for gcc -Wshadow warnings; Fix indentation and do other minor cleanup in a few cases.
...
svn path=/trunk/; revision=31617
2010-01-22 13:56:19 +00:00
Martin Mathieson
417b1839f1
Add initial version of LTE RLC stats dialog.
...
svn path=/trunk/; revision=31588
2010-01-20 12:37:26 +00:00
Martin Mathieson
26c0a94dea
Don't crash by calling null RRC dissector because TM appeared on 'impossible' channel type.
...
svn path=/trunk/; revision=31468
2010-01-08 16:07:14 +00:00
Martin Mathieson
bd55fda74c
From Pascal Quantin: some typo fixes
...
svn path=/trunk/; revision=31455
2010-01-06 17:07:37 +00:00
Martin Mathieson
7897e78d02
Added casts wanted by win64 compiler.
...
svn path=/trunk/; revision=31440
2010-01-04 15:24:33 +00:00
Martin Mathieson
b8596e6ad6
Start to supply data for an RLC tap.
...
svn path=/trunk/; revision=31439
2010-01-04 14:07:24 +00:00
Martin Mathieson
68546e930e
From Pascal Quantin. Add support a UDP framing format for LTE RLC.
...
svn path=/trunk/; revision=31185
2009-12-07 10:23:35 +00:00
Martin Mathieson
0015dc63be
Show whether NACK is full or partial in expert info.
...
svn path=/trunk/; revision=31170
2009-12-04 11:22:33 +00:00
Martin Mathieson
33d4186696
Set extent of AM header root properly when there are extensions.
...
Give more descriptive expert text when we there is no data for non-extension segment.
svn path=/trunk/; revision=31079
2009-11-25 23:17:23 +00:00
Martin Mathieson
51e240596d
Dissect SRB2 as PDCP signalling too.
...
svn path=/trunk/; revision=31021
2009-11-19 18:23:53 +00:00
Martin Mathieson
fa8e0f479f
Trivial: comment update
...
svn path=/trunk/; revision=31004
2009-11-18 13:47:38 +00:00
Martin Mathieson
7af44b2991
Resuse struct for PDCP info when redissecting.
...
svn path=/trunk/; revision=30992
2009-11-17 17:30:40 +00:00
Martin Mathieson
a6bc911e49
Show data-less PDUs are Error rather than warning.
...
Only call PDCP for complete signalling PDUs.
svn path=/trunk/; revision=30976
2009-11-16 18:18:07 +00:00
Martin Mathieson
1a46552674
Allow LTE RRC dissector to call PDCP/RRC dissectors as appropriate for signalling PDUs.
...
svn path=/trunk/; revision=30971
2009-11-16 15:35:56 +00:00
Martin Mathieson
da15f9f5ff
Show how many NACKs appeared in status message root.
...
svn path=/trunk/; revision=30806
2009-11-03 16:39:01 +00:00
Martin Mathieson
c120fa9b8f
Sequence number should be displayed in DEC, not HEX!
...
svn path=/trunk/; revision=30769
2009-10-30 15:56:43 +00:00
Martin Mathieson
f36f5897ee
Tidy up info column output showing partial NACK.
...
svn path=/trunk/; revision=30760
2009-10-29 19:06:10 +00:00
Martin Mathieson
8c9d77f0cd
Add more summary to top-level item.
...
svn path=/trunk/; revision=29931
2009-09-15 17:49:58 +00:00
Martin Mathieson
d69ac7dc4a
Add more useful summary info to RLC root. Useful mostly for when called from MAC.
...
svn path=/trunk/; revision=29862
2009-09-11 15:16:53 +00:00
Martin Mathieson
e09d89e145
Add the option to call RLC dissector for LCID 1&2.
...
These should be srb1 & srb2 (AM).
svn path=/trunk/; revision=29852
2009-09-10 22:53:57 +00:00
Martin Mathieson
fef272347b
Show number of predefined bytes in info column.
...
svn path=/trunk/; revision=29290
2009-08-04 10:41:08 +00:00
Martin Mathieson
29d6ae0ed5
Remove calls to check_col().
...
svn path=/trunk/; revision=29079
2009-07-13 11:23:40 +00:00
Martin Mathieson
fd6bcf67a7
Add expert item to warn of AM data PDUs that don't have any data.
...
svn path=/trunk/; revision=28995
2009-07-07 17:07:24 +00:00
Stig Bjørlykke
b228488bc0
From Kovarththanan Rajaratnam via bug 3548:
...
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero
svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Martin Mathieson
ec48fc388f
Trivial prettifications
...
svn path=/trunk/; revision=28765
2009-06-17 09:43:56 +00:00
Martin Mathieson
55a1075bea
Show data-segment info in info column.
...
svn path=/trunk/; revision=28733
2009-06-15 09:46:13 +00:00
Martin Mathieson
db0bd672a6
Set length of proto item for status pdu.
...
svn path=/trunk/; revision=28702
2009-06-11 13:58:08 +00:00
Martin Mathieson
f56c2e8156
Check for leftover bytes following Status PDU.
...
svn path=/trunk/; revision=28650
2009-06-07 13:35:17 +00:00