osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
31590 commits 23 branches 0 tags 1.3 GiB
Commit graph

56 commits

Author SHA1 Message Date
Bill Meier
10ffd14b8f Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces) 
svn path=/trunk/; revision=32735
 2010-05-10 15:54:57 +00:00
Anders Broman
447faa6082 From Mike Morrin: 
Dissection of BSSMAP IEs: Old BSS to New BSS Info and New BSS to Old BSS Info
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4712

svn path=/trunk/; revision=32606
 2010-04-29 20:45:53 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h> 
svn path=/trunk/; revision=32367
 2010-04-03 21:55:23 +00:00
Gerald Combs
b3a1cd8859 Temporary (?) fix for bug 4623. 
svn path=/trunk/; revision=32327
 2010-03-30 21:12:52 +00:00
Bill Meier
de4c6ff515 Fix a number of gcc _Wshadow warnings 
svn path=/trunk/; revision=31557
 2010-01-18 21:49:47 +00:00
Gerasimos Dimitriadis
809477b66e Fix for Bug 4197: 
Neighbour Cell Description 2 decode error

svn path=/trunk/; revision=31177
 2009-12-04 20:27:16 +00:00
Gerasimos Dimitriadis
c840cdd5a0 Remove the address operator from value_string arrays fed to VALS() 
svn path=/trunk/; revision=30995
 2009-11-17 18:35:27 +00:00
Gerasimos Dimitriadis
79cf9b5f45 Erroneously ommitted from the patch of Bug 4219: 
bit_offset used instead of curr_bit_offset


svn path=/trunk/; revision=30974
 2009-11-16 16:20:49 +00:00
Gerasimos Dimitriadis
9b36fc784e From yy: 
About GSM system information type 2quater
Modified to use newly defined tvb_get_bits() in tvbuff.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4219


svn path=/trunk/; revision=30962
 2009-11-14 20:13:43 +00:00
Jaap Keuter
75f1e13c12 Cleanup header fields. 
svn path=/trunk/; revision=30394
 2009-10-07 23:08:22 +00:00
Bill Meier
6c545e0d79 Save some memory: Don't statically allocate ett[] arrays used "dynamically". 
svn path=/trunk/; revision=29929
 2009-09-15 17:37:54 +00:00
Anders Broman
d41058065f From Mike Morrin: 
The GSM L3 part of the BSSMAP CipherModeComplete message is not being decoded.
Sligtly modified.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3983

svn path=/trunk/; revision=29776
 2009-09-07 17:17:07 +00:00
Anders Broman
e99983ab3a From Vincent Helfre: 
Dissect_ccch does not dissect sys info content.
Me: Remove check_col.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3901

svn path=/trunk/; revision=29693
 2009-09-04 11:06:52 +00:00
Anders Broman
4e87c254f0 From Mike Morrin: 
Minor errors in gsm rr dissectors
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3889

Modified accoring to comments from Pascal Quantin(I hope I got it right).

svn path=/trunk/; revision=29549
 2009-08-25 17:22:32 +00:00
Anders Broman
7945bf1bc9 From Harald Welte : 
Connect RRLP to GSM A DTAP application info message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3919

From me try to fix missuse of pinfo.

svn path=/trunk/; revision=29482
 2009-08-20 07:26:16 +00:00
Anders Broman
87da96be52 From Jan Lübbe: 
packet-gsm_a_rr.c: flip gsm_a_rr_mv_vals, 0 means vaild.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3915

svn path=/trunk/; revision=29472
 2009-08-19 09:32:56 +00:00
Kovarththanan Rajaratnam
97fda7386c Make sure that we find the "data" dissector during handoff else we might crash if the received payload was less than 2 bytes. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3893

svn path=/trunk/; revision=29403
 2009-08-13 12:17:20 +00:00
Jaap Keuter
7267ec9782 Complete the fix in r29389. 
svn path=/trunk/; revision=29390
 2009-08-11 23:52:04 +00:00
Gerald Combs
4bfcd5993a Instead of calling DISSECTOR_ASSERT_NOT_REACHED, just say the subchannel 
is unknown. Fixes bug 3864.

svn path=/trunk/; revision=29389
 2009-08-11 23:44:22 +00:00
Bill Meier
3c1bc8f251 Fix some individual cases of 'if (unsigned) < 0' 
svn path=/trunk/; revision=29320
 2009-08-06 23:51:45 +00:00
Bill Meier
21d8e2d3e1 Prevent possible (benign ?) array references with an array index of -1. 
svn path=/trunk/; revision=29312
 2009-08-06 18:44:38 +00:00
Bill Meier
eba5297683 Remove inadvertantly committed comments re issue yet to be fixed ... 
svn path=/trunk/; revision=29311
 2009-08-06 16:13:31 +00:00
Bill Meier
7f7161f819 Register ett[] subtree array only once. 
svn path=/trunk/; revision=29309
 2009-08-06 16:06:11 +00:00
Jaap Keuter
c9e3f66d14 Optimize empty strings to NULL pointers. 
svn path=/trunk/; revision=29298
 2009-08-04 21:05:38 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548: 
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
 2009-06-18 21:30:42 +00:00
Bill Meier
ab291b9c00 FT_BOOLEAN fields with bitmask: Display is 'parent bitfield width' not BASE... 
Also: Change FT_BOOLEAN with no bitmask from BASE_DEC to BASE_NONE.

svn path=/trunk/; revision=28312
 2009-05-08 19:42:58 +00:00
Bill Meier
0274ef3673 Use NULL instead of repeated identical text if hf[] blurbs; 
Use #if 0 ... #endif instead of /* ... */ to comment out code;
Reformat some long lines;
Use consistent indentation.


svn path=/trunk/; revision=28301
 2009-05-08 15:03:11 +00:00
Bill Meier
3c11319ea4 Adjust some indentation 
svn path=/trunk/; revision=27323
 2009-01-28 21:22:30 +00:00
Anders Broman
b631b88d61 Implement TLV-E and LV-E type IE dissection (2 byte length value). 
svn path=/trunk/; revision=27100
 2008-12-23 20:49:15 +00:00
Bill Meier
c544c20956 Fix various typos and spelling errors (mostly in text strings) 
svn path=/trunk/; revision=27050
 2008-12-18 19:08:49 +00:00
Bill Meier
a8f30cbca1 Fix some typos and spelling (mostly in text strings) 
svn path=/trunk/; revision=27037
 2008-12-17 17:23:37 +00:00
Anders Broman
05fa33881c From Pascal Quantin: 
Improve 3GPP 44.018 RR dissection.

svn path=/trunk/; revision=26779
 2008-11-15 11:36:49 +00:00
Anders Broman
d943c93a0b From Pascal Quantin: 
Proper Fix for "'subtree' may be used uninitialized in this function" error (SVN revision 26730)

svn path=/trunk/; revision=26745
 2008-11-10 20:21:04 +00:00
Anders Broman
3d7baf2c9f Try to pacify the buildbot. 
svn path=/trunk/; revision=26732
 2008-11-07 18:13:10 +00:00
Anders Broman
04f9b031ef From Pascal Quantin: 
Add 3GPP 44.018 RR Short Protocol Discriminator dissection.

svn path=/trunk/; revision=26730
 2008-11-07 17:37:22 +00:00
Guy Harris
c7d0c67e3d Mark the reduced frame number field as generated. 
svn path=/trunk/; revision=26690
 2008-11-04 20:20:33 +00:00
Anders Broman
07dadee5dd From Pascal Quantin: 
The attached patch adds the following enhancements:
- remove duplicated code for Reduced Frame Number computation, and solve
guint64 issue in the same time (see bug 3028 for details)
- BA Range IE decoding
- BA List Pref IE decoding
- UTRAN Frequency List IE decoding
- Cell Selection Indicator after Release of all TCH and SDCCH IE decoding
- UTRAN Classmark Change message decoding (with a call to RRC dissector to
decode the INTER RAT HANDOVER INFO message)
- add Inter System To UTRAN Handover Command message decoding

As usual it compiles fine on Windows but I could not check on Linux.

svn path=/trunk/; revision=26688
 2008-11-04 20:03:19 +00:00
Guy Harris
fa67e2cf41 Show the "FN mod 62432" field; this is how you show a 64-bit integer. 
Clean up indentation.

svn path=/trunk/; revision=26684
 2008-11-03 21:44:22 +00:00
Anders Broman
c0dd6c4ca9 From Pascal Quantin: 
Various enhancements to 3GPP 44.018 Radio Resource dissection.

svn path=/trunk/; revision=26682
 2008-11-03 21:16:18 +00:00
Anders Broman
1cab8c9743 From Pascal Quantin: 
please find attach the patch to fix the bug for the "'xdd_indic0' may be used uninitialized in this function" warning. Initializinf it to 0 will not be sufficient as it will fail to decode properly the TDD Cell Information Field. 
Builds on Windows hopfully woun't break the build bot.

svn path=/trunk/; revision=26668
 2008-11-01 21:48:02 +00:00
Jaap Keuter
e652ccc7ee Fix the broken build. 
svn path=/trunk/; revision=26666
 2008-11-01 10:17:29 +00:00
Anders Broman
ba21bba78e Add Measurement result IE dissection, fix channel list. 
svn path=/trunk/; revision=26665
 2008-11-01 09:23:31 +00:00
Stig Bjørlykke
bd08ae7ee6 Fix some "format not a string literal and no format arguments" warnings. 
svn path=/trunk/; revision=26647
 2008-10-31 15:11:57 +00:00
Anders Broman
34fdd680ef Fix: 
packet-gsm_bsslap.c:374: warning: unused parameter 'len'
packet-gsm_a_rr.c:3035: warning: 'xdd_indic0' may be used uninitialized in this function

svn path=/trunk/; revision=26630
 2008-10-30 20:09:14 +00:00
Anders Broman
e3d3b73a96 From Pascal Quantin: 
Add 3GPP 44.018 SI5bis, SI5ter, SI6 and SI13 decoding
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3014

svn path=/trunk/; revision=26623
 2008-10-30 19:30:08 +00:00
Anders Broman
222869d394 From Pascal Quantin: 
Buggy 3GPP 44.018 Cell Channel Description / Frequency List IEs decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3007

svn path=/trunk/; revision=26604
 2008-10-28 19:19:37 +00:00
Stig Bjørlykke
357e5e016e Fixed some true_false_string definitions. 
svn path=/trunk/; revision=26591
 2008-10-27 21:36:02 +00:00
Anders Broman
497197b525 From Pascal Quantin: 
Add 3GPP 44.018 SI3 and SI4 Rest Octets decoding.

svn path=/trunk/; revision=26590
 2008-10-27 21:08:54 +00:00
Anders Broman
b32c91b5a0 Try to make the build bot hapy. 
svn path=/trunk/; revision=26562
 2008-10-26 21:45:37 +00:00
Anders Broman
f47b645008 From Pascal Quantin: 
Add 3GPP 44.018 SI1, SI2bis, SI2ter and SI2quater full decoding

svn path=/trunk/; revision=26559
 2008-10-26 19:46:46 +00:00