Commit Graph

36333 Commits

Author SHA1 Message Date
Guy Harris 6eec1f97bb Regularize style a bit in help messages.
Clean up capitalization.

Fix a comment.

svn path=/trunk/; revision=38130
2011-07-20 05:49:24 +00:00
Chris Maynard 0506627c30 Apply some endian heuristics when dissecting ICMP originate, receive and transmit timestamps. Fixes bug 6114.
Ref: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6114

svn path=/trunk/; revision=38129
2011-07-20 00:22:31 +00:00
Guy Harris c34b796445 Add a DREP_LITTLE_ENDIAN for the DCE RPC endianness bit in the data
representation.  Use it rather than a raw 0x10.

Add a DREP_ENC_INTEGER() macro that takes a pointer to the data
representation and returns either ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN;
use it for the encoding argument to proto_tree_add_item(), rather than
just the AND of drep[0] and DREP_LITTLE_ENDIAN, as it's not a boolean
any more, and for string values we'll be supporting character encodings
as well and thus won't be able to trust that the 0x10 bit will mean
"little endian".

Use ENC_NA for some other encoding values, i.e. for FT_BYTES and the
like.

Fix a couple of places in the DCOM dissector where we were passing the
byte-order bit rather than the field value to
proto_tree_add_uint_format().

Clean up white space.

svn path=/trunk/; revision=38128
2011-07-19 23:02:02 +00:00
Gerald Combs 3991a62d31 The GTK+ documentation says we can pass NULL to gtk_table_get_size(). Do
that instead of using a dummy variable.

svn path=/trunk/; revision=38127
2011-07-19 22:38:28 +00:00
Stig Bjørlykke 4e20e37aa6 Use ENC_NA for FT_PROTOCOL.
svn path=/trunk/; revision=38125
2011-07-19 19:37:58 +00:00
Stig Bjørlykke cea89ebc80 Use ENC_NA for hf_fragments (FT_NONE).
svn path=/trunk/; revision=38124
2011-07-19 19:37:45 +00:00
Jörg Mayer eedc9b880a Reenable the commented out code. I was able to reproducably break
the compilation but after a complete removal of the build directory
and a rebuild the problem is gone.

svn path=/trunk/; revision=38123
2011-07-19 19:36:26 +00:00
Stig Bjørlykke ba2aae0f8e Use ENC_NA as encoding for FT_PROTOCOL, FT_NONE and FT_BYTES.
svn path=/trunk/; revision=38122
2011-07-19 18:48:31 +00:00
Gerald Combs 1f497af628 Instead of overloading WIRESHARK_LIBS / wireshark_LIBS in Makefile.nmake
use WIRESHARK_LIB_DIR for the location of our external libraries.

svn path=/trunk/; revision=38119
2011-07-19 18:22:46 +00:00
Jörg Mayer fd42af2127 There are some undefined symbols in the code: comment out
the problematic code parts.

svn path=/trunk/; revision=38118
2011-07-19 18:00:08 +00:00
Jörg Mayer 21adeb2cfc Back out parts of 38112, as pointed out by Stig Bj\370rlykke:
The changes in profile_dlg.c, uat_gui.c and new_packet_list.c does not
work.  The tooltip is not displayed, and it's not possible to get the
context menu from a column header in the packet list.
...
I guess gtk_tree_view_column_get_widget() does not return
column->button, which is the widget we use.


svn path=/trunk/; revision=38117
2011-07-19 17:40:23 +00:00
Jörg Mayer 40cc0b57a1 Martin Mathieson: gtk_table_get_size() was only introduced in gtk 2.22
svn path=/trunk/; revision=38116
2011-07-19 17:29:27 +00:00
Martin Mathieson 049643cf28 From Pradip Biswas, bug 6127 - Added Decode for RRC BCCH (BCH and DL_SCH) messages on RLC-over-UDP.
Add separate codes/cases for BCH-over-BCH and BCH-over-DLSCH.

svn path=/trunk/; revision=38115
2011-07-19 16:41:56 +00:00
Gerald Combs e7fce8ccb8 Pull WIRESHARK_LIBS from the system environment if it's available.
svn path=/trunk/; revision=38114
2011-07-19 16:26:42 +00:00
Jörg Mayer 1bf94efa12 Get rid of direct access to struct GtkToggleButton
svn path=/trunk/; revision=38113
2011-07-19 16:02:16 +00:00
Jörg Mayer 6d20f48e88 Fix access to the following stuctures:
GtkCheckMenuItem
GtkTable
GtkTreeViewColumn

svn path=/trunk/; revision=38112
2011-07-19 15:13:36 +00:00
Jörg Mayer 9166443e3c Get rid of all GtkAdjustment element accesses. Fix a bug
introduced when fixing this stuff for rtp_player.c

svn path=/trunk/; revision=38111
2011-07-19 14:33:50 +00:00
Chris Maynard 7bc1f25843 Based on the information provided by Steve Karg via -dev, change all occurrences of ENC_LITTLE_ENDIAN to ENC_BIG_ENDIAN.
Ref: http://www.wireshark.org/lists/wireshark-dev/201107/msg00305.html


svn path=/trunk/; revision=38110
2011-07-19 13:19:49 +00:00
Michael Tüxen 358fcedaba Get the interfaces list from the Capture / Interfaces list in sync
when using the capture / start menu item.

Obtained from Irene Ruengeler.

svn path=/trunk/; revision=38109
2011-07-19 12:42:18 +00:00
Jörg Mayer 4a06b078b6 Fix some errors when compiling with -DGSEAL_ENABLE.
svn path=/trunk/; revision=38108
2011-07-19 11:02:26 +00:00
Stig Bjørlykke f282154ab0 Use correct encoding for proto_tree_add_item().
svn path=/trunk/; revision=38107
2011-07-19 10:51:12 +00:00
Guy Harris 93abdd9804 Use ENC_LITTLE_ENDIAN rather than TRUE in proto_tree_add_item() calls.
(Yes, that means that all but one call uses ENC_LITTLE_ENDIAN, and one
uses ENC_BIG_ENDIAN.  I guess that's how the protocol works....)

svn path=/trunk/; revision=38106
2011-07-19 03:20:02 +00:00
Chris Maynard b968cc5c0b From Michael Mann via bug 5769: In fDevice_Instance(), add field in proper
big-endian byte order.

Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5769

svn path=/trunk/; revision=38105
2011-07-19 02:47:12 +00:00
Guy Harris 2e2dc7179f Work around an annoying problem caused by the collision of GNU gettext's
configure script's attempts to deal with AIX 4 and Lion and/or Xcode 4's
dealings with Fortify.

svn path=/trunk/; revision=38104
2011-07-19 02:29:31 +00:00
Chris Maynard 4a5c24b6fc At the request of Tony Trinh on -dev, set(CMAKE_VERBOSE_MAKEFILE OFF)
Ref: http://www.wireshark.org/lists/wireshark-dev/201107/msg00156.html

svn path=/trunk/; revision=38103
2011-07-19 01:46:16 +00:00
Jörg Mayer 7ba73972cd Add instructions how to use the database offline (taken from
an explanation by Chris Maynard)

svn path=/trunk/; revision=38098
2011-07-18 20:49:35 +00:00
Jörg Mayer 7fc2e9b2b5 Add a comment how to actually use the protocol help.
svn path=/trunk/; revision=38097
2011-07-18 20:44:01 +00:00
Bill Meier 3f7e7672c9 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=38095
2011-07-18 19:11:32 +00:00
Jörg Mayer 7e6b1202c9 Update status file to current state and statistics
svn path=/trunk/; revision=38093
2011-07-18 18:24:22 +00:00
Jörg Mayer f60fdf3dcc Fix some trivial cases of gdk-deprecated warnings. The remaining
ones have to be fixed by someone who understands the code.

svn path=/trunk/; revision=38092
2011-07-18 18:16:36 +00:00
Michael Tüxen f2cbf9239d Ignore interfaces without a name.
svn path=/trunk/; revision=38091
2011-07-18 17:44:26 +00:00
Michael Tüxen da0355b1fa Make a check a bit more pedantic.
svn path=/trunk/; revision=38090
2011-07-18 17:15:45 +00:00
Michael Tüxen a180787959 Make sure that the Capture/Start menue item will always use the
same interfaces as selected in the Main Welcome Window.

svn path=/trunk/; revision=38087
2011-07-18 16:20:19 +00:00
Bill Meier 6bdcd858e9 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=38086
2011-07-18 15:54:25 +00:00
Bill Meier 5db6069274 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=38085
2011-07-18 15:52:16 +00:00
Michael Tüxen e4b18600fb Get --enable-ui-manager working.
svn path=/trunk/; revision=38084
2011-07-18 13:36:11 +00:00
Jörg Mayer fae6f11845 Small comment update: GtkItemFactory has been deprecated as of gtk 2.4
(aka close to forever).

svn path=/trunk/; revision=38083
2011-07-18 13:19:34 +00:00
Bill Meier e6f1541bf1 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=38082
2011-07-18 12:50:26 +00:00
Jörg Mayer 9a7fcb7ec7 Add option --enable-uimanager to mimic cmake -DUI_MANAGER=ON
svn path=/trunk/; revision=38081
2011-07-18 12:49:16 +00:00
Jörg Mayer 6dace04493 Add instructions how to work with "git svn" instead of "svn"
svn path=/trunk/; revision=38080
2011-07-18 12:44:19 +00:00
Jörg Mayer 277a56089c Update STATUS.gtk3
Make linking with stubbed out proto_help functions really work.
Add a comment to proto_help that its functionality will be lost
  once we make the ui-manager code default unless someone cares
  enough to fix it.
Enable -DGTK_DISABLE_DEPRECATED iff building with ui-manager.

svn path=/trunk/; revision=38079
2011-07-18 12:40:40 +00:00
Jörg Mayer 6d7b0cf5f1 Prevent error about undefined function while linking.
svn path=/trunk/; revision=38078
2011-07-18 12:18:00 +00:00
Martin Mathieson b1eb5b9a1a For UL retx, show links forward to next Tx as well as backwards to previous.
svn path=/trunk/; revision=38077
2011-07-18 11:57:38 +00:00
Martin Mathieson 3f3fde986f Add a generated field for the number of NACKs in an AM status PDU.
svn path=/trunk/; revision=38076
2011-07-18 10:40:57 +00:00
Guy Harris b1d83d8d8b We don't have an "--enable-osxapp" configure option; update a comment.
svn path=/trunk/; revision=38075
2011-07-17 23:47:10 +00:00
Guy Harris 2730ef6563 Get rid of the .pkg and .dmg with "make clean".
svn path=/trunk/; revision=38074
2011-07-17 20:40:13 +00:00
Guy Harris 0b967aa242 Handle versions of GTK+ where gdk-pixbuf is a separate library.
svn path=/trunk/; revision=38072
2011-07-17 20:23:07 +00:00
Stig Bjørlykke 73df12fdcc Cleanup and indent in Makefile.
svn path=/trunk/; revision=38071
2011-07-17 17:56:57 +00:00
Stig Bjørlykke 23142d46bc Check for a valid wspy_dissectors disectory to avoid a warning if missing.
svn path=/trunk/; revision=38070
2011-07-17 17:56:42 +00:00
Gerald Combs 155ac876de [Automatic manuf, services and enterprise-numbers update for 2011-07-17]
svn path=/trunk/; revision=38067
2011-07-17 14:03:36 +00:00