Commit Graph

33075 Commits

Author SHA1 Message Date
Stig Bjørlykke 6ead8f1ae5 Support multiple header fields with the same abbreviation in custom columns.
We have some different fields using the same abbreviation (e.g "eth.dst"
used in both eth and tte), and this patch will fetch values from all fields.
When using occurrences the entries listed first is from the field registered
last when starting Wireshark, and not ordered from the occurrence in the
packet, but I don't see how we can easily fix this.

svn path=/trunk/; revision=34513
2010-10-14 13:11:03 +00:00
Guy Harris 9ccf7e431e Make variables used only in file_dlg_win32.c static.
svn path=/trunk/; revision=34512
2010-10-14 09:01:12 +00:00
Guy Harris 55bc235b90 Make routines unused outside file_dlg_win32.c static.
svn path=/trunk/; revision=34511
2010-10-14 08:59:35 +00:00
Anders Broman ddc1c197a4 Fix AVP:s
svn path=/trunk/; revision=34508
2010-10-14 07:55:42 +00:00
Bill Meier ce887cb60d Fix crash for 'tshark -G values' when printing "extended value string" value.
Fixes bug #5296 [ https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5296 ]

svn path=/trunk/; revision=34507
2010-10-14 04:53:07 +00:00
Jeff Morriss ebc190645f From Fulko Hew via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4615 :
The attached patch adds the missing decoded fields
by moving the proto_tree_add_item() call so that it
is no longer within an error handler and will be
called under normal circumstances (as well as error conditions.


From me: Apply the change to the ASN.1 source.  Also some white space
indentation cleanup.

svn path=/trunk/; revision=34505
2010-10-14 01:44:27 +00:00
Jeff Morriss aa749665c5 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5295 :
Hi a patch to enchance the PPTP Dissector
It is a rework of PPTP dissector 
- Replace proto_tree_add_text by proto_tree_add_item 
- Replace not standard table and function by standard value_string
- ....

The code is checked and fuzzed (more 200 pass) ! with personnal PPTP Sample and
PPTP Sample from pcapr.net

svn path=/trunk/; revision=34504
2010-10-14 01:10:51 +00:00
Gerald Combs fc260f7967 From Johannes Berg via bug 4421:
radiotap: re-indent

The current file has very strange mix of various
indentation sometimes using spaces and sometimes
using tabs which is rather hard to keep intact,
so reindent it completely.

svn path=/trunk/; revision=34503
2010-10-13 21:30:27 +00:00
Anders Broman 01a9d015d5 From Jörg Mayer:
(UIManger) Fix compilation warnings.

svn path=/trunk/; revision=34502
2010-10-13 19:04:14 +00:00
Bill Meier 05168e614f Access several large value-string arrays via extended value-string functions.
svn path=/trunk/; revision=34501
2010-10-13 18:51:23 +00:00
Bill Meier 5ed532268f Use extended value string functions to access dce_error_vals (which has 4397 entries)
svn path=/trunk/; revision=34500
2010-10-13 17:56:05 +00:00
Bill Meier 45da078b7d Use val_to_str_ext_const for refs to the extended value strings;
Extern the extended value strings struct (not the value_string arrays themselves) so
 any external use of these arrays is via the extended value string functions.

svn path=/trunk/; revision=34499
2010-10-13 16:47:13 +00:00
Anders Broman d1de327057 (GTKUImanger)
- Open file from the welocme screen.

svn path=/trunk/; revision=34498
2010-10-13 15:52:10 +00:00
Anders Broman 19e1998c2c (GTKUImanger)
- Make use of the new WIRESHARK_FILE_STOCK icon.
- Make clearing of recent files work.
- Make the recent file list in the Welcome menu work again.

svn path=/trunk/; revision=34497
2010-10-13 11:22:23 +00:00
Anders Broman 5bfb661d23 Add a wireshark file stock icon.
svn path=/trunk/; revision=34496
2010-10-13 11:15:11 +00:00
Anders Broman fde95120d2 Try to get the build going again.
svn path=/trunk/; revision=34495
2010-10-13 04:29:07 +00:00
Anders Broman ebb3a7f694 (GUIManager) Base code to get recent files to work with GUIManager.
Based on code from http://people.gnome.org/~ebassi/recent-uimanager-inline.c by Emmanuele Bassi.

svn path=/trunk/; revision=34493
2010-10-12 21:33:08 +00:00
Bill Meier 2e4f755e13 Define some vars & fcns as static;
Also: do some minor reformmating and cleanup of whitespace.

svn path=/trunk/; revision=34492
2010-10-12 19:26:07 +00:00
Guy Harris f2f1023487 Fix comments (not all platforms on which we run support dlopen(), but
GLib handles that with g_module_open() as a platform-independent "load a
module at run time" wrapper).

svn path=/trunk/; revision=34491
2010-10-12 18:25:42 +00:00
Bill Meier 2b0f6a63f1 Define some fcns & vars as static;
Rename g_capture_in_progress to gbl_capture_in_progress (capture_if_dlg.c)
Do some whitespace cleanup.

svn path=/trunk/; revision=34490
2010-10-12 17:39:44 +00:00
Bill Meier 2d3abb5cec Minor cleanup of the global name space:
- Define some vars as static;
- Rename some externs to be less generic;
Also: cleanup some whitespace.

svn path=/trunk/; revision=34489
2010-10-12 16:42:02 +00:00
Bill Meier c004d57361 Minor cleanup of the global namespace:
- Define some fcns and vars as static;
- Use less generic names for certain externs;
Also: Remove some usused #defines & cleanup some whitespace


svn path=/trunk/; revision=34488
2010-10-12 16:05:19 +00:00
Bill Meier c78221d4ce Rename g_resolv_flags --> gbl_resolv_flags; Also: cleanup some whitespace & indentation.
svn path=/trunk/; revision=34487
2010-10-12 13:15:08 +00:00
Anders Broman 6e31c8c406 It's no longer neccesarry to set the E_DFILTER_TE_KEY on the popup_menu objects.
svn path=/trunk/; revision=34486
2010-10-12 07:41:18 +00:00
Guy Harris 3c27b97c26 Get rid of C++-style comments; use #if 0/#endif to remove code.
svn path=/trunk/; revision=34485
2010-10-12 01:27:58 +00:00
Jeff Morriss 0267a5293d Fix an error in a comment I added last week.
svn path=/trunk/; revision=34480
2010-10-11 20:16:35 +00:00
Anders Broman 24d4eda023 menus.c: In function 'add_menu_recent_capture_file_absolute':
menus.c:4583: warning: unused variable 'recent_files_list'

svn path=/trunk/; revision=34479
2010-10-11 20:05:49 +00:00
Anders Broman eb007bae23 Get filter_te from top_level rather then from the widget.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5288

svn path=/trunk/; revision=34478
2010-10-11 19:29:52 +00:00
Bill Meier e7568712ef Define some fcns & vars as static;
Minor whitespace and comments cleanup.

svn path=/trunk/; revision=34477
2010-10-11 19:00:55 +00:00
Gerald Combs b2a92a4c35 Use the latest User's Guide.
svn path=/trunk/; revision=34470
2010-10-11 16:01:48 +00:00
Stig Bjørlykke 32da2562b8 We set sensitivity on the map button in ct_nb_map_switch_page_cb().
svn path=/trunk/; revision=34469
2010-10-11 08:29:25 +00:00
Stig Bjørlykke ce8e4aa47c Don't add a border around the main window, this looks bad in the new
Ubuntu release.

svn path=/trunk/; revision=34468
2010-10-11 08:28:38 +00:00
Jeff Morriss 074e49fd41 hf variables can be copied/passed by value, not by reference.
svn path=/trunk/; revision=34467
2010-10-11 01:52:41 +00:00
Jeff Morriss 6deff94555 Add comments indicating that the DISSECTOR_ASSERT() routines should not be used to report malformed packets.
svn path=/trunk/; revision=34466
2010-10-11 01:28:22 +00:00
Bill Meier 0b9a803e45 #include <string.h> apparently req'd on OSX ...
svn path=/trunk/; revision=34465
2010-10-10 23:48:16 +00:00
Bill Meier 93b94a23ca Define some fcns & vars as static; Some #includes not req'd; packet-mikey.h not req'd.
svn path=/trunk/; revision=34464
2010-10-10 23:28:40 +00:00
Bill Meier 09d718f723 Rename vals_status & vals_pdu_type to wsp_vals_status & wsp_vals_pdu_type
svn path=/trunk/; revision=34463
2010-10-10 20:45:19 +00:00
Bill Meier 4ae8d25300 Minor code cleanup:
- define some vars & fcns as static;
- remove an unused var;
- use tfs_set_notset in tfs.c;
- slightly simplify reg_handoff.

svn path=/trunk/; revision=34462
2010-10-10 20:39:00 +00:00
Bill Meier 4d56c5b57b Define a variable as static; Minor code simplification.
svn path=/trunk/; revision=34461
2010-10-10 20:28:22 +00:00
Bill Meier 6486e8b781 Combine packet-opsi.h with packet-opsi.c (since not used elsewhere); Define some fcns as static.
svn path=/trunk/; revision=34460
2010-10-10 20:19:05 +00:00
Bill Meier acccf6a77c Define some fcns & vars as static...
svn path=/trunk/; revision=34459
2010-10-10 20:14:34 +00:00
Bill Meier 209109c2fd Define some fcns & vars as static ...
svn path=/trunk/; revision=34458
2010-10-10 20:07:06 +00:00
Bill Meier 219877f1d3 #include <epan/tfs.h> not req'd.
svn path=/trunk/; revision=34457
2010-10-10 20:03:39 +00:00
Guy Harris 708e2d905b Fix build.
svn path=/trunk/; revision=34456
2010-10-10 19:42:30 +00:00
Anders Broman 45371fce82 - Fix more callbacks.
When using the GUImanager the callback signature is (GtkAction *action , gpointer user_data) which causes problems when retreiveing
object data stored with the widget such as the filter box widget.

Work around that problem by doing
	filter_cm = g_object_get_data(G_OBJECT(top_level), E_DFILTER_CM_KEY);
	filter_te = gtk_bin_get_child(GTK_BIN(filter_cm));
in the follow_udp/tcp/ssl_stream.

svn path=/trunk/; revision=34455
2010-10-10 19:33:42 +00:00
Guy Harris f9371b0e0b It's now "change column", not just "rename column"; fix build.
Clean up indentation.

svn path=/trunk/; revision=34454
2010-10-10 19:05:04 +00:00
Anders Broman dc03d627d7 Fix up a number of callbacks.
Bug: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5288
requires abit of reworking of the callbacks or a different aproach to setting object data.

svn path=/trunk/; revision=34453
2010-10-10 18:10:33 +00:00
Gerald Combs 6a17a217d9 [Automatic manuf, services and enterprise-numbers update for 2010-10-10]
svn path=/trunk/; revision=34449
2010-10-10 15:42:36 +00:00
Gerald Combs cca5e071af [Automatic manuf, services and enterprise-numbers update for 2010-10-10]
svn path=/trunk/; revision=34448
2010-10-10 15:03:38 +00:00
Stig Bjørlykke 7bb2c88475 Fix menu entry.
svn path=/trunk/; revision=34447
2010-10-09 18:41:46 +00:00