Commit Graph

83 Commits

Author SHA1 Message Date
Bill Meier 1a4283ccf8 Fixes for gcc -Wshadow warnings; Fix indentation and do other minor cleanup in a few cases.
svn path=/trunk/; revision=31617
2010-01-22 13:56:19 +00:00
Anders Broman 440c3f9261 From Didier Gautheron:
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
Stig Bjørlykke d577ca0fa7 Guard #include <sys/types.h> with HAVE_SYS_TYPES_H.
svn path=/trunk/; revision=31053
2009-11-23 18:47:52 +00:00
Gerald Combs cf8126a808 Instead of initializing the Media Format name to NULL, set it to
"Unknown".  This keeps us from crashing on some platforms if we have an
unknown media format ID.

svn path=/trunk/; revision=31011
2009-11-19 01:50:44 +00:00
Anders Broman bc9a809b65 From Didier Gautheron:
ep memory can't be used for tvbs defined as data_source.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4054

svn path=/trunk/; revision=30376
2009-10-06 19:15:58 +00:00
Kovarththanan Rajaratnam 00810ff199 * Prefer col_append_str instead of col_append_fstr for constant strings
* Remove check_col guards

svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
Bill Meier 94f28dd8f9 (FWIW) One step towards including stdio.h & stdlib.h only when req'd.
svn path=/trunk/; revision=29568
2009-08-26 19:27:49 +00:00
Kovarththanan Rajaratnam 17c9803cac Sanitize epan includes
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Anders Broman 3a11073d6b Get info about media type(Video or not) a first step towards usage in rtp statistics.
svn path=/trunk/; revision=28415
2009-05-19 18:42:33 +00:00
Anders Broman c91a384702 Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28356
2009-05-13 19:46:11 +00:00
Bill Meier b45c3cb272 Change to prevent "off-the-end" array access if invalid payload-type/media-format;
Prevents crash as reported in bug 3373:
  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3373)

svn path=/trunk/; revision=27917
2009-03-31 21:47:58 +00:00
Bill Meier 808a4e2c3c Define certain fcns as static (if not used externally).
Also: whiule we're at it: 
 - fix hf[] blurbs as appropriate to use NULL;
 - fix some indentation

svn path=/trunk/; revision=27890
2009-03-29 22:16:26 +00:00
Anders Broman f77b5f8d77 Handle the case when FMTP parameters are "out-of-order".
-  - Use NULL instead of repeated text in blurb in hf[];

svn path=/trunk/; revision=27889
2009-03-29 21:59:28 +00:00
Anders Broman e0171e1a79 More size_t casts.
svn path=/trunk/; revision=27880
2009-03-29 13:47:15 +00:00
Anders Broman 8611ec5f5e More size_t casts.
svn path=/trunk/; revision=27879
2009-03-29 12:07:30 +00:00
Bill Meier 09d097e7a7 #include <conversation.h> not req'd ....
svn path=/trunk/; revision=27389
2009-02-06 20:33:53 +00:00
Anders Broman 821deda3ec Set item generated.
svn path=/trunk/; revision=27352
2009-02-02 18:26:26 +00:00
Anders Broman 2b607d7ce7 Dissect H263-1998/2000 Level
svn path=/trunk/; revision=27267
2009-01-19 20:35:52 +00:00
Anders Broman 360d9f94c7 Accept leading space, payload type name is case insensitive.
svn path=/trunk/; revision=26938
2008-12-08 21:31:37 +00:00
Anders Broman 93b9635a41 Dissect part ofconfiguration parameter in SDP for MP4V-ES.
svn path=/trunk/; revision=26754
2008-11-11 20:42:47 +00:00
Anders Broman 2b9d63a4b5 Move common code to base64.c
svn path=/trunk/; revision=25908
2008-08-03 14:27:22 +00:00
Anders Broman fec43e2350 Update mimetype_and_clock_map and ad samle rate to sdp.
svn path=/trunk/; revision=25860
2008-07-29 15:58:43 +00:00
Martin Mathieson 6492c8e5d0 Minor formatting improvements.
svn path=/trunk/; revision=25324
2008-05-20 09:22:06 +00:00
Martin Mathieson 693291377e Stop using deprecated functions identified by checkAPIs script.
svn path=/trunk/; revision=25258
2008-05-08 14:01:31 +00:00
Stephen Fisher 726a1caaf1 - Remove GLIB1 code
- Change ugly GLIB version checking statements to GLIB_CHECK_VERSION
- Remove ws_strsplit files because we no longer need to borrow GLIB2's
  g_strsplit code for the no longer supported GLIB1 builds


svn path=/trunk/; revision=24829
2008-04-07 05:22:54 +00:00
Stig Bjørlykke 28ae535b00 Removed even more "statement not reached" warnings.
svn path=/trunk/; revision=24286
2008-02-07 15:44:45 +00:00
Martin Mathieson b54b6b4af0 Fix preference text (SDP isn't only carried over SIP).
svn path=/trunk/; revision=23876
2007-12-15 18:26:21 +00:00
Anders Broman 4d01fd05cb tvbuff.c - fix abug if reading last byte in tvb
Further H.264 decoding in SDP

svn path=/trunk/; revision=23847
2007-12-12 21:50:14 +00:00
Anders Broman 92e1ee3721 Decode more of H264 info in SDP.
svn path=/trunk/; revision=23832
2007-12-10 21:25:32 +00:00
Jaap Keuter f4c89beb21 Remove superfluous buffer allocation.
svn path=/trunk/; revision=23742
2007-12-04 06:50:11 +00:00
Anders Broman 95d422156a Use common code for ASCII -> tvb.
svn path=/trunk/; revision=23741
2007-12-04 06:00:02 +00:00
Anders Broman b414c81f1f Fetch all fmtp parameters.
svn path=/trunk/; revision=23724
2007-12-03 22:40:04 +00:00
Ronnie Sahlberg 830da048fc mark two unused parameters as _U_
svn path=/trunk/; revision=23717
2007-12-03 21:52:57 +00:00
Anders Broman 20b383c1b1 Dissect RTP payload of H.264 and SDP profile-leve-id for H.264.
svn path=/trunk/; revision=23709
2007-12-03 20:14:42 +00:00
Tomas Kukosa 1a83466890 setup SRTP stream for RTP/SAVP media protocol
svn path=/trunk/; revision=23336
2007-11-02 07:41:56 +00:00
Ronnie Sahlberg befaad153b we dont have g_hash_table_new_full() on gtk1
use g_hash_table_new() on gtk1 and leak memory instead


this should actually a be using an se_tree instead of hashtables


svn path=/trunk/; revision=22789
2007-09-04 23:27:34 +00:00
Anders Broman 8f1d357618 From Stas Maximov:
RTP analysis' jitter values are thrown off by RTP events
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1076
a) Ephemeral string (packet duration) was inserted into long-term hash of
dynamic payloads
b) There was no clock_rate mapping for MIME type "telephone-event".

svn path=/trunk/; revision=22780
2007-09-04 05:22:43 +00:00
Jeff Morriss d47443ba38 Replace a couple more calls to tvb_get_string() with tvb_get_ephemeral_string(). 2 of the 3 replacements fix memory leaks.
svn path=/trunk/; revision=22542
2007-08-17 21:21:50 +00:00
Jeff Morriss 3dec62b85c - s/ntohs/g_ntohs
- s/ntohl/g_ntohl
- s/free/g_free
- Change some tvb_get_string()+g_free()'s into tvb_get_ephemeral_string()
- Change some tvb_fake_unicode()+g_free()'s into tvb_get_ephemeral_faked_unicode()
- Change some tvb_get_string() calls that were clearly memory leaks (like
  atoi(tvb_get_string(...))) into tvb_get_ephemeral_string()

svn path=/trunk/; revision=22515
2007-08-15 22:27:52 +00:00
Martin Mathieson 355d1e1321 Show malformed SDP line as an expert item
svn path=/trunk/; revision=22334
2007-07-17 13:09:44 +00:00
Anders Broman 1cf1f16391 Split out common asn1 stuff to asn1.h and include that where needed.
svn path=/trunk/; revision=21635
2007-05-01 22:05:11 +00:00
Anders Broman 8d756c3049 Add a reference.
svn path=/trunk/; revision=21377
2007-04-10 21:02:50 +00:00
Anders Broman fc16dece75 From Mikael Magnusson:
This patch adds support for key-mgmt session attributes in SDP (defined in RFC 4567). The patch also contains a Multimedia Internet KEYing (MIKEY is defined in RFC 3830) dissector plugin for "mikey" key-mgmt data.

svn path=/trunk/; revision=20977
2007-03-05 23:11:11 +00:00
Luis Ontanon aa654a1f8a Those two spaces before sdp were bctp (Q.1990), a protocol conveniently encoded to be two spaces in case of IPBCP (SDP+extras).
There's probably something similar in packet-isup.c

svn path=/trunk/; revision=20952
2007-03-01 00:24:57 +00:00
Luis Ontanon 215b7eecc5 have sdp ignoring useless caracters efore the first element (this is a hack to avoid the two spaces found before the v= in sdp messages embeded in h248/q1950)
svn path=/trunk/; revision=20913
2007-02-24 12:24:13 +00:00
Anders Broman 3c8dcc67bb Fix a cut and paste error.
svn path=/trunk/; revision=20043
2006-12-05 06:53:28 +00:00
Anders Broman 9226c9ef57 Add description of CT AS TIAS and H263-2000 profile.
svn path=/trunk/; revision=20035
2006-12-04 23:03:11 +00:00
Anders Broman e5188939c3 Dissect h324ext_h223lcparm.
svn path=/trunk/; revision=19786
2006-11-03 20:15:17 +00:00