Info column and protocol tree to indicate that.
If we find an invalid version number in the *second* switch statement,
don't bother spewing out a warning - that's a "cannot happen", so just
throw a dissector assertion.
svn path=/trunk/; revision=25621
and "deprecated" groups the default. Add an "abort" group for code that
shouldn't exit the program. Update the makefiles to call "checkAPIs.pl
-g abort" for dissectors. Remove a dependency on "cat" in checkAPIs.pl.
svn path=/trunk/; revision=25614
The syslog dissector could crash if the "packlog" MSU is truncated such that
the hex string ends in with a nibble.
From me: Check if that will happen and chop off the nibble before giving it to
convert_string_to_hex() so we'll dissect as much of the MSU as possible.
svn path=/trunk/; revision=25612
GTK+ since version 2.8, when its name was changed to the "GTK MS
Windows-Engine."
Simplify the Windows installer by removing the GTK-Wimp option (which
means the "Wireshark" item can be an entry instead of a group). Move
Rawshark to the "Tools" group.
(If anyone wants to disable the MS Windows Engine they can still do so
after installation by disabling or removing libwimp.dll.)
svn path=/trunk/; revision=25611
link-layer types static.
If the preference is set to "raw data" for any of those types, display
the raw data with an indication that the preference in question has been
set to "raw data", so people don't just wonder why ERF files aren't
working right any more. (See bug 2641; I had the same surprise when I
tried it on some ERF captures I have.)
Pull the dissect_erf_header() code into dissect_erf() - it's dissecting
the *payload*, not the *header*.
Fill in the Info column with the record type.
When using tvb_new_subset() to chop a header off of a tvbuff, just
specify lengths of -1, so we go all the way to the end.
Clean up the Infiniband dissector call.
svn path=/trunk/; revision=25608
"Wireshark" rather than "WireShark" nonwithstanding.
Say we run on NT 4.0 rather than "NT" - I don't know whether we run on
NT 3.x (and 2000/2003/XP are really NT 5.x and Vista/2008 are really NT
6.x - that's why Microsoft are talking about "Windows 7" as the next big
release).
In the capture-privileges paragraph, note that it's dumpcap that needs
to run as root, and suggest not only that Wireshark shouldn't be set-UID
root, but that it shouldn't even be run as root, and that the same
applies to TShark.
Update "How to Report a Bug" to reflect that we're telling people to
report bugs on Bugzilla, and that "wireshark -v"/"tshark -v" give almost
all the version information we want.
svn path=/trunk/; revision=25605
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not
ready to enable that warning by default yet.
Throw in some casts to handle GLib routines that take arbitrary
non-const pointers (they can later return the pointers, and some
callers might want to modify or free up those pointers in cases where
they're known to be writable or allocated).
Use ep_tvb_memdup() rather than a combination of ep_alloc() and
tvb_memcpy().
Clean up some indentation.
svn path=/trunk/; revision=25601
Make build_expert_data() take the size of "buffer" as an argument, and
use that when doing g_snprintf() into the buffer, to ensure we don't
overflow the buffer. Also, don't just assign to "buffer", as that
doesn't put anything *in* the buffer.
svn path=/trunk/; revision=25600
members to be const pointers when that's possible, and throw in some
casts when the GLib API fails to have properly consted arguments.
Use ep_strdup_printf() in some cases.
svn path=/trunk/; revision=25596
From Dustin Johnson: Add support for TurboCap.
- packet-ppi.c: Add aggregation and 802.3 extended information.
- capture-wpcap.c: Add support for pcap_list_datalinks and pcap_set_datalink.
Make pcap_list_datalinks and pcap_set_datalink mandatory on Windows.
svn path=/trunk/; revision=25593
Gerald Combs