Expand show version preference.
implementation of Steven's suggestion of a radio button (actually
dropdown) of the 4 possibilities.
I changed the default to have the version on both in
the welcome screen and on the window as that's how it was and people tend not to change the preferences I think.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6437
svn path=/trunk/; revision=44153
cairo do it. The clipping that was done worked properly for horizontal/verical
lines only, but would not for diagonal ones.
svn path=/trunk/; revision=44125
tcp_graph.c needlessly does this itself, but it only has to deal with horizonal
and vertical lines....
When have returned to original, unzoomed state, set zoom to be 'in' for
the middle mouse button, as thats all that makes sense.
svn path=/trunk/; revision=44124
isn't an SN=1023 for the channel.
Now I understand the time origin toggle - make it show the capture time
by default now.
svn path=/trunk/; revision=44099
- only setting the colour when it has changed
- only calling cairo_stroke() when we need to rather than after every
element
These improvements were previously made to rlc_lte_graph.c. I did look
at trying to extract what these 2 graph modules had in common, but gave up pretty quickly
when I saw how much they had diverged...
svn path=/trunk/; revision=44087
Valgrind log:
= 47,616 bytes in 1 blocks are possibly lost in loss record 41,578 of 41,608
= at 0x4C26ABB: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
= by 0xAA2BA53: gdk_pixbuf_new (in /usr/lib64/libgdk_pixbuf-2.0.so.0.2200.1)
= by 0x10379F2F: ??? (in /usr/lib64/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-xpm.so)
= by 0x1037A4FD: ??? (in /usr/lib64/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-xpm.so)
= by 0xAA3132E: gdk_pixbuf_new_from_xpm_data (in /usr/lib64/libgdk_pixbuf-2.0.so.0.2200.1)
= by 0x4589B5: xpm_to_widget (gui_utils.c:572)
= by 0x4E3FC4: about_wireshark (about_dlg.c:86)
svn path=/trunk/; revision=44066
long list of elements. Now the graph is like greased lightening!
I will look later to see if I can apply the same change to the TCP
graphs.
svn path=/trunk/; revision=44001
do the same type thing for the ui_desciptions.
eg put a "place holder" in the UI descriptions and
make a call from main_menubar.c i.e add_filter_menu()
and do the UI stuff there.
svn path=/trunk/; revision=43999
If column is based on frame data packet_list_get_widest_column_string()
was constructing his own frame_data with biggest *value* for given column
(which might be not the longest string) and later fill column for it.
Which generally should work (time precision is fixed),
but in r41185 to lot col_*() function was added check if fd->flags.has_ts is set.
packet_list_get_widest_column_string() was passing frame_data with flags.has_ts unset.
To make maintaince easier, instead of fixing the problem with flags.has_ts,
generate column buffer for each frame, and find the one which has longest string.
svn path=/trunk/; revision=43991
graph until know that we were able to choose a TCP session.
This could fail if e.g. a MAC LTE frame had > 1 bearers carrying TCP
segments.
svn path=/trunk/; revision=43977
user_data is NULL in the callbacks from the menu_bar, and when preparing filters we need to find the filter widget with g_object_get_data(G_OBJECT(data), E_DFILTER_TE_KEY).
The object is saved in the global variable popup_menu_object.
Use that in the filter callbacks from the menu bar.
- remove unused widget from a couple of callbacks.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7506
svn path=/trunk/; revision=43961
Put generated, with *proper* types version of marshaler (VOID:OBJECT,OBJECT) inside bytes_view.c
It was also only blocker of #undef GTK_DISABLE_DEPRECATED, so remove it.
XXX generated version of marshaler looks portable, but it'd be best to generate it using
glib-genmarshal during compilation.
svn path=/trunk/; revision=43947
this should fix crashes in the interface list handling when the
interface list contains pipes initliazed by scan_local_interfaces() or
add_pipe_cb()
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7511
svn path=/trunk/; revision=43922
gtk_combo_box_text_get_active_text() and gtk_combo_box_get_active_text() [from old-gtk-compat.h]
returns *newly allocated string (...) must be freed with g_free().*
svn path=/trunk/; revision=43918