osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
45,947 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

140 Commits

Author SHA1 Message Date
Pascal Quantin 595a893406 From Lukasz Wachowski via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8559 : 
Fix dissection of RAN-INFORMATION-APPLICATION-ERROR RIM PDU Indications

svn path=/trunk/; revision=48726
 2013-04-04 09:14:11 +00:00
Evan Huus 37600a157b Rename value string (and similar) functions to use a consistent pattern. This 
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).

Use a consistent coding style, and make proper use of the WS_DLL_* defines.

Group the functions appropriately in the header.

I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.

Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48634
 2013-03-29 00:26:23 +00:00
Pascal Quantin bda771b86b Do not initialize ett_tree and msg_fcn_p when match_strval_idx_ext does not find a match 
svn path=/trunk/; revision=48538
 2013-03-24 21:52:19 +00:00
Pascal Quantin 86eda54fe6 As suggested by Evan Huus, use extended value_strings 
svn path=/trunk/; revision=48407
 2013-03-18 22:21:53 +00:00
Pascal Quantin 94f330030d use enum values instead of hardcoded values 
(as suggested by Sylvain Munaut in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487)

svn path=/trunk/; revision=48397
 2013-03-18 20:26:47 +00:00
Anders Broman ef249623e6 [-Wmissing-prototypes] 
Use explicit casts.

svn path=/trunk/; revision=48313
 2013-03-15 06:26:47 +00:00
Martin Kaiser 47a8a496f1 fix 
packet-bssgp.c: In function 'de_bssgp_unconfim_send_state_var':
packet-bssgp.c:3318:13: error: variable 'state_var' set but not used [-Werror=unused-but-set-variable]


svn path=/trunk/; revision=48095
 2013-03-05 20:17:29 +00:00
Anders Broman f6ce72ee04 From Joseph Chai: 
Add aditional IE dissection.
From me patch cleanup and add set fence for multiple DTAP messages in one frame.

svn path=/trunk/; revision=48087
 2013-03-05 17:38:44 +00:00
Anders Broman a3ef2a7293 Fix bit_offset. 
svn path=/trunk/; revision=47637
 2013-02-11 17:39:52 +00:00
Pascal Quantin ae61fe0158 Try to fix dissection of GSM protocol family broken by r47209. 
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks.
(I hope I got everything right...)


svn path=/trunk/; revision=47218
 2013-01-22 23:25:44 +00:00
Bill Meier c230713b57 Fix several [-Wshadow] warnings; 
Also: Do some minor whitespace and formatting changes.
-This line, and those below, will be ignored--

M    dissectors/packet-bootp.c
M    dissectors/packet-bssgp.c
M    dissectors/packet-babel.c

svn path=/trunk/; revision=46191
 2012-11-25 23:16:30 +00:00
Martin Kaiser 6b3bfa5507 fix 
/home/wireshark/builders/trunk/ubuntu1204x64/build/epan/dissectors/packet-bssgp.c: In function de_bssgp_son_transfer_app_id:
/home/wireshark/builders/trunk/ubuntu1204x64/build/epan/dissectors/packet-bssgp.c:3173:12: error: variable next_tvb set but not used
[-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors


svn path=/trunk/; revision=46125
 2012-11-21 22:20:22 +00:00
Guy Harris 715065609b Clean up white space (no tabs). 
svn path=/trunk/; revision=46120
 2012-11-21 21:09:32 +00:00
Guy Harris 6c6b37cada The previous change means the "len" argument is now being used. 
svn path=/trunk/; revision=46113
 2012-11-21 18:13:51 +00:00
Anders Broman 66c80c0f60 From l.wachowski: 
Allign the tables for dissection.
From me try to fix the dissection of SONtransferApplicationIdentity_PDU.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8008

svn path=/trunk/; revision=46111
 2012-11-21 17:59:19 +00:00
Anders Broman 66c34f3c7b From l.wachowski: 
- In de_bssgp_pdu_in_error() use current_offset isof 0.
- in function de_bssgp_ran_inf_error_rim_cont. Error rim
container doesn't have field rim sequence number. This field exists in the rest
of containers but not in this one. So I have removed this field. 
In this function we have field pdu in error and this field is mandatory, not
optional

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8000

svn path=/trunk/; revision=46081
 2012-11-19 18:59:09 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Jakub Zawadzki 5a8783f5b1 Initial commit to support yet another method of passing data between dissectors. 
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
 2012-09-10 21:40:21 +00:00
Jakub Zawadzki b18e880040 Update FSF address - part II. 
svn path=/trunk/; revision=43538
 2012-06-28 23:18:38 +00:00
pascal 0ba1ab2909 Display Element ID in hexadecimal (like in 3GPP specs) 
Display EPS bearer ID in decimal

svn path=/trunk/; revision=42755
 2012-05-21 19:27:38 +00:00
Alexis La Goutte 342c647ed4 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=41466
 2012-03-10 17:48:33 +00:00
Anders Broman 0a7df4d63c Use tce correct IE id 
svn path=/trunk/; revision=41043
 2012-02-16 20:23:16 +00:00
Chris Maynard c2208aa172 Fix some duplicate display filter names. 
svn path=/trunk/; revision=40586
 2012-01-19 19:15:13 +00:00
Anders Broman 27f95726b3 Try to get the container stuff right... 
svn path=/trunk/; revision=40119
 2011-12-08 21:17:03 +00:00
Anders Broman 28f7d63c58 Dissect RIM related IEs 
svn path=/trunk/; revision=39740
 2011-11-06 08:18:26 +00:00
Bill Meier c4b63360dc Fix proto_tree_add_item( encoding args; 
Do whitespace cleanup (for a few files).

svn path=/trunk/; revision=39640
 2011-10-27 20:30:38 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Anders Broman 6eae60aa2f From Yaniv Kaul: 
Fix 'set but not used' errors that GCC 4.6 emits.

svn path=/trunk/; revision=36874
 2011-04-26 20:24:53 +00:00
Bill Meier 91991145de Don't assign to a proto_item * if the value won't be used: Coverity 858; 
Fix two cases where items appear to be added to the wrong tree: Coverioty 856 & 857.
Also: remove some unneeded #includes& do some whitespace cleanup.

svn path=/trunk/; revision=36473
 2011-04-05 15:33:56 +00:00
Anders Broman aaf0d277b8 Get rid of gsm_a_dtap_pinfo. 
svn path=/trunk/; revision=36444
 2011-04-04 14:49:14 +00:00
Anders Broman 8d6ca293dc Change the signature of elem_fcn():ns to include pinfo. 
svn path=/trunk/; revision=36443
 2011-04-04 14:37:25 +00:00
Anders Broman 72b69aeaf5 Change the msg_fcn() signature to include pinfo. 
svn path=/trunk/; revision=36441
 2011-04-04 07:45:34 +00:00
Stig Bjørlykke c9468a80be Added some missing breaks. 
Coverity 443 & 444.

svn path=/trunk/; revision=36361
 2011-03-27 13:40:54 +00:00
Anders Broman 23400cd7a3 Add dissection of 
- MBMS-SESSION-STOP-REQUEST
- MBMS-SESSION-STOP-RESPONSE
- MBMS-SESSION-UPDATE-REQUEST
- MBMS-SESSION-UPDATE-RESPONSE
- PS-HANDOVER-COMPLETE
- PS-HANDOVER-CANCEL
- PS-HANDOVER-COMPLETE-ACK

svn path=/trunk/; revision=36195
 2011-03-15 06:03:58 +00:00
Anders Broman 338f238746 Add dissection of 
- MBMS-SESSION-START-REQUEST
- MBMS-SESSION-START-RESPONSE

svn path=/trunk/; revision=36186
 2011-03-14 07:15:25 +00:00
Anders Broman 840b816f05 Remove more obsolete code. 
svn path=/trunk/; revision=36154
 2011-03-07 11:56:21 +00:00
Anders Broman 6c47c809ef Fix packet-bssgp.c:125: warning: 'hf_bssgp_tmsi_ptmsi' defined but not used 
svn path=/trunk/; revision=36153
 2011-03-07 10:01:24 +00:00
Anders Broman a7e379499d Remove the old code. 
svn path=/trunk/; revision=36152
 2011-03-07 09:36:24 +00:00
Anders Broman b4941ca580 Prepare to remove old bssgp code by changing exports. 
svn path=/trunk/; revision=36142
 2011-03-06 09:42:41 +00:00
Anders Broman 7e17176c39 All messages converted to the "GSM style" dissection. 
svn path=/trunk/; revision=36137
 2011-03-04 12:57:55 +00:00
Anders Broman a469849210 From Pascal Quantin: 
[3GPP protocols] Prettify the display of Mandatory Value information elements

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711

svn path=/trunk/; revision=36026
 2011-02-22 11:56:10 +00:00
Jeff Morriss 34dc101fcb #if out some (currently) unused functions. 
svn path=/trunk/; revision=36000
 2011-02-18 17:38:46 +00:00
Anders Broman 29ddaec6a6 Add more MSG dissection. 
svn path=/trunk/; revision=35998
 2011-02-18 07:00:03 +00:00
Gerald Combs dae5200002 Fix some Visual C++ analysis warnings. 
svn path=/trunk/; revision=35988
 2011-02-17 23:00:34 +00:00
Anders Broman daf631cce8 packet-bssgp.c:10020: warning: 'bssgp_perform_loc_response' defined but not used 
svn path=/trunk/; revision=35738
 2011-01-31 23:00:11 +00:00
Anders Broman 882874e91c More IE dissection. 
svn path=/trunk/; revision=35736
 2011-01-31 22:25:19 +00:00
Anders Broman 7a78a180c7 Dissect more IE's in PERFORM-LOCATION-REQUEST. 
svn path=/trunk/; revision=35721
 2011-01-31 15:16:45 +00:00
Guy Harris 0e2361fdb8 Clean up white space. 
Use the bssgp_perform_loc_request() routine for PERFORM-LOCATION-REQUEST
(fixes a "defined, but not used" warning).

svn path=/trunk/; revision=35714
 2011-01-31 00:12:21 +00:00
Anders Broman f4fad72618 Add more MSG dissection. 
svn path=/trunk/; revision=35707
 2011-01-30 22:08:22 +00:00
Anders Broman 7e77c162b0 Fix a typo and prettify some printouts. 
svn path=/trunk/; revision=35677
 2011-01-27 11:23:22 +00:00