osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
51,915 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

13 Commits

Author SHA1 Message Date
Guy Harris 9815a25971 Fix crash when exporting dissection summaries to a CSV file. 
The while loop in question ends with tmp_str being NULL; the next loop
processes the same string, so you have to set tmp_str to csv_str before
looping.

Fix some comments while we're at it.

Change-Id: I69dd7dc276e0cb11226eceee7921be87e3cc7534
Reviewed-on: https://code.wireshark.org/review/352
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 2014-02-25 09:08:29 +00:00
Pascal Quantin 8f15d3aa8d Fix display of right arrow in CSV export 
Changeset 1d8a895fa4 introduced the use of UTF-8 righ arrow to indicate the direction in TCP dissector.
While it displays nicely in Wireshark GUI or in a text export of packets, an export to CSV results in an escaped string.
This patch is a naive attempt to display the right arrow in a more friendly way when exporting to CSV.
Any smarter fix is welcome.

Change-Id: Ife787268696fa69dafc24a5cf9706af4c4832831
 2014-01-29 21:32:31 +01:00
Jakub Zawadzki 746ee39329 Drop isprint.h use g_ascii_isprint() when this include hack was enabled. 
svn path=/trunk/; revision=54327
 2013-12-21 15:01:45 +00:00
Evan Huus 2ae8edccea Rename more to_str functions to have ep_ in the name if they return ephemeral 
buffers. Remove two unused functions.

svn path=/trunk/; revision=54250
 2013-12-19 16:28:39 +00:00
Guy Harris db25270df8 Move the epan/filesystem.c routines to wsutil; they're not specific to 
packet dissection, they're specific to the entire Wireshark suite of
programs.

svn path=/trunk/; revision=53377
 2013-11-17 02:55:14 +00:00
Jakub Zawadzki 12d1509aa1 Move struct _ftype_t + callback typedefs + free macro to ftypes-int.h 
svn path=/trunk/; revision=53223
 2013-11-10 13:14:09 +00:00
Jakub Zawadzki 1899903f69 Include <epan/to_str.h> only when needed. 
svn path=/trunk/; revision=53189
 2013-11-09 13:41:10 +00:00
Evan Huus ee6916b838 When printing PDML, don't assume that all values with bitmasks are represented 
as guint32 internally - they may be signed and/or 64-bit.

svn path=/trunk/; revision=52587
 2013-10-13 16:10:43 +00:00
Michael Mann ba3e8e070a Make column "filter name" prefixed with _ws. to be the same as other "*shark application filters" created in r52462. 
svn path=/trunk/; revision=52474
 2013-10-09 19:43:02 +00:00
Pascal Quantin 7b71fa4782 Try to fix error: ignoring return value of 'fwrite', declared with attribute warn_unused_result 
svn path=/trunk/; revision=50722
 2013-07-18 07:01:02 +00:00
Jakub Zawadzki 8cefe3b406 Optimize print_line_text 
- fill spaces[] array once
- use fwrite()

svn path=/trunk/; revision=50705
 2013-07-17 20:13:54 +00:00
Jakub Zawadzki 3845249a7f Optimize proto_tree_print_node() + fix possible memleak when -O is used 
svn path=/trunk/; revision=50699
 2013-07-17 17:16:22 +00:00
Jeff Morriss 4dcc156cf3 Move the print modules into epan. 
svn path=/trunk/; revision=50526
 2013-07-12 03:50:50 +00:00