Commit Graph

39 Commits

Author SHA1 Message Date
Gerasimos Dimitriadis ec5cd4d450 Update SM Cause IE; Decode SM Cause 2 IE; Update
Activate PDP Context Accept msg

svn path=/trunk/; revision=31330
2009-12-20 23:17:40 +00:00
Gerasimos Dimitriadis 309d920eb8 Fix/enhacement of Quality of Service IE
svn path=/trunk/; revision=31295
2009-12-17 16:56:56 +00:00
Gerasimos Dimitriadis acd70335d1 More NULL entries in dtap_msg_sm_fcn[] to avoid out of bounds access
svn path=/trunk/; revision=31279
2009-12-15 22:09:32 +00:00
Gerasimos Dimitriadis af4c9216ce Fix/update for PDP Address IE
svn path=/trunk/; revision=31278
2009-12-15 21:48:05 +00:00
Gerasimos Dimitriadis 5de2fed9aa PS LCS Capability IE updated according to 24.008 V8.6.0;
Change printing of values according to standard style.

svn path=/trunk/; revision=31127
2009-11-29 23:23:27 +00:00
Gerasimos Dimitriadis 8a70d722d9 Explicitly show LAC and RAC when dissecting Routing Area
Identification; print LAC/RAC parts as decimals in RAI;
remove unneeded #include.

svn path=/trunk/; revision=31103
2009-11-27 23:55:32 +00:00
Gerasimos Dimitriadis b7261fe2e4 Expert info when E.212 MCC/MNC contain non-decimal digits
svn path=/trunk/; revision=31102
2009-11-27 22:57:50 +00:00
Gerasimos Dimitriadis b77caf13a9 More uniform printing of field values: Interpretation first, actual
value second.

svn path=/trunk/; revision=31092
2009-11-26 22:37:43 +00:00
Gerasimos Dimitriadis 299d64d458 Use range_string for the decoding of the CN specific DRX
cycle length coefficient; fixed the decoding of unknown 
values for Split PG Cycle Code; updated function for
Identity Type 2, now spare bit is explicitly shown; Reuse
the definition of the Switch-Measure-Switch values from
packet-gsm_a_common.c

svn path=/trunk/; revision=31060
2009-11-23 23:02:02 +00:00
Gerasimos Dimitriadis 5664dac535 Analyze GPRS Timer in its two subfields, unit and value
svn path=/trunk/; revision=31056
2009-11-23 19:59:40 +00:00
Gerasimos Dimitriadis 518995a4d8 No need for decoding function for a Tag-only IE
svn path=/trunk/; revision=31055
2009-11-23 19:15:58 +00:00
Gerasimos Dimitriadis 36b1cc8e77 Updated GPRS TMSI Status and Update Type IEs
svn path=/trunk/; revision=31009
2009-11-18 22:41:08 +00:00
Gerasimos Dimitriadis bb3447c6b1 GPRS Attach Type IE updated according to 24.008 v8.6.0
svn path=/trunk/; revision=31008
2009-11-18 22:05:16 +00:00
Gerasimos Dimitriadis 55b982b031 - Use the spare_bits hf from packet_gsm_a_common.c in
packet-gsm_a_dtap.c and packet-gsm_a_gm.c
- Update a number of GPRS IEs according to 24.008 v8.6.0
- Rewrite parts of GPRS IEs so that it is shown which octet parts
  contribute to which header fields


svn path=/trunk/; revision=31006
2009-11-18 20:39:14 +00:00
Gerasimos Dimitriadis e92c2e17da GPRS Attach Result IE updated according to 24.008 v8.6.0
svn path=/trunk/; revision=30977
2009-11-16 18:22:43 +00:00
Anders Broman 40447d1c12 Updated decoding of GMM Cause to V8.6.0, i.e. added cause code 0x19 - "Not authorized for this CSG". Changed to use a range_string.
Based on 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4132

svn path=/trunk/; revision=30627
2009-10-20 03:13:56 +00:00
Bill Meier 8790ed892f Define a global variable as static;
#include <stdio.h> & <stdlib.h>  not req'd.

svn path=/trunk/; revision=30101
2009-09-23 18:20:06 +00:00
Bill Meier 9310f13f19 Change gchar foo[mm][nn] = {"xxx", "yyy", ...} to static const gchar *foo[mm] = {...}
Add a comment about a possible bug: some strings in array are never used ?
Do some minor reformatting.

svn path=/trunk/; revision=30097
2009-09-23 17:55:37 +00:00
Bill Meier 81444cdda0 Quick fix for Bug #4040.
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4040

ToDo: Fix usage of
 gchar xxx[..][..] = {"aaa", "bbb", ...};

svn path=/trunk/; revision=30094
2009-09-23 16:06:39 +00:00
Anders Broman 2cacda1823 From Vincent Helfre:
MS network capability enhancement.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4039

svn path=/trunk/; revision=30075
2009-09-22 19:15:30 +00:00
Bill Meier 6c545e0d79 Save some memory: Don't statically allocate ett[] arrays used "dynamically".
svn path=/trunk/; revision=29929
2009-09-15 17:37:54 +00:00
Anders Broman 7945bf1bc9 From Harald Welte :
Connect RRLP to GSM A DTAP application info message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3919

From me try to fix missuse of pinfo.

svn path=/trunk/; revision=29482
2009-08-20 07:26:16 +00:00
Anders Broman 43cbf13ad4 Minor clean up.
svn path=/trunk/; revision=29466
2009-08-18 14:39:32 +00:00
Jaap Keuter c9e3f66d14 Optimize empty strings to NULL pointers.
svn path=/trunk/; revision=29298
2009-08-04 21:05:38 +00:00
Anders Broman 1464f7ca84 Introduce decode_bits_in_field() and use it.
clean up some left owers from previous checkin.

svn path=/trunk/; revision=28373
2009-05-15 18:38:13 +00:00
Anders Broman 2289fa0d21 Fix:
GSM DTAP: Incorrect decoding of MS Radio Access Capability Switch-Measure*
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3461

svn path=/trunk/; revision=28361
2009-05-14 18:26:18 +00:00
Bill Meier 18fac3d956 Use NULL instead of repeated,indentical text for blurbs in hf[];
Adjust some spacing;
Replace tab in string by a space;
Use #if 0... #endif instead of /* ... */ to comment out some code.

svn path=/trunk/; revision=28296
2009-05-07 21:22:36 +00:00
Jaap Keuter 23143c2580 From rspmn:
Wireshark considers an Activate PDP Context Request which contains a
DNS Server Address Request parameter according to section 10.5.6.3 of
TS 24.008 to be a malformed packet.
The attached patch (against SVN revision 28067) fixes the problem for
the parameters DNS Server Address Request and P-CSCF Address Request.

svn path=/trunk/; revision=28084
2009-04-18 06:34:58 +00:00
Anders Broman 2db386dfd4 - Use correct length in TLV-E and LV-E.
- Update PD values to the latest spec.
- Remove some non ASCII chars.
- Start dissecton of LTE NAS ESM EPS messages and IE's.

svn path=/trunk/; revision=27605
2009-03-04 19:51:55 +00:00
Anders Broman fea7018ed8 Add dissection of some IE's, reworked input from Zakia Karim.
svn path=/trunk/; revision=27467
2009-02-16 21:21:11 +00:00
Bill Meier 35e5fa9bc1 #include <epan/conversation.h> and/or #include <epan/emem.h> not req'd ...
svn path=/trunk/; revision=27390
2009-02-07 14:33:47 +00:00
Anders Broman b631b88d61 Implement TLV-E and LV-E type IE dissection (2 byte length value).
svn path=/trunk/; revision=27100
2008-12-23 20:49:15 +00:00
Bill Meier c544c20956 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Bill Meier 33c99f44fd Fix typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27028
2008-12-17 00:08:38 +00:00
Anders Broman dabf28342f From Pascal Quantin:
Enhance 3GPP 24.008 GMM dissection.

svn path=/trunk/; revision=26796
2008-11-17 19:41:44 +00:00
Anders Broman 2ff51cb037 Update the QoS IE
svn path=/trunk/; revision=26526
2008-10-23 19:22:54 +00:00
Anders Broman 07ccec7bcb 3GPP TMSI STATUS IE decoding does not update curr_offset
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2945

svn path=/trunk/; revision=26379
2008-10-08 16:09:28 +00:00
Anders Broman ebc8f1f8bf From Niel Percy:
Much as I hate white space changes, I got fed up of the huge variation of styles within these files, and tried to get to a much smaller range of variation. Also a few comment tidies, and use of _U_ for unused args rather than "arg = arg" lines.

svn path=/trunk/; revision=26140
2008-09-05 05:49:39 +00:00
Anders Broman 2226bccd44 From Neil Piercy:
1 new split file (GMM & SM in one file) and diff patches for the others. The RR, RP and BSSMAP patches are really a tidy-up: now they are split it becomes clear what was redundant code.

svn path=/trunk/; revision=26064
2008-08-24 17:42:30 +00:00