osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
33771 commits 23 branches 0 tags 1.3 GiB
Commit graph

69 commits

Author SHA1 Message Date
Jeff Morriss
67aba31f94 Deprecate dissector_add(), dissector_change(), dissector_delete(), 
dissector_get_port_handle(), dissector_reset(), dissector_try_port(),
dissector_try_port_new(), and next_tvb_add_port().

Re-tabify the file.

svn path=/trunk/; revision=35229
 2010-12-20 16:39:09 +00:00
Jeff Morriss
9dcabb82c9 Make the hf_ checks errors (they've been running clean for a while now anyway). 
svn path=/trunk/; revision=34711
 2010-10-30 13:23:58 +00:00
Jeff Morriss
052825d8e6 Fix the blurb regexp (sigh) 
svn path=/trunk/; revision=34418
 2010-10-08 00:29:17 +00:00
Jeff Morriss
390252fa29 Escape the pipe (alternation) in the display regexp. 
svn path=/trunk/; revision=34406
 2010-10-07 16:51:25 +00:00
Jeff Morriss
77327f1b6f Tighten the blurb regexp. Check for leading/trailing white space in blurbs. Check for any white space in the abbreviation. 
svn path=/trunk/; revision=34405
 2010-10-07 16:40:22 +00:00
Jeff Morriss
8947fc6a89 Enable hf checks by default. Add a check to see if the abbreviation is equal to the hf_variable_name. 
svn path=/trunk/; revision=34398
 2010-10-06 21:54:01 +00:00
Jeff Morriss
4dc93213e3 Don't use a regexp to compare the name to the blurb, just convert them both to lower case before doing the comparison. 
svn path=/trunk/; revision=34324
 2010-10-02 01:47:16 +00:00
Jeff Morriss
c39f840519 When checking hf, do a case-insensitive comparison between the name and the blurb. 
svn path=/trunk/; revision=34323
 2010-10-02 01:34:31 +00:00
Jeff Morriss
d7b10fbe55 Inspired by https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 : 
Add the option to check hf entries for various problems.  This is disabled by
default for the moment as it's quite noisy.

The regexps may need some additional fine tuning (or maybe simplification),
but they seem to work pretty well.

Arguably this might make more sense in checkhf.pl but it was easier to integrate
into this script.

svn path=/trunk/; revision=34240
 2010-09-24 20:26:29 +00:00
Jeff Morriss
2b52159449 Follow up to bug 5209 and rev 34115: 
%hh is C99 so remove it from packet-ssl-utils and add it to the banned list
(similar to %ll) in checkAPIs.pl .


svn path=/trunk/; revision=34120
 2010-09-15 14:10:25 +00:00
Bill Meier
df29b59def All use of deprecated GtkOptionMenu functions fixed: Error if any usage found. 
Warn instead of Error for several deprecated GTK functions used recently
 in Wireshark source (1 GtkCombo function and 2 GtkItemFactory functions).
 (ToDo: replace remaining use of GtkCombo and all use of GtkItemFactory).

svn path=/trunk/; revision=33598
 2010-07-20 23:58:56 +00:00
Bill Meier
eb232c3954 Add a few deprecated GObject fcns; 
Fix some typos and capitalization.

svn path=/trunk/; revision=33254
 2010-06-18 22:17:43 +00:00
Bill Meier
459eb4eed7 Add deprecated from GLib 2.24 
svn path=/trunk/; revision=33247
 2010-06-17 18:12:46 +00:00
Bill Meier
e636286b3c Add GTK deprecated from GTK 2.20. 
svn path=/trunk/; revision=33246
 2010-06-17 17:51:52 +00:00
Jeff Morriss
ca2a2b6298 Fix the value_string regexp so it doesn't match value_string_ext (which we don't have to check for NULL termination and the like) 
svn path=/trunk/; revision=32937
 2010-05-24 22:31:51 +00:00
Anders Broman
fc0932168f Run deprecated-gtk-todoon all files in the gtk dir. 
svn path=/trunk/; revision=32638
 2010-05-02 21:42:53 +00:00
Bill Meier
264d162f8d (Minor): Improve an output message. 
svn path=/trunk/; revision=32277
 2010-03-25 18:50:31 +00:00
Bill Meier
e3fc8e195c gtk_entry_append_text no longer used by Wireshark: Mark as deprecated-gtk ('W" => 'E') 
svn path=/trunk/; revision=31387
 2009-12-29 19:30:02 +00:00
Bill Meier
06a1aa808c gtk_progress_bar_update no longer used by Wireshark: Mark as deprecated ('W" => 'E'). 
svn path=/trunk/; revision=31385
 2009-12-29 17:50:03 +00:00
Bill Meier
1b15280a40 Mark certain GTK functions now unused by Wireshark as deprecated ("W" ==> 'E'); 
Rework usage() text slightly;
Clean up whitespace (untabify & etc).

svn path=/trunk/; revision=31381
 2009-12-29 15:35:20 +00:00
Bill Meier
5ae2550311 Update GLib/GTK deprecated lists to match current stable Glib/GTK; 
Various other minor changes ....

svn path=/trunk/; revision=31374
 2009-12-28 20:54:20 +00:00
Jaap Keuter
ff810ee91c Following bug 4302 added ctime() to the deprecated list. 
svn path=/trunk/; revision=31210
 2009-12-08 22:26:04 +00:00
Bill Meier
500a247519 Add some comments about GMemChunk usage; 
Enable 'deprecated' checking for some GLib functions 
 Wireshark doesn't currently use.

svn path=/trunk/; revision=30528
 2009-10-12 01:38:43 +00:00
Bill Meier
c7820529f5 Fix indentation. 
svn path=/trunk/; revision=30380
 2009-10-07 01:08:13 +00:00
Anders Broman
8fc53b829b Use gtk_image_new_from_pixmap(). 
svn path=/trunk/; revision=30316
 2009-10-04 18:33:23 +00:00
Anders Broman
199330559c Remove #if 0'ed code. 
svn path=/trunk/; revision=30312
 2009-10-04 18:21:14 +00:00
Anders Broman
ecc0cdb162 From GTK docs: 
Warning
gtk_window_set_policy is deprecated and should not be used in newly-written code. Use gtk_window_set_resizable() instead.

Changes how a toplevel window deals with its size request and user resize attempts. There are really only two reasonable ways to call this function: 

1.gtk_window_set_policy (GTK_WINDOW (window), FALSE, TRUE, FALSE) means that the window is user-resizable. 

2.gtk_window_set_policy (GTK_WINDOW (window), FALSE, FALSE, TRUE) means that the window's size is program-controlled, and should simply match the current size request of the window's children. 

gtk_window_set_resizable () :
Sets whether the user can resize a window. Windows are user resizable by default.

svn path=/trunk/; revision=30311
 2009-10-04 18:11:22 +00:00
Anders Broman
fa3b06e9de Get rid of deprecated symblol gtk_widget_draw(). 
svn path=/trunk/; revision=30305
 2009-10-04 15:49:52 +00:00
Gerald Combs
c66d0e4a6f Add assert and assert_perror to the 'abort' list. 
svn path=/trunk/; revision=28896
 2009-06-30 20:28:26 +00:00
Jeff Morriss
bbc68754f6 It appears Wireshark now has only ASCII in its source files; Treat non-ASCII chars as an error. 
svn path=/trunk/; revision=28738
 2009-06-15 15:16:52 +00:00
Bill Meier
899b857400 gtk_exit(): deprecated and no longer used in Wireshark: 'W' ==> 'E' 
svn path=/trunk/; revision=28445
 2009-05-22 12:39:00 +00:00
Bill Meier
e88bdea0bb gtk_check_menu_item_set_show_toggle() is deprecated and not needed. 
[show_toggle is always TRUE].

svn path=/trunk/; revision=28292
 2009-05-07 14:35:02 +00:00
Anders Broman
2621fbbdf9 Change W->E for now removed functions. 
svn path=/trunk/; revision=28279
 2009-05-05 18:38:59 +00:00
Bill Meier
866eb54ad4 checkAPIs: check for 'const' in value_string definition. 
svn path=/trunk/; revision=28114
 2009-04-21 22:26:34 +00:00
Bill Meier
14980f1592 checkAPIs: Add additional GLib deprecated functions; 
Update comments.

svn path=/trunk/; revision=28051
 2009-04-14 18:22:43 +00:00
Bill Meier
b6366d45f3 gtk_label_get() --> gtk_label_get_text() with related code changes; 
Also: Fix indentation to be consistent.

svn path=/trunk/; revision=28034
 2009-04-11 18:03:11 +00:00
Anders Broman
b686f1fa30 Get rid of gtk_file_selection_new and gtk_file_selection_get_filename. 
svn path=/trunk/; revision=28032
 2009-04-11 14:47:55 +00:00
Bill Meier
3224dc5d7a Remove unnecessary use of (deprecated) gtk_button_box_set_child_ipadding(); 
(In each case the arg values used [4,0] were the same as the defaults).
checkAPIs.pl: gtk_button_box_set_child_ipadding: 'W' --> 'E'

svn path=/trunk/; revision=28030
 2009-04-10 18:31:01 +00:00
Bill Meier
ade9f33ac5 gtk_widget_ref: 'W' --> 'E'; 
Also: Add GTK 2.16.0 deprecated functions

svn path=/trunk/; revision=28028
 2009-04-10 14:12:29 +00:00
Bill Meier
bd86780397 gtk_set_usize: W --> E; 
Change 'usage' to list groups and default groups.

svn path=/trunk/; revision=28020
 2009-04-09 13:04:15 +00:00
Anders Broman
caa4281da4 gtk_widget_ref() -> g_object_ref() 
GTK_SIGNAL_FUNC -> G_CALLBACK()

svn path=/trunk/; revision=28017
 2009-04-09 05:51:56 +00:00
Bill Meier
510a52b128 Treat any usage of functions in the 'deprecated' group an an Error. 
There's no longer any Wireshark usage of these functions.

svn path=/trunk/; revision=27732
 2009-03-15 20:50:33 +00:00
Bill Meier
34515ab429 Add complete list of deprecated GTK API's (as of GTK 2.14.7). 
Group 'deprecated-gtk' lists all deprecated GTK APIs which
  are not currently used in Wireshark.
  -g deprecated-gtk will 'Error';

 Group 'deprecated-gtk-todo' lists the deprecated GTK APIs
  which are still used in Wireshark (ie: not yet fixed).
  -g deprecated-gtk-todo will 'Warn'.

Also: two new options added:
 -M: -g output is one line per function per file;
 -s summary-group: gives a count of the usage of each function in that group
    [currently: any group used in -s must also be specified with -g option].
   

svn path=/trunk/; revision=27729
 2009-03-15 20:09:25 +00:00
Anders Broman
4602e4850d Add GTK deprecated functions. 
svn path=/trunk/; revision=27561
 2009-02-27 07:09:25 +00:00
Anders Broman
e88a6e5392 Update CheckApi with: 
#'gtk_clist_new', should we depriceate?
		# GtkCList has been deprecated since GTK+ 2.0 and should not be used
		# in newly written code. Use GtkTreeView instead. 
		'gtk_file_selection_new',

svn path=/trunk/; revision=27508
 2009-02-22 14:47:07 +00:00
Bill Meier
0726ae61dc Search for "(static const|static|const) value_string" when 
looking for value_string definitions to validate.

svn path=/trunk/; revision=26026
 2008-08-14 23:03:29 +00:00
Jeff Morriss
acd338f422 Remove the (long deprecated) proto_tree_add_*_hidden() functions 
svn path=/trunk/; revision=25820
 2008-07-24 15:35:29 +00:00
Bill Meier
a4d1eb9ee9 (Minor) Disable un-needed 'capture' in regexp 
svn path=/trunk/; revision=25811
 2008-07-23 23:15:07 +00:00
Bill Meier
e86d6997c7 Fix double-quoted string regexp to match strings with "line continuation"; 
Enable value_string check again ....

svn path=/trunk/; revision=25810
 2008-07-23 22:50:03 +00:00
Bill Meier
d35d95395a Disable value_string check for now. 
Apparently the "regex which matches double-quoted strings"
doesn't work with some versions of Perl (eg: 5.8.8) if the
string contains a 'line-continuation' (\ folowed by a new-line).
(This works for Perl 5.10.0).
So: disable value_string check until I look into this further.

svn path=/trunk/; revision=25802
 2008-07-23 11:36:27 +00:00