Commit graph

28 commits

Author SHA1 Message Date
Chris Maynard
1e2ae5a88a Quote all fields when exporting to CSV. Fixes bug 2811.
svn path=/trunk/; revision=34920
2010-11-17 03:29:12 +00:00
Jeff Morriss
b4c2ed1b86 Remove some unnecessary includes: a lot of things don't need globals.h and register.h
svn path=/trunk/; revision=34017
2010-08-30 16:10:01 +00:00
Bill Meier
d5471f6a3d Fix two bugs related to use of the graph Y-Axis Scale combo-box:
1. Incorrect specification of units: Should be ms & s not us and ms;
   Bug introduced in SVN #33834.
2. Selecting 50ms as the yscale actually used 50us as the scale;
   Bug introduced in SVN #30543.

svn path=/trunk/; revision=33854
2010-08-19 21:51:35 +00:00
Bill Meier
b0fcd85278 Various minor cleanups....
svn path=/trunk/; revision=33835
2010-08-18 01:01:06 +00:00
Bill Meier
d97116bd7a Minor cleanup of iax2 graph:
- Display current value in combo boxes (pixels_per_tick, etc) to always
  match actual values being used to create graph;
- yscale combo box entries: 
   show ms values as ms (not x000 usecs);
   show us values with unit "us" (not "ms");
- Determine max yscale label width properly as the largest of the
  top or middle label lengths;
- Cleanup some indentation.

svn path=/trunk/; revision=33834
2010-08-18 00:04:53 +00:00
Guy Harris
2a328da4ef Instead of using a Boolean for the search direction, use an enum, so
that you can tell from examination whether the search is forward or
backward.

Make the cf_find_packet routines take the direction as an explicit
argument, rather than, in the cases where you don't want to permanently
set the direction, saving the direction in the capture_file structure,
changing it, doing the search, and restoring the saved direction.  Give
more information in the Doxygen comments for those routines.

Add a cf_find_packet_dfilter_string() routine, which takes a filter
string rather than a compiled filter as an argument.  Replace
find_previous_next_frame_with_filter() with it.

Have cf_read_frame_r() and cf_read_frame() pop up the error dialog if
the read fails, rather than leaving that up to its caller.  That lets us
eliminate cf_read_error_message(), by swallowing its code into
cf_read_frame_r().  Add Doxygen comments for cf_read_frame_r() and
cf_read_frame().

Don't have find_packet() read the packet before calling the callback
routine; leave that up to the callback routine.

Add cf_find_packet_marked(), to find the next or previous marked packet,
and cf_find_packet_time_reference(), to find the next or previous time
reference packet.  Those routines do *not* need to read the packet data
to see if it matches; that lets them run much faster.

Clean up indentation.

svn path=/trunk/; revision=33791
2010-08-13 07:39:46 +00:00
Gerald Combs
96558700c1 UTF-8-ize a bunch more arrows. If IE6 on XP can render them then they
*must* be safe to use, right?

svn path=/trunk/; revision=33326
2010-06-25 22:09:34 +00:00
Anders Broman
65ee4e797a From Jakub Zawadzki:
New functions: cf_read_frame_r, cf_read_frame

It's much easier to write:
 cf_read_frame (cf, fdata, &err, &err_info)
Than:
 wtap_seek_read (cf->wth, fdata->file_off, &cf->pseudo_header, cf->pd,
fdata->cap_len, &err, &err_info)

svn path=/trunk/; revision=32980
2010-05-26 19:11:23 +00:00
Bill Meier
7397bb0a74 Fix various gcc -Wshadow warnings.
svn path=/trunk/; revision=31737
2010-01-29 23:17:32 +00:00
Anders Broman
9d45f50695 Option_menu -> combo_box
svn path=/trunk/; revision=30543
2009-10-12 15:27:37 +00:00
Anders Broman
4bd41da307 Remove code guarded by #ifdef USE_CONVERSATION_GRAPH
as this eems to newer have been fully implemented and the old clist is replaced now.

svn path=/trunk/; revision=30425
2009-10-09 09:56:16 +00:00
Bill Meier
1bc9f19f05 Add #include <stdio.h> in a few more places for Solaris.
svn path=/trunk/; revision=29577
2009-08-27 03:54:57 +00:00
Kovarththanan Rajaratnam
80a6d3fbcf Introduce epan_dissect_init()/epan_dissect_cleanup(). These are used to initialise/cleanup stack allocated 'edt' structures. This should speed up dissection since we avoid some malloc traffic.
svn path=/trunk/; revision=29404
2009-08-13 19:42:46 +00:00
Kovarththanan Rajaratnam
3512e485ca Add PNODE_FINFO. We've been using PITEM_FINFO on proto_node's. This works because proto_item is typedefed to proto_node. We shouldn't rely on this since this is an implementation detail.
svn path=/trunk/; revision=29354
2009-08-09 17:33:23 +00:00
Anders Broman
6c25896d84 From Kovarththanan Rajaratnam:
No letter-shortcuts in Telephony menu.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3678

svn path=/trunk/; revision=29028
2009-07-08 18:36:31 +00:00
Gerald Combs
e0ebc32195 Updates to create_tempfile:
- Use g_get_tmp_dir, just like get_tempfile_path.
  - Don't make the caller worry about the path buffer length.

svn path=/trunk/; revision=28915
2009-07-01 23:36:51 +00:00
Guy Harris
cf91fdf16b Have tap listeners specify whether the "packet" routine requires
a protocol tree;

	the column values.

This includes stats-tree listeners.

Have the routines to build the packet list, and to retap packets, honor
those requirements.  This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.

This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.

While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.

Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.

Clean up some indentation and some gboolean vs. gint items.

svn path=/trunk/; revision=28645
2009-06-05 22:42:47 +00:00
Bill Meier
c90204d7e2 Fix minor memory leaks; Minor reformatting
svn path=/trunk/; revision=28552
2009-06-01 11:35:52 +00:00
Guy Harris
71c8b6e5cf gtk_file_chooser_set_do_overwrite_confirmation() is only available in
2.8 and later.

svn path=/trunk/; revision=28536
2009-05-30 20:02:38 +00:00
Bill Meier
afb1262228 Fix the save_as functions so they work (including work-around
when save-as raises an alert box). 
Also:
- save_as_csv: don't skip over first line of output;
- save_as_csv: Fix some (probably significant) memory leaks
  associated with the use of gtk_tree_view;
- Prevent tendency for IAX2 stream window and graph window 
  to get lost behind other windows;
- Minor save_as dialog window reformatting;
- Misc source code cleanup & reformatting.

svn path=/trunk/; revision=28534
2009-05-30 18:07:35 +00:00
Bill Meier
fc0a57d2ca Restore original spacing in several constant strings
(as it was before I introduced some incorrect 'tabification' in SVN 27773)

svn path=/trunk/; revision=28294
2009-05-07 17:54:32 +00:00
Bill Meier
d436de7985 Change some usage of tabs within string constants to spaces.
svn path=/trunk/; revision=28293
2009-05-07 15:30:59 +00:00
Guy Harris
54c159cb41 Turn on -Wshorten-64-to-32 by default, and fix some issues that turned
up (99 44/100% of which were assignments of double-precision
floating-point constants to floats).  Hopefully this will catch at least
some P64 issues on UN*X.

svn path=/trunk/; revision=28108
2009-04-21 16:57:52 +00:00
Anders Broman
b686f1fa30 Get rid of gtk_file_selection_new and gtk_file_selection_get_filename.
svn path=/trunk/; revision=28032
2009-04-11 14:47:55 +00:00
Bill Meier
3224dc5d7a Remove unnecessary use of (deprecated) gtk_button_box_set_child_ipadding();
(In each case the arg values used [4,0] were the same as the defaults).
checkAPIs.pl: gtk_button_box_set_child_ipadding: 'W' --> 'E'

svn path=/trunk/; revision=28030
2009-04-10 18:31:01 +00:00
Bill Meier
460957c687 From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1];
From me:
   - As suggested by Jakub actually use sizeof(...) rather than a numeric constant
      in various places;
   - Use #if 0 rather than /* */ to comment out code;
   - Fix indentation to be consistent.


svn path=/trunk/; revision=27773
2009-03-18 15:25:19 +00:00
Jaap Keuter
6acffc2357 Get the build going again on non-Windows compilers.
svn path=/trunk/; revision=27697
2009-03-11 07:35:43 +00:00
Anders Broman
564846935a From Carlos Mendioroz:
IAX2 calls statistics window ala RTP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3217

svn path=/trunk/; revision=27696
2009-03-11 06:43:46 +00:00