Commit Graph

85030 Commits

Author SHA1 Message Date
Roland Knall 645b9ab7f4 Qt6: Adapt various docs 2022-08-23 10:37:14 +00:00
Guy Harris d9e662bc54 Rename some functions and types for endpoint tables.
The "conversation table" mechanism supports two types of tables, one for
the "Conversations" menu item under "Statistics" and one for the
"Endpoints" menu item under "Statistics".  The first of them shows
statistics for conversations at various layers of the networking stack;
the second of them shows statistics for endpoints at various layers of
the networking stack.

The latter is *not* a table of hosts; an endpoint might be a host,
identified by an address at some network level (MAC, IP, etc.), or it
might be a port on a host, identified by an address/port pair.

Some data types, function names, etc. use "host" or "hostlist" or other
terms that imply that an endpoint is a host; change them to speak of
endpoints rather than hosts, using names similar to the corresponding
functions for conversations.

Provide wrapper functions and typedefs for backwards source and binary
compatibility; mark them as deprecated in favor of the new names.

Clean up some comment errors found in the process.
2022-08-23 09:55:14 +00:00
João Valverde 6297831fb9 Gitlab CI: Add another USE_qt6=OFF option.
[skip ci]
2022-08-23 09:51:59 +01:00
João Valverde 9aa8331467 Gitlab CI: Fix ubuntu/rpm builds using Qt5 2022-08-23 08:52:20 +01:00
zhangzhilei 21d93f072a TLS:add error check for ssl_hmac_init
add error check for ssl_hmac_init
2022-08-23 02:20:53 +00:00
Chuck Craft b60240a8a6 spelling: "two pass" -> two-pass 2022-08-22 10:20:29 +00:00
João Valverde 2155a725e1 Gitlab-CI: Disable Qt6 for Windows Qt5 build 2022-08-22 10:17:24 +01:00
João Valverde b33210750c CMake+etc: Enable Qt6 by default for Unix builds
Linux builds were left behind on the Qt transition, presumably because
our Ubuntu CI image does not support Qt6.

Enable Qt6 by default and explicitly disable it for slower or more
conservative Linux distros.

Drop experimental status for Qt6, because we are using it to build
official Windows and macOS releases.
2022-08-22 09:08:06 +00:00
João Valverde 6b35aa0773 Qt: Add dfilter error location to tooltip
If display filter compilation fails and the expression has a syntax
error and associated location, it will be displayed in the filter
tooltip, using a textual underline.

As far as I can tell using a graphical squiggly underline seems extremely
difficult for an object inheriting from QLineEdit, so the tooltip
textual method was used instead.
2022-08-22 07:31:08 +00:00
John Thacker cbe4cd926c HTTP: Send binary Continuation Data to Follow Stream
If we shortcut the HTTP header check because the file starts with
a non-ASCII character, but we think that it is Continuation Data
because we've seen real HTTP in the same conversation, mark the
data as file data and send it to the follow tap, just as we would
if it failed the more extensive checks for being a header. Deals
with cases where desegmentation isn't performed (whether because
of prefs, missing packets, bad checksums, etc.)

Related to #13918.
2022-08-22 03:58:30 +00:00
John Thacker 00bfdf46a7 Qt: Fix export objects memory leak
The export object entries were never getting freed, creating a
pretty serious memory leak.

=1307558==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 2237664 byte(s) in 46618 object(s) allocated from:
    #0 0x55ac70d80457 in malloc (/home/johnthacker/wireshark-clang/run/wireshark+0x1a4a457) (BuildId: ad576854e9259fb05a7d0aacbff6e3e1f8e41157)
    #1 0x7fe8ff2f4278 in g_malloc (/lib64/libglib-2.0.so.0+0x5a278) (BuildId: 8a4c270219135729dff508e4bb3cc03099af40e8)
    #2 0x7fe910912ff4 in tap_push_tapped_queue /home/johnthacker/wireshark/epan/tap.c:366:15
    #3 0x7fe910711548 in epan_dissect_run_with_taps /home/johnthacker/wireshark/epan/epan.c:640:2
    #4 0x55ac7263288d in retap_packet /home/johnthacker/wireshark/file.c:2241:5
    #5 0x55ac7263201c in process_specified_records /home/johnthacker/wireshark/file.c:2207:14
    #6 0x55ac726315fc in cf_retap_packets /home/johnthacker/wireshark/file.c:2292:11
    #7 0x55ac712aed41 in ExportObjectDialog::show() /home/johnthacker/wireshark/ui/qt/export_object_dialog.cpp:173:15
...
Indirect leak of 1700955 byte(s) in 139854 object(s) allocated from:
    #0 0x55ac70d80457 in malloc (/home/johnthacker/wireshark-clang/run/wireshark+0x1a4a457) (BuildId: ad576854e9259fb05a7d0aacbff6e3e1f8e41157)
    #1 0x7fe8ff2f4278 in g_malloc (/lib64/libglib-2.0.so.0+0x5a278) (BuildId: 8a4c270219135729dff508e4bb3cc03099af40e8)
...
SUMMARY: AddressSanitizer: 3961187 byte(s) leaked in 186587 allocation(s).
2022-08-22 03:45:20 +00:00
John Thacker 2617ff294f SMTP: Move the request handling into a function
This makes the code easier to read and will enable handling
multiple PDUs in a message easier (needed for full pipelining
support.)
2022-08-21 18:00:18 -04:00
John Thacker d6812621a0 SMTP: Move response handling into function
Make the code a little easier to read
2022-08-21 18:00:18 -04:00
Martin Mathieson 9a5029b364 DCT2000: Don't assign to tag unused value 2022-08-21 19:48:13 +00:00
Gerald Combs 70dbe58aea [Automatic update for 2022-08-21]
Update manuf, services enterprise numbers, translations, and other items.
2022-08-21 16:39:53 +00:00
John Thacker ccf720d95d epan: Handle subset tvbuffs with non-zero offets and length -1
According to tvbuff.h, tvb_new_subset_length() with length -1
should behave like tvb_new_subset_remaining(). That means that
the reported length should subtract off the offset into the
original tvb.
2022-08-21 15:21:24 +00:00
Guy Harris 58907c0723 blf: change description and add/extend comments.
Call the Vector Informatik BLF format "Vector Informatik Binary Logging
Format (BLF) logfile", to give more details to people who don't
necessarily know what "BLF" means (British Lung Foundation?).

Note that in the introductory comments to blf.c and blf.h as well.

Note that we should perhaps report unknown flags/packet timestamp type
values as errors or warnings.

Note that we can, and should, report at least some 802.11 radio
information to our caller.
2022-08-21 01:34:41 -07:00
Dr. Lars Völker 3167105e2f BLF: Adding ObjectHeader format 2 and 3
This patch adds the format 2 and 3 of the ObjectHeader, so that the blf
code does not stop reading the file, when one of these header formats is
present.

Minor refactoring was necessary.
2022-08-21 01:02:48 +00:00
John Thacker 9c3dee4bb4 Add missing debian symbols
Add new symbols from commit 005169491e
2022-08-20 18:37:33 -04:00
Martin Mathieson eb197df564 RLC Graph: store secs in time_t 2022-08-20 19:56:34 +00:00
Chien Wong 5c216de8cc ieee80211: Improve A-MSDU dissecting
Fix subframe length issue.
Add padding.

Signed-off-by: Chien Wong <m@xv97.com>
2022-08-20 16:43:32 +00:00
Chien Wong 3b7c611be1 ieee80211: Add Transition Disable KDE dissecting
Signed-off-by: Chien Wong <m@xv97.com>
2022-08-20 06:14:29 +00:00
Stephen Hemminger 005169491e pcapng: add support displaying hash from pcapng
Add support for displaying one or more packet hashes that
have been recorded in EPB options.

A patch to add support for EPB hash option is pending for next
DPDK release.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
2022-08-20 06:12:28 +00:00
Gerald Combs 07c7ce6ad0 Windows: Upgrade libgcrypt to 1.10.1. 2022-08-19 18:30:16 -07:00
John Thacker 346c53b0b2 QUIC: In stateless reset only set from_server if token found
When calling quic_find_stateless_reset_token, only change the
from_server pointer is the reset token is actually found.
Fixes a few cases where a new Initial connection is sent with
client and server reversed. Also fixes an error failing to
dereference a pointer to a boolean.
2022-08-19 19:37:41 -04:00
David Perry d0c8efe889 Use `register_dissector()` for more protocols 2022-08-19 22:53:58 +00:00
Martin Mathieson b809e73f7c Fix some spelling errors 2022-08-19 17:46:34 +01:00
huangqiangxiong bb6fc5bb9a Protobuf: correct the starting offsets of the field name and type tree items 2022-08-19 15:14:09 +00:00
John Thacker 2007c929d2 QUIC: Add support for stateless reset
Fix #17938
2022-08-19 12:46:07 +00:00
zhangzhilei 034e48b500 TLS:support decrypt TLS_SM4_GCM_SM3 ciphersuite
ECC_SM4_GCM_SM3 is defined in RFC8998,and it defined how to use
SM3 and SM4 in tls1.3.
2022-08-19 18:08:39 +08:00
zhangzhilei 10b2e62a4a TLS:support decrypt ECC_SM4_GCM_SM3 ciphersuite
ECC_SM4_GCM_SM3 is defined in GB/T38636-2020
Information security technology-Transport layer cryptography protocol
which is a Chinese national standard.
the gcm behaviour of ECC_SM4_GCM_SM3 is the same as TLS1.2.
2022-08-19 08:28:40 +00:00
ismaelrti 066e80cb33 RTPS: Added new Security PIDs in Participant and Endpoint Discovery
Added dissections for the following PIDs:
- PID_PARTICIPANT_SECURITY_DIGITAL_SIGNATURE_ALGO
- PID_PARTICIPANT_SECURITY_KEY_ESTABLISHMENT_ALGO
- PID_PARTICIPANT_SECURITY_SYMMETRIC_CIPHER_ALGO
- PID_ENDPOINT_SECURITY_SYMMETRIC_CIPHER_ALGO
2022-08-19 07:55:05 +00:00
zhangzhilei 7b56170979 TLS:support decrypt ECC_SM4_CBC_SM3 ciphersuite
ECC_SM4_CBC_SM3 is defined in GB/T38636-2020
Information security technology-Transport layer cryptography protocol
which is a Chinese national standard.
prf alg of ciphersuites defined in GB/T 38636-2020 are the same as TLS1.2.
2022-08-19 07:25:51 +00:00
Gerald Combs f854083fd8 Falco Bridge: Add a NULL check. 2022-08-19 04:38:05 +00:00
Dario Lombardo bd0949ba1e rdpudp: fix leaking copy_address.
Fix: #18224.
2022-08-19 04:21:45 +00:00
Michael Tuexen ecefcf8801 TCP: Implement AccECN
This work is based on
https://www.ietf.org/archive/id/draft-ietf-tcpm-accurate-ecn-20.html
In particular, add support for the AccECN option, the experimental
AccECN option, the AE flag and the ACE field.
2022-08-19 00:41:24 +00:00
Gerald Combs 308d9d1856 macOS: Make sure we rpathify QtNetwork.
QtNetwork might be linked with brotli, so make sure we fix up its rpath.
2022-08-18 12:19:54 -07:00
Vadim Yanitskiy 2755cb7516 GSUP: add missing Number of Vectors Requested IE
This IE was introduced back in 2019, see:

https://gerrit.osmocom.org/q/Iaecc47280f8ce54f3e3a888c1cfc160735483d0f
https://cgit.osmocom.org/libosmocore/commit/?id=49ddef610a003f1000422284bf31a653249cf09e
2022-08-18 18:42:53 +00:00
Vadim Yanitskiy 9ca0193fed GSUP: add missing Supported/Current RAT Types IEs
These IEs were introduced back in 2018, see:

https://gerrit.osmocom.org/q/I93850710ab55a605bf61b95063a69682a2899bb1
https://cgit.osmocom.org/libosmocore/commit/?id=1b729ce106f474e29e7bbd57c01c3472e75a8b25

Below is an example PDU containing them:

GSUP SendAuthInfo Request, IMSI: 901700000043352
    Message Type: SendAuthInfo Request (8)
    IE: IMSI, 901700000043352
        Information Element Identifier: IMSI (1)
        Information Element Length: 8
        IMSI: 901700000043352
        [Association IMSI: 901700000043352]
            Mobile Country Code (MCC): International Mobile, shared code (901)
            Mobile Network Code (MNC): Clementvale Baltic OÜ (70)
    IE: Supported RAT Types
        Information Element Identifier: Supported RAT Types (41)
        Information Element Length: 1
        Supported RAT Type: EUTRAN (SGS) (3)
    IE: Current RAT Type
        Information Element Identifier: Current RAT Type (42)
        Information Element Length: 1
        Current RAT Type: EUTRAN (SGS) (3)
2022-08-18 18:42:53 +00:00
Gerald Combs bf6f2068ab macOS: Try to make sure we can find brotli.
libbrotlidec and libbrotlicommon show up in `otool -L` without any path
information on the macOS builders, similar to what's described at

https://github.com/google/brotli/issues/934

Try to work around this in osx-app.sh.
2022-08-18 11:11:14 -07:00
Gerald Combs b51a66f4f1 GitLab CI: Fix our macOS Intel deployment target. 2022-08-17 22:53:58 +00:00
Michael Tuexen c2574b72f4 TCP: Add support for TARR option
Based on https://datatracker.ietf.org/doc/html/draft-gomez-tcpm-ack-rate-request-05.
2022-08-18 00:08:30 +02:00
Michael Tuexen 9cea2c26a1 TCP: Use RFC 6994 for experimental options
Modernize the handling of experimental TCP options based on
RFC 6994. In particular use ExID instead of magic (which
in the context of RFC 6994 are the last two bytes of a
32-bit ExID) and add a desciption of ExID based on the
current state of the IANA registry.
2022-08-17 21:33:31 +00:00
Gerald Combs e555b458de GitLab CI: Enable Qt6 for the macOS builds. 2022-08-17 13:33:55 -07:00
David Perry 3b36ae4b1a TCP tap: check if have seglen before using it 2022-08-17 19:41:05 +00:00
Gerald Combs 9445bda1d8 GitLab CI: Switch the macOS builds to Qt 6.2.4. 2022-08-17 18:46:09 +00:00
Michael Pergament bd6c21696a Add support for Addd Path in EVPN NLRI 2022-08-17 18:22:17 +00:00
Tomasz Moń 12bb2788f9 CMake: Break on GLib criticals by default in MSVC
Set G_DEBUG=fatal-criticals environment variable when debugging with
Visual Studio. Setting the environment variable conveniently triggers
breakpoint whenever there is a programmer error.
2022-08-17 17:06:57 +00:00
Gerald Combs 0b068f3b06 Docs: Add a SharkFest link to the release notes. 2022-08-17 17:04:57 +00:00
Gerald Combs d2a70cc4ac CMake: Add a Logray patch version. 2022-08-17 16:20:06 +00:00