Commit graph

33932 commits

Author SHA1 Message Date
Jeff Morriss
6f1c903e18 There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_string: just use proto_tree_add_item().
svn path=/trunk/; revision=35396
2011-01-06 02:56:10 +00:00
Jeff Morriss
eea559bc2c There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_string: just use proto_tree_add_item().
svn path=/trunk/; revision=35395
2011-01-06 02:52:00 +00:00
Jeff Morriss
0b49360059 Rather than creating strtoul{l} functions that can deal with possibly non-NULL
terminated strings (retrieved with tvb_get_ptr()), just use
tvb_get_ephemeral_string() and the standard strtoul{l} functions.

svn path=/trunk/; revision=35394
2011-01-06 02:45:01 +00:00
Jeff Morriss
fb7450a8df Use tvb_get_ephemeral_stringz() instead of tvb_get_strsize() plus (sometimes multiple) calls to tvb_get_ptr().
svn path=/trunk/; revision=35393
2011-01-06 02:18:36 +00:00
Jaap Keuter
656e914296 Rearrange the Intenals and Help menu somewhat.
svn path=/trunk/; revision=35392
2011-01-05 23:12:51 +00:00
Jeff Morriss
9b3eb1ff4b Reset the global pdu_type *before* returning.
svn path=/trunk/; revision=35391
2011-01-05 22:40:47 +00:00
Jeff Morriss
61317d2dbd Remove an unreached return.
svn path=/trunk/; revision=35390
2011-01-05 22:33:25 +00:00
Jeff Morriss
8535524c6a Remove a duplicate return.
svn path=/trunk/; revision=35389
2011-01-05 22:27:41 +00:00
Jeff Morriss
abe40cfaf1 Remove a break that makes other following statements unreached.
svn path=/trunk/; revision=35388
2011-01-05 22:26:43 +00:00
Jeff Morriss
fc2b1606cf Remove unreached statement.
svn path=/trunk/; revision=35387
2011-01-05 22:20:39 +00:00
Jeff Morriss
f86b14d820 Replace 2 switch()es with duplicated values (but missing most of the case statements--leading the Sun compiler to complain about most of the statements not being reached) with a value_string and a couple of val_to_str() calls. Also some minor reformatting of the function in question.
svn path=/trunk/; revision=35386
2011-01-05 22:17:33 +00:00
Gerald Combs
0a6cf34d6e Update manuf, which the auto-update script has been missing for the past
few weeks.

svn path=/trunk/; revision=35385
2011-01-05 19:35:08 +00:00
Jeff Morriss
11fc9bbe33 Use some tvb_ accessor functions instead of a standard function plus tvb_get_ptr().
svn path=/trunk/; revision=35384
2011-01-05 18:59:47 +00:00
Guy Harris
3e5c04221a Handling a too-long length should be handled better.
svn path=/trunk/; revision=35383
2011-01-05 17:59:50 +00:00
Guy Harris
8d35834342 Fix (legitimate) warning.
svn path=/trunk/; revision=35382
2011-01-05 17:38:03 +00:00
Jeff Morriss
b14b09ac79 Use proto_tree_add_item() to add some FT_BYTES to the tree instead of calling proto_tree_add_bytes() with the result of tvb_get_ptr() passed as the 'value'.
svn path=/trunk/; revision=35381
2011-01-05 17:28:17 +00:00
Guy Harris
216fed8397 From Steve Huston: add support for AMQP 0-10.
From me: add 0_9 to names for #defines and routines for 0-9, add expert
info for the "you ran past the end of the field table" error.

svn path=/trunk/; revision=35380
2011-01-05 17:19:48 +00:00
Jeff Morriss
88da4576cc Don't pass the result of tvb_get_ptr() into a %s format string: the string may
not be NULL terminated.  Use tvb_get_ephemeral_string() instead.

svn path=/trunk/; revision=35379
2011-01-05 17:16:29 +00:00
Anders Broman
660d827706 Enhance IE dissection.
svn path=/trunk/; revision=35378
2011-01-05 16:46:40 +00:00
Jeff Morriss
ae4ef9853c Don't pass the result of tvb_get_ptr() into a %s format string: the string may
not be NULL terminated.  Use tvb_get_ephemeral_string() instead.

svn path=/trunk/; revision=35377
2011-01-05 15:23:53 +00:00
Jeff Morriss
5efa40982a Don't pass the result of tvb_get_ptr() into a %s format string: the string may
not be NULL terminated.  Use tvb_get_ephemeral_string() instead.

svn path=/trunk/; revision=35376
2011-01-05 15:18:54 +00:00
Jeff Morriss
d74bd3ce42 Don't pass the result of tvb_get_ptr() into a %s format string: the string may
not be NULL terminated.  Use tvb_get_ephemeral_string() instead.

svn path=/trunk/; revision=35375
2011-01-05 15:11:32 +00:00
Martin Mathieson
d8506bbfed Remove a stray debug printf().
svn path=/trunk/; revision=35374
2011-01-05 14:45:31 +00:00
Martin Mathieson
7a0f12239c Support FP_R8 over ATM, plus a couple of other tidying-ups.
svn path=/trunk/; revision=35373
2011-01-05 14:36:48 +00:00
Jaap Keuter
90a2ad31dd Clean up the white space.
svn path=/trunk/; revision=35372
2011-01-05 07:31:46 +00:00
Anders Broman
0b2414ebd2 Update the AUTHORS file
svn path=/trunk/; revision=35371
2011-01-05 07:27:41 +00:00
Anders Broman
53cc4d7ea9 From Francesco Fondelli:
RSVP: support for Vendor Private objects, RFC 3936
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5468

svn path=/trunk/; revision=35370
2011-01-05 07:16:09 +00:00
Guy Harris
eaad8c00f2 Put end-of-field-table checks back into dissect_amqp_field_table().
svn path=/trunk/; revision=35369
2011-01-05 06:11:10 +00:00
Jeff Morriss
d298b79628 Use reported length (instead of the captured length) when dissecting error
causes (should have been in rev 35366).

When generating TVB subsets, limit the subset's backing and reported lengths to
the (captured) TVB length and the reported TVB length, respectively.

This allows us to dissect most of the packet in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5546
before asserting out.

It also yields similar better behavior when the capture is limited by a
snapshot length.

svn path=/trunk/; revision=35368
2011-01-05 03:40:02 +00:00
Stephen Fisher
bc2bd6dcc5 Reverse r34810 other than the comment because the re-ordering of dns_types[]
caused the numbering to no longer be lined up so the "SRV" record (#33) type
T_SRV was being given the description "EID" instead of "Service Location"


svn path=/trunk/; revision=35367
2011-01-05 00:48:40 +00:00
Jeff Morriss
25485e9b3e When generating a tvb subset for chunks, parameters, and error causes, set the:
- "reported length" to be minimum of the entity's length (taken from the
   packet) or the reported length of the TVB.
 - "backing length" to be the minimum of the reported length (above) or the
   (captured) length of the TVB.

This prevents tvb_new_subset() from generating an exception if the entity's
length (in the packet) is bogus (bigger than what's in the TVB) which allows
dissection to continue to a point where we can show the user what the problem
is.

When dissecting chunks, add an expert info if the item's length is bigger than
what was on the wire (the reported length).  (The same could also be done for
parameters and error causes.)

This makes captures like that in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5546
easier to understand.

It also starts getting this dissector using the reported length instead of the
(captured) TVB length (there's more to be done with other tvb subsets).

svn path=/trunk/; revision=35366
2011-01-04 23:07:32 +00:00
Jaap Keuter
bc31879963 Drop Python dissectors directory flag from programs that don't have dissectors.
Win32: remove superfluous dumpcap build dependancy on wiretap.

svn path=/trunk/; revision=35365
2011-01-04 22:12:25 +00:00
Jeff Morriss
7a5c44beed Check hf entries *after* removing comments (in case there are commented-out entries).
svn path=/trunk/; revision=35364
2011-01-04 18:48:26 +00:00
Jeff Morriss
c18d15f9f7 Detect (and error on) NULL or empty abbreviations. Wireshark aborts on the former and warns on the latter.
svn path=/trunk/; revision=35363
2011-01-04 18:43:24 +00:00
Jeff Morriss
f94b75c658 Give a couple of fields abbreviations.
svn path=/trunk/; revision=35362
2011-01-04 18:41:25 +00:00
Anders Broman
95397594c9 Maeke use of dissect_e212_mcc_mnc_ep_str().
svn path=/trunk/; revision=35361
2011-01-04 16:58:55 +00:00
Anders Broman
022b418e40 Introduce dissect_e212_mcc_mnc_ep_str()
Which can be useful to make nice lables like:
+ Serving Network : MCC 311 United States of America, MNC 28

svn path=/trunk/; revision=35360
2011-01-04 16:58:07 +00:00
Jeff Morriss
5d7f70bf41 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5544 :
Include the packet-ipv6.h changes too.

svn path=/trunk/; revision=35359
2011-01-04 15:39:12 +00:00
Anders Broman
52264efdfe Fix build.
svn path=/trunk/; revision=35358
2011-01-04 08:45:03 +00:00
Guy Harris
57f521fa1a Don't use DISSECTOR_ASSERT() to catch malformed packets. Fixes bug
4048.

svn path=/trunk/; revision=35357
2011-01-04 08:04:27 +00:00
Guy Harris
6b38961a95 Instead of going over the Report segment twice, once to get the fields
in the segment and once to put them into the protocol tree, just do it
once.  That also means we don't need to allocate an array for all the
reception claims, so we don't have to worry about the claim count (other
than making sure it's non-negative), and that we won't abort the
dissection until we run past the end of the packet.

(The rest of the dissector should be changed to work that way as well.)

svn path=/trunk/; revision=35356
2011-01-04 07:48:28 +00:00
Jaap Keuter
b9f7ef1bb2 From Alexis La Goutte:
A Patch to enchance the ICMPv6 Router Renumbering for IPv6 (RFC 2894) Dissector
- Make RR field filterable 
- Add RR Result Message
- ...

svn path=/trunk/; revision=35355
2011-01-04 07:44:39 +00:00
Anders Broman
9eb2d42bac Add more info to the tree.
svn path=/trunk/; revision=35354
2011-01-04 07:14:11 +00:00
Jaap Keuter
3656ecb823 Free dumpcap from linking to wiretap.
svn path=/trunk/; revision=35353
2011-01-04 07:06:01 +00:00
Anders Broman
da59924551 Prettify dissection of User Location Info (ULI). (Complete)
svn path=/trunk/; revision=35352
2011-01-03 23:21:49 +00:00
Anders Broman
5045d66232 Prettify dissection of User Location Info (ULI).
svn path=/trunk/; revision=35351
2011-01-03 22:13:11 +00:00
Jaap Keuter
b9b7d51226 From Hadar Shoham:
Add support to EuroCableLabs at bootp opt 60 sub 23.
according to PKT-SP-PROV1.5-I04-090624, paragraph 10.23 Device MIB Support:
type 2 is indicating EuroCableLabs.

svn path=/trunk/; revision=35350
2011-01-03 21:40:03 +00:00
Stephen Fisher
1d4c01023b State in the developer documentation that the tvb_fake_unicode() and
tvb_get_ephemeral_fake_unicode() functions have been superceded by
tvb_get_unicode_string() and tvb_get_ephemeral_unicode_string() respectivey.


svn path=/trunk/; revision=35349
2011-01-03 19:37:13 +00:00
Stephen Fisher
18948c2843 Remove the other use of tvb_fake_unicode() from the DCE/RPC dissector and
replace it with tvb_get_unicode_string().


svn path=/trunk/; revision=35348
2011-01-03 19:28:52 +00:00
Jeff Morriss
d1df0f9130 Fix (or at least quiet Valgrind about) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5542 :
Always initialize *all* the outputs of get_sdp_type().

svn path=/trunk/; revision=35347
2011-01-03 18:48:29 +00:00