osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
86,541 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

242 Commits

Author SHA1 Message Date
Anders Broman fa3b06e9de Get rid of deprecated symblol gtk_widget_draw(). 
svn path=/trunk/; revision=30305
 2009-10-04 15:49:52 +00:00
Gerald Combs c66d0e4a6f Add assert and assert_perror to the 'abort' list. 
svn path=/trunk/; revision=28896
 2009-06-30 20:28:26 +00:00
Jeff Morriss bbc68754f6 It appears Wireshark now has only ASCII in its source files; Treat non-ASCII chars as an error. 
svn path=/trunk/; revision=28738
 2009-06-15 15:16:52 +00:00
Bill Meier 899b857400 gtk_exit(): deprecated and no longer used in Wireshark: 'W' ==> 'E' 
svn path=/trunk/; revision=28445
 2009-05-22 12:39:00 +00:00
Bill Meier e88bdea0bb gtk_check_menu_item_set_show_toggle() is deprecated and not needed. 
[show_toggle is always TRUE].

svn path=/trunk/; revision=28292
 2009-05-07 14:35:02 +00:00
Anders Broman 2621fbbdf9 Change W->E for now removed functions. 
svn path=/trunk/; revision=28279
 2009-05-05 18:38:59 +00:00
Bill Meier 866eb54ad4 checkAPIs: check for 'const' in value_string definition. 
svn path=/trunk/; revision=28114
 2009-04-21 22:26:34 +00:00
Bill Meier 14980f1592 checkAPIs: Add additional GLib deprecated functions; 
Update comments.

svn path=/trunk/; revision=28051
 2009-04-14 18:22:43 +00:00
Bill Meier b6366d45f3 gtk_label_get() --> gtk_label_get_text() with related code changes; 
Also: Fix indentation to be consistent.

svn path=/trunk/; revision=28034
 2009-04-11 18:03:11 +00:00
Anders Broman b686f1fa30 Get rid of gtk_file_selection_new and gtk_file_selection_get_filename. 
svn path=/trunk/; revision=28032
 2009-04-11 14:47:55 +00:00
Bill Meier 3224dc5d7a Remove unnecessary use of (deprecated) gtk_button_box_set_child_ipadding(); 
(In each case the arg values used [4,0] were the same as the defaults).
checkAPIs.pl: gtk_button_box_set_child_ipadding: 'W' --> 'E'

svn path=/trunk/; revision=28030
 2009-04-10 18:31:01 +00:00
Bill Meier ade9f33ac5 gtk_widget_ref: 'W' --> 'E'; 
Also: Add GTK 2.16.0 deprecated functions

svn path=/trunk/; revision=28028
 2009-04-10 14:12:29 +00:00
Bill Meier bd86780397 gtk_set_usize: W --> E; 
Change 'usage' to list groups and default groups.

svn path=/trunk/; revision=28020
 2009-04-09 13:04:15 +00:00
Anders Broman caa4281da4 gtk_widget_ref() -> g_object_ref() 
GTK_SIGNAL_FUNC -> G_CALLBACK()

svn path=/trunk/; revision=28017
 2009-04-09 05:51:56 +00:00
Bill Meier 510a52b128 Treat any usage of functions in the 'deprecated' group an an Error. 
There's no longer any Wireshark usage of these functions.

svn path=/trunk/; revision=27732
 2009-03-15 20:50:33 +00:00
Bill Meier 34515ab429 Add complete list of deprecated GTK API's (as of GTK 2.14.7). 
Group 'deprecated-gtk' lists all deprecated GTK APIs which
  are not currently used in Wireshark.
  -g deprecated-gtk will 'Error';

 Group 'deprecated-gtk-todo' lists the deprecated GTK APIs
  which are still used in Wireshark (ie: not yet fixed).
  -g deprecated-gtk-todo will 'Warn'.

Also: two new options added:
 -M: -g output is one line per function per file;
 -s summary-group: gives a count of the usage of each function in that group
    [currently: any group used in -s must also be specified with -g option].
   

svn path=/trunk/; revision=27729
 2009-03-15 20:09:25 +00:00
Anders Broman 4602e4850d Add GTK deprecated functions. 
svn path=/trunk/; revision=27561
 2009-02-27 07:09:25 +00:00
Anders Broman e88a6e5392 Update CheckApi with: 
#'gtk_clist_new', should we depriceate?
		# GtkCList has been deprecated since GTK+ 2.0 and should not be used
		# in newly written code. Use GtkTreeView instead. 
		'gtk_file_selection_new',

svn path=/trunk/; revision=27508
 2009-02-22 14:47:07 +00:00
Bill Meier 0726ae61dc Search for "(static const|static|const) value_string" when 
looking for value_string definitions to validate.

svn path=/trunk/; revision=26026
 2008-08-14 23:03:29 +00:00
Jeff Morriss acd338f422 Remove the (long deprecated) proto_tree_add_*_hidden() functions 
svn path=/trunk/; revision=25820
 2008-07-24 15:35:29 +00:00
Bill Meier a4d1eb9ee9 (Minor) Disable un-needed 'capture' in regexp 
svn path=/trunk/; revision=25811
 2008-07-23 23:15:07 +00:00
Bill Meier e86d6997c7 Fix double-quoted string regexp to match strings with "line continuation"; 
Enable value_string check again ....

svn path=/trunk/; revision=25810
 2008-07-23 22:50:03 +00:00
Bill Meier d35d95395a Disable value_string check for now. 
Apparently the "regex which matches double-quoted strings"
doesn't work with some versions of Perl (eg: 5.8.8) if the
string contains a 'line-continuation' (\ folowed by a new-line).
(This works for Perl 5.10.0).
So: disable value_string check until I look into this further.

svn path=/trunk/; revision=25802
 2008-07-23 11:36:27 +00:00
Bill Meier ac48c59340 Add test to check if value_string arrays are NULL terminated; 
default: test is enabled.
Check for error return from GetOptions

svn path=/trunk/; revision=25800
 2008-07-22 22:27:08 +00:00
Guy Harris b6e20d89be Put printf into a separate "termoutput" API group. For most files, 
check for it - but not for TShark plugins, as they are expected to
print to the standard output.

svn path=/trunk/; revision=25653
 2008-07-01 21:13:32 +00:00
Gerald Combs b642ef10fa Have checkAPIs.pl print to stderr, so that its output is colored red in 
Buildbot. Make capitalization more consistent. Look for abort functions in
wsutil.

svn path=/trunk/; revision=25619
 2008-06-27 22:48:25 +00:00
Gerald Combs 83aacf0a09 Add support for "API groups" in checkAPIs.pl. Make the "prohibited" 
and "deprecated" groups the default. Add an "abort" group for code that
shouldn't exit the program. Update the makefiles to call "checkAPIs.pl
-g abort" for dissectors. Remove a dependency on "cat" in checkAPIs.pl.

svn path=/trunk/; revision=25614
 2008-06-26 22:20:05 +00:00
Jeff Morriss a5cee04fad Move the file utility functions from wiretap to libwsutil so that 
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.

While doing that, rename the eth_* functions to ws_*.

svn path=/trunk/; revision=25354
 2008-05-22 15:46:27 +00:00
Bill Meier 5a43cd6358 Check for a few addt'l functions... 
svn path=/trunk/; revision=25341
 2008-05-21 14:49:50 +00:00
Jeff Morriss 547cda2f1f Update comments. 
svn path=/trunk/; revision=25286
 2008-05-13 12:49:32 +00:00
Anders Broman db6d0b9a4c Run checkAPI in plugins dir. 
svn path=/trunk/; revision=25259
 2008-05-08 18:24:08 +00:00
Anders Broman 9cc9c92e75 Fix some of the Errors/warnings detected by checkapi, 
make non ASCII char a warning for now.

svn path=/trunk/; revision=25240
 2008-05-05 20:38:27 +00:00
Anders Broman 163d568fe6 Add depreceated glib API:s 
svn path=/trunk/; revision=25230
 2008-05-05 06:27:15 +00:00
Jeff Morriss 74a602085e Ban strdup() and strndup(). 
svn path=/trunk/; revision=25045
 2008-04-15 12:56:23 +00:00
Jeff Morriss eeaa432e2a Warn if a file does not have an SVN Id tag in it. 
svn path=/trunk/; revision=24587
 2008-03-08 21:23:14 +00:00
Stig Bjørlykke 34d9fa6c56 Add strncpy and strncat to the list of prohibited APIs. 
svn path=/trunk/; revision=24517
 2008-03-01 12:04:16 +00:00
Jeff Morriss 068f67a499 Warn if we find %ll in the source 
svn path=/trunk/; revision=24182
 2008-01-24 22:02:55 +00:00
Jeff Morriss bb66032801 Add check for non-ASCII characters (defined, for now, as any whose value is > 0x80) anywhere in the source files (as per discussion on -dev). Amazingly, this does not appear to slow the tool down too much. 
svn path=/trunk/; revision=24177
 2008-01-24 18:18:28 +00:00
Jeff Morriss 0e339e83ed Add the file op APIs (e.g., open()) to the list of prhobited APIs (should use the eth_* versions instead). 
svn path=/trunk/; revision=24057
 2008-01-10 15:03:58 +00:00
Guy Harris c6420ae10b Ban strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() 
while we're at it.  More to come....

svn path=/trunk/; revision=23626
 2007-11-27 20:06:20 +00:00
Jeff Morriss c641bfb363 When we've found C++ style comments, tell which file we found them in. 
svn path=/trunk/; revision=23609
 2007-11-26 18:59:32 +00:00
Jeff Morriss 58b8fef9ea As discussed on the -dev list quite a while ago: a small tool to check Wireshark code (or at least parts of it) for "bad" things (C++ style comments and API/function calls that should not be used). I'm checking in because I almost missed some C++ style comments in a file I was contemplating checking in; this tool can help us (at least me) avoid such problems in the future. 
svn path=/trunk/; revision=22509
 2007-08-15 20:35:14 +00:00