improve the Info column text for reassembled messages;
register subdissectors for dissecting Q.931 IEs and make the
ISUP dissector call the codeset 0 IE subdissector through a
handle.
svn path=/trunk/; revision=10400
- display the type of segmented message in the info column
- don't dissect the last IE in the 1st segment if it is incomplete
- don't dissect IEs in following segments as segment boundaries
usually don't IE boundaries
svn path=/trunk/; revision=10097
date/time IE, so support IE lengths of 5 (no seconds) or 6 (includes
seconds).
Merge the two AUTHORS and man page entries for him.
svn path=/trunk/; revision=10089
into "lapd_sapi.h". Use that to register the Q.931 dissector atop LAPD.
From Rolf Fiedler: ISDN TEI management frame support.
svn path=/trunk/; revision=9864
That means that the codeset number cannot be bigger than the number of
elements in "q931_info_element_vals[]", so we can get rid of the checks
for the codeset value; we also make NUM_INFO_ELEMENT_VALS equal to
(Q931_IE_SHIFT_CODESET+1), to make this clearer.
svn path=/trunk/; revision=9676
This was problematic and caused crashes since this variable is used as an index into an array where we grab a
pointer (which is later dereferenced).
Dereferencing that pointer will have surprising effects. Usually crashes.
Update Q.931 to verify sanity of the codeset variable everytime it gets set.
svn path=/trunk/; revision=8927
fix the offset when putting the cause code in a Cause IE into the
protocol tree;
in a Number IE, show the number type, numbering plan, and
extension indicator as named-field bitfields.
svn path=/trunk/; revision=8828
1) Swap locking/non-locking shift IEs. It was used in wrong way. "0"
indicates locking and "1" indicates non-locking shift.
2) Return back to last locked codeset instead of codeset 0 after
non-locking shift.
3) Handling of unknown single-octet IEs.
svn path=/trunk/; revision=7919
don't do so.
Pick up Anders Broman's table of Q.850 cause values, and his change to
use "dissect_q931_cause_ie()" for cause indicators - but do it by
modifying the Q.931 dissector's "dissect_q931_cause_ie()" to take, as an
argument, the header field to use for the cause value, and export that
routine and have the ISUP dissector call it, rather than by duplicating
the cause IE dissector.
svn path=/trunk/; revision=7225
equivalents for the toplevel directory. The removal of winsock2.h will
hopefully not cause any problems under MSVC++, as those files using
struct timeval still include wtap.h, which still includes winsock2.h.
svn path=/trunk/; revision=5932
and other changes to RADIUS.
Export the Q.931 cause location and code values, and use them in the
RADIUS dissector for ACC cause codes and values.
Make "CHAP" all caps, as it should be, and use InterCaps in AppleTalk
(Apple does).
The CHAP Challenge is an octet string, not a text string - the
FreeRadius dictionary has an error there.
In "rdconvertinttostr()", if there's no value_string table, just print
the value numerically, don't call "rd_match_strval()".
Don't pass a null value_string pointer to "rd_match_strval_attrib()" -
just report the value, without attempting to find a string for it.
svn path=/trunk/; revision=5460
whether the length value in the TPKT header is large enough to include
that much payload - if not, report the packet as not being a TPKT
packet.
Have the heuristic Q.931 dissector supply the appropriate value.
svn path=/trunk/; revision=5457
handed looks as if it contains only a TPKT header (4 bytes long, and
those 4 bytes look like a TPKT header according to "is_tpkt()"), call
the "dissect TPKT over a TCP stream" routine. If we're doing
reassembly, that routine will force a reassembly because the TPKT
payload isn't in that segment, and the various heuristic XXX-over-TPKT
dissectors will be called again, this time with enough data for them to
say whether the TPKT payload is for them or not; if we're not doing
reassembly, we'll dissect the TPKT header and then call the "dissect a
Q.931 PDU" routine, which will throw an exception because there isn't
any payload from which to fetch data (and that's what we want to
happen).
In the "dissect TPKT over a TCP stream" routine, if reassembly is
enabled, do the check to see if we need to do reassembly to get the
payload before dissecting the TPKT header, so that we don't dissect the
TPKT header and then decide "oops, we need some more data to get the
TPKT payload".
svn path=/trunk/; revision=4792
have a TPKT header at the beginning, so there's not need for it to have
an offset as an argument; its callers don't have to know how big the
TPKT header is (or we can put a #define in "packet-tpkt.h" for it). Get
rid of the second argument.
svn path=/trunk/; revision=4791
packets per segment.
Instead of having a routine for dissectors such as the Q.931 dissector
to call to dissect the TPKT header, have a routine that does all the
reassembly and multiple-packets-per-segment work, and have the Q.931
dissector call it. Export "is_tpkt()", and the new routine, to plugins.
Add preferences for TPKT and Q.931 reassembly.
svn path=/trunk/; revision=4778
Have the Q.931 PDU dissector, if it's Q.931-over-TPKT, check for
user-user IEs with a protocol discriminator of "X.208 and X.209 coded
user information" and, if it sees one, call an H.225.0 Call Setup
dissector if it could find the handle for it.
svn path=/trunk/; revision=4723
dissector, it's looking for Q.931 encapsulated inside TPKT, so it
shouldn't check whether the first byte is NLPID_Q_931 or not, as it
*won't* be NLPID_Q_931, it'll be 3, for the TPKT version. It should
first check whether "is_tpkt()" thinks it's a TPKT packet, and then
check that the packet has at least 3 bytes past the TPKT header, then
check the first byte in the payload to see whether it's NLPID_Q_931. If
that all succeeds, treat it as Q.931 inside TPKT.
Make "is_tpkt()" return the length from the TPKT header on success, and
-1 on failure, and return the offset past the TPKT header via a pointer
(so clients don't have to know that the TPKT header is 4 bytes long).
svn path=/trunk/; revision=4669
arguments to "proto_tree_add_text()", and to "proto_tree_add_XXX()" calls
that add FT_NONE or FT_PROTO items to the protocol tree, with -1.
Replace some calls to "tvb_length()" or "tvb_length_remaining()" with
calls to "tvb_reported_length()" and "tvb_reported_length_remaining()",
as those give the actual length of the data in the packet, not just the
data that happened to be captured.
svn path=/trunk/; revision=4605
"epan/..." pathnames, so as to avoid collisions with header files in any
of the directories in which we look (e.g., "proto.h", as some other
package has its own "proto.h" file which it installs in the top-level
include directory).
Don't add "-I" flags to search "epan", as that's no longer necessary
(and we want includes of "epan" headers to fail if the "epan/" is left
out, so that we don't re-introduce includes lacking "epan/").
svn path=/trunk/; revision=4586
structure to the "packet_info" structure; only stuff that's permanently
stored with each frame should be in the "frame_data" structure, and the
"column_info" structure is not guaranteed to hold the column values for
that frame at all times - it was only in the "frame_data" structure so
that it could be passed to dissectors, and, as all dissectors are now
passed a pointer to a "packet_info" structure, it could just as well be
put in the "packet_info" structure.
That saves memory, by shrinking the "frame_data" structure (there's one
of those per frame), and also lets us clean up the code a bit.
svn path=/trunk/; revision=4370
Guy Harris