Commit Graph

46356 Commits

Author SHA1 Message Date
Tomasz Moń 5e3d77761b
USBLL: Do not reassemble across reset boundary
Invalidate endpoint info on SET ADDRESS to prevent reassembly and/or
retransmission detection across reset boundary.

Leave endpoint info intact when assigning default address (0) to avoid
issues related to unknown control endpoint max packet size. Only control
transfers are allowed to address 0 so this should pose no issues.
2023-01-28 10:54:40 +01:00
David Fort bb8d183387 rdp_egfx: improve command parsing and packet browsing 2023-01-27 23:18:23 +01:00
David Fort bc40c57b82 rdp: fix zgfx decompression
This fixes a decoding error when the packet is not compressed.
2023-01-27 23:18:23 +01:00
Jorge Mora dbf5bf27d3 NFS: add NFSv4.1 CB_RECALL_ANY operation
Add support for CB_RECALL_ANY operation as given in the following:
RFC 5661 Network File System (NFS) Version 4 Minor Version 1 Protocol.
RFC 8435 Parallel NFS (pNFS) Flexible File Layout.

    Opcode: CB_RECALL_ANY (8)
        Objects to keep: 0
        Number of masks: 1
        Type mask: 0x00000001 (Read Delegation)
            Type: Read Delegation (0)
2023-01-27 11:17:15 -07:00
Ryan Doyle 48fa729a9c HTTP2: Track the frame the request/response is contained in
Similar to the HTTP dissector, link between the frames that contain the request
and response.
2023-01-26 19:37:34 +00:00
David Perry db010b5a27 Exported PDU dissector improvements 2023-01-26 18:02:23 +00:00
Martin Gallo ef2ea2acdd saprouter/saphdb: Fixing warnings due to multiple hf types
Fixed feedback from !9581
2023-01-26 09:12:53 +00:00
Samuel Wein 260f835eef Added Deutsche Telekom specific GREBonding dissection 2023-01-25 19:59:06 +00:00
Martin Gallo 48737e2983 SAPDIAG: Added SAP Diag as main dissector
Added the SAP Diag dissector protocol from [SecureAuth's plugin](https://github.com/SecureAuthCorp/SAP-Dissection-plug-in-for-Wireshark/blob/master/src/packet-sapdiag.c).

This is a dissector that implements the Diag protocol. Decompression of packets is not considered as this requires the proprietary LZC/LZH decompression routines still pending to be added in #8973. The Diag packets can be wrapped in an SNC frame, in which case the respective dissector is called. Embedded RFC calls are disabled as this requires the respective dissector to be found, which will be submitted in a separate merge request.

Details about the protocol and example requests can be found in [pysap's documentation](https://pysap.readthedocs.io/en/latest/protocols/SAPDiag.html).
2023-01-25 17:06:27 +00:00
Martin Mathieson b1b180fd9e Fix some spelling errors. 2023-01-25 10:52:18 +00:00
Martin Gallo 13b6063d27 SAPRouter: Adding found passwords to the credentials tap
Adding info and route string passwords to the 'credentials' tap to find them easily.
2023-01-25 09:07:44 +00:00
Daniël van Eeden f0a066dd0d MySQL: Try to handle converstations w/o caps
If the server greeting and login packets weren't part of the captured packets we assume various capabilities were not set. This MR tries to make a better guess in those cases to allow dissection to work in most cases.
2023-01-25 06:57:27 +00:00
Mokhtar Ben Messaoud 9c3ce8e371 ieee1905: Update Profile-2 AP Capability TLV
update r2_ap_capa_flags (epan/dissectors/packet-ieee1905.c):
    - rename
        - hf_ieee1905_basic_service_prio_flag ==>
                    hf_ieee1905_ctag_service_prio_flag
        - hf_ieee1905_enhanced_service_prio_flag ==>
                        hf_ieee1905_dpp_onboarding_flag
    - add new flag hf_ieee1905_traffic_separation_flag:0x08
        used by r2_ap_capa_flags
    - update hf_ieee1905_r2_ap_capa_flags_reserved:0x07

as defined by Wi-Fi EasyMesh™ Specification Version 5.0 :
                17.2.48 Profile-2 AP Capability TLV format
2023-01-25 06:12:43 +00:00
Daniël van Eeden 0ba90d1249 MySQL: Reduce noise related to length encoded ints
Length encoded integers were:
- Reported as `mariadb.prefix` and `mariadb.length` but were not specific to MariaDB specific protocol features.
- These were reported in the UI as "Length" and "Prefix" and were in many cases the same as 1 byte integers are very common.
- These were often duplicating things like `hf_mysql_connattrs_length`, `hf_mysql_connattrs_name_length`, etc which meant that the same length was often reported 3 times in the interface.
2023-01-24 17:43:06 +00:00
Dr. Lars Völker 2d2528cc2f UDS: Support OBD Services in UDS Service Error
Since OBD uses the UDS Service Error, it needs to resolve the OBD
Service IDs too.
2023-01-24 14:16:07 +00:00
Dr. Lars Völker cf3d5fad5a UDS: Fix Typo in Error Service
The response code is short NRC, while SID is the Service ID.
2023-01-24 13:11:35 +00:00
Daniël van Eeden 8ec198c272 MySQL: Decode caching_sha2_password packets 2023-01-24 09:51:12 +00:00
Chuck Craft 06fc6483b3 twamp: test mbz fields are FT_UINT16 2023-01-23 20:16:54 -06:00
Daniël van Eeden 2691f87ef9 MySQL: Fix warning about incomplete dissector 2023-01-23 19:19:11 +00:00
Martin Mathieson 0d8f9f908a ORAN FH CUS: Update some vals[], and add subtree for bfwCompHdr 2023-01-23 15:09:58 +00:00
Alexis La Goutte 4d5a6e5c4a SMB2: Fix typo
Lock Sequence Number => Lock Sequence Index
2023-01-23 13:31:16 +00:00
Mokhtar Ben Messaoud 0b47fde866 WPS: Multi-AP Extension subelement: Profile 1/2 Backhaul STA assoc disallowed
Parse Multi-AP Extension subelement flags:
	- Profile-1 Backhaul STA association disallowed.
	- Profile-2 Backhaul STA association disallowed.
defined by Wi-Fi_EasyMesh_Specification_v5.0.pdf / Table 14
2023-01-23 11:28:54 +00:00
Martin Mathieson 7199a04c4c BTLE: Fix a copy/paste error in control_opcode_vals 2023-01-23 10:32:52 +00:00
Gerald Combs 6787835373 [Automatic update for 2023-01-22]
Update manuf, services enterprise numbers, translations, and other items.
2023-01-23 00:27:45 +00:00
Alexis La Goutte 3c97c2f226 BGP: Fix check warning
packet-bgp.c hf_bgp_ls_tlv_te_default_metric_value : - filter 'bgp.ls.tlv.te_default_metric_value' appears consecutively - labels are 'TE Default Metric (old format)' and 'TE Default Metric'
packet-bgp.c:4026 proto_tree_add_item called for hf_bgp_mcast_vpn_nlri_source_as  -  item type is FT_UINT16 but call has len 4
packet-bgp.c:4095 proto_tree_add_item called for hf_bgp_mcast_vpn_nlri_source_as  -  item type is FT_UINT16 but call has len 4
2023-01-21 14:57:33 +00:00
Joakim Karlsson dee461254b GTPv2: Track Session during Inter RAT Mobility signaling 2023-01-21 14:33:04 +00:00
Dylan Ulis 39d9c77109 ENIP: CPF format only applies to List responses 2023-01-21 13:34:09 +00:00
Martin Mathieson c84a54c82f Checked encoded values for proto_tree_add_item() 2023-01-21 11:16:20 +00:00
Alexis La Goutte 2bde511bb5 SMB2: Add (Request) Lock Sequence Number/Index
Close 18810
2023-01-21 01:01:46 +00:00
John Thacker b230aa1df0 epan: Do not add dependent packets more than once
Do not add a dependent frame if it's already been added to a
frame's list. Do not mark a frame as a dependent of a displayed
frame if we've already marked it as such in this pass.

Clear the list of dependent frames if we reset the frame data,
because the list of dependent frames depends on the dissection
and may not be valid if redissecting (because, for example,
a reassembly preference may have changed.)

Move the pointer to the list of dependent frames away from the
bitfields to a location that minimizes the struct size.

Fixup f870c6085d
Fix #18809
2023-01-20 16:16:47 +00:00
hidd3ncod3s f268ef2f17 Support for TDS SSPI Token parsing. 2023-01-20 15:01:36 +00:00
Martin Mathieson be51acfffb Fix some issues seen by tools/check_typed_item_calls.py 2023-01-20 12:47:59 +00:00
PMcL d45a733258 mako: Updated Metamako trailer dissection
Minor updates to some variable names and wording of fields.
2023-01-20 09:27:01 +00:00
Alexis La Goutte 8080189ff3 h261: remove if(tree) check
not longer needed
2023-01-20 07:36:05 +00:00
Alexis La Goutte d4932b3313 h261: Remove extra space 2023-01-20 07:36:05 +00:00
Alexis La Goutte 1844094e07 H261: Fix encoding of H261 vmvd
Close #18812
2023-01-20 07:36:05 +00:00
John Thacker c380f516a2 GTP, GTPv2: Add request/response framenum types
Add the appropriate FT_FRAMENUM string types to the request
and response fields for GTP and GTPv2, so that arrows are
drawn for the related packet symbols.
2023-01-20 00:51:19 +00:00
Sergey V. Lobanov 4d2d0b7f6d MP4: add support for segment boxes (styp, sidx)
sidx and styp boxes are implemented according to 3GPP TS 26.244
Both boxes are added as mp4 magic bytes due to mp4 segments start from them

pcap and mp4 samples: https://wiki.wireshark.org/SampleCaptures#mp4-init-segments-and-segments
2023-01-19 17:59:50 +00:00
Kevin Grigorenko 43c5eedc97 Handle NULL http2_session_t parsing an H2 settings frame 2023-01-19 17:35:48 +00:00
João Valverde 74909f1499 Install PDML files to DOCDIR
Add README because this stuff is somewhat obscure and move XSLT
file to DOCDIR because it is not used by wireshark directly.
2023-01-19 17:08:36 +00:00
Jorge Mora ae4868f4bd NFS: fix IO_ADVISE hints mask
Use correct tree for hints mask in IO_ADVISE so it is displayed
properly within the operation.
2023-01-19 15:40:38 +00:00
John Thacker 1dac8660fc DHCP: Use BASE_CUSTOM for formatting time options
Use BASE_CUSTOM and custom formatting functions for formatting
DHCP options that are time fields, instead of
proto_tree_add_uint_format_value(). This makes the formatted form
show up in columns.

Fix #18743
2023-01-19 09:41:55 +00:00
Mikael Kanstrup c4db402db5 Add follow websocket stream support
The websocket protocol masking feature makes follow TCP stream
on websocket traffic show masked payload. To easily view unmasked
and reassembled websocket payload add follow websocket stream
support.
2023-01-19 03:14:18 +00:00
João Valverde a5eb85a1d6 Revert "ORAN FH CUS: Add subtree for bfwCompHdr"
This reverts commit 2c5f2e40fc.
2023-01-18 19:19:32 +00:00
Martin Mathieson 2c5f2e40fc ORAN FH CUS: Add subtree for bfwCompHdr 2023-01-18 14:59:17 +00:00
John Thacker b1f50b0b68 DNS: Add reverse DNS (PTR) answers to Resolved Addresses
If "use captured DNS packet data for name resolution" is enabled,
also use the information from PTR (reverse DNS) answers to fill
the hash table for IPv4 and IPv6 host resolution.

Fix #10036
2023-01-18 14:13:34 +00:00
Kevin Grigorenko b301dee0e1 Add HTTP2 connection and session window sizes 2023-01-18 07:04:53 +00:00
João Valverde fe7bfdf6ca CMake: Require explicit installation of development headers
Develpment headers are a sizeable part of the binary installation
and most users won't ever require them. It's recommended to package
them separately in a devel package or SDK.

Create a CMake installation component for development headers
and add the EXCLUDE_FROM_ALL property.

Headers can be installed using the invocation:

    cmake --install <dir> --component Development
2023-01-18 03:35:13 +00:00
João Valverde b801ea0191 MinGW: Fix -Wclobbered 2023-01-17 15:04:40 +00:00
Alexis La Goutte 3504b423b9 MySQL: Fix Dead Store Found by Clang Analyzer
Line 3728 Value stored to 'offset' is never read
2023-01-17 14:18:31 +00:00