Commit Graph

49 Commits

Author SHA1 Message Date
Anders Broman 7eac3c2879 From Alejandro Vaquero:
- Change the "listen_rtp" to "rtp_player"
- Change from a plugin to be part of the core
- By default it will not compile with the rtp_player. In order to 
compile it is necessary to:
       + For windows: uncomment the line 
"PORTAUDIO_DIR=$(WIRESHARK_LIBS)\portaudio_v18_1" in config.nmake
       + For linux: using the "--with-portaudio=yes"

svn path=/trunk/; revision=19094
2006-08-30 21:51:31 +00:00
Guy Harris 92552c2d76 Get rid of a bunch of "Ethereal"s and "ethereal"s in comments, GUI
strings, and function names.

svn path=/trunk/; revision=18205
2006-05-22 07:29:40 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Guy Harris 7db8eea5c6 Make the GUIDs in various data structures e_guid_t's rather than arrays
of 16 bytes.  Use "sizeof" for the size of e_guid_t's, and use structure
assignment to copy GUID values.

Make functions such as append_h225ras_call() and new_h225ras_call() take
pointers to e_guid_t's as arguments.

Define GUID_LEN in epan/guid-utils.h and use it as the length of a GUID
in a packet.  (Note that "sizeof e_guid_t" is not guaranteed to be 16,
although it is guaranteed to be the size of an e_guid_t.)

When constructing a display filter that matches a GUID, use
guid_to_str() to construct the string for the GUID.

svn path=/trunk/; revision=17676
2006-03-19 20:45:45 +00:00
Jaap Keuter e6ca05b8d8 From Laurant Rabret:
Please find enclosed 2 patches.
- Voip_calls_dlg.c.patch fixes a problem that appears with a release
compiled with GTK 2.8 + Visual Studio 2003. It seems g_snprintf can
corrupt memory when a length bigger than the array size is provided in
the second parameter (even if the generated string is smaller than the
array actual size!!)
- graph_analysis.c.patch fixes a memory corruption problem easy to
reproduce. Just open the pcap file enclosed, select "Statistics"->"Flow
Graph" and activate the "Network source/destination addresses" radio
button before pressing OK. You'll see a crash dump.
Thanks to check in
Best Regards
Laurent

svn path=/trunk/; revision=17543
2006-03-09 07:07:35 +00:00
Luis Ontanon fcf7b3789c add an userdata argument to register_stat_cmd_arg() and its callback to use the callback for multiple registrations.
svn path=/trunk/; revision=17252
2006-02-11 13:05:24 +00:00
Jaap Keuter 815a4af69e Hi All,
Find attached a couple of changes for t38:
- Use the dissector to reassemble t30 frames
- Dissect t30 protocol
- Move the "Fax t38 analysis" to the "VoIP Calls". Now when selecting
"Statistics"->"Fax t38 analysis" option, there is a message that
redirect the user to use the "Voip calls" instead. We may keep this
option for one release, and then remove it ?
- Added in the "Voip calls" the ability to detect a t38 call if there
are not signaling associated with it. For example, when using "Decode
as.." to dissect t38 packets, it is possible to use the "Voip calls" to                                                      analyze that call.
- Display "SDP (t38)" in the "Voip calls graph" for SDP t38 sessions.

Regards
Alejandro Vaquero


svn path=/trunk/; revision=17033
2006-01-15 15:01:14 +00:00
Jörg Mayer eff40f65db Trivial warning fixes
svn path=/trunk/; revision=16561
2005-11-22 12:51:14 +00:00
Guy Harris f34e1a97c6 Have cf_retap_packets() take an argument that indicates whether to
generate columns; use cf_retap_packets instead of cf_redissect_packets()
when running taps (the general flow graph stat uses the Info column).

svn path=/trunk/; revision=15793
2005-09-14 08:59:41 +00:00
Guy Harris 13e0b409cf As per a suggestion by Ulf Lamping, rename gtk_*.[ch] to gui_*.[ch], so
that it doesn't appear to be part of GTK+.

svn path=/trunk/; revision=15501
2005-08-21 19:24:11 +00:00
Guy Harris 195c549d1a Have "register_dfilter_stat()" add "..." to the menu item, as all menu
items registered with it pop up a dialog box before displaying the stat.
Don't pass a name with "..." to it.

Put "..." into other menu items that pop up a dialog box before
displaying the stat; remove "..." from other menu items that don't.

svn path=/trunk/; revision=15495
2005-08-21 10:29:47 +00:00
Guy Harris a0e68da918 Add a "register_dfilter_stat()", to register stats that take a display
filter as an argument on the command line and have a dialog box to enter
the display filter through the GUI.  Use it for all stats using
"gtk_tap_dfilter_dlg_cb()".

Add a top-level "stat_menu.h" file to declare "REGISTER_STAT_GROUP_E"
for the benefit of the declaration of "register_dfilter_stat()" in the
top-level "tap_dfilter_dlg.h".  Rename the "stat_menu.h" in the gtk
directory to "gtk_stat_menu.h", so as not to have two headers with the
same name.

Get rid of headers not declaring any functions not being used in the
module.

svn path=/trunk/; revision=15493
2005-08-21 09:48:27 +00:00
Guy Harris 50d77b113c Rename epan/stat.[ch] to epan/stat_cmd_args.[ch] - it only deals with
implementing the "-z" command-line arguments, it doesn't deal with *all*
issues for stats.

svn path=/trunk/; revision=15483
2005-08-20 20:06:05 +00:00
Jörg Mayer 0edcc8920e - Declare some functions static
- Add plugins_dlg.h
- Include .h files in their respective .c files
- Include .h and remove extern declarations in .c files
- set eol-style and keywords on gui_utils.[hc]

svn path=/trunk/; revision=15471
2005-08-20 14:02:00 +00:00
Ulf Lamping eafbbbcabb renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical named ui_util.h in / dir
svn path=/trunk/; revision=15465
2005-08-20 12:09:48 +00:00
Guy Harris 4ddd504bb4 Move the stats.[ch] stuff into epan, so plugins can use it.
svn path=/trunk/; revision=15429
2005-08-19 10:00:14 +00:00
Guy Harris b2807e2ab6 Move the APIs for registering and processing "-z" command-line arguments
and "Statistics" menu items into "stat.h" and "stat.c", to separate them
from the core tapping APIs.  A tap could conceivably not register as a
"-z" command-line argument or "Statistics" menu item, and a stat could
conceivably not be implemented as a tap, and dissectors that implement
tapping points don't need the UI-related stuff from "stat.h", they just
want the tap-related stuff in <epan/tap.h>.

svn path=/trunk/; revision=15427
2005-08-19 09:29:41 +00:00
Jörg Mayer 62b7cc3043 Last set of char -> const char trivial warning fixes.
svn path=/trunk/; revision=15244
2005-08-06 14:03:14 +00:00
Guy Harris 5fb6e97fb4 Squelch more const warnings (and fix some memory leaks that found).
_U_-ify some unused arguments, rather than assigning them to themselves.

Un-constify one variable that gets assigned a mallocated pointer.

Clean up indentation.

svn path=/trunk/; revision=15236
2005-08-06 03:44:55 +00:00
Guy Harris a95d1209eb Squelch a compiler pointer vs. integer warning - NULL is for pointers,
'\0' is for characters.

svn path=/trunk/; revision=14868
2005-07-07 04:05:01 +00:00
Anders Broman c8b69874cb From Alejandro Vaquero
- avoid the clist of the calls dlg to be refreshed multiple times when 
first appear.
- destroy the Graph window when the data is not valid anymore.
- fixes an H245 packet count error
- resizing the Graph windows when is displayed (up to 5 columns).
With a change to leave static voip_calls_tapinfo_t the_tapinfo_struct =
	{0, NULL, 0, NULL, 0, 0, 0, 0, NULL, 0, 0, 0, 0, 0, 0, 0, 0, 0};
alone.

svn path=/trunk/; revision=14852
2005-07-05 05:16:28 +00:00
Guy Harris 3f01c028ba "Handle" a couple of cases in the switch statement by adding them to the
"not supported" case, to suppress compiler warnings.

svn path=/trunk/; revision=14811
2005-06-28 22:01:18 +00:00
Anders Broman 8d5958785d From Alejandro Vaquero
new dissector for the AudioCodes trunk trace protocol. 
This protocol is used to debug the trunk protocol in AudioCodes 
gateways. It currently supports ISDN PRI and CAS (MFCR2, WinkStart, 
etc...) trunk protocols. It also add these protocols in the "Voip Calls 
Graph..."

svn path=/trunk/; revision=14789
2005-06-27 06:20:23 +00:00
Anders Broman 5e3a716014 From Javier Acuna
patch to include Cic info in Voip Calls

svn path=/trunk/; revision=14630
2005-06-14 21:48:42 +00:00
Ulf Lamping 4a2cdd3f42 add missing #include "webbrowser.h" from previous commit
svn path=/trunk/; revision=14614
2005-06-11 16:50:18 +00:00
Ulf Lamping f20b5b0a32 add help button pointing to the wiki page
svn path=/trunk/; revision=14611
2005-06-11 12:12:12 +00:00
Anders Broman a67a1fb29b Back out the two last changes by popular demand :)
as we don't want multiple language versions.

svn path=/trunk/; revision=14433
2005-05-25 18:27:33 +00:00
Guy Harris ea838882e6 Include "webbrowser.h" to declare "browser_open_url()".
svn path=/trunk/; revision=14423
2005-05-24 01:28:25 +00:00
Anders Broman b91e9cb311 From Javier Acuna:
It adds "CIC" info display on the comments column for ISUP
It adds a small Help button that open up a window that offers you to vist the Wiki page containing the explanation of the Dialog window.


svn path=/trunk/; revision=14410
2005-05-21 09:26:16 +00:00
Ulf Lamping e571cbfa9d add 12 new toolbar/menu icons
add two toolbar toggle buttons
add icons to various menu items

create new Statistics telephony group and put telephony and alike protocols in it

svn path=/trunk/; revision=14098
2005-04-16 10:53:09 +00:00
Guy Harris 80c1907a36 Rename "register_ethereal_tap()" to "register_tap_listener_cmd_arg()" as
it's used to register a callback for a tap listener invoked if the
specified command line argument is specified to the "-z" flag.

Move it, along with routines to:

	look up a "-z" argument in the table constructed by
	"register_tap_listener_cmd_arg()" and either save the full
	argument to "-z" and the corresponding listener if it's found or
	return a failure indication if it isn't;

	list the available tap listeners;

	call the "init" routines for the tap listeners saved in the
	table above;

and have Ethereal and Tethereal use those routines.

svn path=/trunk/; revision=13993
2005-04-01 09:08:27 +00:00
Luis Ontanon 008054453b From Alejandro Vaquero:
- Automatic dissection of RTP events (RFC2833) set in SDP sessions.
- Add RTP events (RFC2833) to the Voip Graph


svn path=/trunk/; revision=13697
2005-03-10 19:32:22 +00:00
Jörg Mayer 9804663036 Trivial warning fixes
svn path=/trunk/; revision=13691
2005-03-10 12:43:35 +00:00
Guy Harris ae622c416d From Francisco Alcoba: don't generate long filter expressions, fall back
to the old filter mechanism if the filter expression is too long.

svn path=/trunk/; revision=13675
2005-03-09 10:12:05 +00:00
Luis Ontanon e968b0c066 From Francisco Alcoba:
- Correct the order of the calls in the VoIP Calls dialog when ordering by time fields
 - Prevent an assertion when ordering on the last columns


svn path=/trunk/; revision=13649
2005-03-07 11:01:16 +00:00
Lars Roland 2ed9ca813b By Francisco Alcoba:
Support for name resolution and IPv6 in VoIP Call Analysis

svn path=/trunk/; revision=13501
2005-02-24 21:31:20 +00:00
Luis Ontanon 516d559fe8 From Alejandro Vaquero
voip_calls_dlg.c
    Change the "prepare filter" function to be protocol independent. Now it uses the
    "frame_num"s  from the Graph structure to create the filter. This also add support
    to MGCP and H323 LRQ/LCF filters that were not supported before.

graph_analysis.c:
    Change the mouse scroll wheel implementation to make a 3 line step change instead of 1 line.


svn path=/trunk/; revision=13489
2005-02-24 04:15:40 +00:00
Ulf Lamping d86cad09bd some changes to the dialog's button behaviour
svn path=/trunk/; revision=13467
2005-02-22 07:31:19 +00:00
Lars Roland b65e9739d2 Don't register mgcp taps,
when we haven't loaded the mgcp plugin.

and

From Alejandro Vaquero:
mgcp support for the voip call analysis tap

svn path=/trunk/; revision=13447
2005-02-20 15:53:11 +00:00
Guy Harris ffc29da21e Add #includes to define various macros and declare various functions.
svn path=/trunk/; revision=13403
2005-02-14 22:06:22 +00:00
Lars Roland aec5f71469 remove a bunch of unnecessary "includes" from VoIP tap and graph analysis sources
svn path=/trunk/; revision=13392
2005-02-13 23:30:56 +00:00
Anders Broman c765d211e9 From Alejandro Vaquero :
Find attached a patch for "Voip analysis" to get the LRQ/LCF/LRJ messages included in the H323 calls for Gatekeeper to Gatekeeper configurations

svn path=/trunk/; revision=13336
2005-02-07 08:56:39 +00:00
Anders Broman c00014119d From Alejandro Vaquero:
a patch that to shows the RTP streams in the Graph. Now 
using an RTP tap (not using the rtp_stream).

svn path=/trunk/; revision=13299
2005-02-05 11:07:21 +00:00
Ulf Lamping 0861927ce3 huge cleanup of capture file API (functions in file.c/file.h).
This includes: all functions in file.h now have a cf_ prefix, will have doxygen tags, will have the capture_file *cf as the first parameter and I tried to generalize the return values for non trivial functions.

Hopefully, I didn't introduced any new bugs, as I had to change a lot of files...

svn path=/trunk/; revision=13289
2005-02-04 18:44:44 +00:00
Guy Harris 26c2759ebc Get rid of an unused typedef.
svn path=/trunk/; revision=13239
2005-02-02 10:19:35 +00:00
Guy Harris 0c5d6e35ee Don't assume that the only blank filter expression is empty - check for
an all-space-character string.

Don't use "filter_string" both for the (unfreeable, unmodifiable) value
fetched from the text entry and the new filter expression; use it only
for the former, and make it a "const" pointer to avoid compiler
warnings.

Use a GString to construct the stuff to be added to the new filter
expression - the old code, when appending stuff to the filter expression
in a loop, would leak the pre-append value.

svn path=/trunk/; revision=13237
2005-02-02 08:53:08 +00:00
Guy Harris d393884422 "filter_string_fwd" is assigned a "const" pointer, so make it a "const"
pointer.

svn path=/trunk/; revision=13233
2005-02-02 08:01:27 +00:00
Lars Roland 70eb306bb2 for VoIP Call Analysis:
- make VoIP Call Analysis work if, called from command line
- should also work now while capturing with packet list
  updated in "real time" (to be tested)
- give each tap listener a unique identifier, so ethereal
  won't mix them up
- various cleanups
- compile by default

Todo:
- add support for "tap display filter"
- reimplement function to add rtp streams to the call flow.
 

svn path=/trunk/; revision=13232
2005-02-02 01:02:09 +00:00
Lars Roland 197ceddab1 From Alejandro Vaquero:
h323 taps support up to 5 messages per packet now.

VoIP call analysis:
      - Collect ISUP, SIP and H323 calls from a capture and show them in window with the following info:
      - Start and Stop time of the call
      - Init

svn path=/trunk/; revision=13225
2005-02-01 12:12:35 +00:00