Stig Bjørlykke
e08522f0dd
From Florian Lohoff (bug 2959):
...
rudp looks up the ciscosm dissector for every single packet. Make this a one
time in proto_handoff and use the dissector handle.
While at it - decode the checksum when there is one. An indicator is that the
header length has space for the checksum.
Additionally we have seen "stray bytes" after the checksum we can't explain. So
decode them as data when there are some.
svn path=/trunk/; revision=26427
2008-10-13 12:55:16 +00:00
Guy Harris
ef51ff82fb
Get one more pointer difference.
...
svn path=/trunk/; revision=26163
2008-09-07 17:49:03 +00:00
Guy Harris
bdec87026c
To compute the difference between two addresses, cast the pointers
...
holding those addresses to "void *" and then to "char *" (so we don't
get warnings from casting directly to "char *" or errors from
subtracting two "void *"s), and subtract them, rather than casting the
pointers to an integral type possibly shorter than the pointers (to
avoid warnings and to avoid the admittedly-infinitesimal chance that the
two pointers don't differ in the bits that fit into the integral type).
svn path=/trunk/; revision=26151
2008-09-06 18:27:33 +00:00
Guy Harris
768b822f9b
Use GINT_TO_POINTER() to cast integral values to gpointer in
...
g_hash_table_lookup() calls, in the hopes of suppressing warnings on
platforms with 32-bit ints and 64-bit pointers.
svn path=/trunk/; revision=26149
2008-09-06 17:27:20 +00:00
Bill Meier
a3a9ff5a2b
#include <prefs.h> not required
...
svn path=/trunk/; revision=26103
2008-08-29 01:40:32 +00:00
Bill Meier
4aa1788a3b
#include <emem.h> not req'd
...
svn path=/trunk/; revision=26095
2008-08-26 03:19:29 +00:00
Jaap Keuter
677ce2b209
From Frank Wang:
...
dl-map decoder error when decode HARQ_DLMAP_IE and normal IE.
svn path=/trunk/; revision=26020
2008-08-14 18:05:18 +00:00
Luis Ontanon
42c3239a1a
luis.ontanon@gmail.com => luis@ontanon.org
...
svn path=/trunk/; revision=25937
2008-08-05 21:03:46 +00:00
Martin Mathieson
ad16b7b403
Declare next_tvb volatile. This prevents the warning:
...
packet-infiniband.c:806: warning: variable 'next_tvb' might be clobbered by `longjmp' or `vfork'
seen with gcc 3.4.6 (building for 32-bits on a pentium 4).
svn path=/trunk/; revision=25916
2008-08-04 16:36:16 +00:00
Anders Broman
e2070d0efb
From Stephen Donnelly:
...
Fences incorrectly set in source/destination columns in IB plugin.
svn path=/trunk/; revision=25880
2008-07-31 09:08:13 +00:00
Guy Harris
476c61472a
No C++ comments - some compilers don't allow them (at least not by default).
...
svn path=/trunk/; revision=25878
2008-07-30 19:11:28 +00:00
Anders Broman
de0ca39861
From Stephen Donnelly:
...
Infiniband Dissector Plugin 1.2.0
svn path=/trunk/; revision=25876
2008-07-30 15:47:11 +00:00
Anders Broman
c954861fe5
From Bruno Verstuyft:
...
DOCSIS3.0 support in wireshark (MDD, REG-REQ-MP, REG-RSP-MP)
svn path=/trunk/; revision=25875
2008-07-30 15:13:12 +00:00
Jeff Morriss
688abd6e54
Fix checkapi target for the plugins
...
svn path=/trunk/; revision=25864
2008-07-29 23:16:04 +00:00
Jeff Morriss
b4d2c37635
Allow checkapis target to work in out-of-tree builds (s#../../#$(top_srcdir)).
...
Also use $(top_builddir) instead of ../../ in a couple of other spots.
svn path=/trunk/; revision=25863
2008-07-29 22:06:37 +00:00
Martin Mathieson
7921dca80d
Fix DLMAP UL_interference_and_noise_level_IE decode error (bug 2737).
...
From Frank Wang.
svn path=/trunk/; revision=25816
2008-07-24 08:53:14 +00:00
Martin Mathieson
9c34677453
Fix HARQ_ULMAP_IE decoder padding error (bug 2738).
...
From Frank Wang.
svn path=/trunk/; revision=25815
2008-07-24 08:46:13 +00:00
Martin Mathieson
56455be25a
This file predominantly uses spaces, so remove tabs that were making
...
indentation look wrong in my editor.
svn path=/trunk/; revision=25805
2008-07-23 14:32:24 +00:00
Martin Mathieson
ee1534f851
Fix bug 2663 (DLMAP HAEQ_DLMAP_UE decode error).
...
From Frank Wang.
svn path=/trunk/; revision=25801
2008-07-23 11:18:33 +00:00
Bill Meier
e2e72c7664
Add NULL termination element to value_string arrays
...
svn path=/trunk/; revision=25799
2008-07-22 21:53:50 +00:00
Bill Meier
f2fd24c9c0
Change C++ style comments to C style ...
...
svn path=/trunk/; revision=25762
2008-07-18 02:48:37 +00:00
Sake Blok
53bee63aa1
Oops... missed one ;
...
svn path=/trunk/; revision=25740
2008-07-14 21:02:30 +00:00
Sake Blok
03e0f71e8f
From Richard Kuemmel (bug 2668):
...
Removed the line
tvb_ensure_bytes_exist(tvb, offset, 44);
from again.
This is not correct, because the frame might have been captured before the
os added the padding bytes. E.g. in Windows the frames are captured on the
protocol layer. When another protocol driver sends a frame this frame does
not include the padding bytes.
Also the dataLength variable in case of bMox==TRUE was not calculated
correctly.
svn path=/trunk/; revision=25738
2008-07-14 19:56:37 +00:00
Jeff Morriss
71c1e4faf0
Change the stats tree API to use signed chars instead of guint8s for all its
...
strings; this should fix a number of signed/unsigned char warnings.
Reindent a bunch, too.
svn path=/trunk/; revision=25716
2008-07-11 21:13:39 +00:00
Jaap Keuter
77c287a58c
From Frank Wang:
...
The ULMAP decoder can get a wrong bit offset when decoding CQICH_Alloc_IE.
The finishing position shoud not pad to byte but pad to the length specified,
which can be nibble aligned.
svn path=/trunk/; revision=25703
2008-07-11 16:03:06 +00:00
Martin Mathieson
5283264092
Fix bug 2662 (ULMAP HARQ_ULMAP_IE decode error).
...
From Frank Wang.
I'd prefer to delete wrong code, but we'll see if anyone misses it.
svn path=/trunk/; revision=25675
2008-07-08 16:05:41 +00:00
Guy Harris
a04774395f
Add Makefile.common files for epan/dfilter and epan/ftypes.
...
Add checkapi rules to Makefile.am files.
svn path=/trunk/; revision=25656
2008-07-02 01:44:30 +00:00
Guy Harris
40773753ad
Get rid of a misleading comment (it says "no need to modify anything
...
under here", right above a comment that tells you what you need to
modify under there...).
svn path=/trunk/; revision=25655
2008-07-02 01:43:50 +00:00
Guy Harris
b6e20d89be
Put printf into a separate "termoutput" API group. For most files,
...
check for it - but not for TShark plugins, as they are expected to
print to the standard output.
svn path=/trunk/; revision=25653
2008-07-01 21:13:32 +00:00
Gerald Combs
83aacf0a09
Add support for "API groups" in checkAPIs.pl. Make the "prohibited"
...
and "deprecated" groups the default. Add an "abort" group for code that
shouldn't exit the program. Update the makefiles to call "checkAPIs.pl
-g abort" for dissectors. Remove a dependency on "cat" in checkAPIs.pl.
svn path=/trunk/; revision=25614
2008-06-26 22:20:05 +00:00
Martin Mathieson
7001a1564b
For for compressed DLMAP decode error.
...
From Frank Wang (bug 2640).
svn path=/trunk/; revision=25599
2008-06-25 08:54:22 +00:00
Martin Mathieson
4aa522855d
Make sure info column is set correctly when tree == NULL.
...
Fixes but 2561.
svn path=/trunk/; revision=25530
2008-06-23 13:02:50 +00:00
Martin Mathieson
d2036aca8a
Try again to get labels matching function names.
...
svn path=/trunk/; revision=25529
2008-06-23 10:08:13 +00:00
Martin Mathieson
8d053ee86d
Fix wimax UL-MAP ext IE decode error.
...
From Frank Wang (bug 2548).
svn path=/trunk/; revision=25528
2008-06-23 09:24:32 +00:00
Martin Mathieson
89ed3a03bb
Wimax: support TLV type 48 in REG-REQ/REG-RSP.
...
From cfreeer, fixes bug 2571.
svn path=/trunk/; revision=25495
2008-06-20 15:55:32 +00:00
Martin Mathieson
2cddcc6b58
Fix wimax encoding err when packing subheader present.
...
From Frank Wang, fixes bug 2570.
svn path=/trunk/; revision=25494
2008-06-20 10:26:18 +00:00
Martin Mathieson
5da0fe48b0
Support TLV type 36 in wimax plugin.
...
From cfreeer (fix for bug 2569).
svn path=/trunk/; revision=25493
2008-06-20 10:17:13 +00:00
Ulf Lamping
bd8528644e
fix BlockError strings
...
svn path=/trunk/; revision=25490
2008-06-19 18:44:23 +00:00
Bill Meier
9a53920530
Do plugins Checkapi only if the checkapi target is explicitly invoked.
...
svn path=/trunk/; revision=25382
2008-05-27 02:14:14 +00:00
Martin Mathieson
03d7032acd
Show ops, etc even when no filter set.
...
Also avoid crash I was seeing when changing preferences.
svn path=/trunk/; revision=25379
2008-05-26 08:22:33 +00:00
Jaap Keuter
ab26f8d8a3
From cfreeer:
...
Wimax vals_tek_encryption_ids does not confirm the latest spec. Zero should be
"No TEK encryption" instead of "Reserved".
svn path=/trunk/; revision=25367
2008-05-23 05:36:09 +00:00
Jeff Morriss
a5cee04fad
Move the file utility functions from wiretap to libwsutil so that
...
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.
While doing that, rename the eth_* functions to ws_*.
svn path=/trunk/; revision=25354
2008-05-22 15:46:27 +00:00
Stig Bjørlykke
d1208e55e1
Initialize aitem.
...
svn path=/trunk/; revision=25302
2008-05-14 11:02:39 +00:00
Tomas Kukosa
1e82573549
fix missing brackets causing uninitialized hidden_item
...
svn path=/trunk/; revision=25300
2008-05-14 10:48:59 +00:00
Tomas Kukosa
19c327d160
From Anders Broman:
...
Patches for broken build
svn path=/trunk/; revision=25298
2008-05-14 10:21:41 +00:00
Stig Bjørlykke
38011c53da
From cfreeer (bug 2541):
...
Add tlv_tree for PKM_FLOW_CONTROL and MAX_SUPPT_SECURITY_ASSNS.
svn path=/trunk/; revision=25297
2008-05-14 08:46:47 +00:00
Stig Bjørlykke
fe1738c394
From cfreeer (bug 2540):
...
Corrected use of hf_snp_auth_policy_support.
svn path=/trunk/; revision=25296
2008-05-14 08:38:58 +00:00
Jaap Keuter
9b0b67d6bb
From cfreeer:
...
The offset need to be increased while decoding.
svn path=/trunk/; revision=25292
2008-05-14 05:52:32 +00:00
Anders Broman
d22975841b
Fix some of the Errors/warnings detected by checkapi.
...
svn path=/trunk/; revision=25283
2008-05-13 06:55:45 +00:00
Bill Meier
fe5c2d9820
g_string_sprintf --> g_string_printf and g_string_sprintfa --> g_string_append_printf
...
svn path=/trunk/; revision=25276
2008-05-11 18:33:49 +00:00