Commit graph

73 commits

Author SHA1 Message Date
Tim Potter
795926735d When dissecting specific rights, pass a name string down so the
proto item says "foo specific rights" instead of just "specific
rights".

svn path=/trunk/; revision=7401
2003-04-03 05:43:59 +00:00
Guy Harris
64991e3fa1 Have "dissect_ndr_counted_string()" add 2, not 1, to its argument, as it
adds 2 levels to the tree.  Fix calls to it not to add 1 for that level.

The NT and LM challenges in a NETWORK_INFO structure are opaque arrays
of bytes, not Unicode strings; dissect them as such, adding a new
routine "dissect_ndr_counted_byte_array()" for that purpose.

Get rid of some extra colons in names - the colon is put there if a
string is appended, so putting a colon in there explicitly gives double
colons.

Decorate some higher-level tree nodes with strings.

svn path=/trunk/; revision=7107
2003-02-08 09:41:44 +00:00
Guy Harris
e9f0f4b74f Rename "dissect_ndr_char_string()" and "dissect_ndr_wchar_string()" to
"dissect_ndr_char_cvstring()" and "dissect_ndr_wchar_cvstring()", to
indicate that they're for conformant varying strings.

Rename "dissect_ndr_character_array()" to "dissect_ndr_cvstring()", to
indicate that it's for conformant varying strings.

svn path=/trunk/; revision=7096
2003-02-07 22:44:54 +00:00
Guy Harris
9a348d5736 Rename "dissect_ndr_char_array" and "disect_ndr_wchar_array" to
"dissect_ndr_char_string" and "dissect_ndr_wchar_string", to make it
clearer what it does.

svn path=/trunk/; revision=7095
2003-02-07 22:31:32 +00:00
Guy Harris
5fbd5615c1 Decorate the top-level items for the account name in
POLICY_ACCOUNT_DOMAIN_INFO and the domain in TRUSTED_DOMAIN with the
string.

svn path=/trunk/; revision=7089
2003-02-07 08:33:07 +00:00
Guy Harris
6e33ba9d28 Decorate the top-level tree items for "LSA_TRANSLATED_NAME" and an
"LSA_TRUST_INFORMATION" with the account name.

svn path=/trunk/; revision=7088
2003-02-07 06:38:40 +00:00
Tim Potter
e15193fa72 Fix callers to dissect_nt_sec_desc() to use new function interface.
Dissection of security descriptors in SPOOLSS RPC calls now display
the correct meaning of the specific access mask bits.

svn path=/trunk/; revision=7087
2003-02-07 06:04:28 +00:00
Tim Potter
e2d77c2911 Remove out of date comment.
Display server name in COL_INFO for OpenPolicy2 request.

svn path=/trunk/; revision=7070
2003-02-04 05:22:41 +00:00
Tim Potter
6b8a47a691 Convert to new DCERPC string handling functions. There are still some
cosmetic bugs to work out though.

svn path=/trunk/; revision=7069
2003-02-03 02:14:01 +00:00
Guy Harris
892de6f27c Put in a missing assignment of the value of
"dissect_ndr_nt_UNICODE_STRING_cb()" to "offset".

svn path=/trunk/; revision=7061
2003-01-31 07:27:27 +00:00
Guy Harris
5dc66497b7 Generalize "cb_str_postprocess()" to allow the string to be appended to
items N levels up from the item being processed, and use that to
decorate the tree as it was decorated before.

svn path=/trunk/; revision=7043
2003-01-30 08:19:39 +00:00
Tim Potter
497042348b Display random useful tidbits in COL_INFO.
svn path=/trunk/; revision=7040
2003-01-30 05:38:56 +00:00
Tim Potter
1d6acba45c Convert dissector to callback based version of dissect_ndr_pointer().
Strings that used to call with levels != -1 should call the
callback helper which will append the string to the pointer item.

svn path=/trunk/; revision=7017
2003-01-28 06:39:41 +00:00
Guy Harris
522ef0a1b7 The LSA_REFERENCED_DOMAIN_LIST pointer in a LookupSIDs2 reply appears to
be a UNIQUE pointer, at least from one capture I'e seen, just as it is
in a LookupSIDs reply; make it so.

svn path=/trunk/; revision=6515
2002-10-28 20:12:30 +00:00
Ronnie Sahlberg
5f4545bce0 From Luke Howard: Bugfix for one NETLOGON command
svn path=/trunk/; revision=6348
2002-09-28 09:43:10 +00:00
Jörg Mayer
7c4176d868 Removed trailing whitespaces from .h and .c files using the
winapi_cleanup tool written by Patrik Stridvall for the wine
project.

svn path=/trunk/; revision=6117
2002-08-28 21:04:11 +00:00
Guy Harris
e495c4917e "lsa.key" is a Unicode string, and is ultimately put into the protocol
tree with "proto_tree_add_string()", so it has to have the type
FT_STRING, not FT_BYTES.

svn path=/trunk/; revision=6096
2002-08-27 19:02:51 +00:00
Tim Potter
50b37822a0 Some cleanups and fixes from Guy:
- combine proto_tree_add_text() and proto_tree_append_text() calls in the
   access mask dissector

 - make the specific access bits dissector functions return void instead of
   an offset

I think Samba has the create user reply wrong.  There is perhaps a uint32
marked as unknown that shouldn't be there.  Removing this parses all the
captures I have.

svn path=/trunk/; revision=6057
2002-08-22 01:13:13 +00:00
Tim Potter
bc792aa9a4 Call dissect_nt_access_mask() instead of dissect_ndr_uint32()
svn path=/trunk/; revision=6054
2002-08-21 21:31:15 +00:00
Ronnie Sahlberg
fb477fa5a9 Updated LSA. Function 2f is called SetInformationPolicy2
svn path=/trunk/; revision=5974
2002-08-09 09:27:33 +00:00
Guy Harris
7f881fdcd4 From Jim McDonough: support for LsaQueryInformationPolicy2 in the LSA
dissector.

svn path=/trunk/; revision=5924
2002-07-31 21:22:39 +00:00
Tim Potter
6d6dce305d Change each DCERPC dissector to pass in a hf value on initialisation
for a value_string that corresponds to that dissectors opnums.  Pass
in -1 if no such table is available.

svn path=/trunk/; revision=5749
2002-06-24 00:03:18 +00:00
Tim Potter
e77d6b098b Replace sub-dissector names with InterCaps names instead of the ugly
all caps version.

svn path=/trunk/; revision=5719
2002-06-21 02:17:32 +00:00
Ronnie Sahlberg
2cdcbf6d3c Added dissection of the request to NetrShareAdd
svn path=/trunk/; revision=5698
2002-06-18 13:18:30 +00:00
Tim Potter
501daf1770 Removed some trailing commas from various DCERPC dissectors.
svn path=/trunk/; revision=5604
2002-05-31 00:31:13 +00:00
Ronnie Sahlberg
259903dc66 Changed toplevel REF pointer dissection to create a subtree. Not creating a subtree was a design mistake which caused ugliness in the unicode string str dissector and in other places.
Dissectors will temporarily have less pretty output for topleve ref pointers until their output is retuned.

svn path=/trunk/; revision=5573
2002-05-27 09:50:58 +00:00
Guy Harris
6a79ad7e91 In "dissect_nt_policy_hnd()":
add arguments to specify whether the policy handle is being
	opened or closed, and don't set the "open frame" for the handle
	unless it's being opened and don't set the "close frame" for the
	handle unless it's being closed;

	store the policy handle before fetching it, so that an open or
	close is marked appropriately in the protocol tree on the first
	pass;

	if the policy handle has a name associated with it, put that
	name into the top-level item for the policy handle.

In "packet-dcerpc-spoolss.c":

	get rid of aun unused variable;

	make "setjob_commands[]" static, as it's not used outside
	"packet-dcerpc-spoolss.c";

	put a "VALS()" call around the reference to "setjob_commands",
	to squelch compiler warnings;

	give the SPOOLSS return code field the appropriate
	"value_string" array.

svn path=/trunk/; revision=5448
2002-05-11 22:29:43 +00:00
Ronnie Sahlberg
aec8996522 Added LSA functions 0x38 and 0x3b. These were the two last LSA functions and now
all functions described in lsarpc.idl had been implemented.

svn path=/trunk/; revision=5351
2002-05-02 08:47:23 +00:00
Ronnie Sahlberg
67682ad896 Added LSAEnumerateTrustedDomainsEX and LSACreateTrustedDomainEX
svn path=/trunk/; revision=5350
2002-05-02 08:38:24 +00:00
Ronnie Sahlberg
49c9f431a0 Added LSAGetUserName
svn path=/trunk/; revision=5349
2002-05-02 08:18:53 +00:00
Ronnie Sahlberg
478548e282 Added LSALookupSIDs2
svn path=/trunk/; revision=5346
2002-05-02 06:46:31 +00:00
Ronnie Sahlberg
6c963907d9 Added LSACloseTrustedDomainEX
svn path=/trunk/; revision=5345
2002-05-02 06:33:39 +00:00
Ronnie Sahlberg
9dba75997a Added LSAStorePrivateData and LSARetrievePrivateData
svn path=/trunk/; revision=5344
2002-05-02 06:21:52 +00:00
Ronnie Sahlberg
9eee5a67be Added LSALookupPrivilegedDisplayName
svn path=/trunk/; revision=5343
2002-05-02 06:13:07 +00:00
Guy Harris
a06dd1c724 From Joerg Mayer: get rid of unused "pinfo" argument to
"dissect_nt_sec_desc()".

Also, get rid of code to handle lengths of -1 in "dissect_nt_sec_desc()"
- we never pass it a length of -1, as security descriptors aren't sent
over the wire with NDR syntax.

svn path=/trunk/; revision=5317
2002-04-30 23:48:15 +00:00
Ronnie Sahlberg
3db3147785 Added LSACreateAccount
svn path=/trunk/; revision=5310
2002-04-30 10:17:53 +00:00
Ronnie Sahlberg
f4699e7346 Added LSALookupNames2
svn path=/trunk/; revision=5309
2002-04-30 10:14:34 +00:00
Ronnie Sahlberg
7eae4eaa8c Added LSAFunction_2e , LSAFunction_2f, LSAQueryDomainInformationPolicy and LSASetDomainInformationPolicy
svn path=/trunk/; revision=5308
2002-04-30 10:02:11 +00:00
Ronnie Sahlberg
1812a849c9 Added LSAOpenTrustedDomainByName
svn path=/trunk/; revision=5307
2002-04-30 09:46:48 +00:00
Ronnie Sahlberg
d4f5fe8249 Added LSAQueryTrustedDomainInfo and LSASetTrustedDomainInfo
svn path=/trunk/; revision=5306
2002-04-30 09:40:41 +00:00
Ronnie Sahlberg
1931eb5880 Added LSAQueryTrustedDomainByName and LSASetTrustedDomainByName
svn path=/trunk/; revision=5305
2002-04-30 09:35:10 +00:00
Guy Harris
9a80f0a521 Removal (or, at least, #ifdeffing out) of unused variables and
functions, from David Frascone.

svn path=/trunk/; revision=5288
2002-04-29 08:20:18 +00:00
Ronnie Sahlberg
6c553bf998 Added LSAAddAccountRights and LSARemoveAccountRights
svn path=/trunk/; revision=5286
2002-04-29 06:23:03 +00:00
Ronnie Sahlberg
3508d634d9 Added LSAEnumerateAccountRights
svn path=/trunk/; revision=5285
2002-04-29 06:15:31 +00:00
Guy Harris
8729e8b514 From Ronnie Sahlberg: the LSA_REFERENCED_DOMAIN_LIST pointer in a
LsaLookupNames reply appears to be a UNIQUE pointer rather than a REF
pointer.

svn path=/trunk/; revision=5284
2002-04-29 01:25:51 +00:00
Ronnie Sahlberg
67bb2c4457 Added LsaDeleteObject and LSAEnumerateAccountsWithUserRight
svn path=/trunk/; revision=5269
2002-04-28 10:33:30 +00:00
Ronnie Sahlberg
faa2c52f4d Added LSAOpenSecret, LSASetSecret and LSAQuerySecret
svn path=/trunk/; revision=5268
2002-04-28 10:24:40 +00:00
Ronnie Sahlberg
a665066485 Added LSAQueryInfoTrustedDomain and LSASetInfoTrustedDomain and support functions
svn path=/trunk/; revision=5267
2002-04-28 10:09:25 +00:00
Ronnie Sahlberg
18e5ef9640 LSAOpenAccount added according to lsarpc.idl
svn path=/trunk/; revision=5266
2002-04-28 07:06:30 +00:00
Ronnie Sahlberg
5937b3db4c LSACreateSecret added according to lsarpc.idl
svn path=/trunk/; revision=5265
2002-04-28 07:00:06 +00:00