Alfredo
ddab0457f0
FTP: Add initial support for TLS
...
Add support for the AUTH TLS command as per RFC 2417 adding the new field tls_requested to FTP conversation, as soon as the 234 response code is received start the TLS communications
2021-05-29 07:42:07 +00:00
Dr. Lars Völker
642d1ca97d
MKA: Stop warning for MKA v3
...
IEEE 802.1X-2020 defined MKA version 3, so the MKA dissector should
not warn that this version does not exist anymore.
2021-05-29 07:26:55 +00:00
Michael Tuexen
96aa5d9b68
macos-setup.sh: update sparkle
2021-05-29 01:41:15 +02:00
Gerald Combs
a72b60b58b
GitLab CI: Add CMake sections in more places.
...
Add section start and end markers for cmake in more places.
2021-05-28 18:39:28 +00:00
Thomas Dreibholz
5107ece526
Bugfix: Added Analyze -> SCTP -> Filter this Association
...
Analyze -> SCTP -> Filter this Association was missing in the menu, but available in the context menu for packets. This MR fixes the issue by adding Analyze -> SCTP -> Filter this Association again.
2021-05-28 16:35:05 +00:00
Thomas Dreibholz
08f1d27a9b
Using G_GUINT64_FORMAT for printing DCCP sequence numbers.
2021-05-28 14:28:21 +00:00
Thomas Dreibholz
8dc0e42721
DCCP: Added preferences setting for relative sequence numbers.
2021-05-28 14:28:21 +00:00
Thomas Dreibholz
6928241b30
DCCP: Added support for displaying relative sequence numbers.
2021-05-28 14:28:21 +00:00
Thomas Dreibholz
d7fb8c0bf7
Bugfix: Added Analyze -> Follow -> DCCP Stream again.
...
Analyze -> Follow -> DCCP Stream was missing in the menu, but available
in the context menu for packets. This MR fixes the issue by adding
Analyze -> Follow -> DCCP Stream again.
2021-05-28 14:00:11 +00:00
João Valverde
ce41dee302
Add Qt runtime version to about dialog
2021-05-28 13:40:06 +00:00
Stig Bjørlykke
6f72d738de
exported_pdu: Add a new TAG for p2p_dir
...
Add a new exported_pdu TAG to specify pinfo->p2p_dir.
2021-05-28 12:43:21 +00:00
Anders Broman
e1e2aaf91a
Geographical description, correct the bitmask.
2021-05-28 12:19:15 +00:00
João Valverde
1dba58789d
dfilter: Fix handling of escaped quotes in macros
...
We can't unescape characters when expanding a display filter macro.
The escaping must be preserved until the expression is evaluated in
the display filter engine, otherwise it will likely generate a syntax
error in the parser.
In the macro body we allow '$' (or any other char) to be escaped
with backslash (preserving the backslash).
Fixes #17160 .
2021-05-28 10:36:41 +00:00
Constantine Gavrilov
8d60d8c4f2
NVMe: decode Set Fatures data transfers.
...
This closes #17407 .
2021-05-28 08:45:26 +00:00
Constantine Gavrilov
e75998cded
NVMe: decode Set Fatures response (DWORD0) in CQE.
2021-05-28 08:45:26 +00:00
Constantine Gavrilov
d5c1bd9d93
NVMe: refactor CQE decoding to decode all fields and decode comand status.
2021-05-28 08:45:26 +00:00
Constantine Gavrilov
12ddec82bf
NVMe: decode Set Features DWORD11 and DWORD12 for each feature.
2021-05-28 08:45:26 +00:00
Constantine Gavrilov
f0b83585c1
NVMe: decode Set Features command.
2021-05-28 08:45:26 +00:00
Constantine Gavrilov
6755309958
NVMe: refactor command parsing to always print DWORD10-DWORD15.
2021-05-28 08:45:26 +00:00
Thomas Dreibholz
03921ac668
DCCP: Lookup of service code for DCCP Request and Response.
2021-05-28 04:22:29 +00:00
JanTheMan
108b816fcc
doip: make version hdr for ISO13400-2:2019 usable
...
the already provided defines for the latest ISO version have been made
usable for the version detection in the protocol header
2021-05-28 03:14:58 +02:00
Richard Sharpe
fa89a8f673
ieee80211: Fix an infinite loop in the HE Trigger handling.
...
fixes #17410
Change-Id: I04ce052722f3ed62eb36b8894ee7d67d7c522f94
2021-05-27 19:26:30 +00:00
João Valverde
9dbe29e2ec
Minor style change to libpcap version string
2021-05-27 17:40:01 +00:00
Michael Tuexen
a889e8e04b
macos-setup.sh: improve arm support
...
Disable on arm the usage of assember code in nettle and sbc, since this
doesn't compile (yet) on arm platforms.
2021-05-27 14:18:45 +02:00
Lin Sun
5f338e5f1b
opus: fix dissector error for win32 build
...
* packet-opus.c: the array for proto_tree_add_bitmask_list should end with NULL
2021-05-27 07:12:01 +00:00
Kirill Smorodinnikov
dde67b0182
PCEP: Fixing PATH-SETUP-TYPE-CAPABILITY padding offset
...
Fix offset of padding in PATH-SETUP-TYPE-CAPABILITY TLV. The offset was incorrect.
2021-05-27 06:13:12 +00:00
Lin Sun
7f63556627
opus: fix build error on MacOS for commit ecd1ab5b23
2021-05-27 05:13:25 +00:00
John Thacker
1513237d10
DVB-S2-BB: Add preference for default mode adaptation format
...
DVB Baseband Frames have four possible mode adaptation formats, and
the check to distinguish them depends on only a CRC-8, so it's possible
to have ambiguity, particularly in a large capture. Add a preference to
for preferred format, defaulting to the SatLabs L.3 mode, since that's
the most common format I've seen in captures or in datasheets for
BBFrames over UDP or RTP. Also make L.3 the second highest preference
when something else is set to the default.
2021-05-26 21:57:05 -04:00
John Thacker
17f2fc32f7
tshark: Correct documentation about name resolution.
...
The tshark help and documentation has been incorrect for at least
eight years, claiming that by default all name resolutions are
performed. Fixes #11762
2021-05-26 23:09:53 +00:00
Chuck Craft
4bd80d551b
WSDG: update link to artwork in master on gitlab
2021-05-26 21:58:54 +00:00
Michael Tuexen
bb327af305
macossetup.sh: fix syntax
2021-05-26 23:21:39 +02:00
Michael Tuexen
c1518877fa
macossetup.sh: whitespace fix
2021-05-26 23:20:44 +02:00
John Thacker
99618b5b93
DVB-S2-BB: Verify EIP CRC
...
Verify the optional DVB-RCS2 Explicit Integrity Protection CRC32.
2021-05-26 20:31:28 +00:00
Kirill Smorodinnikov
33c414a2c8
PCEP: Fixing SR-PCE-CAPABILITY flags offset
...
Fix offset of flags in SR-PCE-CAPABILITY TLV. Flags are placed after reserved 2 bytes: https://datatracker.ietf.org/doc/html/rfc8664#section-4.1.2
2021-05-26 19:27:41 +00:00
Gtker
837fd40081
WOW: Move unused variable into function
2021-05-26 19:09:30 +00:00
Gtker
7b73af34ce
WOW: Remove unused variables
...
As discussed on issue
https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_581073618
2021-05-26 19:09:30 +00:00
Gtker
2e8027c645
WOW: Remove declarations and move functions above dissect_wow_pdu
...
As discussed in issue
https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580961205
2021-05-26 19:09:30 +00:00
Gtker
09b0e09cb8
WOW: Fix whitespace change that was accidentally applied
2021-05-26 19:09:30 +00:00
Gtker
bc1fd8e5c4
WOW: Rearrange header field variables and add comments
...
From discussion with maintainers on issue tracker
https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
60c68534a5
Revert "WOW: Refactor logon challenge server to client packet into struct"
...
This reverts commit 94333a170b0e7b55db035ccb7224bd2a0fd2395c.
See discussion in issue tracker https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
881a8f300f
Revert "WOW: Refactor logon challenge server to client packet into struct"
...
This reverts commit 07f796f3573dc05e561e6034acabf28514715561.
See discussion on issue tracker https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
1fb8a922e7
Revert "WOW: Refactor logon proof client to server packet into struct"
...
This reverts commit 92fe72f612f789693eba8f2ee02143db2193b5b3.
See discussion on issue tracker https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
b8c5f8ab00
Revert "WOW: Refactor logon proof server to client packet into struct"
...
This reverts commit 12b28e29f98ce1ee64e4e3759ae1adbde1530a5c.
See discussion on issue tracker https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
d457983c74
Revert "WOW: Refactor logon proof server to client packet into struct"
...
This reverts commit 3bc3ce07ffdb96fb6aa20aaefa8cbfa3ccef80aa.
See discussion on issue tracker https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
30ed82bb94
Revert "WOW: Refactor reconnect challenge server to client packet into struct"
...
This reverts commit 8e36f124f66fde0d8d23f095601cbd9be1df1e6e.
See discussion on issue tracker https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
b6ee285fd6
Revert "WOW: Refactor reconnect proof client to server packet into struct"
...
This reverts commit e0164783e497142906dbfb1267e68979e1e9e896.
See discussion on issue tracker https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
4688922527
Revert "WOW: Refactor realm list server to client packet into struct"
...
This reverts commit b35b1692a35181557c2d514f9ff2a0bc33a40f09.
See discussion on issue tracker https://gitlab.com/wireshark/wireshark/-/merge_requests/3039#note_580145729
2021-05-26 19:09:30 +00:00
Gtker
fc16a536d6
WOW: Refactor realm list server to client packet into struct
...
None of the fields in the struct are present in any other packet.
2021-05-26 19:09:30 +00:00
Gtker
c920d63574
WOW: Refactor reconnect proof client to server packet into struct
...
None of the fields in the struct are present in any other packet.
2021-05-26 19:09:30 +00:00
Gtker
4c11ba87e2
WOW: Refactor reconnect challenge server to client packet into struct
...
None of the fields in the struct are present in any other packet.
2021-05-26 19:09:30 +00:00