Commit Graph

23233 Commits

Author SHA1 Message Date
Michael Mann 598726be02 Datablob size is NDR64/32 dependant. Bug 9301 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9301).
From Matthieu Patou

svn path=/trunk/; revision=52734
2013-10-21 15:50:23 +00:00
Michael Mann 8ee3d11818 Fix padding bytes overlapping due to NDR alignment. Bug 9300 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9300)
From Matthieu Patou

svn path=/trunk/; revision=52733
2013-10-21 15:46:13 +00:00
Michael Mann f69a489472 NULL check ref_nt_challenge_response and ref_lm_challenge_response. Bug 9299 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9299)
From Matthieu Patou

svn path=/trunk/; revision=52732
2013-10-21 15:39:07 +00:00
Pascal Quantin 14fd3d0157 ZeroMemory -> SecureZeroMemory
svn path=/trunk/; revision=52731
2013-10-21 15:16:41 +00:00
Evan Huus 23191ea6e6 Don't go into a loop if we find a zero-length line. Fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9312

Anders, this may be related to your recent TVB optimizations, since I don't
think it happened before that? Did you change the behaviour of tvb_find_line_end
or its callees at all?

svn path=/trunk/; revision=52730
2013-10-21 13:07:19 +00:00
Michael Mann be62b39687 Pass fc_hdr "private data" into subdissectors instead of using pinfo->private_data.
svn path=/trunk/; revision=52729
2013-10-21 03:13:47 +00:00
Michael Mann 77837d2c9e Pass struct aspinfo "private data" into subdissectors instead of using pinfo->private_data.
svn path=/trunk/; revision=52728
2013-10-21 00:27:36 +00:00
Evan Huus 63eac3f6fd Fix -Wshadow error
svn path=/trunk/; revision=52726
2013-10-20 23:35:48 +00:00
Anders Broman 98dec2f09b Adds dissecting for actions, and proper display for OXM values.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283

svn path=/trunk/; revision=52725
2013-10-20 21:12:32 +00:00
Pascal Quantin b552143a5c Put PDU dissection in protocol tree
svn path=/trunk/; revision=52724
2013-10-20 21:05:37 +00:00
Michael Mann 24ba431d80 Pass ROHC "private data" from PDCP-LTE using dissector data parameter instead of using pinfo->private_data.
Passing data through the dissector parameter eliminates the need for ROHC dissector to save/restore private_data.

svn path=/trunk/; revision=52723
2013-10-20 20:35:24 +00:00
Jakub Zawadzki 1f110ac43f 2nd try to fix recent test failures.
After recent changes it's possible that epan_dissect_cleanup() can be called if there were
no dissection run on it (epan_dissect_run()) In such case ->tvb will have random value,
just initialize it to NULL in _init() and see if it's working.

Thanks goes to Evan for backtrace.

svn path=/trunk/; revision=52722
2013-10-20 19:05:00 +00:00
Pascal Quantin 7f3d07b9fd From e.yimjia via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9289 :
Add dissection of OMA-ILP

svn path=/trunk/; revision=52721
2013-10-20 18:43:00 +00:00
Pascal Quantin f06d7caaa5 Regenerate H.225 dissector
svn path=/trunk/; revision=52720
2013-10-20 18:26:08 +00:00
Pascal Quantin d269d19f99 Fix a typo
svn path=/trunk/; revision=52719
2013-10-20 18:06:23 +00:00
Michael Mann df6594bbd2 Pass MPLS "private data" into subdissectors instead of using pinfo->private_data.
svn path=/trunk/; revision=52718
2013-10-20 18:00:05 +00:00
Pascal Quantin cf9bbdecef From RobiOneKenobi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9297 :
Add support for MSVC2013

svn path=/trunk/; revision=52716
2013-10-20 17:35:30 +00:00
Pascal Quantin 33e376d180 From robionekenobi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9267 :
Fix compilation of packet-mq.c

svn path=/trunk/; revision=52715
2013-10-20 16:57:38 +00:00
Michael Mann 94c3d21550 Enhancement of the packet-mq dissector (WMQ 7.1-7.5). Bug 9267 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9267)
From robionekenobi

From me: Pass data through dissectors instead of using pinfo->private_data

svn path=/trunk/; revision=52707
2013-10-20 12:11:55 +00:00
Jakub Zawadzki bad81b517f Reintroduce back epan_dissect_reset(), proto_tree_reset()
This time it makes more sense, cause for each dissection we need two wmem allocators.
Reseting wmem allocator is much faster than destroy & create.

svn path=/trunk/; revision=52706
2013-10-20 10:21:25 +00:00
Jakub Zawadzki 107e4a6c80 Move resetting packet_info structure from dissect_packet() to epan_dissect_init()
It'd be actually good idea to seperate packet_info data (packet.c) from epan_dissect_t (epan.c),
but this rule is already violated.

Strict seperation could allow for example allow multiple dissection on the same epan_dissect_t
(I think it was idea behind it), but it's not working.

svn path=/trunk/; revision=52705
2013-10-20 10:11:16 +00:00
Jakub Zawadzki 336befd903 Remove allocation stem from PROTO_NODE_NEW() macro.
Tree root-node will be allocated using g_slice()

svn path=/trunk/; revision=52704
2013-10-20 10:03:32 +00:00
Evan Huus 7cc5d870ee Remove non-ASCII characters causing checkAPI failures
svn path=/trunk/; revision=52703
2013-10-20 02:38:51 +00:00
Evan Huus f5442e27a1 Fix format error.
svn path=/trunk/; revision=52702
2013-10-20 02:24:34 +00:00
Evan Huus b054d20a14 Don't use g_assert_cmpint, it isn't happy on Windows. g_assert is nearly as good
except it doesn't produce as nice error messages.

svn path=/trunk/; revision=52701
2013-10-20 02:18:19 +00:00
Michael Mann 796985587c Convert the proto_tree_add_text calls that should have been expert info.
svn path=/trunk/; revision=52700
2013-10-20 02:17:42 +00:00
Evan Huus badde83d4e Take a blind stab at adding oids_test to nmake
svn path=/trunk/; revision=52699
2013-10-20 02:10:39 +00:00
Michael Mann 522b4ce5c0 Pass SPX "private data" into subdissectors instead of using pinfo->private_data.
svn path=/trunk/; revision=52698
2013-10-19 23:06:13 +00:00
Anders Broman e958d8c081 From beroset@mindspring.com:
remove unnecessary and unused oid_resolv_cleanup()

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9295

svn path=/trunk/; revision=52697
2013-10-19 20:25:55 +00:00
Anders Broman 3c813bbcc1 From Zoltán Lajos Kis:
dissect flow_mod body in openflow_v4

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283

svn path=/trunk/; revision=52696
2013-10-19 20:19:35 +00:00
Anders Broman 09e32f5fb8 Minor optimizations.
svn path=/trunk/; revision=52695
2013-10-19 20:16:00 +00:00
Evan Huus 1f3549168d Don't link explicitly with libwmem, it's already in libwireshark and the symbol
doubling leads to all sorts of very subtle badness (including test failures due
to funny internal assertions because the two wmems have mismatching state).

Make wmem_init and wmem_cleanup PUBLIC instead of LOCAL so that they don't get
stripped and don't cause a link failure when trying to build oids_test (now that
it's not linking with libwmem explicitly). There is possibly a better way to fix
this, but I'm not sure what it is.

svn path=/trunk/; revision=52694
2013-10-19 19:40:02 +00:00
Michael Mann 3635bea0a4 Add OID unit tests. Bug 9294 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9294)
From Ed Beroset

svn path=/trunk/; revision=52692
2013-10-19 18:52:13 +00:00
Michael Mann b752cfa88d Correct source code formatting. Bug 9146 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9146)
From Roland Knall

svn path=/trunk/; revision=52691
2013-10-19 16:50:52 +00:00
Pascal Quantin 030b8c51d2 Update comments
svn path=/trunk/; revision=52690
2013-10-19 16:13:40 +00:00
Balint Reczey 2ec414c257 Minor refactoring in CMake ABI dump generation
svn path=/trunk/; revision=52689
2013-10-19 15:51:36 +00:00
Balint Reczey 70dce86ab3 Set and use TMPDIR for ABI dump generation when using CMake
svn path=/trunk/; revision=52688
2013-10-19 14:55:12 +00:00
Pascal Quantin f6e6660a19 Update E.212 list to Operational Bulletin No. 1038 (15.X.2013)
svn path=/trunk/; revision=52687
2013-10-19 14:10:05 +00:00
Pascal Quantin d9a0c655f9 Update ITU E.164 list to Operational Bulletin No. 1038 (15.X.2013)
svn path=/trunk/; revision=52686
2013-10-19 14:09:14 +00:00
Jörg Mayer 64018e9ee2 Convert to new hf handling
svn path=/trunk/; revision=52685
2013-10-19 10:04:39 +00:00
Jörg Mayer 141673b515 Some more decoding of mint traffic, start reformatting (incomplete)
svn path=/trunk/; revision=52684
2013-10-19 09:04:10 +00:00
Michael Mann 2657071e88 Don't allow invalid ranges to be specified for the stats tree. Bug 9130 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9130)
Not sure which memory allocation should be used here (using wmem caused crash), but this revision can at least be easily backported to 1.10 where the bug was reported.

Also allow a single number to be used in the stats range since it's considered a valid "range" by the UAT.

svn path=/trunk/; revision=52679
2013-10-18 21:17:01 +00:00
Jakub Zawadzki d3a09e0514 - Remove hf_ integers from few more dissectors
- udp: remove proto_udp.

svn path=/trunk/; revision=52678
2013-10-18 21:11:11 +00:00
Bill Meier 19f63eb2bd Revert SVN #52650 as per discussion on wireshark-dev
svn path=/trunk/; revision=52671
2013-10-18 15:08:19 +00:00
Michael Mann 4578df790d Use Z_tree for the subtree
svn path=/trunk/; revision=52670
2013-10-18 14:41:01 +00:00
Jörg Mayer 1318ec2c5e Beginnings of Motrola's MiNT protocol.
Most important missing item: Fill in the test functions
to avoid using all packets to the (fixed) ports.

svn path=/trunk/; revision=52669
2013-10-18 13:09:22 +00:00
Jörg Mayer 1b0fa2ec9c Forgot in the previous checkin.
svn path=/trunk/; revision=52668
2013-10-18 13:06:33 +00:00
Jörg Mayer 662c7704f8 After looking for something in the column-*.h files and
not finding it, I finally found it in column_info.h
Renamed column_info.h to column-info.h to have consistency
with the column*h files.

svn path=/trunk/; revision=52667
2013-10-18 13:06:05 +00:00
Bill Meier 2197f291e5 Revert SVN #52665.
Compilation fails on (only the ?) OSX-10.6-x64 buildbot with error:

netscaler.c: In function 'nstrace_read_v30':
netscaler.c:1295: warning: implicit conversion shortens 64-bit value into a 32-bit value

(Life is too short for me to dig multiple levels deep into a set of macros to try to see which
 actual line of code is causing the problem.  Maybe the patch submitter can identify the problem).


svn path=/trunk/; revision=52666
2013-10-18 04:31:08 +00:00
Bill Meier c50b988807 From Shekhar Chandra: support for version 3.0 of netscaler packet wire format.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9280

From me: fix indentation(tabs->spaces) and trailing whitespace.


svn path=/trunk/; revision=52665
2013-10-18 03:36:04 +00:00