Commit graph

2700 commits

Author SHA1 Message Date
Ulf Lamping
58c388e903 add a "private_data" pointer to the read_prefs_file() function, which will be "tunneled" to the callback function. This seems to be generally a good idea - as a lot of GLib/GTK function doing similiar and I'll need this for the upcoming update mechanisms.
svn path=/trunk/; revision=19905
2006-11-15 23:33:39 +00:00
Stephen Fisher
a79f06d71c A fix bug #1138: "Follow TCP Streams gets stream direction wrong if started
from a server->client frame."


svn path=/trunk/; revision=19898
2006-11-14 22:53:24 +00:00
Stephen Fisher
90303fb17f New feature to automatically highlight the field found when doing a find.
This works for both string and hex searches.  This resolves feature request
bug #776.


svn path=/trunk/; revision=19897
2006-11-14 22:35:22 +00:00
Jörg Mayer
dd26a7021b nikai@nikai.net:
Remaining fixes from:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225

svn path=/trunk/; revision=19895
2006-11-14 20:32:29 +00:00
Jörg Mayer
c3814a25de nikai@nikai.net:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225

Attempting a simple cleanup of duplicated includes, will attach patch.


svn path=/trunk/; revision=19894
2006-11-14 20:08:44 +00:00
Anders Broman
99511df5a0 From Simon Munton as pointed out by Stephen Fisher:
patch on bug #220 (to main.c. 
the second part to packet_list.c was done separately for bug 1159 in rev 19735).  That patch fixes bug #1205 coincidentally.

svn path=/trunk/; revision=19888
2006-11-14 06:00:48 +00:00
Jörg Mayer
80f82b9203 Warning fixes (void) instead of (), no newline at end of file.
svn path=/trunk/; revision=19845
2006-11-07 07:47:49 +00:00
Jaap Keuter
5f955a0fcc From Albert Chin:
Patch attached to convert usage of ntohl() -> g_ntohl(). On HP-UX,
ntohl() isn't available unless you -D_XOPEN_SOURCE_EXTENDED but there
are other uses of g_ntohl().

svn path=/trunk/; revision=19844
2006-11-07 07:39:16 +00:00
Ulf Lamping
59d6c8ea33 change all file offsets from long to gint64 so we can - theoretically - handle files > 2GB correct.
Please distclean Win32 builds!

svn path=/trunk/; revision=19814
2006-11-05 22:46:44 +00:00
Ronnie Sahlberg
6a612f0b15 it is GtkText in gtk-1.x not GtkTextView
svn path=/trunk/; revision=19799
2006-11-05 04:38:47 +00:00
Guy Harris
87dd0d2636 Make the routines that manipulate the hex/text display window take a
GtkWidget * as an argument, rather than a version-of-GTK+-dependent
pointer; that way, we need fewer #ifdefs.

Use WIDGET_SET_SIZE() instead of #ifdeffed code using
gtk_widget_set_usize() or gtk_widget_set_size_request() -
WIDGET_SET_SIZE() was created to encapsulate that GTK+ 1.2[.x] vs. 2.x
difference.

Make some variables not used outside gtk/main.c static.

Clean up white space.

Clean up handling of return value from load_airpcap() a bit.

Use one big #ifdef HAVE_AIRPCAP/#endif for all the AirPcap stuff in
gtk/main.c.

Attach _U_ to the unused arguments to driver_warning_dialog_cb(), not to
the arguments that are being used - and don't include it at all if
HAVE_AIRPCAP isn't defined, as it's not used in that case.

svn path=/trunk/; revision=19798
2006-11-05 00:54:17 +00:00
Jörg Mayer
dd85189750 Try to fix bug 1043.
svn path=/trunk/; revision=19773
2006-11-02 08:52:25 +00:00
Gerald Combs
2fcb67b496 From Giorgio Tino: Add a "Don't show this message again" option to an
AirPcap warning dialog.  Fix a callback bug in simple_dialog.c.

svn path=/trunk/; revision=19747
2006-10-31 01:44:11 +00:00
Gerald Combs
9a0a626449 Fix for bug 1164 from Stephen Fisher: In the coloring rules edit dialog, set
the foreground color correctly.

svn path=/trunk/; revision=19740
2006-10-30 16:01:40 +00:00
Gerald Combs
ff8422a3e4 From Giorgio Tino: Add support for version 2.0 of the AirPcap driver,
which has an updated API for WEP key handling.

svn path=/trunk/; revision=19736
2006-10-30 06:34:31 +00:00
Ulf Lamping
b8b14bf66a fix #1159 from Jim Young (should go into 0.99.4):
I think I have a fix for this problem.   The procedure
packet_list_set_selected_row()would do a clist freeze but not a corresponding
clist thaw if the list was empty.  A one line fix to gtk/packet_list.c appears
to fix this problem.

svn path=/trunk/; revision=19735
2006-10-30 02:09:59 +00:00
Ulf Lamping
f0c62ba9c8 don't use custom build buttons for standard tasks like: Ok, Apply, Cancel.
It might be a good idea to add tooltips to the various GUI elements - this makes understanding the GUI *much* faster.

svn path=/trunk/; revision=19694
2006-10-26 00:39:05 +00:00
Ulf Lamping
d5ce1ae2be the labels of the airpcap toolbar, e.g. "Not a valid Wireless Interface" are pretty misleading. I've changed it to "AirPcap interface: Not selected" which might be more helpful
svn path=/trunk/; revision=19693
2006-10-25 23:54:56 +00:00
Guy Harris
007f88f3e2 Unreffing rci->cursor_pixbuf should cause the pixbuf to be released, so
null out the pointer to it.  This prevents a freed pixbuf from being
used.

svn path=/trunk/; revision=19687
2006-10-25 19:48:54 +00:00
Guy Harris
3a21415651 Include the top-level header for CoreFoundation, to see whether it'll
fix a build failure I've seen on L**p*rd.

svn path=/trunk/; revision=19685
2006-10-25 18:25:17 +00:00
Gerald Combs
ac0181b469 Put a trailing ellipsis behind the wireless toolbar buttons since they open
a new window.

svn path=/trunk/; revision=19673
2006-10-24 21:07:05 +00:00
Anders Broman
c881dacb48 From Alejandro Vaquero:
For the Radius dissector to add statistics 
 in the "Service Response Time" menu and the tshark stats.

svn path=/trunk/; revision=19668
2006-10-24 05:21:00 +00:00
Jaap Keuter
3475ae994d From Alejandro Vaquero:
Find attached a patch for this bug. The problem was actually in the "Voip Calls" logic, when the first RTP packet was after the last signaling packet (e.g. a call connected and the release not captured), that caused the RTP to not be added to the graph list and therefor to the player.

svn path=/trunk/; revision=19667
2006-10-24 05:17:49 +00:00
Jaap Keuter
c629886ab1 Fix for bug 1178. Allow FT_?INT24 BASE_DEC VALs in the expression selection dialog.
svn path=/trunk/; revision=19666
2006-10-23 22:43:11 +00:00
Guy Harris
a08a2b5b89 Put the ", " before the PortAudio item regardless of whether we have
PortAudio or not; this fixes 1174.

svn path=/trunk/; revision=19653
2006-10-21 17:48:45 +00:00
Ulf Lamping
e26475108a the text in the about box license page was hard to read because of line breaks at the wrong places.
set the minimum size of the widget to 600 pixels - this is working well on my machine. If anyone has problems even with this width (e.g. because of using a larger font) we might increase the size even further.

Of course, this increases the overall size of the about dialog, but the other tabs seem to be working well with it.

svn path=/trunk/; revision=19652
2006-10-21 12:06:26 +00:00
Gerald Combs
fd2d2df09f AirPcap fixes from Giorgio Tino:
1) When choosing to Merge, Import or Keep decryption keys,  key lists will be saved to the preferences file AND into the registry.

2) Now if you check/uncheck the WEP deccryption checkbox in the Preferences..., the AirPcap toolbar will be modified as well.

svn path=/trunk/; revision=19646
2006-10-20 23:22:53 +00:00
Guy Harris
58bbda182a Don't display the Play button if we're not built with the RTP player.
In tests for whether we're built with the RTP player, test
HAVE_LIBPORTAUDIO first - hopefully we can eventually get rid of the
test for the GTK+ version number.

svn path=/trunk/; revision=19641
2006-10-20 20:05:27 +00:00
Guy Harris
b6e73ed047 Put the period into ITU-T Recommendation names.
Clean up indentation.

svn path=/trunk/; revision=19635
2006-10-20 18:41:40 +00:00
Guy Harris
c87e8bacad Add #defines for the column numbers, and use them.
Clean up indentation.

svn path=/trunk/; revision=19634
2006-10-20 18:36:42 +00:00
Guy Harris
aecfc9cf43 Clean up indentation.
Fix typos.

Null out "pa_stream" when the stream is closed; this appears to prevent
some crashes.

svn path=/trunk/; revision=19633
2006-10-20 18:18:50 +00:00
Guy Harris
62d7ab40f6 Don't destroy something if it doesn't exist.
svn path=/trunk/; revision=19632
2006-10-20 17:56:21 +00:00
Guy Harris
89b99ff3f2 Don't pass an uninitialized string to gtk_widget_create_pango_layout();
it supports NULL for "no text".

svn path=/trunk/; revision=19631
2006-10-20 17:47:28 +00:00
Guy Harris
0d9a445fee Don't do things with the RTP channels hash table if it hasn't been
created yet.

svn path=/trunk/; revision=19630
2006-10-20 17:30:27 +00:00
Guy Harris
ff780d78f3 Fix the progress bars.
svn path=/trunk/; revision=19629
2006-10-20 17:12:52 +00:00
Guy Harris
b12232d7a1 Do the word-wrapping in end_string(), once the string is completely
constructed.  Clean up the insertion of ", ".

Put the runtime libpcap version into the runtime version info.

svn path=/trunk/; revision=19625
2006-10-20 09:06:24 +00:00
Jaap Keuter
22a949a42f Make dumpcap complile again and other minor improvements.
svn path=/trunk/; revision=19624
2006-10-20 06:24:56 +00:00
Gerald Combs
99d5c5e440 Rename get_epan_and_portaudio_version_info() to get_gui_compiled_info()
and add version info for AirPcap.  Add a corresponding
get_gui_runtime_info().  Fix up whitespace.

svn path=/trunk/; revision=19620
2006-10-19 22:43:38 +00:00
Jaap Keuter
ed69c761c8 From Stephen Fisher:
Attached is a patch to fix bug #1165.  To summarize: "if you click on the button to change the background color and hit ok, it changes not only the name field but also the string field's color away from the red/green [syntax check]."

svn path=/trunk/; revision=19619
2006-10-19 21:39:18 +00:00
Guy Harris
1eefc6d60e Clean up the word wrap stuff a bit. (Arguably, that should be done in
the code that displays it - we might, for example, be able to have the
About dialog word-wrap to the appropriate size, and word-wrap text
printed to the standard output to the terminal width if it's going to a
terminal and to 80 or whatever columns otherwise.)

Don't report anything in dumpcap about libraries not used by dumpcap. 
(It was printing a blank, which looked a bit weird.)

Fix the handling of _MSC_VER as per Gerald's fix for _MSC_FULL_VER.

svn path=/trunk/; revision=19618
2006-10-19 21:17:23 +00:00
Guy Harris
00d8ca2d45 Fix up the changes to put the Portaudio information at the end of the
version string, so the information comes out right for applications that
don't use Portaudio.

Get rid of an extra "with" in the version string for dumpcap.

Get rid of an extra blank after the libpcap version string, and get rid
of an extra newline before it.

Attempt to add more compiler version information and to prettify the
MSVC++ version information (both untested).

svn path=/trunk/; revision=19613
2006-10-19 18:43:12 +00:00
Guy Harris
26faa9ad5a Include gtk/main.h to declare main_filter_packets().
svn path=/trunk/; revision=19603
2006-10-19 09:10:40 +00:00
Jaap Keuter
4f5a48c4f6 Adding license tab to about dialog
svn path=/trunk/; revision=19601
2006-10-19 06:29:13 +00:00
Gerald Combs
40b8458408 Add support for:
- The AirPcap Multi-Channel Aggregator (which is marketspeak for an "any" 
    device)
  - Merging the 802.11 dissector WEP key list with AirPcap's
  - Decrypting WEP in the adapter, in Wireshark, or not at all
  
Update the release notes.

svn path=/trunk/; revision=19599
2006-10-19 00:48:03 +00:00
Jaap Keuter
c57d78db9c From Stephen Fisher:
While researching another bug in follow_dlg.c, I spotted a different one that causes the from and to hostnames/ip addresses to be the same in the follow tcp stream dialog only with IPv6.

svn path=/trunk/; revision=19583
2006-10-17 20:53:57 +00:00
Luis Ontanon
482ded17c6 Hide the "Tools" menu if it has no items .
svn path=/trunk/; revision=19578
2006-10-17 17:52:15 +00:00
Ulf Lamping
a1b7a22a8e from Stephen Fisher:
Here is a patch for spelling typos in comments and strings in the gtk/ 
directories.

svn path=/trunk/; revision=19568
2006-10-17 01:29:55 +00:00
Luis Ontanon
dad92a4808 Hide the "Tools" menu if unused.
svn path=/trunk/; revision=19559
2006-10-16 16:54:48 +00:00
Ulf Lamping
a1656642c6 as Stephen Fisher noted: fix the files header comment
svn path=/trunk/; revision=19520
2006-10-14 00:22:36 +00:00
Ulf Lamping
c9ad9d765a remove the experimental display of the highest expert level in the statusbar for now.
as long as we haven't solved that TCP checksum offload problems causing checksum errors all the time, this will display the error level for almost every capture done on a local machine - rendering this display pretty useless in it's current form.

svn path=/trunk/; revision=19516
2006-10-13 18:19:42 +00:00