Commit Graph

23 Commits

Author SHA1 Message Date
Michael Mann 1c0ef12021 Fix typos in display filters caught by checkfiltername.pl
svn path=/trunk/; revision=47645
2013-02-12 21:26:47 +00:00
Bill Meier c439b805e2 Comment out unused hf[] entries & etc.
(found by checkhf)

svn path=/trunk/; revision=47389
2013-01-31 17:55:31 +00:00
Chris Maynard ad78db491a Fix Coverity CID 732304: Missing break in switch.
svn path=/trunk/; revision=47077
2013-01-14 19:23:26 +00:00
Alexis La Goutte 3bf44b5a27 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=46962
2013-01-06 14:50:06 +00:00
Anders Broman 5f9709ad8c Comment out unused variable remoce C++ style comments etc.
svn path=/trunk/; revision=45420
2012-10-09 10:24:15 +00:00
Anders Broman de222a1b5a From Chris Wulff:
Minor bugfixes to packet-msrp.c and packet-mrp-mvrp.c

Major updates to packet-ieee17221.c

Changes to ieee17221.c update dissector from draft revision 18 / 19 code to
draft revision 21.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7779

svn path=/trunk/; revision=45419
2012-10-09 08:49:40 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Michael Mann 1741731384 remove unnecessary underscores from display filters
svn path=/trunk/; revision=44181
2012-08-01 02:59:17 +00:00
Jakub Zawadzki b18e880040 Update FSF address - part II.
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Pascal Quantin 3ceda0e1c4 Rename two entries to avoid having same filter name for entries with incompatible types
svn path=/trunk/; revision=43449
2012-06-23 15:04:13 +00:00
pascal e191fe2a99 From Tom Bottom:
Fix AEM status field decoding
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7205

svn path=/trunk/; revision=42294
2012-04-27 17:36:53 +00:00
pascal 7eab849657 Fix typo errors
svn path=/trunk/; revision=42288
2012-04-27 09:04:23 +00:00
Anders Broman 33b522efd5 From Tom Bottom:
The AEM status field was erroneously displayed using ACMP status field values.
Minor change to display correct (as of draft 18) AEM status field values.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7205

svn path=/trunk/; revision=42284
2012-04-27 08:32:06 +00:00
Jakub Zawadzki 8a1dc57c03 Remove doubled semicolons and semicolons outside function.
svn path=/trunk/; revision=42053
2012-04-13 20:22:31 +00:00
Jeff Morriss 323dd08b61 Add a couple casts to fix the Windows builds.
svn path=/trunk/; revision=41745
2012-03-23 01:58:46 +00:00
Jeff Morriss a7f0f54612 From Tom Bottom via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6887 :
Address comments in the bug: fix up some hf issues and use
proto_item_set_len() when necessary.

Added status field dissection to AEM packets.

From me: hf_aem_frequency is an FT_FLOAT and appears to have a length of 4 so
use that length (instead of 5).

svn path=/trunk/; revision=41742
2012-03-23 01:18:06 +00:00
Chris Maynard 66aa2c5b93 Add missing break between AECP_COMMAND_SET_NAME and AECP_COMMAND_GET_NAME cases. Fixes Coverity CID 1430: MISSING BREAK.
svn path=/trunk/; revision=41699
2012-03-21 01:27:22 +00:00
Bill Meier b672c45b72 Use tvb_new_subset_remaining(...) rather than tvb_new_subset(...,-1,-1).
svn path=/trunk/; revision=41376
2012-03-06 17:24:21 +00:00
Bill Meier 69ef1478d4 Fix filter name: "iee17221.channels" --> "ieee17221.channels"
svn path=/trunk/; revision=41358
2012-03-05 20:50:25 +00:00
Bill Meier 2e729fbb96 Change all hf[] FT_UINT? fields referencing 'avp_bool_vals' to be FT_BOOLEAN fields.
#include <stdio.h> not req'd;
Add editor modelines for "3 space" indentation.

svn path=/trunk/; revision=41331
2012-03-03 21:58:38 +00:00
Jeff Morriss 9bd0312661 Fix a few bugs found by Clang analysis:
packet-ieee17221.c:3123:10: warning: Value stored to 'mr_offset' is never read
	- Put the offset increment inside the loop

packet-ieee17221.c:2888:10: warning: Value stored to 'mr_subtree' is never read
	 - Use the newly-created subtree (instead of the parent tree)

packet-ieee17221.c:2692:13: warning: Value stored to 'next_tvb' is never read
	- Use next_tvb (instead of the main tvb which doesn't start at the
	  correct offset)

svn path=/trunk/; revision=41324
2012-03-02 20:17:36 +00:00
Bill Meier c58bbe0ad7 Fix proto_tree_add_item() 'encoding' args.
svn path=/trunk/; revision=41285
2012-03-02 05:10:02 +00:00
Jeff Morriss 1ff7c5d916 From Tom Bottom and Chris Pane via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6887 :
A new dissector for IEEE 1722.1.

From me: some code cleanup, including:
 - Get rid of some unnecessary local variable initializations.
 - Put all of 1722.1 under one subtree.
 - Just put if(tree)s in the top-level function rather than scattered throughout.
 - Remove a couple "set but not used" warnings (a couple are #if'd out).
 - Don't use deprecated functions.

svn path=/trunk/; revision=41282
2012-03-02 03:30:30 +00:00