Commit Graph

46667 Commits

Author SHA1 Message Date
Guy Harris a8023c97a3 Menu labels aren't paths, they're just the strings shown to the user for
the menu item.

svn path=/trunk/; revision=49572
2013-05-25 02:37:51 +00:00
Evan Huus cf7ec9f1e9 From Fabio Tarabelloni via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8387
ZigBee ZCL OnOff cluster dissection.

Also, fix decryption of APS commands.

svn path=/trunk/; revision=49571
2013-05-25 01:45:16 +00:00
Chris Maynard 035f3fc27a Add Mike Garratt to the list of authors for (at the very least) his contributions from bug6645, committed in r46083.
svn path=/trunk/; revision=49570
2013-05-25 00:54:30 +00:00
Anders Broman 91c0a93914 Edit comments
svn path=/trunk/; revision=49569
2013-05-24 22:38:53 +00:00
Anders Broman 9d5b23bc76 use key in all p_add_proto_data() p_get_proto_data()
svn path=/trunk/; revision=49568
2013-05-24 22:38:25 +00:00
Pascal Quantin ec1ebf5dd8 From LI Hai via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8708 :
Add MAC-DATA support to TETRA dissector and other minor improvements

svn path=/trunk/; revision=49567
2013-05-24 20:55:42 +00:00
Michael Mann a686f1713a Bluetooth: Highlight correct bytes in some SDP trees (Part 2). Bug 8700 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8700)
svn path=/trunk/; revision=49566
2013-05-24 19:40:09 +00:00
Michael Mann 586df977d1 Ensure most severe is displayed in expert column. Bug 7733 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7733)
#BACKPORT

svn path=/trunk/; revision=49565
2013-05-24 19:23:36 +00:00
Jeff Morriss 71bc722866 expert_add_info(): we can't use va_start()/va_end() so don't try to use a va_list (which isn't used by the called function) either.
svn path=/trunk/; revision=49564
2013-05-24 19:14:09 +00:00
Jeff Morriss 44b437c331 expert_add_info() doesn't take a variable number of args; don't use va_start()/va_end().
svn path=/trunk/; revision=49563
2013-05-24 18:15:09 +00:00
Jeff Morriss ac845e4d83 expert_add_info_format_text(): use the correct argument numbers in G_GNUC_PRINTF().
svn path=/trunk/; revision=49562
2013-05-24 18:12:00 +00:00
Michael Mann 5e86cb9bf4 Use new expert info API in idl dissectors. These generated about 50% of the add_expert_info_format() calls.
svn path=/trunk/; revision=49561
2013-05-24 18:09:57 +00:00
Michael Mann 45658e1cbd first batch of dissectors to use the new expert info API.
svn path=/trunk/; revision=49560
2013-05-24 18:02:54 +00:00
Michael Mann 0d1a4b2920 Add expert info configuration framework. Bug 2412 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2412).
Expert info "fields" can now be registered/addressed by name.  Right now, the basic framework allows expert info fields to become "display filters".  However more could be done, like user preferences overriding default severity level, speeding up expert info dialog load time by not needing to redissect a file, etc.

Long term goal is to have all expert_info filterable and have the functionality of expert_add_info_format() include the "registered index".  expert_add_info_format_text() is the workaround until all current calls to expert_add_info_format() have been updated with either expert_add_info() or expert_add_info_format_text().  Then the remaining expert_add_info_format_text() will be renamed to expert_add_info_format().

svn path=/trunk/; revision=49559
2013-05-24 17:59:36 +00:00
Pascal Quantin ecd3073813 How to mess with a keyboard...
svn path=/trunk/; revision=49558
2013-05-24 17:43:36 +00:00
Pascal Quantin 01da09fcb5 One more compilation fix for gcc 4.3.2 ('toi' may be used uninitialized in this function)
svn path=/trunk/; revision=49557
2013-05-24 17:36:19 +00:00
Evan Huus f953ba8346 Remove unused function parameter, rename variable to avoid shadowing.
svn path=/trunk/; revision=49556
2013-05-24 17:24:58 +00:00
Michael Mann d12fc51afd Overhauled the RMT dissectors. Not sure each needs its own file, but since this involves multiple RFCs, they remain split out by that. More are now a "pure" dissector and not a "decoding function hook".
Some Notes:
1. Converted to "new style" dissectors with data being passed between dissectors
2. Combined header files into one since there wasn't much that should have really been in the header files.  Implemented functionality is in c module of respective dissector.

Not sure if LCT preferences should just be in the LCT dissector and not the RMT-ALC "parent", but kept for backwards compatibility.

svn path=/trunk/; revision=49555
2013-05-24 17:06:23 +00:00
Jeff Morriss 7dddfb1784 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8714 :
If we're not doing dissection (in 2-pass mode) then don't try to mark frames
as depended upon: in that case epan has not been initialized so we shouldn't
be looking in the edt (and anyway without dissection there won't be any
dependent frames).

(I'm not convinced there's any reason to run 2-pass mode without dissection,
however...)

svn path=/trunk/; revision=49554
2013-05-24 15:28:04 +00:00
Jeff Morriss f93348a2f7 As suggested by Moshe Kaplan in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8712 :
When pointing people to the mailing lists, point them directly to the lists
page rather than explaining where to look for the link on the main page (the
directions were several years out of date).

While there also fix up some of the indentation and add a link to the Q&A site
in the developer's guide.

svn path=/trunk/; revision=49553
2013-05-24 14:45:55 +00:00
Guy Harris 3598d9e2ac Have register_param_stat() add menu items, rather than having the menu
items hardcoded into ui/gtk/main_menubar.c

Get rid of more stuff implying that the code for adding menu items is
used only by Lua, as it's also used by register_param_stat().

Add the items to the menu list sorted by the menu item name shown to the
user.

Get rid of some const declarations that are lies.

Use the label given for a menu item as the label in the menu, rather
than parsing it from a token.

svn path=/trunk/; revision=49552
2013-05-24 03:10:56 +00:00
Evan Huus ba77e3c54d Add an optimization to req_resp_hdrs_do_reassembly that shaves about 20% off
the load time of one of my sample captures that is HTTP-but-not-really.

Also add modelines.

svn path=/trunk/; revision=49551
2013-05-24 02:31:26 +00:00
Guy Harris 4caa94335d And another (cosmetic) change for that.
svn path=/trunk/; revision=49550
2013-05-24 01:11:07 +00:00
Guy Harris 699f06760c A long-overdue rename of register_dfilter_stat() to
register_param_stat() to reflect that it's for arbitrary statistics tap
parameters, not just a display filter.

svn path=/trunk/; revision=49549
2013-05-24 01:10:16 +00:00
Guy Harris 3c41347f67 Rename register_lua_menu_bar_menu_items() to
register_menu_bar_menu_items(), to emphasize that it's not just for Lua.

svn path=/trunk/; revision=49548
2013-05-24 01:05:39 +00:00
Guy Harris dcdfc836c2 We don't want to restrict the ability to dynamically add statistics
menus to Lua taps.

svn path=/trunk/; revision=49547
2013-05-23 23:32:20 +00:00
Pascal Quantin 608fe54c05 Fix computation of TP-User-Data-Length when SMS is coded with GSM 7 bit default alphabet and TP-User-Data-Header field is present
svn path=/trunk/; revision=49546
2013-05-23 20:28:59 +00:00
Chris Maynard 2084249565 It's actually enough just to add some blank lines without the need for the <pre> tags.
svn path=/trunk/; revision=49545
2013-05-23 17:45:21 +00:00
Guy Harris 6613d28818 Use a single #ifdef HAVE_LUA/#endif for two routines (currently) used
only from the Lua code.

svn path=/trunk/; revision=49544
2013-05-23 03:26:22 +00:00
Evan Huus 396a1881b7 Add -p option to the valgrind script for profiling with callgrind.
svn path=/trunk/; revision=49543
2013-05-23 02:30:40 +00:00
Guy Harris ff20a73022 No need for those arguments to be pointers to arrays of const pointers,
especially given that we end up freeing what all of those pointers point
to.

svn path=/trunk/; revision=49542
2013-05-23 01:25:06 +00:00
Guy Harris 08979d5154 See if this squelches a warning.
svn path=/trunk/; revision=49541
2013-05-23 01:19:09 +00:00
Guy Harris 14147099ea Include ui/gtk/export_pdu_dlg.h so that the functions defined here are
checked against their declarations.

svn path=/trunk/; revision=49540
2013-05-23 01:07:51 +00:00
Jeff Morriss 82554ebb52 make_menu_xml() is only used if we HAVE_LUA; only define it when we'll use it.
svn path=/trunk/; revision=49539
2013-05-23 00:33:33 +00:00
Guy Harris c6ba199a89 Include ui/ssl_key_export.h so that functions defined here are checked
against their declarations.

svn path=/trunk/; revision=49537
2013-05-22 23:30:29 +00:00
Guy Harris 9c6cae4bde Include ui/gtk/addr_resolution_dlg.h so that functions defined here are
checked against their declarations.

Fix a tpo.

svn path=/trunk/; revision=49536
2013-05-22 23:28:11 +00:00
Guy Harris 845728e520 Make a routine not used outside this file static.
svn path=/trunk/; revision=49535
2013-05-22 23:25:17 +00:00
Guy Harris fe233df490 Include ui/gtk/prefs_filter_expressions.h so that functions defined here
are checked against their declarations.

svn path=/trunk/; revision=49534
2013-05-22 23:22:35 +00:00
Guy Harris 1fe073a93b Make a routine not used outside this file static.
svn path=/trunk/; revision=49533
2013-05-22 23:20:35 +00:00
Guy Harris b213dcc584 Make a routine not used outside this file static.
svn path=/trunk/; revision=49532
2013-05-22 23:16:54 +00:00
Guy Harris f053368a0d Include ui/recent_utils.h, to check functions defined here against their
declarations - and fix a problem that turned up.

svn path=/trunk/; revision=49531
2013-05-22 23:14:44 +00:00
Guy Harris 70bb111bab Turn "packet_is_ssl()" into a general "does the packet whose dissection
is in this epan_dissect_t contain the field whose name is passed as an
argument" routine in libwireshark, and use it where we used
packet_is_ssl().  (We should check to see if anything *else* could use
it.)

svn path=/trunk/; revision=49530
2013-05-22 23:02:19 +00:00
Guy Harris 3384fee177 Include ui/gtk/main_80211_toolbar.h so that the functions we define are
checked against their declarations in that file.

svn path=/trunk/; revision=49529
2013-05-22 22:43:07 +00:00
Guy Harris 5a56506cf5 Include "ui/recent_utils.h" so that the functions we define are checked
against the declarations for them.

svn path=/trunk/; revision=49528
2013-05-22 22:39:05 +00:00
Guy Harris f35b5919a7 Include "ui/gtk/gtk_iface_monitor.h" so that our definitions are checked
against the published declarations.

svn path=/trunk/; revision=49527
2013-05-22 22:34:27 +00:00
Michael Mann 7f832c18c3 Support Raptor/Raptor-Q FEC in RMT dissector. Bug 8699 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8699)
From Igor Slepchin.

svn path=/trunk/; revision=49523
2013-05-22 20:30:30 +00:00
Guy Harris 05c9234020 Make routines not used outside their source files static.
svn path=/trunk/; revision=49522
2013-05-22 20:23:10 +00:00
Guy Harris eb56f6fb96 Get rid of an unused routine.
svn path=/trunk/; revision=49521
2013-05-22 20:22:40 +00:00
Guy Harris 48effa3ac2 Make a routine not called from outside the file static.
svn path=/trunk/; revision=49520
2013-05-22 20:14:16 +00:00
Guy Harris f334c4a0c8 No capture options if no libpcap.
svn path=/trunk/; revision=49519
2013-05-22 19:21:31 +00:00