Commit Graph

6228 Commits

Author SHA1 Message Date
Bill Meier 547a03b25b Fix some C++ style comments
svn path=/trunk/; revision=20865
2007-02-19 21:45:27 +00:00
Jeff Morriss 0787b688cc Squelch a few unused parameter warnings.
svn path=/trunk/; revision=20863
2007-02-19 15:30:06 +00:00
Jeff Morriss 376124960d Remove some unused parameters (pinfo).
Remove some _U_'s on parameters that _are_ used.
Reindent some.

svn path=/trunk/; revision=20862
2007-02-19 15:14:00 +00:00
Jeff Morriss f2e0f951f7 fetch_tapped_data() returns a const pointer, so declare the function as returning such
svn path=/trunk/; revision=20861
2007-02-19 12:24:32 +00:00
Jeff Morriss 3542de4287 Remove some unused parameters (pinfo).
Remove some _U_'s on parameters that _are_ used.
Reindent some.

svn path=/trunk/; revision=20860
2007-02-19 11:24:56 +00:00
Ronnie Sahlberg 1401a27b06 the policy handles created/opened in CreateKey and OpenKey are now called "handle" and not "new_handle"
update the conformance file so the correct functions are loaded with the correct PARAM value to signal "in this frame, this policy handle was created"



svn path=/trunk/; revision=20857
2007-02-19 08:26:27 +00:00
Anders Broman 7164abe385 Decode some RANAP elements.
svn path=/trunk/; revision=20854
2007-02-19 06:09:33 +00:00
Stephen Fisher 6c1dce1710 From Kriang Lerdsuwanakij:
While I reading source code of IuUP dissector, I notice some
obvious bugs inside the code. One is a missing assignment
that causes the following "if (iuup_circuit)" block to never execute.
Another is wrong field names.

Althoug both won't show up in final result (for the first bug, the call to
g_hash_table_insert several lines later will do the right thing anyway;
for the second bug, there is no services utilizing more than 3 subflows),
I think it is better to have them fixed.


svn path=/trunk/; revision=20853
2007-02-19 05:32:01 +00:00
Stephen Fisher d4fffce05f Add comments to the statistics functions to tell which is which
svn path=/trunk/; revision=20852
2007-02-19 05:21:12 +00:00
Bill Meier 3dbfb21cf9 packet-afp: remove unneeded line of code;
packet-sctp: register sctp dissector since packet-lge-monitor wants to call same


svn path=/trunk/; revision=20850
2007-02-19 01:27:16 +00:00
Guy Harris 16b7912456 Initialize the description in UAT_FLD_PROTO().
svn path=/trunk/; revision=20849
2007-02-19 01:22:45 +00:00
Guy Harris eaf1ae2df2 wep_decrypt() isn't needed if we have AirPDCap.
Use "break" instead of "goto done" when possible, don't goto a label
that follows immediately, and get rid of labels for which there's no
goto.

svn path=/trunk/; revision=20846
2007-02-19 01:18:26 +00:00
Guy Harris 8bc5fca60a Get rid of an unused variable.
svn path=/trunk/; revision=20845
2007-02-19 01:15:22 +00:00
Guy Harris d00fe9517b dissect_x411_mts_apdu() is an old-style dissector, so it shouldn't
return any value.

svn path=/trunk/; revision=20844
2007-02-19 01:09:55 +00:00
Guy Harris 1a2a777a1f Declare nbytes to match what the routine getting a pointer to it
expects.

svn path=/trunk/; revision=20843
2007-02-19 00:59:20 +00:00
Guy Harris df08840bbe Get rid of an unused variable.
svn path=/trunk/; revision=20841
2007-02-19 00:46:01 +00:00
Uwe Girlich ab177ee1cd Added a DTPT (DekTop PassThrough) dissector.
svn path=/trunk/; revision=20839
2007-02-18 13:24:30 +00:00
Jeff Morriss 43e550c754 Fix bug 1380:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1380

by registering the spnego dissector by name (e.g., call 'register_dissector()').


svn path=/trunk/; revision=20837
2007-02-18 10:18:53 +00:00
Stephen Fisher 4017f3c43a From Mike Duigou:
Adds support for dissecting the new version 2 binary wire format messages.


svn path=/trunk/; revision=20836
2007-02-18 03:30:20 +00:00
Anders Broman 0e706015c2 From Florent Drouin:
Update the Camel dissector to have the same structure as the gsm map dissector.
Now the dissector correctly handles the Tcap return error component.
Some improvement have been made for ApplyChargingReport too.

svn path=/trunk/; revision=20835
2007-02-17 20:04:10 +00:00
Graeme Lunt 38515fbf22 From X.690 8.6.2.3
"If the bitstring is empty, there shall be no subsequent octets, and the initial octet shall be zero." 

The BER dissector marked empty bitstrings as "Padding", but they are now marked as "Empty". 

http://www.wireshark.org/lists/wireshark-dev/200702/msg00574.html


svn path=/trunk/; revision=20834
2007-02-17 14:23:09 +00:00
Graeme Lunt 1864da87a8 This patch looks for a confounder in GSSWrap for DES_MAC_MD5 algorithm.
This is purely empirical as I can find no standard that says it should be there.
However successful LDAP/SASL/GSSAPI between AD and Java client shows it seems to be present.
If the confounder is not dissected, the LDAPMessage to fail to be decoded.


svn path=/trunk/; revision=20833
2007-02-17 11:16:52 +00:00
Graeme Lunt c09afc2db6 This patch adds some new features to the BER dissector:
- Added option to decode OCTET STRINGs as BER encoded data
- Added decoding of unknown VisibleString and GeneralString
- Some code cleanup

http://www.wireshark.org/lists/wireshark-dev/200702/msg00482.html


svn path=/trunk/; revision=20831
2007-02-17 11:10:02 +00:00
Graeme Lunt c55b754264 Tidy ups for SASL/GSSAPI support:
1) Handle empty (zero length) saslCredentials
2) Handle "GSSAPI" auth_mech when identified from the bind
3) Annotate column info to show SASL service applied to LDAP operation


svn path=/trunk/; revision=20830
2007-02-17 11:06:25 +00:00
Ronnie Sahlberg 657bf78561 if the KRB-ERROR PDU contains a pw-salt containing an NT status code, show that NT status code on the summary line since it gives more precise error description to why there was an kerberos error.
svn path=/trunk/; revision=20827
2007-02-17 00:47:09 +00:00
Ronnie Sahlberg ffc2333ea8 decode the known 4 bytes of the 16 byte blob that prepends the ndr encoded logoninfo and constraineddelegation ndr encoded blobs inside the PAC
svn path=/trunk/; revision=20826
2007-02-17 00:13:57 +00:00
Ulf Lamping d6e22b2d9a major code cleanup:
- move dcom-cba and pn-rt files into profinet plugin (where they really belong)
- move some common pn functionality into new packet-pn.c/h instead of having duplicate code

svn path=/trunk/; revision=20825
2007-02-16 21:53:36 +00:00
Ronnie Sahlberg 7214c88fa2 when decrypting a blob allocate a new private memory area to return to the caller instead of reusing the same one over and over (g_free followed by g_malloc by the same size often result in the same area being returned)
this resolves some issues where the decode is ok  but the hexpane shows corrupted memory where the decrypted blob should be.



svn path=/trunk/; revision=20824
2007-02-16 21:04:45 +00:00
Anders Broman 9288918d6b From Florent Drouin:
A patch to update the gsm map definition up to 3GPP TS 29.002 V7.5.0 (2006-09) Release 7 There is a little impact on the GTP dissector, because I had to change the name of the Local ErrorCode in the gsm map asn1 definition due to a conflict with the Camel dissector.

svn path=/trunk/; revision=20823
2007-02-16 21:02:19 +00:00
Martin Mathieson 946897ace7 Make RFC2198 pt preference work (wasn't calling
proto_reg_handoff_rtp when prefs changed).

svn path=/trunk/; revision=20822
2007-02-16 13:47:49 +00:00
Anders Broman f30812691b Fix the bugs part of http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1371.
- a typor in in hf_bssgp_ie_type
- id def out debug code.

svn path=/trunk/; revision=20821
2007-02-16 06:54:32 +00:00
Gerald Combs c4a52b1995 According to David Young, IEEE80211_RADIOTAP_FCS was never officially
assigned.

svn path=/trunk/; revision=20817
2007-02-15 18:35:30 +00:00
Ronnie Sahlberg 02a8ed7abc using the latest SVN of PIDL it is now possible to compile the corrected WINREG.IDL where QueryInfoKey responses are parsed correctly.
(since we do not yet use all of the various idl files from s4 i commented out the import directove from the idl file since othervise it would generate #include directives for files we do not yet provide)



svn path=/trunk/; revision=20816
2007-02-15 09:33:12 +00:00
Jörg Mayer b068c93dea Guess the meaning of some trailer bytes
svn path=/trunk/; revision=20815
2007-02-15 08:40:18 +00:00
Gerald Combs 2e89206961 Try to fix a naming conflict on Windows.
svn path=/trunk/; revision=20814
2007-02-14 22:03:39 +00:00
Martin Mathieson 958a67763d Change fp_info struct to be more general by removing DCT2000-specific field.
Also:
- Fix a division-by-zero error in FP dissector
- Correct the way DCT2000 IPPrim addresses and ports are dissected and displayed

svn path=/trunk/; revision=20812
2007-02-14 15:41:43 +00:00
Jörg Mayer 4bc0860be2 Dissect the Cisco proprietary encapsulation of IPSEC/ISAKMP
in TCP (incomplete).
Add preference to select the tcp port (default: 10000)

svn path=/trunk/; revision=20809
2007-02-14 13:22:55 +00:00
Ronnie Sahlberg bfcb77a3ff show the share mode bits that are SET on the share mode expansion line so one can see easily which share modes are requested without having to open the share mode expansion
svn path=/trunk/; revision=20808
2007-02-14 11:49:01 +00:00
Tomas Kukosa a91eb30021 H.225.0 updated to 05/2006, Amendment 1 01/2007
svn path=/trunk/; revision=20807
2007-02-14 08:08:44 +00:00
Stephen Fisher 3f3d725506 Changes to the ansi_map and ospf dissectors to use new RVAL() (range string)
feature.


svn path=/trunk/; revision=20806
2007-02-14 01:16:19 +00:00
Stephen Fisher aa897723ff From Sebastien Tandel:
Here is an updated patch for proto_tree_add_item and the
range_string structure. The new macro RVALS() can be used as the macro
VALS() in the declaration of your hf_register_info with another
structure (range_string).  Be aware that you *have to* ORed the value of
the field display with BASE_RANGE_STRING constant and it can 'only' be
used with FT_(U)INT* types in a header_field_info.


svn path=/trunk/; revision=20805
2007-02-14 00:39:48 +00:00
Stephen Fisher 0ebc01dc03 From Sebastien Tandel:
Create two new files (ws_strsplit.[ch]) that use GTK2 code to override
the buggy g_strsplit() function when compiling for GTK1.  Include this
work-around function (ws_strsplit) in libwireshark.def.  Add notes on usage
to README.developer.  Include epan/ws_strsplit.h in all files that use
g_strsplit().


svn path=/trunk/; revision=20804
2007-02-13 20:57:22 +00:00
Anders Broman 79a551e513 Display 2 octet length field correctly.
svn path=/trunk/; revision=20801
2007-02-12 22:04:58 +00:00
Anders Broman ef318fcf0a Return correct length.
svn path=/trunk/; revision=20800
2007-02-12 21:48:41 +00:00
Ronnie Sahlberg 10cace66eb add dissection of SMC POSITION TO ELEMENT cdb
svn path=/trunk/; revision=20799
2007-02-12 20:26:52 +00:00
Luis Ontanon b26c1c4ca2 Add a description of UAT fields, and have it as a tooltip in the New/Edit Dialog.
svn path=/trunk/; revision=20797
2007-02-12 19:57:41 +00:00
Ronnie Sahlberg 327d0a646c add dissection of SMC OPEN/CLOSE IMPORT/EXPORT ELEMENT cdb
svn path=/trunk/; revision=20794
2007-02-12 10:30:10 +00:00
Anders Broman c1fcb99d13 Fix Bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1365 Authentication Quintuplet decoding fails.
svn path=/trunk/; revision=20793
2007-02-12 08:13:56 +00:00
Anders Broman 766f209edc Add uat_clear and uat_load.
svn path=/trunk/; revision=20792
2007-02-12 08:12:32 +00:00
Luis Ontanon 5db2005993 Have Aply, Cancel and OK buttons instead of the save and ok button.
Have these buttons reloading the capture file if needed.
Some rearrangement of the window (the editor is still missing "ornaments" and tooltips)


svn path=/trunk/; revision=20788
2007-02-11 16:09:21 +00:00