Commit graph

76 commits

Author SHA1 Message Date
Jörg Mayer
369929c2f6 Create a file containing macros to provide the access-functions
when the gtk version is too old (for the 2,14,0 case).

Remove all old access methods that were guarded by 2,14,0 tests.

Feel free to do the same for newer guards :-)

svn path=/trunk/; revision=38147
2011-07-21 17:44:02 +00:00
Gerald Combs
49b92440de More GLIB_CHECK_VERSION cleanups. Update the minimum GLib/GTK+ versions
in README.devloper. Remove g_gnuc.h since it's no longer needed. Remove
tvbuff_init(), tvbuff_cleanup(), reassemble_init(), and
reassemble_cleanup() since they were only used for older GLib versions
which didn't support GSlices. Assume we always support the "matches"
operator.

svn path=/trunk/; revision=37978
2011-07-11 20:32:19 +00:00
Gerald Combs
4608a76a51 Remaining GLIB_CHECK_VERSION and GTK_CHECK_VERSION in the gtk directory.
svn path=/trunk/; revision=37973
2011-07-11 19:10:57 +00:00
Anders Broman
a2106225ad Add the correct casts to make it compile on some old ERHL box.
svn path=/trunk/; revision=37693
2011-06-17 13:19:44 +00:00
Anders Broman
5659d18813 Add casts to make it compile on some old ERHL box.
svn path=/trunk/; revision=37629
2011-06-09 08:51:30 +00:00
Stephen Fisher
9d3586b4f5 And even more -DGSEAL_ENABLE cleanup for GTK+ 3.0 preparation...
svn path=/trunk/; revision=35849
2011-02-07 18:41:38 +00:00
Guy Harris
9ff6526256 Partially clean up white space.
svn path=/trunk/; revision=35049
2010-11-28 00:53:23 +00:00
Stig Bjørlykke
0ca8c586d3 Use UTF8_HORIZONTAL_ELLIPSIS instead of "..." in menus.
svn path=/trunk/; revision=34346
2010-10-03 16:09:25 +00:00
Anders Broman
f51ed4d4c3 Remove the depricated GtkItemFactory code.
svn path=/trunk/; revision=34027
2010-08-30 20:30:20 +00:00
Jeff Morriss
b4c2ed1b86 Remove some unnecessary includes: a lot of things don't need globals.h and register.h
svn path=/trunk/; revision=34017
2010-08-30 16:10:01 +00:00
Anders Broman
5fbc1e101b Make the expert filter popup behave as in filter_utils.
svn path=/trunk/; revision=33915
2010-08-24 20:03:33 +00:00
Anders Broman
7e8752c70c Change the wording in the menu.
svn path=/trunk/; revision=33902
2010-08-24 05:11:37 +00:00
Bill Meier
66d340863f (Minor) Cleanup signal callbak signatures and related:
- Don't mark callback arg as _U_ if actually used (and vice-versa);
- Use Null as user_data in g_signal_callback if unused in callback;
- Use correct signature for certain event callbacks.

svn path=/trunk/; revision=33895
2010-08-23 19:29:08 +00:00
Anders Broman
9e6e00b9a5 Remove a comment.
svn path=/trunk/; revision=33858
2010-08-20 11:57:20 +00:00
Anders Broman
4f0a8b5bec Use better naming.
svn path=/trunk/; revision=33852
2010-08-19 19:05:56 +00:00
Guy Harris
2a328da4ef Instead of using a Boolean for the search direction, use an enum, so
that you can tell from examination whether the search is forward or
backward.

Make the cf_find_packet routines take the direction as an explicit
argument, rather than, in the cases where you don't want to permanently
set the direction, saving the direction in the capture_file structure,
changing it, doing the search, and restoring the saved direction.  Give
more information in the Doxygen comments for those routines.

Add a cf_find_packet_dfilter_string() routine, which takes a filter
string rather than a compiled filter as an argument.  Replace
find_previous_next_frame_with_filter() with it.

Have cf_read_frame_r() and cf_read_frame() pop up the error dialog if
the read fails, rather than leaving that up to its caller.  That lets us
eliminate cf_read_error_message(), by swallowing its code into
cf_read_frame_r().  Add Doxygen comments for cf_read_frame_r() and
cf_read_frame().

Don't have find_packet() read the packet before calling the callback
routine; leave that up to the callback routine.

Add cf_find_packet_marked(), to find the next or previous marked packet,
and cf_find_packet_time_reference(), to find the next or previous time
reference packet.  Those routines do *not* need to read the packet data
to see if it matches; that lets them run much faster.

Clean up indentation.

svn path=/trunk/; revision=33791
2010-08-13 07:39:46 +00:00
Anders Broman
c34f5acf83 Switch to GtkUIManager in stead of the deprecated GtkItemFactory.
In case of problems switch back by removing the line: 
#define USE_GUIMANAGER 1

svn path=/trunk/; revision=33761
2010-08-10 15:47:29 +00:00
Anders Broman
777a4ee10e - Fix a crash when an entry in the popup menue is selected and there
are no epert info entries.
- Updates to GUManager code(still incomplete).

svn path=/trunk/; revision=33757
2010-08-10 11:08:18 +00:00
Anders Broman
93f65bb572 Update the experimental code to use the UI manager.
svn path=/trunk/; revision=33743
2010-08-09 16:16:58 +00:00
Bill Meier
6cdec04e59 (Minor) Cleanup some "event callback" function declarations/definitions:
- Add missing 'user_data' arg as needed;
- Use gboolean rather than int as the type of the value returned.
Also: Cleanup whitespace & reformat long lines in a few cases.

svn path=/trunk/; revision=33679
2010-07-30 12:41:56 +00:00
Martin Mathieson
d2087d514e Add Copy (to clipboard) to expert item popup menu.
svn path=/trunk/; revision=33214
2010-06-13 14:55:11 +00:00
Anders Broman
73452c577b Prepare to change GtkItemFactory to GtkUIManager.
(Will not have time to work on this for a while).

svn path=/trunk/; revision=30325
2009-10-05 08:32:59 +00:00
Stig Bjørlykke
be378b901e Rewrite some local variable names to avoid function argument names.
svn path=/trunk/; revision=30202
2009-09-29 19:29:03 +00:00
Anders Broman
9c5451174f 'function' : different 'const' qualifiers
svn path=/trunk/; revision=29878
2009-09-13 16:03:46 +00:00
Anders Broman
b9901ede8a Be consistent use and g_string_chunk_insert_const() in stead of
g_string_chunk_insert() as in expert_dlg.c

svn path=/trunk/; revision=29827
2009-09-09 19:34:14 +00:00
Anders Broman
8035954712 Didier Gautheron:
Expert info clean up.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3971

svn path=/trunk/; revision=29663
2009-09-02 05:48:38 +00:00
Anders Broman
5e4e5755a8 From Didier Gautheron:
expert info clean up,
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3948

svn path=/trunk/; revision=29566
2009-08-26 17:26:26 +00:00
Anders Broman
112dda41fa From Didier Gautheron:
Speed up expert info composite.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3935

svn path=/trunk/; revision=29542
2009-08-24 20:33:49 +00:00
Anders Broman
efba5a7678 Use list_store isf deprecated clist.
Try to optimize expert_comp_table.

svn path=/trunk/; revision=29539
2009-08-24 16:11:00 +00:00
Kovarththanan Rajaratnam
7c1d96d831 From Didier gautheron via bug 3929:
* Don't use g_string_chunk_clear(). It is only defined if GLib >= 2.14

From me:

* Whitespace fixes

svn path=/trunk/; revision=29529
2009-08-23 18:13:03 +00:00
Anders Broman
3c86b750e5 expert_comp_table.c: Minor cleanup
expert_dlg.c change GtkOptionMenu to GtkComboBox.

svn path=/trunk/; revision=29504
2009-08-22 16:17:42 +00:00
Kovarththanan Rajaratnam
27f7d88c84 Also fake empty field_info's by gracefully handling NULL field_info pointer elsewhere.
svn path=/trunk/; revision=29490
2009-08-21 11:03:30 +00:00
Anders Broman
7ec476b88a From Didier Gautheron:
Part 2
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Optimize expert info.
Slightly changed by me.

svn path=/trunk/; revision=29478
2009-08-19 18:37:13 +00:00
Kovarththanan Rajaratnam
083729e02c Add PTREE_FINFO and use PITEM_FINFO when possible.
svn path=/trunk/; revision=29355
2009-08-09 17:57:31 +00:00
Bill Meier
79e537af33 expert_comp: Fix some memory leaks (several non-trivial);
Fix hack wherein a ptr was stored using the address of an int (could cause Win64 crash ?)
  Use consistent indentation;

svn path=/trunk/; revision=28410
2009-05-19 15:53:26 +00:00
Bill Meier
27024a1d5a As suggested by Jakub Zawadzki: actually use sizeof(...) rather than a numeric constant in various places;
svn path=/trunk/; revision=27800
2009-03-19 17:49:11 +00:00
Stig Bjørlykke
18c5caa3d4 From Jakub Zawadzki:
Use non-formatting functions when appropriate.

svn path=/trunk/; revision=27709
2009-03-12 07:56:42 +00:00
Jaap Keuter
0855f501cc Set the packet details counter column to 1, as it's one expert info per packet.
svn path=/trunk/; revision=27261
2009-01-18 14:51:22 +00:00
Bill Meier
c9898d7f6b #include <emem.h> not req'd
svn path=/trunk/; revision=26094
2008-08-26 02:53:21 +00:00
Stig Bjørlykke
1cfa1550e1 - Don't create illegal filter from context menu.
- Use filter defines from common header file.

svn path=/trunk/; revision=25313
2008-05-17 22:59:52 +00:00
Ulf Lamping
8e3e8b588f sort #includes by directories
svn path=/trunk/; revision=24968
2008-04-13 01:54:20 +00:00
Ulf Lamping
d4ccf577a8 where it's not necessary, remove #include "compat_macros.h"
svn path=/trunk/; revision=24922
2008-04-12 01:02:59 +00:00
Ronnie Sahlberg
154e8f0892 add missing braces to unbreak the build
svn path=/trunk/; revision=24916
2008-04-11 23:12:24 +00:00
Ulf Lamping
f9f87904c4 second round to replace SIGNAL_CONNECT with g_signal_connect
This requires some casts to be added and I just don't want to add casts at all possible places. So I compile and only add casts where the (MSVC) compiler has a hard time. 

Unfortunately this won't find any problems in Linux/Unix only code - I'll keep an eye on the buildbot and try to fix things as I'm going on ...

svn path=/trunk/; revision=24913
2008-04-11 21:39:16 +00:00
Ulf Lamping
a471e1af90 replace ITEM_FACTORY_ENTRY and ITEM_FACTORY_STOCK_ENTRY with their required data values to build the menus
svn path=/trunk/; revision=24909
2008-04-11 20:21:05 +00:00
Anders Broman
c973aa3830 Remove:
#ifdef NEED_G_ASCII_STRCASECMP_H
#include "g_ascii_strcasecmp.h"
#endif

svn path=/trunk/; revision=24868
2008-04-09 19:39:58 +00:00
Ulf Lamping
0e701b77ae remove GTK1 code
svn path=/trunk/; revision=24816
2008-04-06 23:20:23 +00:00
Guy Harris
88adb489c3 Add extra parenthesization, tweak name of argument to some macros to
more accurately reflect what it is.

svn path=/trunk/; revision=23814
2007-12-09 09:02:14 +00:00
Guy Harris
15f3b2c750 Add macros for various filter actions and types, and to combine them
into a callback argument and split a callback argument up.

svn path=/trunk/; revision=23747
2007-12-04 08:27:48 +00:00
Guy Harris
a8ce49d758 More whitespace cleanup.
svn path=/trunk/; revision=23746
2007-12-04 07:53:23 +00:00