Commit Graph

81 Commits

Author SHA1 Message Date
Stig Bjørlykke b03c1345d2 Initialize geom in window_get_geometry.
Coverity 804.

svn path=/trunk/; revision=36259
2011-03-22 18:28:08 +00:00
Guy Harris c66802f606 Fix typo.
svn path=/trunk/; revision=35856
2011-02-07 19:39:05 +00:00
Stephen Fisher 9d3586b4f5 And even more -DGSEAL_ENABLE cleanup for GTK+ 3.0 preparation...
svn path=/trunk/; revision=35849
2011-02-07 18:41:38 +00:00
Anders Broman 6adf502aa7 Replace a couple of deprecated functions # ifdef:ed with the GTK version they are deprecated in.
svn path=/trunk/; revision=35740
2011-02-01 07:15:14 +00:00
Bill Meier 2b0f6a63f1 Define some fcns & vars as static;
Rename g_capture_in_progress to gbl_capture_in_progress (capture_if_dlg.c)
Do some whitespace cleanup.

svn path=/trunk/; revision=34490
2010-10-12 17:39:44 +00:00
Stephen Fisher 2c3fe49a03 Format changes from r34265 to fit a 80 column wide window.
svn path=/trunk/; revision=34268
2010-09-27 21:23:29 +00:00
Stephen Fisher eb27557794 Fix bug #553 by ensuring that the upper-left corner of Wireshark is within the viewable area of the monitor.
svn path=/trunk/; revision=34265
2010-09-27 20:02:54 +00:00
Anders Broman 46b05449ce Doxygen changes.
svn path=/trunk/; revision=33991
2010-08-29 13:18:58 +00:00
Jeff Morriss 522c9b85b8 Don't leak the memory used by the original title when we're appending the version to it.
svn path=/trunk/; revision=33864
2010-08-20 22:12:55 +00:00
Guy Harris e85c2051ff Don't set the icon name:
1) the GTK+ documentation recommends against it;

	2) the X11 implementation of gtk_window_set_title() sets the
	   icon name to the title, so gdk_window_set_icon_name() doesn't
	   do anything interesting, and the Win32 and Quartz
	   implementations of gdk_window_set_icon_name() don't do
	   anything;

	3) gdk_window_set_icon_name() either crashes or complains if
	   it's handed a null pointer, which happens at startup.

Clean up indentation.

svn path=/trunk/; revision=33739
2010-08-08 21:26:39 +00:00
Anders Broman c9a7fade6a From Cal Turney:
Optionally display Wireshark version in the main window's title bar.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5040

svn path=/trunk/; revision=33729
2010-08-07 14:37:37 +00:00
Bill Meier 6cdec04e59 (Minor) Cleanup some "event callback" function declarations/definitions:
- Add missing 'user_data' arg as needed;
- Use gboolean rather than int as the type of the value returned.
Also: Cleanup whitespace & reformat long lines in a few cases.

svn path=/trunk/; revision=33679
2010-07-30 12:41:56 +00:00
Bill Meier 020ceaeb1a (Trivial) Fix some typos; Also: Use consistent indentation.
svn path=/trunk/; revision=33647
2010-07-28 13:34:41 +00:00
Bill Meier 4f48117483 Add ws_combo_box_new_text_and_pointer_full() to allow returning
the cell renderer associated with the ComboBox.

svn path=/trunk/; revision=33591
2010-07-20 14:30:41 +00:00
Bill Meier fa5fecf047 Change ws_combo_box... to use a tree-store instead of a list-store;
This allows the dispay of the ws_combo_box choices as a tree.
Also: Rename ws_combo_box_append_text_and_pointer_with_sensitivity() to
             ws_combo_box_append_text_and_pointer_full().

svn path=/trunk/; revision=33538
2010-07-15 15:05:39 +00:00
Bill Meier 40de4ed2b0 ws_combo_box_text_and_pointer: allow setting entries as "insensitive".
svn path=/trunk/; revision=33494
2010-07-13 00:17:08 +00:00
Anders Broman 1b3be7a754 From Jim Young:
Remove unneeded "gtk_tree_path_free(path);" from case
"GDK_Return:" in tree_view_key_pressed_cb() that was reverted in r32957 to restore X11 functionality lost in refactored code from r32323.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4847

svn path=/trunk/; revision=33112
2010-06-06 16:25:41 +00:00
Gerald Combs 237eef2ae7 r32323 broke packet detail tree expansion using the left/right keys on
X11. Add back the removed code and add checks for expandable items.

svn path=/trunk/; revision=32957
2010-05-25 23:55:33 +00:00
Jaap Keuter 1a3fd99542 Fix for bug 4778:
Check that the widget pointer is still present.

svn path=/trunk/; revision=32911
2010-05-20 19:03:13 +00:00
Anders Broman 677e54d0a9 Replace deprecated gtk_input_add_full()
svn path=/trunk/; revision=32750
2010-05-11 08:36:16 +00:00
Gerald Combs 1bf2a7c78b Replace GtkClist in uat_gui.c with GtkTreeView+GtkListStore. Pop up the
edit window when an item is double-clicked. Add a couple of convenience
routines to gui_utils.c.

svn path=/trunk/; revision=32621
2010-04-30 22:33:51 +00:00
Anders Broman b75f17ca1b From Jim Young:
patch to gui_utils.c to allow the new packetlist to respond to left/right keystrokes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4614

svn path=/trunk/; revision=32323
2010-03-28 20:22:09 +00:00
Bill Meier 8822e6bf24 Update (slightly) the description of ws_combo_box_clear_text_and_pointer().
svn path=/trunk/; revision=31971
2010-02-24 01:21:09 +00:00
Bill Meier 59dbaca913 Add ws_combo_box_new_text_and_pointer() and related which provides a
variant of gtk_combo_box which stores a pointer along as well as text for
each combo_box entry. 

svn path=/trunk/; revision=31947
2010-02-22 18:39:55 +00:00
Guy Harris 5f1887e630 Fix a comment.
svn path=/trunk/; revision=31146
2009-12-01 21:30:30 +00:00
Gerald Combs 9338d16323 Use pango_font_description_get_size() to pad out the default column
size.  This may require tweaking, e.g. with
pango_font_description_set_absolute_size().

svn path=/trunk/; revision=31145
2009-12-01 21:24:48 +00:00
Guy Harris 1e72ad9469 Clean up indentation a bit more.
svn path=/trunk/; revision=31139
2009-12-01 01:40:37 +00:00
Guy Harris a39e0b3afc Squelch LLP64 warning.
Clean up indentation somewhat.

svn path=/trunk/; revision=31138
2009-12-01 01:37:52 +00:00
Anders Broman 8c3d9cf0d7 Add a character's spacing when resizing columns.
svn path=/trunk/; revision=31134
2009-11-30 20:46:07 +00:00
Gerald Combs d54eea534e Add a convenience routine to convert pixbuf data generated by
gdk-pixbuf-csource to a GtkImage. Use it to load the expert indicator
images. Add prettier indicator images. The "chat" indicator is more blue
in order to differentiate it from the "none" indicator; make the chat
text background more blue to match.

svn path=/trunk/; revision=30825
2009-11-04 21:16:38 +00:00
Anders Broman 85d8b896a6 From Didier Gautheron:
- memory leak, free the list after walking it, ie free a NULL list, ie free nothing. I've only fixed bugs introduced by me with GTKCList to TreeView modifs, it seems there's the same bug in gtk/dlg_utils.c.

svn path=/trunk/; revision=30421
2009-10-09 09:06:22 +00:00
Anders Broman 4d52b3aa83 From Didier Gautheron:
- Display number with a space as thousand separator.
- Move functions use both by conversations and hostlist in gui_utils.c, they may be useful for other taps too.

svn path=/trunk/; revision=30416
2009-10-09 08:52:36 +00:00
Anders Broman 528382445f From Didier Gautheron:
optimizations patch http://wiki.wireshark.org/Development/Optimization
'patch.29854.diff.gz"

Speed up sorting.

svn path=/trunk/; revision=29879
2009-09-13 16:11:11 +00:00
Anders Broman beb57e259b make the columns sortable.
svn path=/trunk/; revision=29583
2009-08-27 06:57:53 +00:00
Anders Broman 0267ffb01c Don't copy const strings, store the pointer in the list store instead,
saves memory.

svn path=/trunk/; revision=29582
2009-08-27 05:34:06 +00:00
Stephen Fisher 91e7c80973 Include packet_info.h before ui_utils.h since we just started passing a
packet_info structure to one of the functions.


svn path=/trunk/; revision=29251
2009-07-31 07:02:02 +00:00
Bill Meier 6cdedfddd1 gtk_exit() is deprecated; "use the standard exit() function instead"
svn path=/trunk/; revision=28444
2009-05-22 12:36:20 +00:00
Anders Broman 3c2eddf646 Get rid of Clists, move a comment, move display as hex to gui_utils.
svn path=/trunk/; revision=27741
2009-03-16 18:01:25 +00:00
Stig Bjørlykke 62f60df6b4 From Jakub Zawadzki (bug 3331):
g_free() is NULL safe, so we don't need check against it.

svn path=/trunk/; revision=27718
2009-03-13 22:06:48 +00:00
Stig Bjørlykke 04dfb4c8b8 Remove a unused g_strdup().
svn path=/trunk/; revision=27666
2009-03-08 22:57:39 +00:00
Anders Broman 4175480de6 Get rid of a Clist and move the functon to display floats with two decimals to gui_utils.
svn path=/trunk/; revision=27621
2009-03-06 17:16:56 +00:00
Stig Bjørlykke 0a791948b4 Free path fetched from gtk_tree_model_get_path with gtk_tree_path_free()
svn path=/trunk/; revision=27516
2009-02-22 21:28:13 +00:00
Bill Meier 8afa208ffb Windows build: #include winsock2.h only when needed.
#include winsock2.h pulls in about 90 distinct .h files
and about 140 total .h files. 
Currently winsock2.h is (mostly unnecessarily) included
for each dissector via packet.h/wtap.h.
This patch removes #include winsock2.h from wtap.h and 
then includes winsock2.h (or windows.h) in the 
few specific places required. 
With this patch, my Windows Wireshark build takes 
about 30% less time.


svn path=/trunk/; revision=26535
2008-10-24 00:42:09 +00:00
Jaap Keuter 8a32775150 Set a title on the splash window even though it's not decorated.
This sets the title/icon of the taskbar item created when the splash screen is up.

svn path=/trunk/; revision=26533
2008-10-23 21:13:58 +00:00
Bill Meier 44efa0ed2e Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_timeout_add()     ==> g_timeout_add
   gtk_timeout_remove()  ==> g_source_remove()

Also: timer callback should return gboolean (not void or gint)

svn path=/trunk/; revision=25672
2008-07-08 02:25:30 +00:00
Jeff Morriss a5cee04fad Move the file utility functions from wiretap to libwsutil so that
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.

While doing that, rename the eth_* functions to ws_*.

svn path=/trunk/; revision=25354
2008-05-22 15:46:27 +00:00
Graeme Lunt 39ab6c51c0 Allow the folders in the About Wireshark/Folders list to be double clicked on to open the appropriate folder in explorer.
The MIB/PIB paths have been split up to allow each one to be clicked on separately, but as a result this will lose the order if the whole list is reordered.

XXX: I have been unable to test this on MacOS or Linux. Stig? :-)
I suppose it should work, but we may need to make it WIN32 specific?


svn path=/trunk/; revision=24995
2008-04-13 17:48:47 +00:00
Ulf Lamping 8e3e8b588f sort #includes by directories
svn path=/trunk/; revision=24968
2008-04-13 01:54:20 +00:00
Ulf Lamping d4ccf577a8 where it's not necessary, remove #include "compat_macros.h"
svn path=/trunk/; revision=24922
2008-04-12 01:02:59 +00:00
Ulf Lamping 8e58ec7085 last round to replace SIGNAL_CONNECT with g_signal_connect
svn path=/trunk/; revision=24918
2008-04-11 23:16:06 +00:00