Commit Graph

15 Commits

Author SHA1 Message Date
Evan Huus 71e0d23701 From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9180
A few enhancements to the SEL Fast Message (selfm) Dissector:
- Final piece of dissection for standard Fast Meter messages to display pad byte
  (if present) and single-byte checksum footer.
- Enhancement to digital word display to show 1-byte bit patterns on proto_item
  without requiring user to expand tree.

svn path=/trunk/; revision=52210
2013-09-24 22:42:27 +00:00
Pascal Quantin a0c53ffaa1 emem -> wmem conversion:
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly

svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
Michael Mann b38ee917b1 Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly.
The script didn't catch as many as I would have liked, but it's a start.

The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum.

svn path=/trunk/; revision=52045
2013-09-15 01:48:30 +00:00
Evan Huus 6635f5ef67 Replace wmem slist (singly-linked) with wmem list (doubly-linked).
The overhead is not large, and it makes append much faster (O(1) vs O(n)).

It also will make a queue easy to add, which I need for a dissector I'm
writing...

svn path=/trunk/; revision=50744
2013-07-20 20:33:38 +00:00
Jakub Zawadzki a18172147f Remove fragment_data, add fragment_head, fragment_item - for now alias it to the same structure.
This is begin of work to split fragment head and fragments items.

svn path=/trunk/; revision=50708
2013-07-17 21:12:24 +00:00
Chris Maynard 02fa8a5d19 Fix Coverity CID 1050092: Dereference null return value.
svn path=/trunk/; revision=50667
2013-07-16 15:30:20 +00:00
Evan Huus 611eaf8069 From Chris Botje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8917
Minor Enhancement to add further to the Fast Message conversation structure to
provide Data Region Address/Name lookup.

From me: use tree for lookups, not slist.

svn path=/trunk/; revision=50555
2013-07-13 14:37:06 +00:00
Alexis La Goutte 5b7c3b3105 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=50446
2013-07-08 16:37:47 +00:00
Evan Huus 599d994938 From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8860
Numerous changes and fixes to the selfm dissector. Too many to bother listing
here, see the bug for full details.

svn path=/trunk/; revision=50394
2013-07-06 00:01:59 +00:00
Michael Mann dfa2156e30 Remove check_col() and the occasional tree.
svn path=/trunk/; revision=49923
2013-06-14 02:50:46 +00:00
Anders Broman 85a8e304dd Add the posibillity to use a key for per-packet-data.
svn path=/trunk/; revision=49259
2013-05-12 18:11:02 +00:00
Anders Broman a10b98284c From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48412
2013-03-19 04:54:30 +00:00
Evan Huus ab9129add9 Small updates to the SEL Fast Message dissector.
From Chris Bontje via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8170

svn path=/trunk/; revision=46995
2013-01-07 23:53:56 +00:00
Alexis La Goutte ab7f4395d7 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=46967
2013-01-06 14:50:52 +00:00
Evan Huus d131bc1077 From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8089
Dissector for the SEL (Schweitzer Engineering Labs) Fast Message protocol.

From me:
- use wmem instead of glib to not leak memory
- simplify port preference
- remove unneeded initializers
- modelines
- Id tag

svn path=/trunk/; revision=46949
2013-01-05 14:19:15 +00:00