Michael Mann
cff098e3eb
guid_to_ep_str -> guid_to_str
...
guid_to_str now uses wmem allocation.
Change-Id: I8e48d1a720942fbefbaa6227ae0929cb9f856359
Reviewed-on: https://code.wireshark.org/review/6391
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-08 07:18:09 +00:00
Pascal Quantin
119f564e0d
MBIM: call dissector_(add|delete)_uint only when necessary
...
Change-Id: I12bbe9e1d81560f1874d4e575b19db1842fa0c72
Reviewed-on: https://code.wireshark.org/review/6352
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-06 21:04:19 +00:00
Martin Mathieson
7e8a4b0927
Deleting unnecessary #includes from dissectors.
...
Fourth batch (packet-mac-lte.c -> packet-rtp.c).
Will look at cleaning up and committing script afterwards.
Change-Id: Id921f07f4b274f0cfb77ce81abe4a285fdb8b644
Reviewed-on: https://code.wireshark.org/review/6023
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-23 17:16:40 +00:00
Bill Meier
b5d7b7ab6e
Cleanup use of #includes in non-generated epan/dissector/*.c
...
Specifically:
- Set packet.h to be the first wireshark #include after
config.h and "system" #includes.
packet.h added as an #include in some cases when missing.
- Remove some #includes included (directly/indirectly) in
packet.h. E.g., glib.h.
(Done only for those files including packet.h).
- As needed, move "system" #includes to be after config.h and
before wireshark #includes.
- Rework various #include file specifications for consistency.
- Misc.
Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95
Reviewed-on: https://code.wireshark.org/review/5923
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-21 05:46:22 +00:00
Bill Meier
c28f280c1d
Fix a number of dup hf[] filter-names probably resulting from cut/paste errs.
...
Change-Id: I9242300b2ace3155c1506b584a90f073100a305e
Reviewed-on: https://code.wireshark.org/review/5512
Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-26 23:27:31 +00:00
Michael Mann
c7a6e6fa13
convert to proto_tree_add_subtree[_format]
...
Change-Id: I621f2e2cad9403449cb78f45302388f0c874d3bc
Reviewed-on: https://code.wireshark.org/review/2852
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-07-04 16:59:14 +00:00
Pascal Quantin
eaf6bf3ec0
MBIM: add an option to force SMS PDU decoding format if MBIM_DEVICE_CAPS_INFO message was not captured
...
Change-Id: Iff78a00b463a7a33e1705c76ea49618af532f3aa
Reviewed-on: https://code.wireshark.org/review/2621
Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-24 17:25:30 +00:00
Michael Mann
73217d9f3f
tvb_new_subset -> tvb_new_subset_length when length parameters are equal.
...
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is.
Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d
Reviewed-on: https://code.wireshark.org/review/1999
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-07 15:41:07 +00:00
Pascal Quantin
c5de173edc
MBIM: do not access to hash map when it is not initialized yet
...
Change-Id: I560941115316ead5a85b9e0b55be693217fddff2
Reviewed-on: https://code.wireshark.org/review/1940
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-03 18:01:51 +00:00
Pascal Quantin
4d55a12c0e
MBIM: dissect MBIM_SET_STK_PAC and MBIM_STK_PAC_INFO messages
...
Change-Id: Ib58dece7ce7278e292d88f68368c238695c32394
Reviewed-on: https://code.wireshark.org/review/1463
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-01 19:04:24 +00:00
Pascal Quantin
3116cf4add
MBIM: use hash map instead of red/black tree for UUID extension table
...
Change-Id: Iaab9ff66e94bfe38fc875ad312b8e795b80814f4
Reviewed-on: https://code.wireshark.org/review/1438
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-30 10:15:12 +00:00
Pascal Quantin
484b183e3f
MBIM: make the backward compatibility function static
...
Change-Id: I51bbdf9c0dbb80a8350ec7762e588ca3182dce63
Reviewed-on: https://code.wireshark.org/review/1408
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-28 09:18:46 +00:00
Pascal Quantin
3b1903c394
MBIM: fix compilation with GLib versions < 2.22.0
...
Change-Id: I27e794347dc0988f0f34798cb62f08a11a217176
Reviewed-on: https://code.wireshark.org/review/1400
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-27 21:42:52 +00:00
Pascal Quantin
7ddf2b4540
MBIM: use wmem hash map functions for request/response tracking
...
Change-Id: Ie550b0ef2b57827f610c4c6a83ff14868e853125
Reviewed-on: https://code.wireshark.org/review/1399
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-27 21:21:37 +00:00
Pascal Quantin
cd4d4acdbc
MBIM: fix dissection of GSM SMS messages
...
Change-Id: I07e753e50a42513daa704e56ee5c9b399a91fec9
Reviewed-on: https://code.wireshark.org/review/1305
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-23 17:45:25 +00:00
Pascal Quantin
f532fb94fc
MBIM: fix dissection of ENVELOPE Sim Toolkit messages
...
Change-Id: I3e6567e8ebfe83f12a0e2cbb2998b2e43ad2277a
Reviewed-on: https://code.wireshark.org/review/1092
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-13 20:55:32 +00:00
Pascal Quantin
f6dfda3a33
MBIM: add decoding of text based CDMA SMS
...
Change-Id: Id2497597660bffeff2d98087d6511b91bfd93b1a
Reviewed-on: https://code.wireshark.org/review/1091
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-13 20:53:44 +00:00
Pascal Quantin
3dd4ef59bb
MBIM: fix identification of DSS streams and add a way to register an external dissector for DSS
...
Change-Id: Ic7f5708b60ee5846d95725dbbd14d8958d43372e
Reviewed-on: https://code.wireshark.org/review/843
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-27 10:12:27 +00:00
Pascal Quantin
38b5efd5cf
MBIM: fix dissection of control packets when capturing with usbmon
...
Change-Id: Ie20fcb8d393a85d47ba78f6cb70de77fedda2587
Reviewed-on: https://code.wireshark.org/review/829
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-25 22:04:23 +00:00
Pascal Quantin
2f794e95d1
MBIM: fix 3GPP SMS PDU record dissection
...
Change-Id: I232a12eb7f7ee49464bb45c6f284ca3a3825909c
Reviewed-on: https://code.wireshark.org/review/644
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-13 21:59:12 +00:00
Pascal Quantin
af36d776c4
MBIM: add sanity checks to bulk packets
...
Change-Id: I425f4ecd03f5ae0ec27b77b1437366d66107342f
Reviewed-on: https://code.wireshark.org/review/579
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-10 09:49:14 +00:00
Pascal Quantin
1678b0a825
Remove deprecated TVB APIs
...
Change-Id: I87216c3bd2061c12ce486c752d4381ab722db95e
Reviewed-on: https://code.wireshark.org/review/328
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-23 22:28:40 +00:00
Pascal Quantin
d8c15b8d91
Add ability to register new UUID and CIDs
...
svn path=/trunk/; revision=54944
2014-01-24 18:53:06 +00:00
Pascal Quantin
944db5d447
Set explicitly P2P direction for received SMS
...
svn path=/trunk/; revision=54682
2014-01-09 21:29:07 +00:00
Pascal Quantin
6ebc058f47
Add proto_tree_add_ts_23_038_7bits_item() / tvb_get_ts_23_038_7bits_string() functions and update dissectors to use it.
...
Remove gsm_sms_char_7bit_unpack() / gsm_sms_chars_to_utf8() functions.
Update documentation a bit.
svn path=/trunk/; revision=54534
2014-01-01 14:33:19 +00:00
Guy Harris
0d7a48a8bf
Add a ENC_3GPP_TS_23_038 encoding, for the standard SMS alphabet in a
...
bit-packed string, and use it in some places.
svn path=/trunk/; revision=54428
2013-12-24 00:20:09 +00:00
Pascal Quantin
ee0ea80d07
Fix dissection of GSM SMS PDU
...
svn path=/trunk/; revision=54368
2013-12-22 19:26:58 +00:00
Pascal Quantin
302a4cf1c0
Fix copy/paste error
...
svn path=/trunk/; revision=54366
2013-12-22 17:27:53 +00:00
Pascal Quantin
3fba8ea2fe
proto_tree_add_text -> proto_tree_add_item
...
svn path=/trunk/; revision=54365
2013-12-22 16:27:21 +00:00
Guy Harris
5084f58ce2
We support ENC_UCS_2, so use that in proto_tree_add_item() and
...
tvb_get_string_enc() rather than using iconv to convert it to UTF-8.
svn path=/trunk/; revision=54350
2013-12-22 02:12:32 +00:00
Jakub Zawadzki
deb2b236f2
Add missing includes
...
svn path=/trunk/; revision=54332
2013-12-21 17:23:17 +00:00
Evan Huus
2ae8edccea
Rename more to_str functions to have ep_ in the name if they return ephemeral
...
buffers. Remove two unused functions.
svn path=/trunk/; revision=54250
2013-12-19 16:28:39 +00:00
Pascal Quantin
2f3a943f0a
Fix a typo and check that handle exists before calling call_dissector()
...
svn path=/trunk/; revision=54175
2013-12-17 11:34:45 +00:00
Jakub Zawadzki
715e2d6699
Fix [-Wmissing-prototypes]
...
svn path=/trunk/; revision=54095
2013-12-14 16:09:57 +00:00
Jakub Zawadzki
4d92f6079b
Remove not needed ';'
...
svn path=/trunk/; revision=54088
2013-12-14 11:12:20 +00:00
Pascal Quantin
293e390c61
Use an item for USSD text
...
svn path=/trunk/; revision=53879
2013-12-09 08:56:06 +00:00
Pascal Quantin
8b3f82def1
Add request / response tracking to MBIM_FUNCTION_ERROR_MSG messages
...
svn path=/trunk/; revision=53762
2013-12-03 19:44:32 +00:00
Pascal Quantin
2d49720de6
Add Qualcomm proprietary UUID
...
svn path=/trunk/; revision=53760
2013-12-03 19:32:10 +00:00
Pascal Quantin
9a48c7e8da
Improve request / response tracking in case you have several open / close commands in the capture
...
svn path=/trunk/; revision=53644
2013-11-29 10:38:00 +00:00
Pascal Quantin
12618aadcd
Add command type to info column
...
svn path=/trunk/; revision=53575
2013-11-25 18:04:07 +00:00
Pascal Quantin
9150571bf3
Check the packet length when using the "Force decoding of unknown USB control data as MBIM" option to reduce false positives.
...
Align text in info column.
svn path=/trunk/; revision=53521
2013-11-23 12:30:19 +00:00
Pascal Quantin
3894de27f3
Indicate fragments in info column
...
svn path=/trunk/; revision=53472
2013-11-21 11:20:06 +00:00
Pascal Quantin
5064834661
Fix a typo
...
svn path=/trunk/; revision=53433
2013-11-19 18:18:52 +00:00
Pascal Quantin
70b9ce2b48
Dissect USB Com Network Control Model requests
...
svn path=/trunk/; revision=53349
2013-11-15 23:16:25 +00:00
Pascal Quantin
488cf801a2
Fix dissection of MBIM Extended Functional Descriptor MTU
...
svn path=/trunk/; revision=53312
2013-11-14 09:43:32 +00:00
Michael Mann
76bfa2ce1a
Remove usb_conv_info_t from packet_info and pass the data directly into the subdissectors. Bug 9413 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9413 )
...
svn path=/trunk/; revision=53274
2013-11-12 13:46:51 +00:00
Pascal Quantin
8f112c0390
Fix dissection of MBIM data packets when using 32-bits NDPs
...
svn path=/trunk/; revision=53142
2013-11-07 16:53:59 +00:00
Bill Meier
0ad98563a2
From didier gautheron: remove redundant or use faster col_xxx functions
...
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
+ before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344
svn path=/trunk/; revision=52948
2013-10-29 14:09:20 +00:00
Alexis La Goutte
70b52fc4f5
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
...
svn path=/trunk/; revision=52873
2013-10-26 17:17:53 +00:00
Bill Meier
9874da2fcb
#if 0 numerous "unused const variables" (mostly value-string-arrays);
...
Also; fix a few "set but not used" warnings.
svn path=/trunk/; revision=52780
2013-10-23 06:29:11 +00:00